73341 2011-11-29 11:15:13 -0800 Remove unused isInlineCode from V8Proxy 2014-04-24 16:45:24 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rafaelw rafaelw abarth adamk fishd japhet webkit.review.bot oldest_to_newest 510928 0 rafaelw 2011-11-29 11:15:13 -0800 If this code is doing something, I'm missing what. Creating a patch to ask the question. 510931 1 117005 rafaelw 2011-11-29 11:17:01 -0800 Created attachment 117005 Patch 510961 2 117005 abarth 2011-11-29 11:43:55 -0800 Comment on attachment 117005 Patch This used to be used during user gesture detection, which we now do in a more sane way. 511606 3 117005 webkit.review.bot 2011-11-30 03:30:39 -0800 Comment on attachment 117005 Patch Clearing flags on attachment: 117005 Committed r101480: <http://trac.webkit.org/changeset/101480> 511607 4 webkit.review.bot 2011-11-30 03:30:43 -0800 All reviewed patches have been landed. Closing bug. 1003859 5 darin 2014-04-24 16:45:24 -0700 Moving all JavaScriptGlue bugs to JavaScriptCore. The JavaScriptGlue framework itself is long gone. And most of the more recent bugs put in this component were put there by people who thought this was for some other aspect of “JavaScript glue” and have nothing to do with the actual original reason for the existence of this component, which was an OS-X-only framework named JavaScriptGlue. 117005 2011-11-29 11:17:01 -0800 2011-11-30 03:30:39 -0800 Patch bug-73341-20111129111700.patch text/plain 5699 rafaelw U3VidmVyc2lvbiBSZXZpc2lvbjogMTAxMzk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzNiMWU4MzllOGMxMTZj M2MwYzIxODg2NGUyYzE1ZmRiNzE0MTEwZC4uYzliZTJiOTJlMzM5Zjc3MDQwNGQ0YmQ1MTVlZWQ0 ZGIwZjQ2MThiMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDExLTExLTI5ICBSYWZh ZWwgV2VpbnN0ZWluICA8cmFmYWVsd0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmVtb3ZlIHVu dXNlZCBpc0lubGluZUNvZGUgZnJvbSBWOFByb3h5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MzM0MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIE5vIHRlc3RzIG5lZWRlZC4gVGhpcyBwYXRjaCBvbmx5IHJl bW92ZXMgdW5uZWNlc3NhcnkgY29kZS4KKworICAgICAgICAqIGJpbmRpbmdzL3Y4L1Y4TGF6eUV2 ZW50TGlzdGVuZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6VjhMYXp5RXZlbnRMaXN0ZW5lcjo6 cHJlcGFyZUxpc3RlbmVyT2JqZWN0KToKKyAgICAgICAgKiBiaW5kaW5ncy92OC9WOFByb3h5LmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OlY4UHJveHk6OlY4UHJveHkpOgorICAgICAgICAoV2ViQ29y ZTo6VjhQcm94eTo6ZXZhbHVhdGUpOgorICAgICAgICAoV2ViQ29yZTo6VjhQcm94eTo6cnVuU2Ny aXB0KToKKyAgICAgICAgKiBiaW5kaW5ncy92OC9WOFByb3h5Lmg6CisKIDIwMTEtMTEtMjkgIE9s aXZlciBIdW50ICA8b2xpdmVyQGFwcGxlLmNvbT4KIAogICAgICAgICBET00gd3JhcHBlciBjYWNo ZSBkb2Vzbid0IG5lZWQgdG8gdXNlIEpTRE9NV3JhcHBlcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvYmluZGluZ3MvdjgvVjhMYXp5RXZlbnRMaXN0ZW5lci5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy92OC9WOExhenlFdmVudExpc3RlbmVyLmNwcAppbmRleCBlZWUyNDU3YjY3NzM2 MTAzYzk0MmU0NTY4YjUxYWFjOTY0NDIyMTJmLi43ODlmYmQyMWM0NTVmZDdkOTEwYWM4ZjA2YWUx NjZjNTMzM2E3MjBiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOExh enlFdmVudExpc3RlbmVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOExh enlFdmVudExpc3RlbmVyLmNwcApAQCAtMTIzLDcgKzEyMyw3IEBAIHZvaWQgVjhMYXp5RXZlbnRM aXN0ZW5lcjo6cHJlcGFyZUxpc3RlbmVyT2JqZWN0KFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQqIGNv bnRleHQpCiAgICAgdjg6OkhhbmRsZTx2ODo6U3RyaW5nPiBjb2RlRXh0ZXJuYWxTdHJpbmcgPSB2 OEV4dGVybmFsU3RyaW5nKGNvZGUpOwogICAgIHY4OjpIYW5kbGU8djg6OlNjcmlwdD4gc2NyaXB0 ID0gVjhQcm94eTo6Y29tcGlsZVNjcmlwdChjb2RlRXh0ZXJuYWxTdHJpbmcsIG1fc291cmNlVVJM LCBtX3Bvc2l0aW9uKTsKICAgICBpZiAoIXNjcmlwdC5Jc0VtcHR5KCkpIHsKLSAgICAgICAgdjg6 OkxvY2FsPHY4OjpWYWx1ZT4gdmFsdWUgPSBwcm94eS0+cnVuU2NyaXB0KHNjcmlwdCwgZmFsc2Up OworICAgICAgICB2ODo6TG9jYWw8djg6OlZhbHVlPiB2YWx1ZSA9IHByb3h5LT5ydW5TY3JpcHQo c2NyaXB0KTsKICAgICAgICAgaWYgKCF2YWx1ZS5Jc0VtcHR5KCkpIHsKICAgICAgICAgICAgIEFT U0VSVCh2YWx1ZS0+SXNGdW5jdGlvbigpKTsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv YmluZGluZ3MvdjgvVjhQcm94eS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOFBy b3h5LmNwcAppbmRleCA4ZmZkMWMxYmZjODQ5YzYzZWNhNGNmMzg3Mjk0MzNmNDNhNjViYjE3Li41 OWFhOTFjMzdjYjU1MzdiYTFkN2RmMTMwNjVmMDJhYmJlNDE3OTNmIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOFByb3h5LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9i aW5kaW5ncy92OC9WOFByb3h5LmNwcApAQCAtMTg5LDcgKzE4OSw2IEBAIHN0YXRpYyB2ODo6TG9j YWw8djg6OlZhbHVlPiBoYW5kbGVNYXhSZWN1cnNpb25EZXB0aEV4Y2VlZGVkKCkKIFY4UHJveHk6 OlY4UHJveHkoRnJhbWUqIGZyYW1lKQogICAgIDogbV9mcmFtZShmcmFtZSkKICAgICAsIG1fd2lu ZG93U2hlbGwoVjhET01XaW5kb3dTaGVsbDo6Y3JlYXRlKGZyYW1lKSkKLSAgICAsIG1faW5saW5l Q29kZShmYWxzZSkKIHsKIH0KIApAQCAtMzc0LDEwICszNzMsNyBAQCB2ODo6TG9jYWw8djg6OlZh bHVlPiBWOFByb3h5OjpldmFsdWF0ZShjb25zdCBTY3JpcHRTb3VyY2VDb2RlJiBzb3VyY2UsIE5v ZGUqIG5vZAogCiAgICAgICAgIFBsYXRmb3JtU3VwcG9ydDo6dHJhY2VFdmVudEJlZ2luKCJ2OC5y dW4iLCBub2RlLCAiIik7CiAjZW5kaWYKLSAgICAgICAgLy8gU2V0IGlubGluZUNvZGUgdG8gdHJ1 ZSBmb3IgPGEgaHJlZj0iamF2YXNjcmlwdDpkb1NvbWV0aGluZygpIj4KLSAgICAgICAgLy8gYW5k IGZhbHNlIGZvciA8c2NyaXB0PmRvU29tZXRoaW5nPC9zY3JpcHQ+LiBXZSBtYWtlIGEgcm91Z2gg Z3Vlc3MgYXQKLSAgICAgICAgLy8gdGhpcyBiYXNlZCBvbiB3aGV0aGVyIHRoZSBzY3JpcHQgc291 cmNlIGhhcyBhIFVSTC4KLSAgICAgICAgcmVzdWx0ID0gcnVuU2NyaXB0KHNjcmlwdCwgc291cmNl LnVybCgpLnN0cmluZygpLmlzTnVsbCgpKTsKKyAgICAgICAgcmVzdWx0ID0gcnVuU2NyaXB0KHNj cmlwdCk7CiAgICAgfQogI2lmIFBMQVRGT1JNKENIUk9NSVVNKQogICAgIFBsYXRmb3JtU3VwcG9y dDo6dHJhY2VFdmVudEVuZCgidjgucnVuIiwgbm9kZSwgIiIpOwpAQCAtMzg4LDcgKzM4NCw3IEBA IHY4OjpMb2NhbDx2ODo6VmFsdWU+IFY4UHJveHk6OmV2YWx1YXRlKGNvbnN0IFNjcmlwdFNvdXJj ZUNvZGUmIHNvdXJjZSwgTm9kZSogbm9kCiAgICAgcmV0dXJuIHJlc3VsdDsKIH0KIAotdjg6Okxv Y2FsPHY4OjpWYWx1ZT4gVjhQcm94eTo6cnVuU2NyaXB0KHY4OjpIYW5kbGU8djg6OlNjcmlwdD4g c2NyaXB0LCBib29sIGlzSW5saW5lQ29kZSkKK3Y4OjpMb2NhbDx2ODo6VmFsdWU+IFY4UHJveHk6 OnJ1blNjcmlwdCh2ODo6SGFuZGxlPHY4OjpTY3JpcHQ+IHNjcmlwdCkKIHsKICAgICBpZiAoc2Ny aXB0LklzRW1wdHkoKSkKICAgICAgICAgcmV0dXJuIG5vdEhhbmRsZWRCeUludGVyY2VwdG9yKCk7 CkBAIC00MDAsMTEgKzM5Niw2IEBAIHY4OjpMb2NhbDx2ODo6VmFsdWU+IFY4UHJveHk6OnJ1blNj cmlwdCh2ODo6SGFuZGxlPHY4OjpTY3JpcHQ+IHNjcmlwdCwgYm9vbCBpc0luCiAgICAgaWYgKGhh bmRsZU91dE9mTWVtb3J5KCkpCiAgICAgICAgIEFTU0VSVChzY3JpcHQuSXNFbXB0eSgpKTsKIAot ICAgIC8vIFNhdmUgdGhlIHByZXZpb3VzIHZhbHVlIG9mIHRoZSBpbmxpbmVDb2RlIGZsYWcgYW5k IHVwZGF0ZSB0aGUgZmxhZyBmb3IKLSAgICAvLyB0aGUgZHVyYXRpb24gb2YgdGhlIHNjcmlwdCBp bnZvY2F0aW9uLgotICAgIGJvb2wgcHJldmlvdXNJbmxpbmVDb2RlID0gaW5saW5lQ29kZSgpOwot ICAgIHNldElubGluZUNvZGUoaXNJbmxpbmVDb2RlKTsKLQogICAgIC8vIEtlZXAgRnJhbWUgKGFu ZCB0aGVyZWZvcmUgU2NyaXB0Q29udHJvbGxlciBhbmQgVjhQcm94eSkgYWxpdmUuCiAgICAgUmVm UHRyPEZyYW1lPiBwcm90ZWN0KGZyYW1lKCkpOwogCkBAIC00MzEsOSArNDIyLDYgQEAgdjg6Okxv Y2FsPHY4OjpWYWx1ZT4gVjhQcm94eTo6cnVuU2NyaXB0KHY4OjpIYW5kbGU8djg6OlNjcmlwdD4g c2NyaXB0LCBib29sIGlzSW4KICAgICBpZiAocmVzdWx0LklzRW1wdHkoKSkKICAgICAgICAgcmV0 dXJuIG5vdEhhbmRsZWRCeUludGVyY2VwdG9yKCk7CiAKLSAgICAvLyBSZXN0b3JlIGlubGluZUNv ZGUgZmxhZy4KLSAgICBzZXRJbmxpbmVDb2RlKHByZXZpb3VzSW5saW5lQ29kZSk7Ci0KICAgICBp ZiAodjg6OlY4OjpJc0RlYWQoKSkKICAgICAgICAgaGFuZGxlRmF0YWxFcnJvckluVjgoKTsKIApk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhQcm94eS5oIGIvU291cmNl L1dlYkNvcmUvYmluZGluZ3MvdjgvVjhQcm94eS5oCmluZGV4IGExMzIyYThlNDU3MTUzMzBmNjVm NzdlY2YwYTE3Nzc3YjI3ZDVjMDIuLjIyZDJjMTQzZWMyMzg0YzhiNDgyOWE2ZTA0YzNjZDc3ZjUz MWEwOGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4UHJveHkuaAor KysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOFByb3h5LmgKQEAgLTE0MywxMCArMTQz LDYgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgICAgICB2b2lkIGNsZWFyRm9yTmF2aWdhdGlv bigpOwogICAgICAgICB2b2lkIGNsZWFyRm9yQ2xvc2UoKTsKIAotICAgICAgICAvLyBGSVhNRTog TmVlZCBjb21tZW50LiBVc2VyIEdlc3R1cmUgcmVsYXRlZC4KLSAgICAgICAgYm9vbCBpbmxpbmVD b2RlKCkgY29uc3QgeyByZXR1cm4gbV9pbmxpbmVDb2RlOyB9Ci0gICAgICAgIHZvaWQgc2V0SW5s aW5lQ29kZShib29sIHZhbHVlKSB7IG1faW5saW5lQ29kZSA9IHZhbHVlOyB9Ci0KICAgICAgICAg dm9pZCBmaW5pc2hlZFdpdGhFdmVudChFdmVudCopIHsgfQogCiAgICAgICAgIC8vIEV2YWx1YXRl IEphdmFTY3JpcHQgaW4gYSBuZXcgaXNvbGF0ZWQgd29ybGQuIFRoZSBzY3JpcHQgZ2V0cyBpdHMg b3duCkBAIC0xNjMsNyArMTU5LDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgICAgICB2ODo6 TG9jYWw8djg6OlZhbHVlPiBldmFsdWF0ZShjb25zdCBTY3JpcHRTb3VyY2VDb2RlJiwgTm9kZSop OwogCiAgICAgICAgIC8vIFJ1biBhbiBhbHJlYWR5IGNvbXBpbGVkIHNjcmlwdC4KLSAgICAgICAg djg6OkxvY2FsPHY4OjpWYWx1ZT4gcnVuU2NyaXB0KHY4OjpIYW5kbGU8djg6OlNjcmlwdD4sIGJv b2wgaXNJbmxpbmVDb2RlKTsKKyAgICAgICAgdjg6OkxvY2FsPHY4OjpWYWx1ZT4gcnVuU2NyaXB0 KHY4OjpIYW5kbGU8djg6OlNjcmlwdD4pOwogCiAgICAgICAgIC8vIENhbGwgdGhlIGZ1bmN0aW9u IHdpdGggdGhlIGdpdmVuIHJlY2VpdmVyIGFuZCBhcmd1bWVudHMuCiAgICAgICAgIHY4OjpMb2Nh bDx2ODo6VmFsdWU+IGNhbGxGdW5jdGlvbih2ODo6SGFuZGxlPHY4OjpGdW5jdGlvbj4sIHY4OjpI YW5kbGU8djg6Ok9iamVjdD4sIGludCBhcmdjLCB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gYXJndltd KTsKQEAgLTI5OSwxMCArMjk1LDYgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgICAgICAvLyBG b3IgdGhlIG1vbWVudCwgd2UgaGF2ZSBvbmUgb2YgdGhlc2UuICBTb29uIHdlIHdpbGwgaGF2ZSBv bmUgcGVyIERPTVdyYXBwZXJXb3JsZC4KICAgICAgICAgUmVmUHRyPFY4RE9NV2luZG93U2hlbGw+ IG1fd2luZG93U2hlbGw7CiAKLSAgICAgICAgLy8gVHJ1ZSBmb3IgPGEgaHJlZj0iamF2YXNjcmlw dDpmb28oKSI+IGFuZCBmYWxzZSBmb3IgPHNjcmlwdD5mb28oKTwvc2NyaXB0Pi4KLSAgICAgICAg Ly8gT25seSB2YWxpZCBkdXJpbmcgZXhlY3V0aW9uLgotICAgICAgICBib29sIG1faW5saW5lQ29k ZTsKLQogICAgICAgICAvLyBBbGwgb2YgdGhlIGV4dGVuc2lvbnMgcmVnaXN0ZXJlZCB3aXRoIHRo ZSBjb250ZXh0LgogICAgICAgICBzdGF0aWMgVjhFeHRlbnNpb25zIG1fZXh0ZW5zaW9uczsKIAo=