73298 2011-11-29 02:17:15 -0800 [GTK] Add accelerated compositing compilation option 2011-11-30 13:24:42 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 73319 1 alex webkit-unassigned cgarcia joone.hur mrobinson nayankk webkit.review.bot oldest_to_newest 510629 0 alex 2011-11-29 02:17:15 -0800 We need the option and fix compilation with it activated. 510636 1 116930 alex 2011-11-29 02:25:05 -0800 Created attachment 116930 Proposed patch 510639 2 webkit.review.bot 2011-11-29 02:37:34 -0800 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 512066 3 alex 2011-11-30 13:24:42 -0800 Thanks! Landed http://trac.webkit.org/changeset/101547 116930 2011-11-29 02:25:05 -0800 2011-11-29 03:32:55 -0800 Proposed patch ac_compilation.patch text/plain 6716 alex Y29tbWl0IGQxNWY2NWE0MDM2ZmJkNThiNWIwZTgzMjE4MzA0NmM0NzA4MzVlZTQKQXV0aG9yOiBB bGVqYW5kcm8gRy4gQ2FzdHJvIDxhbGV4QGlnYWxpYS5jb20+CkRhdGU6ICAgVHVlIE5vdiAyMiAx OTowMjo0NSAyMDExICswMTAwCgogICAgMjAxMS0xMS0yOSAgQWxlamFuZHJvIEcuIENhc3RybyAg PGFsZXhAaWdhbGlhLmNvbT4KICAgIAogICAgICAgICAgICBbR1RLXSBBZGQgYWNjZWxlcmF0ZWQg Y29tcG9zaXRpbmcgY29tcGlsYXRpb24gb3B0aW9uCiAgICAgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MzI5OAogICAgCiAgICAgICAgICAgIENvbXBpbGUg d2hhdGV2ZXIgd2UgaGF2ZSBpbnNpZGUgdGhlIFVTRShBQ0NFTEVSQVRFRF9DT01QT1NJVElORykK ICAgICAgICAgICAgZGVmaW5lLiBBZGQgdGhlIGJ1aWxkIGNvbXBpbGF0aW9uIG9wdGlvbgogICAg ICAgICAgICAtLXdpdGgtYWNjZWxlcmF0ZWQtY29tcG9zaXRpbmcgYW5kIHVzZSBpdCBpbiB0aGUg bWFrZWZpbGUuCiAgICAKICAgICAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCiAg ICAKICAgICAgICAgICAgKiBHTlVtYWtlZmlsZS5hbToKICAgICAgICAgICAgKiBjb25maWd1cmUu YWM6CiAgICAKICAgIDIwMTEtMTEtMjkgIEFsZWphbmRybyBHLiBDYXN0cm8gIDxhbGV4QGlnYWxp YS5jb20+CiAgICAKICAgICAgICAgICAgW0dUS10gQWRkIGFjY2VsZXJhdGVkIGNvbXBvc2l0aW5n IGNvbXBpbGF0aW9uIG9wdGlvbgogICAgICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NzMyOTgKICAgIAogICAgICAgICAgICBDb21waWxlIHdoYXRldmVyIHdl IGhhdmUgaW5zaWRlIHRoZSBVU0UoQUNDRUxFUkFURURfQ09NUE9TSVRJTkcpCiAgICAgICAgICAg IGRlZmluZS4gRml4IGFjY2VsZXJhdGVkIGNvbXBvc2l0aW5nIGNvbXBpbGF0aW9uIGluIFdLMiwg dXBkYXRlIHRoZQogICAgICAgICAgICBlbnRlci9leGl0IGZ1bmN0aW9ucy4KICAgIAogICAgICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KICAgIAogICAgICAgICAgICAqIFVJUHJv Y2Vzcy9BUEkvZ3RrL1BhZ2VDbGllbnRJbXBsLmNwcDoKICAgICAgICAgICAgKFdlYktpdDo6UGFn ZUNsaWVudEltcGw6OmVudGVyQWNjZWxlcmF0ZWRDb21wb3NpdGluZ01vZGUpOgogICAgICAgICAg ICAoV2ViS2l0OjpQYWdlQ2xpZW50SW1wbDo6ZXhpdEFjY2VsZXJhdGVkQ29tcG9zaXRpbmdNb2Rl KToKICAgICAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2d0ay9QYWdlQ2xpZW50SW1wbC5oOgoKZGlm ZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCBhNmJkNDIxLi4zNjU2NmM3IDEw MDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIw MTEtMTEtMjkgIEFsZWphbmRybyBHLiBDYXN0cm8gIDxhbGV4QGlnYWxpYS5jb20+CisKKyAgICAg ICAgW0dUS10gQWRkIGFjY2VsZXJhdGVkIGNvbXBvc2l0aW5nIGNvbXBpbGF0aW9uIG9wdGlvbgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzMyOTgKKwor ICAgICAgICBDb21waWxlIHdoYXRldmVyIHdlIGhhdmUgaW5zaWRlIHRoZSBVU0UoQUNDRUxFUkFU RURfQ09NUE9TSVRJTkcpCisgICAgICAgIGRlZmluZS4gQWRkIHRoZSBidWlsZCBjb21waWxhdGlv biBvcHRpb24KKyAgICAgICAgLS13aXRoLWFjY2VsZXJhdGVkLWNvbXBvc2l0aW5nIGFuZCB1c2Ug aXQgaW4gdGhlIG1ha2VmaWxlLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogR05VbWFrZWZpbGUuYW06CisgICAgICAgICogY29uZmlndXJlLmFjOgor CiAyMDExLTExLTI5ICBSb2xhbmQgU3RlaW5lciAgPHJvbGFuZHN0ZWluZXJAY2hyb21pdW0ub3Jn PgogCiAgICAgICAgIDxzdHlsZSBzY29wZWQ+OiBhZGQgRU5BQkxFKFNUWUxFX1NDT1BFRCkgZmxh ZyB0byBXZWJLaXQKZGlmZiAtLWdpdCBhL0dOVW1ha2VmaWxlLmFtIGIvR05VbWFrZWZpbGUuYW0K aW5kZXggNGQyNzg1Zi4uY2YyZGQ4OCAxMDA2NDQKLS0tIGEvR05VbWFrZWZpbGUuYW0KKysrIGIv R05VbWFrZWZpbGUuYW0KQEAgLTE2NSw2ICsxNjUsMTEgQEAgZ2xvYmFsX2NwcGZsYWdzICs9IFwK IAktRFdURl9VU0VfR1NUUkVBTUVSPTEKIGVuZGlmCiAKK2lmIFVTRV9BQ0NFTEVSQVRFRF9DT01Q T1NJVElORworZ2xvYmFsX2NwcGZsYWdzICs9IFwKKwktRFdURl9VU0VfQUNDRUxFUkFURURfQ09N UE9TSVRJTkc9MQorZW5kaWYKKwogIyAtLS0tCiAjIEdUSysgMi54LzMueCBzdXBwb3J0CiAjIC0t LS0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQy L0NoYW5nZUxvZwppbmRleCAzMzI2Y2JhLi5hMjI3MDFhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEs MTkgQEAKKzIwMTEtMTEtMjkgIEFsZWphbmRybyBHLiBDYXN0cm8gIDxhbGV4QGlnYWxpYS5jb20+ CisKKyAgICAgICAgW0dUS10gQWRkIGFjY2VsZXJhdGVkIGNvbXBvc2l0aW5nIGNvbXBpbGF0aW9u IG9wdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NzMyOTgKKworICAgICAgICBDb21waWxlIHdoYXRldmVyIHdlIGhhdmUgaW5zaWRlIHRoZSBVU0Uo QUNDRUxFUkFURURfQ09NUE9TSVRJTkcpCisgICAgICAgIGRlZmluZS4gRml4IGFjY2VsZXJhdGVk IGNvbXBvc2l0aW5nIGNvbXBpbGF0aW9uIGluIFdLMiwgdXBkYXRlIHRoZQorICAgICAgICBlbnRl ci9leGl0IGZ1bmN0aW9ucy4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZ3RrL1BhZ2VDbGllbnRJbXBsLmNwcDoKKyAgICAg ICAgKFdlYktpdDo6UGFnZUNsaWVudEltcGw6OmVudGVyQWNjZWxlcmF0ZWRDb21wb3NpdGluZ01v ZGUpOgorICAgICAgICAoV2ViS2l0OjpQYWdlQ2xpZW50SW1wbDo6ZXhpdEFjY2VsZXJhdGVkQ29t cG9zaXRpbmdNb2RlKToKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2d0ay9QYWdlQ2xpZW50SW1w bC5oOgorCiAyMDExLTExLTI5ICBLZW5uZXRoIFJvaGRlIENocmlzdGlhbnNlbiAgPGtlbm5ldGhA d2Via2l0Lm9yZz4KIAogICAgICAgICBbUXRdIFFRdWlja1dlYlZpZXcgZ2V0cyB3cm9uZyBwb3Np dGlvbiBhZnRlciByZWxvYWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9B UEkvZ3RrL1BhZ2VDbGllbnRJbXBsLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkv Z3RrL1BhZ2VDbGllbnRJbXBsLmNwcAppbmRleCAyMWQ2MThiLi4wZTQzMjU5IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9QYWdlQ2xpZW50SW1wbC5jcHAKKysr IGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvUGFnZUNsaWVudEltcGwuY3BwCkBA IC0yMzEsMTIgKzIzMSwxMiBAQCB2b2lkIFBhZ2VDbGllbnRJbXBsOjpzZXRGaW5kSW5kaWNhdG9y KFBhc3NSZWZQdHI8RmluZEluZGljYXRvcj4sIGJvb2wgZmFkZU91dCwgYgogfQogCiAjaWYgVVNF KEFDQ0VMRVJBVEVEX0NPTVBPU0lUSU5HKQotdm9pZCBQYWdlQ2xpZW50SW1wbDo6cGFnZURpZEVu dGVyQWNjZWxlcmF0ZWRDb21wb3NpdGluZygpCit2b2lkIFBhZ2VDbGllbnRJbXBsOjplbnRlckFj Y2VsZXJhdGVkQ29tcG9zaXRpbmdNb2RlKGNvbnN0IExheWVyVHJlZUNvbnRleHQmKQogewogICAg IG5vdEltcGxlbWVudGVkKCk7CiB9CiAKLXZvaWQgUGFnZUNsaWVudEltcGw6OnBhZ2VEaWRMZWF2 ZUFjY2VsZXJhdGVkQ29tcG9zaXRpbmcoKQordm9pZCBQYWdlQ2xpZW50SW1wbDo6ZXhpdEFjY2Vs ZXJhdGVkQ29tcG9zaXRpbmdNb2RlKCkKIHsKICAgICBub3RJbXBsZW1lbnRlZCgpOwogfQpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvUGFnZUNsaWVudEltcGwu aCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1BhZ2VDbGllbnRJbXBsLmgKaW5k ZXggN2RjMjUxZC4uMjkxYmEyMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0FQSS9ndGsvUGFnZUNsaWVudEltcGwuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv QVBJL2d0ay9QYWdlQ2xpZW50SW1wbC5oCkBAIC05MCw4ICs5MCw4IEBAIHByaXZhdGU6CiAgICAg dmlydHVhbCB2b2lkIHN0YXJ0RHJhZyhjb25zdCBXZWJDb3JlOjpEcmFnRGF0YSYsIFBhc3NSZWZQ dHI8U2hhcmVhYmxlQml0bWFwPiBkcmFnSW1hZ2UpOwogCiAjaWYgVVNFKEFDQ0VMRVJBVEVEX0NP TVBPU0lUSU5HKQotICAgIHZpcnR1YWwgdm9pZCBwYWdlRGlkRW50ZXJBY2NlbGVyYXRlZENvbXBv c2l0aW5nKCk7Ci0gICAgdmlydHVhbCB2b2lkIHBhZ2VEaWRMZWF2ZUFjY2VsZXJhdGVkQ29tcG9z aXRpbmcoKTsKKyAgICB2aXJ0dWFsIHZvaWQgZW50ZXJBY2NlbGVyYXRlZENvbXBvc2l0aW5nTW9k ZShjb25zdCBMYXllclRyZWVDb250ZXh0Jik7CisgICAgdmlydHVhbCB2b2lkIGV4aXRBY2NlbGVy YXRlZENvbXBvc2l0aW5nTW9kZSgpOwogI2VuZGlmCiAKICAgICB2aXJ0dWFsIHZvaWQgZGlkQ29t bWl0TG9hZEZvck1haW5GcmFtZShib29sIHVzZUN1c3RvbVJlcHJlc2VudGF0aW9uKTsKZGlmZiAt LWdpdCBhL2NvbmZpZ3VyZS5hYyBiL2NvbmZpZ3VyZS5hYwppbmRleCAwMTcxYTE2Li5mNzQ1ZjAz IDEwMDY0NAotLS0gYS9jb25maWd1cmUuYWMKKysrIGIvY29uZmlndXJlLmFjCkBAIC0zODYsNyAr Mzg2LDE1IEBAIEFDX0FSR19FTkFCTEUod2ViZ2wsCiAgICAgICAgICAgICAgIFtdLCBbaWYgdGVz dCAiJHdpdGhfdGFyZ2V0IiA9ICJ4MTEiOyB0aGVuIGVuYWJsZV93ZWJnbD0ieWVzIjsgZWxzZSBl bmFibGVfd2ViZ2w9Im5vIjsgZmldKQogQUNfTVNHX1JFU1VMVChbJGVuYWJsZV93ZWJnbF0pCiAK LWlmIHRlc3QgIiRlbmFibGVfd2ViZ2wiID0gInllcyI7IHRoZW4KKyMgY2hlY2sgd2hldGhlciB0 byBlbmFibGUgYWNjZWxlcmF0ZWQgY29tcG9zaXRpbmcgc3VwcG9ydAorQUNfTVNHX0NIRUNLSU5H KFt3aGV0aGVyIHRvIGVuYWJsZSBhY2NlbGVyYXRlZCBjb21wb3NpdGluZyBzdXBwb3J0XSkKK0FD X0FSR19XSVRIKGFjY2VsZXJhdGVkX2NvbXBvc2l0aW5nLAorICAgICAgICAgICAgQUNfSEVMUF9T VFJJTkcoWy0td2l0aC1hY2NlbGVyYXRlZC1jb21wb3NpdGluZ10sCisgICAgICAgICAgICAgICAg ICAgICAgICAgICBbdXNlIGFjY2VsZXJhdGVkIGNvbXBvc2l0aW5nIChleHBlcmltZW50YWwpIFtk ZWZhdWx0PW5vXV0pLAorICAgICAgICAgICAgW10sIFt3aXRoX2FjY2VsZXJhdGVkX2NvbXBvc2l0 aW5nPSJubyJdKQorQUNfTVNHX1JFU1VMVChbJHdpdGhfYWNjZWxlcmF0ZWRfY29tcG9zaXRpbmdd KQorCitpZiB0ZXN0ICIkZW5hYmxlX3dlYmdsIiA9ICJ5ZXMiIHx8IHRlc3QgIndpdGhfYWNjZWxl cmF0ZWRfY29tcG9zaXRpbmciID0gInllcyI7IHRoZW4KICAgICBBQ19DSEVDS19IRUFERVJTKFtH TC9nbC5oXSwgW10sIEFDX01TR19FUlJPUihbT3BlbkdMIGhlYWRlciBub3QgZm91bmRdKSkKICAg ICBBQ19DSEVDS19IRUFERVJTKFtHTC9nbHguaF0sIFtdLCBBQ19NU0dfRVJST1IoW0dMWCBoZWFk ZXIgbm90IGZvdW5kXSkpCiAgICAgT1BFTkdMX0xJQlM9Ii1sR0wgLWxkbCIKQEAgLTExNDYsNiAr MTE1NCw5IEBAIEFNX0NPTkRJVElPTkFMKFtVU0VfR1NUUkVBTUVSXSwgW3Rlc3QgIiRoYXZlX2dz dHJlYW1lciIgPSAieWVzIl0pCiAjIFdlYiBBdWRpbyBmZWF0dXJlIGNvbmRpdGlvbmFsCiBBTV9D T05ESVRJT05BTChbVVNFX1dFQkFVRElPX0ZGVFddLCBbdGVzdCAiJGhhdmVfZmZ0dyIgPSAieWVz Il0pCiAKKyMgQWNjZWxlcmF0ZWQgY29tcG9zaXRpbmcgY29uZGl0aW9uYWwKK0FNX0NPTkRJVElP TkFMKFtVU0VfQUNDRUxFUkFURURfQ09NUE9TSVRJTkddLCBbdGVzdCAiJHdpdGhfYWNjZWxlcmF0 ZWRfY29tcG9zaXRpbmciID0gInllcyJdKQorCiAjIFdlYktpdCBmZWF0dXJlIGNvbmRpdGlvbmFs cwogQU1fQ09ORElUSU9OQUwoW0VOQUJMRV9ERUJVR10sW3Rlc3QgIiRlbmFibGVfZGVidWdfZmVh dHVyZXMiID0gInllcyJdKQogQU1fQ09ORElUSU9OQUwoW0VOQUJMRV8zRF9SRU5ERVJJTkddLFt0 ZXN0ICIkZW5hYmxlXzNkX3JlbmRlcmluZyIgPSAieWVzIl0pCkBAIC0xMjUzLDYgKzEyNjQsNyBA QCBCdWlsZCBjb25maWd1cmF0aW9uOgogIEZvbnQgYmFja2VuZCAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIDogJHdpdGhfZm9udF9iYWNrZW5kCiAgT3B0aW1pemVk IG1lbW9yeSBhbGxvY2F0b3IgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgOiAkZW5hYmxl X2Zhc3RfbWFsbG9jCiAgSmF2YVNjcmlwdCBFbmdpbmUgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgOiAkd2l0aF9qc2VuZ2luZQorIEFjY2VsZXJhdGVkIENvbXBvc2l0aW5n ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDogJHdpdGhfYWNjZWxlcmF0ZWRfY29t cG9zaXRpbmcKIAogRmVhdHVyZXM6CiAgM0QgUmVuZGVyaW5nICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgOiAkZW5hYmxlXzNkX3JlbmRlcmluZwo=