73296 2011-11-29 01:58:25 -0800 [GTK] generate-gtkdoc should respect build type 2011-12-02 10:17:31 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mrobinson mrobinson webkit.review.bot oldest_to_newest 510615 0 mrobinson 2011-11-29 01:58:25 -0800 Right now generate-gtkdoc just tries to guess what your build type is, with a preference toward a release build. It shoud be smarter about what type of build you are using by means of a command-line parameter. 510619 1 116925 mrobinson 2011-11-29 02:03:38 -0800 Created attachment 116925 Patch 511825 2 116925 pnormand 2011-11-30 10:00:31 -0800 Comment on attachment 116925 Patch LGTM 511839 3 116925 webkit.review.bot 2011-11-30 10:08:25 -0800 Comment on attachment 116925 Patch Rejecting attachment 116925 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Philippe Normand', u'-..." exit_code: 1 Parsed 3 diffs from patch file(s). patching file Tools/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Tools/Scripts/webkitdirs.pm patching file Tools/gtk/common.py Hunk #1 FAILED at 40. 1 out of 1 hunk FAILED -- saving rejects to file Tools/gtk/common.py.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Philippe Normand', u'-..." exit_code: 1 Full output: http://queues.webkit.org/results/10704207 513892 4 mrobinson 2011-12-02 10:17:31 -0800 Committed r101820: <http://trac.webkit.org/changeset/101820> 116925 2011-11-29 02:03:38 -0800 2011-11-30 10:08:25 -0800 Patch bug-73296-20111129110337.patch text/plain 3150 mrobinson U3VidmVyc2lvbiBSZXZpc2lvbjogMTAxMjg4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYmVjNTNmNzZhMTRiNjMxZGNkOTljMWY2Y2ExNTRiNjQw ZjQ1NzZhNC4uNTBhMDE4Y2E5NWYxYzljNTA0NmJhZTdjN2M3NWQ5YTM1YTc2ZjgwZCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDExLTExLTI5ICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4K KworICAgICAgICBbR1RLXSBnZW5lcmF0ZS1ndGtkb2Mgc2hvdWxkIHJlc3BlY3QgYnVpbGQgdHlw ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzMyOTYK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlw dHMvd2Via2l0ZGlycy5wbToKKyAgICAgICAgKGJ1aWxkQXV0b3Rvb2xzUHJvamVjdCk6IFBhc3Mg dGhlIC0tZGVidWcgdG8gdGhlIGdlbmVyYXRlLWd0a2RvYyBzY3JpcHQuCisgICAgICAgICogZ3Rr L2NvbW1vbi5weTogSWYgLS1idWlsZCBpcyBwYXNzZWQgZ2l2ZSBwcmVmZXJlbmNlIHRvIHRoZSBE ZWJ1ZyBidWlsZCBkaXJlY3RvcnkuCisKIDIwMTEtMTEtMjggIFRvbnkgQ2hhbmcgIDx0b255QGNo cm9taXVtLm9yZz4KIAogICAgICAgICBld3MgYm90cyBzaG91bGQgcGFzcyAtLWZvcmNlIHRvIHVw ZGF0ZS13ZWJraXQtY2hyb21pdW0KZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGly cy5wbSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQppbmRleCBlYTJjNmJmZTRjNmE3ODNj YjU3YjlkNzFkMGM2NDdlMGY3NmY2YzQ5Li40ZGM4MDFmYjI2NTA5NGFjNGRiNDM2MTgzNzUzZDJk OTU4MmQ0YTMxIDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KKysrIGIv VG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCkBAIC0xNjE0LDYgKzE2MTQsNyBAQCBzdWIgYnVp bGRBdXRvdG9vbHNQcm9qZWN0KCRAKQogICAgIG15ICRtYWtlID0gJ21ha2UnOwogICAgIG15ICRk aXIgPSBwcm9kdWN0RGlyKCk7CiAgICAgbXkgJGNvbmZpZyA9IHBhc3NlZENvbmZpZ3VyYXRpb24o KSB8fCBjb25maWd1cmF0aW9uKCk7CisgICAgbXkgJGRlYnVnID0gJGNvbmZpZyA9fiBtL2RlYnVn L2k7CiAgICAgbXkgJHByZWZpeDsKIAogICAgIG15IEBidWlsZEFyZ3MgPSAoKTsKQEAgLTE2NTAs NyArMTY1MSw3IEBAIHN1YiBidWlsZEF1dG90b29sc1Byb2plY3QoJEApCiAgICAgcHVzaCBAYnVp bGRBcmdzLCAiLS1wcmVmaXg9IiAuICRwcmVmaXggaWYgZGVmaW5lZCgkcHJlZml4KTsKIAogICAg ICMgY2hlY2sgaWYgY29uZmlndXJhdGlvbiBpcyBEZWJ1ZwotICAgIGlmICgkY29uZmlnID1+IG0v ZGVidWcvaSkgeworICAgIGlmICgkZGVidWcpIHsKICAgICAgICAgcHVzaCBAYnVpbGRBcmdzLCAi LS1lbmFibGUtZGVidWciOwogICAgIH0gZWxzZSB7CiAgICAgICAgIHB1c2ggQGJ1aWxkQXJncywg Ii0tZGlzYWJsZS1kZWJ1ZyI7CkBAIC0xNjkxLDcgKzE2OTIsMTMgQEAgc3ViIGJ1aWxkQXV0b3Rv b2xzUHJvamVjdCgkQCkKIAogICAgIGlmIChpc0d0aygpKSB7CiAgICAgICAgIG15ICRyZWxhdGl2 ZVNjcmlwdHNQYXRoID0gcmVsYXRpdmVTY3JpcHRzRGlyKCk7Ci0gICAgICAgIGlmIChzeXN0ZW0o IiRyZWxhdGl2ZVNjcmlwdHNQYXRoLy4uL2d0ay9nZW5lcmF0ZS1ndGtkb2MgLS1za2lwLWh0bWwi KSkgeworICAgICAgICBteSBAb3B0aW9ucyA9ICgiJHJlbGF0aXZlU2NyaXB0c1BhdGgvLi4vZ3Rr L2dlbmVyYXRlLWd0a2RvYyIsICItLXNraXAtaHRtbCIpOworCisgICAgICAgIGlmICgkZGVidWcp IHsKKyAgICAgICAgICAgIHB1c2goQG9wdGlvbnMsICItLWRlYnVnIik7CisgICAgICAgIH0KKwor ICAgICAgICBpZiAoc3lzdGVtKEBvcHRpb25zKSkgewogICAgICAgICAgICAgZGllICJcbiBndGtk b2MgZGlkIG5vdCBidWlsZCB3aXRob3V0IHdhcm5pbmdzXG4iOwogICAgICAgICB9CiAgICAgfQpk aWZmIC0tZ2l0IGEvVG9vbHMvZ3RrL2NvbW1vbi5weSBiL1Rvb2xzL2d0ay9jb21tb24ucHkKaW5k ZXggYzQwMDNmMTMxMTljYmZmMzFhMTk5MTliZTJiNjNkYmRiYWU2MjMxZi4uY2VjZjI5MTRjN2Qz ZjYzYTZmMTA2NzY4NTkxNGZlNzM3YzIyMjJkMiAxMDA2NDQKLS0tIGEvVG9vbHMvZ3RrL2NvbW1v bi5weQorKysgYi9Ub29scy9ndGsvY29tbW9uLnB5CkBAIC00MCwxNSArNDAsMTYgQEAgZGVmIGdl dF9idWlsZF9wYXRoKCk6CiAgICAgICAgIHJldHVybiBidWlsZF9kaXIKIAogICAgIGRlZiBpc192 YWxpZF9idWlsZF9kaXJlY3RvcnkocGF0aCk6Ci0gICAgICAgIHJldHVybiBvcy5wYXRoLmV4aXN0 cyhvcy5wYXRoLmpvaW4ocGF0aCwgJy5saWJzJykpCisgICAgICAgIHJldHVybiBvcy5wYXRoLmV4 aXN0cyhvcy5wYXRoLmpvaW4ocGF0aCwgJ0dOVW1ha2VmaWxlJykpCiAKLSAgICBidWlsZF9kaXIg PSB0b3BfbGV2ZWxfcGF0aCgnV2ViS2l0QnVpbGQnLCAnUmVsZWFzZScpCi0gICAgaWYgaXNfdmFs aWRfYnVpbGRfZGlyZWN0b3J5KGJ1aWxkX2Rpcik6Ci0gICAgICAgIHJldHVybiBidWlsZF9kaXIK KyAgICBidWlsZF90eXBlcyA9IFsnUmVsZWFzZScsICdEZWJ1ZyddCisgICAgaWYgJy0tZGVidWcn IGluIHN5cy5hcmd2OgorICAgICAgICBidWlsZF90eXBlcy5yZXZlcnNlKCkKIAotICAgIGJ1aWxk X2RpciA9IHRvcF9sZXZlbF9wYXRoKCdXZWJLaXRCdWlsZCcsICdEZWJ1ZycpCi0gICAgaWYgaXNf dmFsaWRfYnVpbGRfZGlyZWN0b3J5KGJ1aWxkX2Rpcik6Ci0gICAgICAgIHJldHVybiBidWlsZF9k aXIKKyAgICBmb3IgYnVpbGRfdHlwZSBpbiBidWlsZF90eXBlczoKKyAgICAgICAgYnVpbGRfZGly ID0gdG9wX2xldmVsX3BhdGgoJ1dlYktpdEJ1aWxkJywgYnVpbGRfdHlwZSkKKyAgICAgICAgaWYg aXNfdmFsaWRfYnVpbGRfZGlyZWN0b3J5KGJ1aWxkX2Rpcik6CisgICAgICAgICAgICByZXR1cm4g YnVpbGRfZGlyCiAKICAgICAjIGRpc3RjaGVjayBidWlsZHMgaW4gYSBkaXJlY3RvcnkgbmFtZWQg X2J1aWxkIGluIHRoZSB0b3AtbGV2ZWwgcGF0aC4KICAgICBidWlsZF9kaXIgPSB0b3BfbGV2ZWxf cGF0aCgiX2J1aWxkIikK