73271 2011-11-28 17:32:51 -0800 Size of ResourceRequestBase could be reduced by using bitfields. 2011-11-28 22:26:07 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All Unspecified RESOLVED FIXED P2 Normal --- 1 yongjun_zhang webkit-unassigned webkit.review.bot yongjun_zhang oldest_to_newest 510362 0 yongjun_zhang 2011-11-28 17:32:51 -0800 ResourceRequestBase has 6 bool data members; we could use bitfields to reduce its memory size. 510374 1 116859 yongjun_zhang 2011-11-28 17:47:42 -0800 Created attachment 116859 Add bitfields for data members in ResourceRequestBase. 510501 2 116859 webkit.review.bot 2011-11-28 22:26:03 -0800 Comment on attachment 116859 Add bitfields for data members in ResourceRequestBase. Clearing flags on attachment: 116859 Committed r101327: <http://trac.webkit.org/changeset/101327> 510502 3 webkit.review.bot 2011-11-28 22:26:07 -0800 All reviewed patches have been landed. Closing bug. 116859 2011-11-28 17:47:42 -0800 2011-11-28 22:26:03 -0800 Add bitfields for data members in ResourceRequestBase. bug_73271.patch text/plain 1705 yongjun_zhang SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwMTMxMCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDExLTExLTI4ICBZb25nanVu IFpoYW5nICA8eW9uZ2p1bl96aGFuZ0BhcHBsZS5jb20+CisKKyAgICAgICAgU2l6ZSBvZiBSZXNv dXJjZVJlcXVlc3RCYXNlIGNvdWxkIGJlIHJlZHVjZWQgYnkgdXNpbmcgYml0ZmllbGRzLgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzMyNzEKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgYml0ZmllbGQg Zm9yIGJvb2wgbWVtYmVycyBpbiBSZXNvdXJjZVJlcXVlc3RCYXNlIHRvIHJlZHVjZSBpdHMgbWVt b3J5IHNpemUuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL1Jlc291cmNlUmVxdWVzdEJh c2UuaDoKKwogMjAxMS0xMS0yOCAgUmFmYWVsIFdlaW5zdGVpbiAgPHJhZmFlbHdAY2hyb21pdW0u b3JnPgogCiAgICAgICAgIFtNdXRhdGlvbk9ic2VydmVyc10gRml4IGJ1aWxkIGJyZWFrYWdlIGFm dGVyIENTU0lubGluZURlY2xhcmF0aW9uIHJlZmFjdG9yCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9uZXR3b3JrL1Jlc291cmNlUmVxdWVzdEJhc2UuaAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL1Jlc291cmNlUmVxdWVzdEJhc2UuaAkocmV2aXNp b24gMTAxMzAwKQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9SZXNvdXJjZVJl cXVlc3RCYXNlLmgJKHdvcmtpbmcgY29weSkKQEAgLTE4NCwxMiArMTg0LDEyIEBAIG5hbWVzcGFj ZSBXZWJDb3JlIHsKICAgICAgICAgVmVjdG9yPFN0cmluZz4gbV9yZXNwb25zZUNvbnRlbnREaXNw b3NpdGlvbkVuY29kaW5nRmFsbGJhY2tBcnJheTsKICNlbmRpZgogICAgICAgICBSZWZQdHI8Rm9y bURhdGE+IG1faHR0cEJvZHk7Ci0gICAgICAgIGJvb2wgbV9hbGxvd0Nvb2tpZXM7Ci0gICAgICAg IG11dGFibGUgYm9vbCBtX3Jlc291cmNlUmVxdWVzdFVwZGF0ZWQ7Ci0gICAgICAgIG11dGFibGUg Ym9vbCBtX3BsYXRmb3JtUmVxdWVzdFVwZGF0ZWQ7Ci0gICAgICAgIGJvb2wgbV9yZXBvcnRVcGxv YWRQcm9ncmVzczsKLSAgICAgICAgYm9vbCBtX3JlcG9ydExvYWRUaW1pbmc7Ci0gICAgICAgIGJv b2wgbV9yZXBvcnRSYXdIZWFkZXJzOworICAgICAgICBib29sIG1fYWxsb3dDb29raWVzIDogMTsK KyAgICAgICAgbXV0YWJsZSBib29sIG1fcmVzb3VyY2VSZXF1ZXN0VXBkYXRlZCA6IDE7CisgICAg ICAgIG11dGFibGUgYm9vbCBtX3BsYXRmb3JtUmVxdWVzdFVwZGF0ZWQgOiAxOworICAgICAgICBi b29sIG1fcmVwb3J0VXBsb2FkUHJvZ3Jlc3MgOiAxOworICAgICAgICBib29sIG1fcmVwb3J0TG9h ZFRpbWluZyA6IDE7CisgICAgICAgIGJvb2wgbV9yZXBvcnRSYXdIZWFkZXJzIDogMTsKICAgICAg ICAgUmVzb3VyY2VMb2FkUHJpb3JpdHkgbV9wcmlvcml0eTsKIAogICAgIHByaXZhdGU6Cg==