73269 2011-11-28 17:08:03 -0800 js-test-pre: don't try to load stylesheet from a web worker 2011-11-28 22:41:51 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dgrogan dgrogan arv ojan webkit.review.bot oldest_to_newest 510344 0 dgrogan 2011-11-28 17:08:03 -0800 js-test-pre: don't try to load stylesheet from a web worker 510347 1 116854 dgrogan 2011-11-28 17:11:20 -0800 Created attachment 116854 Patch 510351 2 dgrogan 2011-11-28 17:15:08 -0800 Ojan, could you review this? 510398 3 116854 ojan 2011-11-28 18:52:02 -0800 Comment on attachment 116854 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=116854&action=review > LayoutTests/ChangeLog:8 > + The other DOM-modification functions can be overridden but > + insertStyleSheet is called when js-test-pre loads. I'm fine with adding the logic to make this file work in workers here. No need to override IMO. That will just make it harder to maintain the file since the definitions will be in different places. > LayoutTests/fast/js/resources/js-test-pre.js:72 > + if (typeof document !== 'undefined') I would find this more readable if you made an isWorker helper function that returned this value. 510412 4 dgrogan 2011-11-28 19:29:52 -0800 (In reply to comment #3) > (From update of attachment 116854 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=116854&action=review > > > LayoutTests/ChangeLog:8 > > + The other DOM-modification functions can be overridden but > > + insertStyleSheet is called when js-test-pre loads. > > I'm fine with adding the logic to make this file work in workers here. No need to override IMO. That will just make it harder to maintain the file since the definitions will be in different places. Sounds good. > > LayoutTests/fast/js/resources/js-test-pre.js:72 > > + if (typeof document !== 'undefined') > > I would find this more readable if you made an isWorker helper function that returned this value. Done. 510413 5 116871 dgrogan 2011-11-28 19:30:32 -0800 Created attachment 116871 Patch for landing 510423 6 116871 webkit.review.bot 2011-11-28 19:48:29 -0800 Comment on attachment 116871 Patch for landing Clearing flags on attachment: 116871 Committed r101320: <http://trac.webkit.org/changeset/101320> 510424 7 webkit.review.bot 2011-11-28 19:48:33 -0800 All reviewed patches have been landed. Closing bug. 510508 8 116871 arv 2011-11-28 22:35:40 -0800 Comment on attachment 116871 Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=116871&action=review What tests inserts this in a worker? > LayoutTests/fast/js/resources/js-test-pre.js:80 > window.onerror = function(message) Doesn't the above line fail too? 510513 9 dgrogan 2011-11-28 22:41:51 -0800 (In reply to comment #8) > (From update of attachment 116871 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=116871&action=review > > What tests inserts this in a worker? Nothing checked in yet, but I have a few tests for indexeddb on workers locally that do. > > LayoutTests/fast/js/resources/js-test-pre.js:80 > > window.onerror = function(message) > > Doesn't the above line fail too? My tests assign window = self if run from a worker so I didn't run into any problems with it. But I see the potential problem. 116854 2011-11-28 17:11:20 -0800 2011-11-28 19:30:29 -0800 Patch bug-73269-20111128171119.patch text/plain 1489 dgrogan U3VidmVyc2lvbiBSZXZpc2lvbjogMTAxMjc4CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMTc2YTUwZTJkODg5YWJmZTVlOWFj Y2E5MzI4MzZjNmVlMjQ2YWFkYy4uYTY3MjM0NWNlOTQzZDM3NTExODgzMGNkNTMwMDc4ZGM0MzBh YmRkMyAxMDA3NTUKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDExLTExLTI4ICBEYXZpZCBHcm9nYW4gIDxk Z3JvZ2FuQGNocm9taXVtLm9yZz4KKworICAgICAgICBqcy10ZXN0LXByZTogZG9uJ3QgdHJ5IHRv IGxvYWQgc3R5bGVzaGVldCBmcm9tIGEgd2ViIHdvcmtlcgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzMyNjkKKworICAgICAgICBJJ20gZ29pbmcgdG8g c3RhcnQgaW5jbHVkaW5nIGpzLXRlc3QtcHJlLmpzIGluIHdvcmtlciB0ZXN0cy4KKyAgICAgICAg VGhlIG90aGVyIERPTS1tb2RpZmljYXRpb24gZnVuY3Rpb25zIGNhbiBiZSBvdmVycmlkZGVuIGJ1 dAorICAgICAgICBpbnNlcnRTdHlsZVNoZWV0IGlzIGNhbGxlZCB3aGVuIGpzLXRlc3QtcHJlIGxv YWRzLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog ZmFzdC9qcy9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanM6CisKIDIwMTEtMTEtMjggIEZhZHkgU2Ft dWVsICA8ZnNhbXVlbEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgRml4IEFzcGVjdCBSYXRpbyBQ cm9wZXJ0eSBJbmhlcml0YW5jZSBBbmQgTWFrZSB0aGUgQ29tcHV0ZWQgVmFsdWUgRXF1YWwgdGhl IFNwZWNpZmllZCBWYWx1ZQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9qcy9yZXNvdXJj ZXMvanMtdGVzdC1wcmUuanMgYi9MYXlvdXRUZXN0cy9mYXN0L2pzL3Jlc291cmNlcy9qcy10ZXN0 LXByZS5qcwppbmRleCAzODQ0MjdmZDIxZjU5Yzc3M2NhZjljNTM1YTRkYTA5MjhhYjhhMDIwLi45 OWYwOGI3MDY4YzIyZDdmZTFjMjBmOWY4M2NjMTg0ZGE0NDE2Y2U1IDEwMDY0NAotLS0gYS9MYXlv dXRUZXN0cy9mYXN0L2pzL3Jlc291cmNlcy9qcy10ZXN0LXByZS5qcworKysgYi9MYXlvdXRUZXN0 cy9mYXN0L2pzL3Jlc291cmNlcy9qcy10ZXN0LXByZS5qcwpAQCAtNjksNyArNjksOCBAQCB2YXIg ZGVzY3JpcHRpb24sIGRlYnVnLCBzdWNjZXNzZnVsbHlQYXJzZWQsIGVycm9yTWVzc2FnZTsKICAg ICAgICAgKGRvY3VtZW50LmhlYWQgfHwgZG9jdW1lbnQuZG9jdW1lbnRFbGVtZW50KS5hcHBlbmRD aGlsZChzdHlsZUVsZW1lbnQpOwogICAgIH0KICAgICAKLSAgICBpbnNlcnRTdHlsZVNoZWV0KCk7 CisgICAgaWYgKHR5cGVvZiBkb2N1bWVudCAhPT0gJ3VuZGVmaW5lZCcpCisgICAgICAgIGluc2Vy dFN0eWxlU2hlZXQoKTsKIAogICAgIHdpbmRvdy5vbmVycm9yID0gZnVuY3Rpb24obWVzc2FnZSkK ICAgICB7Cg== 116871 2011-11-28 19:30:32 -0800 2011-11-28 22:35:40 -0800 Patch for landing bug-73269-20111128193031.patch text/plain 1556 dgrogan U3VidmVyc2lvbiBSZXZpc2lvbjogMTAxMjc4CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMTc2YTUwZTJkODg5YWJmZTVlOWFj Y2E5MzI4MzZjNmVlMjQ2YWFkYy4uY2NjM2QxZTU4ZmQzOTgxNzM1MTk2NmU2MGQ2ZjU1MDFlYzBi ZTQ2MiAxMDA3NTUKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDExLTExLTI4ICBEYXZpZCBHcm9nYW4gIDxk Z3JvZ2FuQGNocm9taXVtLm9yZz4KKworICAgICAgICBqcy10ZXN0LXByZTogZG9uJ3QgdHJ5IHRv IGxvYWQgc3R5bGVzaGVldCBmcm9tIGEgd2ViIHdvcmtlcgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzMyNjkKKworICAgICAgICBSZXZpZXdlZCBieSBP amFuIFZhZmFpLgorCisgICAgICAgICogZmFzdC9qcy9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanM6 CisKIDIwMTEtMTEtMjggIEZhZHkgU2FtdWVsICA8ZnNhbXVlbEBjaHJvbWl1bS5vcmc+CiAKICAg ICAgICAgRml4IEFzcGVjdCBSYXRpbyBQcm9wZXJ0eSBJbmhlcml0YW5jZSBBbmQgTWFrZSB0aGUg Q29tcHV0ZWQgVmFsdWUgRXF1YWwgdGhlIFNwZWNpZmllZCBWYWx1ZQpkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvZmFzdC9qcy9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMgYi9MYXlvdXRUZXN0cy9m YXN0L2pzL3Jlc291cmNlcy9qcy10ZXN0LXByZS5qcwppbmRleCAzODQ0MjdmZDIxZjU5Yzc3M2Nh ZjljNTM1YTRkYTA5MjhhYjhhMDIwLi45MzE1NDI2ZTcxMDc0ODUyZTI4NWYxZDJjM2E3ZTRjY2U1 ZTRmMjA4IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L2pzL3Jlc291cmNlcy9qcy10ZXN0 LXByZS5qcworKysgYi9MYXlvdXRUZXN0cy9mYXN0L2pzL3Jlc291cmNlcy9qcy10ZXN0LXByZS5q cwpAQCAtNDgsNiArNDgsMTEgQEAgdmFyIGRlc2NyaXB0aW9uLCBkZWJ1Zywgc3VjY2Vzc2Z1bGx5 UGFyc2VkLCBlcnJvck1lc3NhZ2U7CiAgICAgICAgIHNwYW4uaW5uZXJIVE1MID0gbXNnICsgJzxi ciAvPic7CiAgICAgfTsKIAorICAgIGZ1bmN0aW9uIGlzV29ya2VyKCkKKyAgICB7CisgICAgICAg IHJldHVybiB0eXBlb2YgZG9jdW1lbnQgPT09ICd1bmRlZmluZWQnOworICAgIH0KKwogICAgIHZh ciBjc3MgPQogICAgICAgICAiLnBhc3MgeyIgKwogICAgICAgICAgICAgImZvbnQtd2VpZ2h0OiBi b2xkOyIgKwpAQCAtNjksNyArNzQsOCBAQCB2YXIgZGVzY3JpcHRpb24sIGRlYnVnLCBzdWNjZXNz ZnVsbHlQYXJzZWQsIGVycm9yTWVzc2FnZTsKICAgICAgICAgKGRvY3VtZW50LmhlYWQgfHwgZG9j dW1lbnQuZG9jdW1lbnRFbGVtZW50KS5hcHBlbmRDaGlsZChzdHlsZUVsZW1lbnQpOwogICAgIH0K ICAgICAKLSAgICBpbnNlcnRTdHlsZVNoZWV0KCk7CisgICAgaWYgKCFpc1dvcmtlcigpKQorICAg ICAgICBpbnNlcnRTdHlsZVNoZWV0KCk7CiAKICAgICB3aW5kb3cub25lcnJvciA9IGZ1bmN0aW9u KG1lc3NhZ2UpCiAgICAgewo=