73261 2011-11-28 15:42:48 -0800 Some of the results.json files have results/times entries at the directory level 2011-11-28 16:13:20 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ojan ojan tony oldest_to_newest 510279 0 ojan 2011-11-28 15:42:48 -0800 Some of the results.json files have results/times entries at the directory level 510281 1 116842 ojan 2011-11-28 15:44:46 -0800 Created attachment 116842 Patch 510284 2 116842 tony 2011-11-28 15:49:26 -0800 Comment on attachment 116842 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=116842&action=review > Tools/ChangeLog:8 > + This is just a bug that go introduced in a temporary push of the results server. Nit: go -> got > Tools/TestResultServer/model/jsonresults.py:86 > + # Once the data is fixe, this should assert that the directory level does not have Nit: fixe -> fixed > Tools/TestResultServer/model/jsonresults.py:123 > + logging.error("Failed to load json results: %s", traceback.print_exception(*sys.exc_info())) Nit: I think there are 2 spaces after the , instead of 1. 510308 3 ojan 2011-11-28 16:13:20 -0800 Committed r101299: <http://trac.webkit.org/changeset/101299> 116842 2011-11-28 15:44:46 -0800 2011-11-28 15:49:26 -0800 Patch bug-73261-20111128154444.patch text/plain 6507 ojan U3VidmVyc2lvbiBSZXZpc2lvbjogMTAxMjgwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOGQxZTI2NjRmNmE4OTlhMTFmMWYyZmJiZDc1NTM2NDRk OTM5NmRjYy4uY2U2NTY4MmViMmM4ZTdhNjMwNzdjZjg2ZjAxNjU4ZjM0YzcxN2U2MiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI2 IEBACiAyMDExLTExLTI4ICBPamFuIFZhZmFpICA8b2phbkBjaHJvbWl1bS5vcmc+CiAKKyAgICAg ICAgU29tZSBvZiB0aGUgcmVzdWx0cy5qc29uIGZpbGVzIGhhdmUgcmVzdWx0cy90aW1lcyBlbnRy aWVzIGF0IHRoZSBkaXJlY3RvcnkgbGV2ZWwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTczMjYxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgVGhpcyBpcyBqdXN0IGEgYnVnIHRoYXQgZ28gaW50cm9kdWNlZCBp biBhIHRlbXBvcmFyeSBwdXNoIG9mIHRoZSByZXN1bHRzIHNlcnZlci4KKyAgICAgICAgVGhpcyBw YXRjaCByZXBhaXJzIHRoZSBicm9rZW4gZmlsZXMuIEFmdGVyIGFsbCB0aGUgYm90cyBoYXZlIGN5 Y2xlZCwgd2UgY2FuIHNpbXBsaWZ5CisgICAgICAgIHRoaXMgY29kZSB0byBqdXN0IGFzc2VydCB0 aGF0IHJlc3VsdHMvdGltZXMgYXJlIG5vdCBhdCB0aGUgZGlyZWN0b3J5IGxldmVsLgorCisgICAg ICAgIEFsc28sIHdoZW4gY2F0Y2hpbmcgZXhjZXB0aW9ucywgbG9nIHRoZSBmdWxsIHN0YWNrdHJh Y2UuCisKKyAgICAgICAgKiBUZXN0UmVzdWx0U2VydmVyL21vZGVsL2pzb25yZXN1bHRzLnB5Ogor ICAgICAgICAoX2lzX2RpcmVjdG9yeSk6CisgICAgICAgIChKc29uUmVzdWx0cy5fbG9hZF9qc29u KToKKyAgICAgICAgKEpzb25SZXN1bHRzLl9tZXJnZV90ZXN0cyk6CisgICAgICAgIChKc29uUmVz dWx0cy5tZXJnZSk6CisgICAgICAgICogVGVzdFJlc3VsdFNlcnZlci9tb2RlbC9qc29ucmVzdWx0 c191bml0dGVzdC5weToKKyAgICAgICAgKEpzb25SZXN1bHRzVGVzdC50ZXN0X21lcmdlX2RpcmVj dG9yeV9oaWVyYXJjaHlfZXh0cmFfcmVzdWx0c19hbmRfdGltZXMpOgorCisyMDExLTExLTI4ICBP amFuIFZhZmFpICA8b2phbkBjaHJvbWl1bS5vcmc+CisKICAgICAgICAgdGVzdGxpc3Rqc29uIG9u IHRoZSB0ZXN0IHJlc3VsdHMgc2VydmVyIGRvZXNuJ3QgdW5kZXJzdGFuZCBoaWVyYXJjaGljYWwg cmVzdWx0cyBmb3JtYXQKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTczMjQ2CiAKZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RSZXN1bHRTZXJ2ZXIvbW9kZWwv anNvbnJlc3VsdHMucHkgYi9Ub29scy9UZXN0UmVzdWx0U2VydmVyL21vZGVsL2pzb25yZXN1bHRz LnB5CmluZGV4IGQ5ZjJlNWFlM2ZlYjQ1YjFlZmIwMWZjNjI3YmNmNTcwNDUxZTQxZjIuLjVmZmZj MmE5YTJlZTU0MDJjYTViZmJlNmQzYWUwZDgzYzQ0YjM4MjkgMTAwNzU1Ci0tLSBhL1Rvb2xzL1Rl c3RSZXN1bHRTZXJ2ZXIvbW9kZWwvanNvbnJlc3VsdHMucHkKKysrIGIvVG9vbHMvVGVzdFJlc3Vs dFNlcnZlci9tb2RlbC9qc29ucmVzdWx0cy5weQpAQCAtMjksNiArMjksOCBAQAogZnJvbSBkYXRl dGltZSBpbXBvcnQgZGF0ZXRpbWUKIGZyb20gZGphbmdvLnV0aWxzIGltcG9ydCBzaW1wbGVqc29u CiBpbXBvcnQgbG9nZ2luZworaW1wb3J0IHN5cworaW1wb3J0IHRyYWNlYmFjawogCiBmcm9tIG1v ZGVsLnRlc3RmaWxlIGltcG9ydCBUZXN0RmlsZQogCkBAIC03OSw2ICs4MSwyMiBAQCBkZWYgX3Ry aWVfanNvbl90ZXN0cyh0ZXN0cyk6CiAgICAgcmV0dXJuIHRyaWUKIAogCitkZWYgX2lzX2RpcmVj dG9yeShzdWJ0cmVlKToKKyAgICAjIEZJWE1FOiBTb21lIGRhdGEgZ290IGNvcnJ1cHRlZCBhbmQg aGFzIHJlc3VsdHMvdGltZXMgYXQgdGhlIGRpcmVjdG9yeSBsZXZlbC4KKyAgICAjIE9uY2UgdGhl IGRhdGEgaXMgZml4ZSwgdGhpcyBzaG91bGQgYXNzZXJ0IHRoYXQgdGhlIGRpcmVjdG9yeSBsZXZl bCBkb2VzIG5vdCBoYXZlCisgICAgIyByZXN1bHRzIG9yIHRpbWVzIGFuZCBqdXN0IHJldHVybiAi SlNPTl9SRVNVTFRTX1JFU1VMVFMgbm90IGluIHN1YnRyZWUiLgorICAgIGlmIEpTT05fUkVTVUxU U19SRVNVTFRTIG5vdCBpbiBzdWJ0cmVlOgorICAgICAgICByZXR1cm4gVHJ1ZQorCisgICAgZm9y IGtleSBpbiBzdWJ0cmVlOgorICAgICAgICBpZiBrZXkgbm90IGluIChKU09OX1JFU1VMVFNfUkVT VUxUUywgSlNPTl9SRVNVTFRTX1RJTUVTKToKKyAgICAgICAgICAgIGRlbCBzdWJ0cmVlW0pTT05f UkVTVUxUU19SRVNVTFRTXQorICAgICAgICAgICAgZGVsIHN1YnRyZWVbSlNPTl9SRVNVTFRTX1RJ TUVTXQorICAgICAgICAgICAgcmV0dXJuIFRydWUKKworICAgIHJldHVybiBGYWxzZQorCisKIGNs YXNzIEpzb25SZXN1bHRzKG9iamVjdCk6CiAgICAgQGNsYXNzbWV0aG9kCiAgICAgZGVmIF9zdHJp cF9wcmVmaXhfc3VmZml4KGNscywgZGF0YSk6CkBAIC0xMDAsOSArMTE4LDkgQEAgY2xhc3MgSnNv blJlc3VsdHMob2JqZWN0KToKIAogICAgICAgICB0cnk6CiAgICAgICAgICAgICByZXR1cm4gc2lt cGxlanNvbi5sb2Fkcyhqc29uX3Jlc3VsdHNfc3RyKQotICAgICAgICBleGNlcHQgRXhjZXB0aW9u LCBlcnI6CisgICAgICAgIGV4Y2VwdDoKICAgICAgICAgICAgIGxvZ2dpbmcuZGVidWcoanNvbl9y ZXN1bHRzX3N0cikKLSAgICAgICAgICAgIGxvZ2dpbmcuZXJyb3IoIkZhaWxlZCB0byBsb2FkIGpz b24gcmVzdWx0czogJXMiLCBzdHIoZXJyKSkKKyAgICAgICAgICAgIGxvZ2dpbmcuZXJyb3IoIkZh aWxlZCB0byBsb2FkIGpzb24gcmVzdWx0czogJXMiLCAgdHJhY2ViYWNrLnByaW50X2V4Y2VwdGlv bigqc3lzLmV4Y19pbmZvKCkpKQogICAgICAgICAgICAgcmV0dXJuIE5vbmUKIAogICAgIEBjbGFz c21ldGhvZApAQCAtMTQyLDYgKzE2MCwxNCBAQCBjbGFzcyBKc29uUmVzdWx0cyhvYmplY3QpOgog CiAgICAgQGNsYXNzbWV0aG9kCiAgICAgZGVmIF9tZXJnZV90ZXN0cyhjbHMsIGFnZ3JlZ2F0ZWRf anNvbiwgaW5jcmVtZW50YWxfanNvbiwgbnVtX3J1bnMpOgorICAgICAgICAjIEZJWE1FOiBTb21l IGRhdGEgZ290IGNvcnJ1cHRlZCBhbmQgaGFzIHJlc3VsdHMvdGltZXMgYXQgdGhlIGRpcmVjdG9y eSBsZXZlbC4KKyAgICAgICAgIyBPbmNlIHRoZSBkYXRhIGlzIGZpeGUsIHRoaXMgc2hvdWxkIGFz c2VydCB0aGF0IHRoZSBkaXJlY3RvcnkgbGV2ZWwgZG9lcyBub3QgaGF2ZQorICAgICAgICAjIHJl c3VsdHMgb3IgdGltZXMgYW5kIGp1c3QgcmV0dXJuICJKU09OX1JFU1VMVFNfUkVTVUxUUyBub3Qg aW4gc3VidHJlZSIuCisgICAgICAgIGlmIEpTT05fUkVTVUxUU19SRVNVTFRTIGluIGFnZ3JlZ2F0 ZWRfanNvbjoKKyAgICAgICAgICAgIGRlbCBhZ2dyZWdhdGVkX2pzb25bSlNPTl9SRVNVTFRTX1JF U1VMVFNdCisgICAgICAgIGlmIEpTT05fUkVTVUxUU19USU1FUyBpbiBhZ2dyZWdhdGVkX2pzb246 CisgICAgICAgICAgICBkZWwgYWdncmVnYXRlZF9qc29uW0pTT05fUkVTVUxUU19USU1FU10KKwog ICAgICAgICBhbGxfdGVzdHMgPSBzZXQoYWdncmVnYXRlZF9qc29uLml0ZXJrZXlzKCkpCiAgICAg ICAgIGlmIGluY3JlbWVudGFsX2pzb246CiAgICAgICAgICAgICBhbGxfdGVzdHMgfD0gc2V0KGlu Y3JlbWVudGFsX2pzb24uaXRlcmtleXMoKSkKQEAgLTE1Miw3ICsxNzgsNyBAQCBjbGFzcyBKc29u UmVzdWx0cyhvYmplY3QpOgogICAgICAgICAgICAgICAgIGNvbnRpbnVlCiAKICAgICAgICAgICAg IGluY3JlbWVudGFsX3N1Yl9yZXN1bHQgPSBpbmNyZW1lbnRhbF9qc29uW3Rlc3RfbmFtZV0gaWYg aW5jcmVtZW50YWxfanNvbiBhbmQgdGVzdF9uYW1lIGluIGluY3JlbWVudGFsX2pzb24gZWxzZSBO b25lCi0gICAgICAgICAgICBpZiBKU09OX1JFU1VMVFNfUkVTVUxUUyBub3QgaW4gYWdncmVnYXRl ZF9qc29uW3Rlc3RfbmFtZV06CisgICAgICAgICAgICBpZiBfaXNfZGlyZWN0b3J5KGFnZ3JlZ2F0 ZWRfanNvblt0ZXN0X25hbWVdKToKICAgICAgICAgICAgICAgICBjbHMuX21lcmdlX3Rlc3RzKGFn Z3JlZ2F0ZWRfanNvblt0ZXN0X25hbWVdLCBpbmNyZW1lbnRhbF9zdWJfcmVzdWx0LCBudW1fcnVu cykKICAgICAgICAgICAgICAgICBjb250aW51ZQogCkBAIC0yNzUsOCArMzAxLDggQEAgY2xhc3Mg SnNvblJlc3VsdHMob2JqZWN0KToKICAgICAgICAgbG9nZ2luZy5pbmZvKCJNZXJnaW5nIGpzb24g cmVzdWx0cy4uLiIpCiAgICAgICAgIHRyeToKICAgICAgICAgICAgIGNscy5fbWVyZ2VfanNvbihh Z2dyZWdhdGVkX2pzb25bYnVpbGRlcl0sIGluY3JlbWVudGFsX2pzb25bYnVpbGRlcl0sIG51bV9y dW5zKQotICAgICAgICBleGNlcHQgRXhjZXB0aW9uLCBlcnI6Ci0gICAgICAgICAgICBsb2dnaW5n LmVycm9yKCJGYWlsZWQgdG8gbWVyZ2UganNvbiByZXN1bHRzOiAlcyIsIHN0cihlcnIpKQorICAg ICAgICBleGNlcHQ6CisgICAgICAgICAgICBsb2dnaW5nLmVycm9yKCJGYWlsZWQgdG8gbWVyZ2Ug anNvbiByZXN1bHRzOiAlcyIsIHRyYWNlYmFjay5wcmludF9leGNlcHRpb24oKnN5cy5leGNfaW5m bygpKSkKICAgICAgICAgICAgIHJldHVybiBOb25lCiAKICAgICAgICAgYWdncmVnYXRlZF9qc29u W0pTT05fUkVTVUxUU19WRVJTSU9OX0tFWV0gPSBKU09OX1JFU1VMVFNfSElFUkFSQ0hJQ0FMX1ZF UlNJT04KZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RSZXN1bHRTZXJ2ZXIvbW9kZWwvanNvbnJlc3Vs dHNfdW5pdHRlc3QucHkgYi9Ub29scy9UZXN0UmVzdWx0U2VydmVyL21vZGVsL2pzb25yZXN1bHRz X3VuaXR0ZXN0LnB5CmluZGV4IDJiZmZmMmEwZGU1NzEwNjQ0NDE0NDQ4ZjEzZTgzOGRlMjk0YTUx YjcuLjk1NTVlOWExNmMyNmNlMTg1YzYwNjQ1YmFhOWMyZTI1MWYwN2QzNTAgMTAwNzU1Ci0tLSBh L1Rvb2xzL1Rlc3RSZXN1bHRTZXJ2ZXIvbW9kZWwvanNvbnJlc3VsdHNfdW5pdHRlc3QucHkKKysr IGIvVG9vbHMvVGVzdFJlc3VsdFNlcnZlci9tb2RlbC9qc29ucmVzdWx0c191bml0dGVzdC5weQpA QCAtNTc0LDYgKzU3NCwzMiBAQCBjbGFzcyBKc29uUmVzdWx0c1Rlc3QodW5pdHRlc3QuVGVzdENh c2UpOgogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICJ0aW1lcyI6IFtbMTAxLDBdXX19 fSwKICAgICAgICAgICAgICAidmVyc2lvbiI6IDR9KQogCisgICAgIyBGSVhNRTogU29tZSBkYXRh IGdvdCBjb3JydXB0ZWQgYW5kIGhhcyByZXN1bHRzIGFuZCB0aW1lcyBhdCB0aGUgZGlyZWN0b3J5 IGxldmVsLgorICAgICMgT25jZSB3ZSd2ZSBwdXJnZWQgdGhpcyBmcm9tIGFsbCB0aGUgZGF0YSwg d2Ugc2hvdWxkIHRocm93IGFuIGVycm9yIG9uIHRoaXMgY2FzZS4KKyAgICBkZWYgdGVzdF9tZXJn ZV9kaXJlY3RvcnlfaGllcmFyY2h5X2V4dHJhX3Jlc3VsdHNfYW5kX3RpbWVzKHNlbGYpOgorICAg ICAgICBzZWxmLl90ZXN0X21lcmdlKAorICAgICAgICAgICAgIyBBZ2dyZWdhdGVkIHJlc3VsdHMK KyAgICAgICAgICAgIHsiYnVpbGRzIjogWyIyIiwgIjEiXSwKKyAgICAgICAgICAgICAidGVzdHMi OiB7ImJheiI6IHsKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAiMDAzLmh0bWwiOiB7Cisg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICJyZXN1bHRzIjogW1syNSwiRiJdXSwKKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgInRpbWVzIjogW1syNSwwXV19fSwKKyAgICAg ICAgICAgICAgICAgICAgICAgICJyZXN1bHRzIjogW1syNSwiRiJdXSwKKyAgICAgICAgICAgICAg ICAgICAgICAgICJ0aW1lcyI6IFtbMjUsMF1dfX0sCisgICAgICAgICAgICAgIyBJbmNyZW1lbnRh bCByZXN1bHRzCisgICAgICAgICAgICAgeyJidWlsZHMiOiBbIjMiXSwKKyAgICAgICAgICAgICAi dGVzdHMiOiB7ImJheiI6IHsKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAiMDAzLmh0bWwi OiB7CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICJyZXN1bHRzIjogW1sxLCJGIl1d LAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAidGltZXMiOiBbWzEsMF1dfX19fSwK KyAgICAgICAgICAgICAjIEV4cGVjdGVkIHJlc3VsdHMKKyAgICAgICAgICAgICB7ImJ1aWxkcyI6 IFsiMyIsICIyIiwgIjEiXSwKKyAgICAgICAgICAgICAidGVzdHMiOiB7ImJheiI6IHsKKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAiMDAzLmh0bWwiOiB7CisgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICJyZXN1bHRzIjogW1syNiwiRiJdXSwKKyAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgInRpbWVzIjogW1syNiwwXV19fX0sCisgICAgICAgICAgICAgICJ2ZXJzaW9u IjogNH0pCisKICAgICBkZWYgdGVzdF9tZXJnZV9idWlsZF9kaXJlY3RvcnlfaGllcmFyY2h5KHNl bGYpOgogICAgICAgICBzZWxmLl90ZXN0X21lcmdlKAogICAgICAgICAgICAgIyBBZ2dyZWdhdGVk IHJlc3VsdHMK