73243 2011-11-28 13:21:37 -0800 [MutationObservers] Fix build breakage after CSSInlineDeclaration refactor 2011-11-28 17:31:55 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 68729 1 rafaelw rafaelw adamk kling koivisto macpherson ojan rniwa webkit.review.bot oldest_to_newest 510112 0 rafaelw 2011-11-28 13:21:37 -0800 bug 73121 broke code that is behind the MUTATION_OBSERVERS compile flag. 510113 1 116807 rafaelw 2011-11-28 13:23:16 -0800 Created attachment 116807 Patch 510125 2 116807 rniwa 2011-11-28 13:36:08 -0800 Comment on attachment 116807 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=116807&action=review > Source/WebCore/css/CSSMutableStyleDeclaration.cpp:69 > + CSSInlineStyleDeclaration* inlineDecl = static_cast<CSSInlineStyleDeclaration*>(s_currentDecl); We should add toCSSInlineStyleDeclaration. 510141 3 116814 rafaelw 2011-11-28 13:51:35 -0800 Created attachment 116814 Patch 510146 4 116814 rniwa 2011-11-28 13:56:39 -0800 Comment on attachment 116814 Patch Thanks for adding toCSSInlineStyleDeclaration! 510358 5 116814 webkit.review.bot 2011-11-28 17:31:50 -0800 Comment on attachment 116814 Patch Clearing flags on attachment: 116814 Committed r101310: <http://trac.webkit.org/changeset/101310> 510359 6 webkit.review.bot 2011-11-28 17:31:55 -0800 All reviewed patches have been landed. Closing bug. 116807 2011-11-28 13:23:16 -0800 2011-11-28 13:51:31 -0800 Patch bug-73243-20111128132315.patch text/plain 2470 rafaelw U3VidmVyc2lvbiBSZXZpc2lvbjogMTAxMjYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmUwYjdmNGUxM2M0NmE0 ODlkMTE0MGIzNjkzYjYxZWYyNzMyNzU2Ni4uNzA2N2Q3NDk5ZGRmZGYxYTc1YWUxNTZiY2Q5OWM5 MjBlNTQ3NDAzZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDExLTExLTI4ICBSYWZh ZWwgV2VpbnN0ZWluICA8cmFmYWVsd0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW011dGF0aW9u T2JzZXJ2ZXJzXSBGaXggYnVpbGQgYnJlYWthZ2UgYWZ0ZXIgQ1NTSW5saW5lRGVjbGFyYXRpb24g cmVmYWN0b3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTczMjQzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg Tm8gdGVzdHMgbmVlZGVkLiBUaGlzIHBhdGNoIG9ubHkgY29udGFpbnMgY29tcGlsZSBmaXhlcy4K KworICAgICAgICAqIGNzcy9DU1NNdXRhYmxlU3R5bGVEZWNsYXJhdGlvbi5jcHA6CisKIDIwMTEt MTEtMjggIEFuZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgogCiAgICAgICAgIEluc3Bl Y3RvckNTU0FnZW50OiBSZW1vdmUgdW51c2VkIGZ1bmN0aW9uIGlubGluZVN0eWxlRWxlbWVudCgp LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU011dGFibGVTdHlsZURlY2xhcmF0 aW9uLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NNdXRhYmxlU3R5bGVEZWNsYXJhdGlvbi5j cHAKaW5kZXggYjYyODlmNTc1Y2JmOWI4YzM0NDYyMGJjYTJiMDk3N2Q5NzE2NmRjMC4uY2U4N2Mx MjFlOTk4ZTIwZTI4Y2Y5MTZmZGUwYjk4OWFiMmFjMWU3OSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvY3NzL0NTU011dGFibGVTdHlsZURlY2xhcmF0aW9uLmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9jc3MvQ1NTTXV0YWJsZVN0eWxlRGVjbGFyYXRpb24uY3BwCkBAIC0yMyw2ICsyMyw3IEBA CiAjaW5jbHVkZSAiQ1NTTXV0YWJsZVN0eWxlRGVjbGFyYXRpb24uaCIKIAogI2luY2x1ZGUgIkNT U0ltYWdlVmFsdWUuaCIKKyNpbmNsdWRlICJDU1NJbmxpbmVTdHlsZURlY2xhcmF0aW9uLmgiCiAj aW5jbHVkZSAiQ1NTUGFyc2VyLmgiCiAjaW5jbHVkZSAiQ1NTUHJvcGVydHlMb25naGFuZC5oIgog I2luY2x1ZGUgIkNTU1Byb3BlcnR5TmFtZXMuaCIKQEAgLTY1LDE0ICs2NiwxNSBAQCBwdWJsaWM6 CiAgICAgICAgIGlmICghc19jdXJyZW50RGVjbC0+aXNJbmxpbmVTdHlsZURlY2xhcmF0aW9uKCkp CiAgICAgICAgICAgICByZXR1cm47CiAKLSAgICAgICAgc19tdXRhdGlvblJlY2lwaWVudHMgPSBN dXRhdGlvbk9ic2VydmVySW50ZXJlc3RHcm91cDo6Y3JlYXRlRm9yQXR0cmlidXRlc011dGF0aW9u KHNfY3VycmVudERlY2wtPmVsZW1lbnQoKSwgSFRNTE5hbWVzOjpzdHlsZUF0dHIpOworICAgICAg ICBDU1NJbmxpbmVTdHlsZURlY2xhcmF0aW9uKiBpbmxpbmVEZWNsID0gc3RhdGljX2Nhc3Q8Q1NT SW5saW5lU3R5bGVEZWNsYXJhdGlvbio+KHNfY3VycmVudERlY2wpOworICAgICAgICBzX211dGF0 aW9uUmVjaXBpZW50cyA9IE11dGF0aW9uT2JzZXJ2ZXJJbnRlcmVzdEdyb3VwOjpjcmVhdGVGb3JB dHRyaWJ1dGVzTXV0YXRpb24oaW5saW5lRGVjbC0+ZWxlbWVudCgpLCBIVE1MTmFtZXM6OnN0eWxl QXR0cik7CiAgICAgICAgIGlmIChzX211dGF0aW9uUmVjaXBpZW50cy0+aXNFbXB0eSgpKSB7CiAg ICAgICAgICAgICBzX211dGF0aW9uUmVjaXBpZW50cy5jbGVhcigpOwogICAgICAgICAgICAgcmV0 dXJuOwogICAgICAgICB9CiAKLSAgICAgICAgQXRvbWljU3RyaW5nIG9sZFZhbHVlID0gc19tdXRh dGlvblJlY2lwaWVudHMtPmlzT2xkVmFsdWVSZXF1ZXN0ZWQoKSA/IHNfY3VycmVudERlY2wtPmVs ZW1lbnQoKS0+Z2V0QXR0cmlidXRlKEhUTUxOYW1lczo6c3R5bGVBdHRyKSA6IG51bGxBdG9tOwot ICAgICAgICBzX211dGF0aW9uID0gTXV0YXRpb25SZWNvcmQ6OmNyZWF0ZUF0dHJpYnV0ZXMoc19j dXJyZW50RGVjbC0+ZWxlbWVudCgpLCBIVE1MTmFtZXM6OnN0eWxlQXR0ciwgb2xkVmFsdWUpOwor ICAgICAgICBBdG9taWNTdHJpbmcgb2xkVmFsdWUgPSBzX211dGF0aW9uUmVjaXBpZW50cy0+aXNP bGRWYWx1ZVJlcXVlc3RlZCgpID8gaW5saW5lRGVjbC0+ZWxlbWVudCgpLT5nZXRBdHRyaWJ1dGUo SFRNTE5hbWVzOjpzdHlsZUF0dHIpIDogbnVsbEF0b207CisgICAgICAgIHNfbXV0YXRpb24gPSBN dXRhdGlvblJlY29yZDo6Y3JlYXRlQXR0cmlidXRlcyhpbmxpbmVEZWNsLT5lbGVtZW50KCksIEhU TUxOYW1lczo6c3R5bGVBdHRyLCBvbGRWYWx1ZSk7CiAgICAgfQogCiAgICAgflN0eWxlQXR0cmli dXRlTXV0YXRpb25TY29wZSgpCg== 116814 2011-11-28 13:51:35 -0800 2011-11-28 17:31:50 -0800 Patch bug-73243-20111128135134.patch text/plain 3125 rafaelw U3VidmVyc2lvbiBSZXZpc2lvbjogMTAxMjc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDJiNDQ3MmEwNjdmMmFh NWE3NzM2MWFiZjgyOGQ2OGNkYzM1MjFiNS4uZWNhMDQyNmVjM2ZiOGZlMDQ2NWU4ZTU4NzM0Yjg4 MTI1YTYzZGQzNCAxMDA3NTUKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDExLTExLTI4ICBSYWZh ZWwgV2VpbnN0ZWluICA8cmFmYWVsd0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW011dGF0aW9u T2JzZXJ2ZXJzXSBGaXggYnVpbGQgYnJlYWthZ2UgYWZ0ZXIgQ1NTSW5saW5lRGVjbGFyYXRpb24g cmVmYWN0b3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTczMjQzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg Tm8gdGVzdHMgbmVlZGVkLiBUaGlzIHBhdGNoIG9ubHkgY29udGFpbnMgY29tcGlsZSBmaXhlcy4K KworICAgICAgICAqIGNzcy9DU1NNdXRhYmxlU3R5bGVEZWNsYXJhdGlvbi5jcHA6CisKIDIwMTEt MTEtMjggIEZhZHkgU2FtdWVsICA8ZnNhbXVlbEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgRml4 IEFzcGVjdCBSYXRpbyBQcm9wZXJ0eSBJbmhlcml0YW5jZSBBbmQgTWFrZSB0aGUgQ29tcHV0ZWQg VmFsdWUgRXF1YWwgdGhlIFNwZWNpZmllZCBWYWx1ZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvY3NzL0NTU0lubGluZVN0eWxlRGVjbGFyYXRpb24uaCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9D U1NJbmxpbmVTdHlsZURlY2xhcmF0aW9uLmgKaW5kZXggZDIyYzU1Mjc5OTgxNGYxY2Q0M2EzYmRk ZTcwYWQ2Mjg3NjBkMTAyNC4uNjc5NWI2MTU2N2M5OWMzNTFkNjY3YTY0N2Q2YWFiODkwZTk3YjNk YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU0lubGluZVN0eWxlRGVjbGFyYXRp b24uaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTSW5saW5lU3R5bGVEZWNsYXJhdGlvbi5o CkBAIC00Nyw2ICs0NywxMiBAQCBwcml2YXRlOgogICAgIH0KIH07CiAKK2lubGluZSBDU1NJbmxp bmVTdHlsZURlY2xhcmF0aW9uKiB0b0NTU0lubGluZVN0eWxlRGVjbGFyYXRpb24oQ1NTTXV0YWJs ZVN0eWxlRGVjbGFyYXRpb24qIGRlY2wpCit7CisgICAgQVNTRVJUKCFkZWNsIHx8IGRlY2wtPmlz SW5saW5lU3R5bGVEZWNsYXJhdGlvbigpKTsKKyAgICByZXR1cm4gc3RhdGljX2Nhc3Q8Q1NTSW5s aW5lU3R5bGVEZWNsYXJhdGlvbio+KGRlY2wpOworfQorCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3Jl CiAKICNlbmRpZiAvLyBDU1NJbmxpbmVTdHlsZURlY2xhcmF0aW9uX2gKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2Nzcy9DU1NNdXRhYmxlU3R5bGVEZWNsYXJhdGlvbi5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9jc3MvQ1NTTXV0YWJsZVN0eWxlRGVjbGFyYXRpb24uY3BwCmluZGV4IGI2Mjg5ZjU3 NWNiZjliOGMzNDQ2MjBiY2EyYjA5NzdkOTcxNjZkYzAuLjkyNmJlMWRmMWQ4YWVhYzg5Y2Q3Mjkx NjkyNzdkMmM5YjRhODIwNmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NNdXRh YmxlU3R5bGVEZWNsYXJhdGlvbi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU011dGFi bGVTdHlsZURlY2xhcmF0aW9uLmNwcApAQCAtMjMsNiArMjMsNyBAQAogI2luY2x1ZGUgIkNTU011 dGFibGVTdHlsZURlY2xhcmF0aW9uLmgiCiAKICNpbmNsdWRlICJDU1NJbWFnZVZhbHVlLmgiCisj aW5jbHVkZSAiQ1NTSW5saW5lU3R5bGVEZWNsYXJhdGlvbi5oIgogI2luY2x1ZGUgIkNTU1BhcnNl ci5oIgogI2luY2x1ZGUgIkNTU1Byb3BlcnR5TG9uZ2hhbmQuaCIKICNpbmNsdWRlICJDU1NQcm9w ZXJ0eU5hbWVzLmgiCkBAIC02NSwxNCArNjYsMTUgQEAgcHVibGljOgogICAgICAgICBpZiAoIXNf Y3VycmVudERlY2wtPmlzSW5saW5lU3R5bGVEZWNsYXJhdGlvbigpKQogICAgICAgICAgICAgcmV0 dXJuOwogCi0gICAgICAgIHNfbXV0YXRpb25SZWNpcGllbnRzID0gTXV0YXRpb25PYnNlcnZlcklu dGVyZXN0R3JvdXA6OmNyZWF0ZUZvckF0dHJpYnV0ZXNNdXRhdGlvbihzX2N1cnJlbnREZWNsLT5l bGVtZW50KCksIEhUTUxOYW1lczo6c3R5bGVBdHRyKTsKKyAgICAgICAgQ1NTSW5saW5lU3R5bGVE ZWNsYXJhdGlvbiogaW5saW5lRGVjbCA9IHRvQ1NTSW5saW5lU3R5bGVEZWNsYXJhdGlvbihzX2N1 cnJlbnREZWNsKTsKKyAgICAgICAgc19tdXRhdGlvblJlY2lwaWVudHMgPSBNdXRhdGlvbk9ic2Vy dmVySW50ZXJlc3RHcm91cDo6Y3JlYXRlRm9yQXR0cmlidXRlc011dGF0aW9uKGlubGluZURlY2wt PmVsZW1lbnQoKSwgSFRNTE5hbWVzOjpzdHlsZUF0dHIpOwogICAgICAgICBpZiAoc19tdXRhdGlv blJlY2lwaWVudHMtPmlzRW1wdHkoKSkgewogICAgICAgICAgICAgc19tdXRhdGlvblJlY2lwaWVu dHMuY2xlYXIoKTsKICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgfQogCi0gICAgICAgIEF0 b21pY1N0cmluZyBvbGRWYWx1ZSA9IHNfbXV0YXRpb25SZWNpcGllbnRzLT5pc09sZFZhbHVlUmVx dWVzdGVkKCkgPyBzX2N1cnJlbnREZWNsLT5lbGVtZW50KCktPmdldEF0dHJpYnV0ZShIVE1MTmFt ZXM6OnN0eWxlQXR0cikgOiBudWxsQXRvbTsKLSAgICAgICAgc19tdXRhdGlvbiA9IE11dGF0aW9u UmVjb3JkOjpjcmVhdGVBdHRyaWJ1dGVzKHNfY3VycmVudERlY2wtPmVsZW1lbnQoKSwgSFRNTE5h bWVzOjpzdHlsZUF0dHIsIG9sZFZhbHVlKTsKKyAgICAgICAgQXRvbWljU3RyaW5nIG9sZFZhbHVl ID0gc19tdXRhdGlvblJlY2lwaWVudHMtPmlzT2xkVmFsdWVSZXF1ZXN0ZWQoKSA/IGlubGluZURl Y2wtPmVsZW1lbnQoKS0+Z2V0QXR0cmlidXRlKEhUTUxOYW1lczo6c3R5bGVBdHRyKSA6IG51bGxB dG9tOworICAgICAgICBzX211dGF0aW9uID0gTXV0YXRpb25SZWNvcmQ6OmNyZWF0ZUF0dHJpYnV0 ZXMoaW5saW5lRGVjbC0+ZWxlbWVudCgpLCBIVE1MTmFtZXM6OnN0eWxlQXR0ciwgb2xkVmFsdWUp OwogICAgIH0KIAogICAgIH5TdHlsZUF0dHJpYnV0ZU11dGF0aW9uU2NvcGUoKQo=