73234 2011-11-28 11:18:19 -0800 Web Inspector: TreeOutline elements should be formatted using margin-left instead of text-indent. 2011-11-30 07:03:10 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 vsevik vsevik apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 509990 0 vsevik 2011-11-28 11:18:19 -0800 TreeOutline elements should be formatted using margin-left instead of text-indent. This way there is no need to override isEventWithinDisclosureTriangle in ResourcesPanel. 510012 1 116791 vsevik 2011-11-28 11:29:53 -0800 Created attachment 116791 Patch 510560 2 116791 pfeldman 2011-11-29 00:22:55 -0800 Comment on attachment 116791 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=116791&action=review > Source/WebCore/inspector/front-end/treeoutline.js:961 > + var left = this._listItemNode.totalOffsetLeft() + computedLeftPadding; Please make sure this works Ok with the scroller (toggle word wrap off on elements panel) 511716 3 vsevik 2011-11-30 07:01:15 -0800 Committed r101509: <http://trac.webkit.org/changeset/101509> 511718 4 vsevik 2011-11-30 07:03:10 -0800 Filed https://bugs.webkit.org/show_bug.cgi?id=73443 for scroll. 116791 2011-11-28 11:29:53 -0800 2011-11-29 00:22:55 -0800 Patch bug-73234-20111128232951.patch text/plain 7279 vsevik U3VidmVyc2lvbiBSZXZpc2lvbjogMTAxMjQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2M5ZTUyMjhjOTYzZDM4 MTRlODQyNDk3MWQ1NDAzNTFhMDRlNjk1OC4uODQ4OGE4ZGUwNWIyOGQzNWRkNzVjZTJkYmY1YWM1 OTRiZDNiMzViYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDExLTExLTI4ICBWc2V2 b2xvZCBWbGFzb3YgIDx2c2V2aWtAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IFRyZWVPdXRsaW5lIGVsZW1lbnRzIHNob3VsZCBiZSBmb3JtYXR0ZWQgdXNpbmcgbWFyZ2lu LWxlZnQgaW5zdGVhZCBvZiB0ZXh0LWluZGVudC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTczMjM0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL1Jlc291cmNlSGVhZGVy c1ZpZXcuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuUmVzb3VyY2VIZWFkZXJzVmlldy5wcm90 b3R5cGUuX3JlZnJlc2hIZWFkZXJzVGV4dCk6CisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVu ZC9SZXNvdXJjZXNQYW5lbC5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5CYXNlU3RvcmFnZVRy ZWVFbGVtZW50LnByb3RvdHlwZS5nZXQgc2VhcmNoTWF0Y2hlc0NvdW50KToKKyAgICAgICAgKiBp bnNwZWN0b3IvZnJvbnQtZW5kL2F1ZGl0c1BhbmVsLmNzczoKKyAgICAgICAgKC5hdWRpdC1yZXN1 bHQtdHJlZSBsaSk6CisgICAgICAgICguYXVkaXQtcmVzdWx0LXRyZWUgbGkucGFyZW50KToKKyAg ICAgICAgKC5hdWRpdC1yZXN1bHQgaW1nKToKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5k L2luc3BlY3Rvci5jc3M6CisgICAgICAgICgub3V0bGluZS1kaXNjbG9zdXJlIGxpKToKKyAgICAg ICAgKC5vdXRsaW5lLWRpc2Nsb3N1cmUgbGkucGFyZW50KToKKyAgICAgICAgKiBpbnNwZWN0b3Iv ZnJvbnQtZW5kL25ldHdvcmtQYW5lbC5jc3M6CisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVu ZC9yZXNvdXJjZXNQYW5lbC5jc3M6CisgICAgICAgICgucmVzb3VyY2VzLnBhbmVsIC5zaWRlYmFy LXJlc2l6ZXItdmVydGljYWwpOgorICAgICAgICAoLnJlc291cmNlcy5wYW5lbCAuc2lkZWJhciBs aSk6CisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC90cmVlb3V0bGluZS5qczoKKyAgICAg ICAgKFRyZWVFbGVtZW50LnByb3RvdHlwZS5pc0V2ZW50V2l0aGluRGlzY2xvc3VyZVRyaWFuZ2xl KToKKwogMjAxMS0xMS0yOCAgTHVrZSBNYWNwaGVyc29uICAgPG1hY3BoZXJzb25AY2hyb21pdW0u b3JnPgogCiAgICAgICAgIEltcGxlbWVudCBDU1MgYm9yZGVyIGltYWdlIHByb3BlcnRpZXMgaW4g Q1NTU3R5bGVBcHBseVByb3BlcnR5LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVj dG9yL2Zyb250LWVuZC9SZXNvdXJjZUhlYWRlcnNWaWV3LmpzIGIvU291cmNlL1dlYkNvcmUvaW5z cGVjdG9yL2Zyb250LWVuZC9SZXNvdXJjZUhlYWRlcnNWaWV3LmpzCmluZGV4IDRiNTUzY2YwYmQw N2NhOTViMDcxMDcwNTNmNTZkNjg0N2QwMjQ1NDAuLjJkNzc1NjViNzJjNTljZWJmMTY5MGQ1N2Qw NzBkOGIxYjIyNjUwMmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9u dC1lbmQvUmVzb3VyY2VIZWFkZXJzVmlldy5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0 b3IvZnJvbnQtZW5kL1Jlc291cmNlSGVhZGVyc1ZpZXcuanMKQEAgLTM2NCw3ICszNjQsNiBAQCBX ZWJJbnNwZWN0b3IuUmVzb3VyY2VIZWFkZXJzVmlldy5wcm90b3R5cGUgPSB7CiAgICAgICAgIHZh ciBoZWFkZXJUcmVlRWxlbWVudCA9IG5ldyBUcmVlRWxlbWVudChudWxsLCBudWxsLCBmYWxzZSk7 CiAgICAgICAgIGhlYWRlclRyZWVFbGVtZW50LnNlbGVjdGFibGUgPSBmYWxzZTsKICAgICAgICAg aGVhZGVyc1RyZWVFbGVtZW50LmFwcGVuZENoaWxkKGhlYWRlclRyZWVFbGVtZW50KTsKLSAgICAg ICAgaGVhZGVyVHJlZUVsZW1lbnQubGlzdEl0ZW1FbGVtZW50LmFkZFN0eWxlQ2xhc3MoImhlYWRl cnMtdGV4dCIpOwogCiAgICAgICAgIHZhciBoZWFkZXJzVGV4dEVsZW1lbnQgPSBkb2N1bWVudC5j cmVhdGVFbGVtZW50KCJzcGFuIik7CiAgICAgICAgIGhlYWRlcnNUZXh0RWxlbWVudC5hZGRTdHls ZUNsYXNzKCJoZWFkZXItdmFsdWUiKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3Bl Y3Rvci9mcm9udC1lbmQvUmVzb3VyY2VzUGFuZWwuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0 b3IvZnJvbnQtZW5kL1Jlc291cmNlc1BhbmVsLmpzCmluZGV4IDUyNDUwODVkODQ2MWM3OGM4MDhi MjhkNzg2YWRlYzc5MTdkYmFhMmYuLjM5OTExNTVjNWQwNmJjZTI4ZTE1MjYxNTRjNjMxM2M0NGRk ZDA3NTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvUmVz b3VyY2VzUGFuZWwuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9S ZXNvdXJjZXNQYW5lbC5qcwpAQCAtMTAwMCwxNiArMTAwMCw2IEBAIFdlYkluc3BlY3Rvci5CYXNl U3RvcmFnZVRyZWVFbGVtZW50LnByb3RvdHlwZSA9IHsKICAgICBnZXQgc2VhcmNoTWF0Y2hlc0Nv dW50KCkKICAgICB7CiAgICAgICAgIHJldHVybiAwOwotICAgIH0sCi0KLSAgICBpc0V2ZW50V2l0 aGluRGlzY2xvc3VyZVRyaWFuZ2xlOiBmdW5jdGlvbihldmVudCkKLSAgICB7Ci0gICAgICAgIC8v IE92ZXJyaWRlIGl0IHNpbmNlIHdlIHVzZSBtYXJnaW4tbGVmdCBpbiBwbGFjZSBvZiB0cmVlb3V0 bGluZSdzIHRleHQtaW5kZW50LgotICAgICAgICAvLyBIZW5jZSB3ZSBuZWVkIHRvIHRha2UgcGFk ZGluZyBpbnRvIGNvbnNpZGVyYXRpb24uIFRoaXMgYWxsIGlzIG5lZWRlZCBmb3IgbGVhZGluZwot ICAgICAgICAvLyBpY29ucyBpbiB0aGUgdHJlZS4KLSAgICAgICAgY29uc3QgcGFkZGluZ0xlZnQg PSAxNDsKLSAgICAgICAgdmFyIGxlZnQgPSB0aGlzLmxpc3RJdGVtRWxlbWVudC50b3RhbE9mZnNl dExlZnQoKSArIHBhZGRpbmdMZWZ0OwotICAgICAgICByZXR1cm4gZXZlbnQucGFnZVggPj0gbGVm dCAmJiBldmVudC5wYWdlWCA8PSBsZWZ0ICsgdGhpcy5hcnJvd1RvZ2dsZVdpZHRoICYmIHRoaXMu aGFzQ2hpbGRyZW47CiAgICAgfQogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNw ZWN0b3IvZnJvbnQtZW5kL2F1ZGl0c1BhbmVsLmNzcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rv ci9mcm9udC1lbmQvYXVkaXRzUGFuZWwuY3NzCmluZGV4IDI3NzY3MGJkNmY0YTQ5YzcxMGI0NjZj ZjJlNmI2NjYxZGU3YTgwM2YuLjRjZWFiYjc1ODExYzEyZjlkYmQ4MmVhMmNlODlkYWFkNTFhZmVj NWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvYXVkaXRz UGFuZWwuY3NzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvYXVkaXRz UGFuZWwuY3NzCkBAIC0yMzIsMTEgKzIzMiwxMSBAQCBib2R5LmluYWN0aXZlIC5hdWRpdC1sYXVu Y2hlci12aWV3IGJ1dHRvbiwgLmF1ZGl0LWxhdW5jaGVyLXZpZXcgYnV0dG9uOmRpc2FibGVkCiAg ICAgbWFyZ2luLXRvcDogMXB4OwogICAgIG1hcmdpbi1ib3R0b206IDFweDsKICAgICB3b3JkLXdy YXA6IGJyZWFrLXdvcmQ7Ci0gICAgdGV4dC1pbmRlbnQ6IC0ycHg7CisgICAgbWFyZ2luLWxlZnQ6 IC0ycHg7CiB9CiAKIC5hdWRpdC1yZXN1bHQtdHJlZSBsaS5wYXJlbnQgewotICAgIHRleHQtaW5k ZW50OiAtMTJweAorICAgIG1hcmdpbi1sZWZ0OiAtMTJweAogfQogCiAuYXVkaXQtcmVzdWx0LXRy ZWUgbGkucGFyZW50OjpiZWZvcmUgewpAQCAtMjY3LDYgKzI2Nyw2IEBAIGJvZHkuaW5hY3RpdmUg LmF1ZGl0LWxhdW5jaGVyLXZpZXcgYnV0dG9uLCAuYXVkaXQtbGF1bmNoZXItdmlldyBidXR0b246 ZGlzYWJsZWQKIAogLmF1ZGl0LXJlc3VsdCBpbWcgewogICAgIGZsb2F0OiBsZWZ0OwotICAgIG1h cmdpbi1sZWZ0OiAtNDBweDsKKyAgICBtYXJnaW4tbGVmdDogLTI4cHg7CiAgICAgbWFyZ2luLXRv cDogLTFweDsKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1l bmQvaW5zcGVjdG9yLmNzcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvaW5z cGVjdG9yLmNzcwppbmRleCA4Y2UzNjA5OWMwNmY2ZTI3OTlhODc1MjQ5Zjk1ZDkzZDc2OWIxZjE5 Li44ZmZkZDZhMzcyMGU3YzM5YjUyODE1NjNlYWVmYTk0YjZkOWM3MmQ1IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL2luc3BlY3Rvci5jc3MKKysrIGIvU291 cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9pbnNwZWN0b3IuY3NzCkBAIC0xMDQyLDgg KzEwNDIsOCBAQCBpZnJhbWUucGFuZWwuZXh0ZW5zaW9uIHsKICAgICBwYWRkaW5nOiAwIDAgMCAx NHB4OwogICAgIG1hcmdpbi10b3A6IDFweDsKICAgICBtYXJnaW4tYm90dG9tOiAxcHg7CisgICAg bWFyZ2luLWxlZnQ6IC0ycHg7CiAgICAgd29yZC13cmFwOiBicmVhay13b3JkOwotICAgIHRleHQt aW5kZW50OiAtMnB4OwogfQogCiAub3V0bGluZS1kaXNjbG9zdXJlIG9sOmZvY3VzIGxpLnNlbGVj dGVkIHsKQEAgLTEwNTUsNyArMTA1NSw3IEBAIGlmcmFtZS5wYW5lbC5leHRlbnNpb24gewogfQog CiAub3V0bGluZS1kaXNjbG9zdXJlIGxpLnBhcmVudCB7Ci0gICAgdGV4dC1pbmRlbnQ6IC0xMnB4 CisgICAgbWFyZ2luLWxlZnQ6IC0xMnB4CiB9CiAKIC5vdXRsaW5lLWRpc2Nsb3N1cmUgbGkgLndl YmtpdC1odG1sLXRhZy5jbG9zZSB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0 b3IvZnJvbnQtZW5kL25ldHdvcmtQYW5lbC5jc3MgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3Iv ZnJvbnQtZW5kL25ldHdvcmtQYW5lbC5jc3MKaW5kZXggNThlOTU4MjkyMTRhMDAwMjgxMjE4MTdm MTRkMmVmNWE3MzFhYzRjNy4uODg1MDRhMWE5ZjRhNDFiZGYyZjg4ODI5YmE3NmVjMTQxOTA4OTNj MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9uZXR3b3Jr UGFuZWwuY3NzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvbmV0d29y a1BhbmVsLmNzcwpAQCAtMTkyLDExICsxOTIsNiBAQAogICAgIG1hcmdpbi10b3A6IDFweDsKIH0K IAotLnJlc291cmNlLWhlYWRlcnMtdmlldyAub3V0bGluZS1kaXNjbG9zdXJlIGxpLmhlYWRlcnMt dGV4dCB7Ci0gICAgdGV4dC1pbmRlbnQ6IDA7Ci0gICAgbWFyZ2luLWxlZnQ6IC0ycHg7Ci19Ci0K IC5yZXNvdXJjZS1oZWFkZXJzLXZpZXcgLm91dGxpbmUtZGlzY2xvc3VyZSAucmF3LWZvcm0tZGF0 YSB7CiAgICAgd2hpdGUtc3BhY2U6IHByZS13cmFwOwogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9yZXNvdXJjZXNQYW5lbC5jc3MgYi9Tb3VyY2UvV2Vi Q29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL3Jlc291cmNlc1BhbmVsLmNzcwppbmRleCAxOGM3NmFl MjE3Mzk4NDJkNzk0ODAyNTJjNjcxYzczYWQwMjlkZWM4Li5hODJmMzVkYWYwMzBhM2M0ZmVmNzE1 NTRjZTdlMmY0ODMzNjQxMjQ5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3Iv ZnJvbnQtZW5kL3Jlc291cmNlc1BhbmVsLmNzcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0 b3IvZnJvbnQtZW5kL3Jlc291cmNlc1BhbmVsLmNzcwpAQCAtMjcsMTEgKzI3LDcgQEAKICAqIFRI SVMgU09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRiBUSEUgUE9TU0lCSUxJVFkgT0YgU1VDSCBE QU1BR0UuCiAgKi8KIAotLnJlc291cmNlcyAub3V0bGluZS1kaXNjbG9zdXJlIGxpIHsKLSAgICB0 ZXh0LWluZGVudDogLTFweDsKLX0KLQotLnJlc291cmNlcyAuc2lkZWJhci1yZXNpemVyLXZlcnRp Y2FsIHsKKy5yZXNvdXJjZXMucGFuZWwgLnNpZGViYXItcmVzaXplci12ZXJ0aWNhbCB7CiAgICAg dG9wOiAyM3B4OwogfQogCkBAIC00MywxMyArMzksNiBAQAogLnJlc291cmNlcy5wYW5lbCAuc2lk ZWJhciBsaSB7CiAgICAgaGVpZ2h0OiAxN3B4OwogICAgIHdoaXRlLXNwYWNlOiBub3dyYXA7Ci0g ICAgdGV4dC1pbmRlbnQ6IDA7Ci0gICAgbWFyZ2luLWxlZnQ6IC0ycHg7Ci19Ci0KLS5yZXNvdXJj ZXMucGFuZWwgLnNpZGViYXIgbGkucGFyZW50IHsKLSAgICB0ZXh0LWluZGVudDogMDsKLSAgICBt YXJnaW4tbGVmdDogLTEycHg7CiB9CiAKIC5yZXNvdXJjZXMucGFuZWwgLnNpZGViYXIgbGkuc2Vs ZWN0ZWQgewpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC90 cmVlb3V0bGluZS5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvdHJlZW91 dGxpbmUuanMKaW5kZXggYWJiNDQ2ZTZiMzg3Zjk5YjFhNzUwMDFjMDA1ZjA3ZDhmMWUyZDEyYS4u OWQzNDY4YjYxMmM3ZWMyOTc4ODgzYjIzMjkzYWI4YTQ2ZDQ5MDQzMyAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC90cmVlb3V0bGluZS5qcworKysgYi9Tb3Vy Y2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL3RyZWVvdXRsaW5lLmpzCkBAIC05NTcsNiAr OTU3LDcgQEAgVHJlZUVsZW1lbnQucHJvdG90eXBlLnRyYXZlcnNlUHJldmlvdXNUcmVlRWxlbWVu dCA9IGZ1bmN0aW9uKHNraXBIaWRkZW4sIGRvbnRQb3AKIAogVHJlZUVsZW1lbnQucHJvdG90eXBl LmlzRXZlbnRXaXRoaW5EaXNjbG9zdXJlVHJpYW5nbGUgPSBmdW5jdGlvbihldmVudCkKIHsKLSAg ICB2YXIgbGVmdCA9IHRoaXMuX2xpc3RJdGVtTm9kZS50b3RhbE9mZnNldExlZnQoKTsKKyAgICB2 YXIgY29tcHV0ZWRMZWZ0UGFkZGluZyA9IHdpbmRvdy5nZXRDb21wdXRlZFN0eWxlKHRoaXMuX2xp c3RJdGVtTm9kZSkuZ2V0UHJvcGVydHlDU1NWYWx1ZSgicGFkZGluZy1sZWZ0IikuZ2V0RmxvYXRW YWx1ZShDU1NQcmltaXRpdmVWYWx1ZS5DU1NfUFgpOworICAgIHZhciBsZWZ0ID0gdGhpcy5fbGlz dEl0ZW1Ob2RlLnRvdGFsT2Zmc2V0TGVmdCgpICsgY29tcHV0ZWRMZWZ0UGFkZGluZzsKICAgICBy ZXR1cm4gZXZlbnQucGFnZVggPj0gbGVmdCAmJiBldmVudC5wYWdlWCA8PSBsZWZ0ICsgdGhpcy5h cnJvd1RvZ2dsZVdpZHRoICYmIHRoaXMuaGFzQ2hpbGRyZW47CiB9Cg==