73216 2011-11-28 06:47:16 -0800 [GTK] Add a method to detect 'make dist' errors without running 'make dist' 2011-11-29 12:30:31 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mrobinson mrobinson cgarcia pnormand oldest_to_newest 509801 0 mrobinson 2011-11-28 06:47:16 -0800 'make dist' takes a long time to run and running it once for every file missing on the source list is incredibly painful. We should just try guess which files are missing by inspecting the generated GNUmakefile and the Plo (header dependencies) files. 509966 1 116783 mrobinson 2011-11-28 11:00:39 -0800 Created attachment 116783 Patch 510993 2 116783 pnormand 2011-11-29 12:21:18 -0800 Comment on attachment 116783 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=116783&action=review Nice. Maybe at some point we can get the bots to run this script? > Tools/gtk/find-make-dist-errors:59 > +def scan_headers_from_depedency_files(): typo: depedency 511002 3 mrobinson 2011-11-29 12:30:31 -0800 Committed r101404: <http://trac.webkit.org/changeset/101404> 116783 2011-11-28 11:00:39 -0800 2011-11-29 12:21:18 -0800 Patch bug-73216-20111128200037.patch text/plain 5889 mrobinson U3VidmVyc2lvbiBSZXZpc2lvbjogMTAxMjQyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMDE3ZjM5ZDMzMmQ3OTBmYzdkOTU5OWI5ZGRjOTI1Yzlh MWVmMjZjZS4uMmFhMzg3NjE3NTVkOGRmZmJhOTg0ZmUzNTZhYTMzZDZiMzFlMDVhNyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIx IEBACisyMDExLTExLTI4ICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4K KworICAgICAgICBbR1RLXSBBZGQgYSBtZXRob2QgdG8gZGV0ZWN0ICdtYWtlIGRpc3QnIGVycm9y cyB3aXRob3V0IHJ1bm5pbmcgJ21ha2UgZGlzdCcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTczMjE2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgQWRkIGEgc2NyaXB0IHRoYXQgdHJpZXMgdG8gc25pZmYgb3V0 ICdtYWtlIGRpc3QnIHByb2JsZW1zIHdpdGhvdXQgcnVubmluZworICAgICAgICAnbWFrZSBkaXN0 LicgJ21ha2UgZGlzdGNoZWNrJyB0YWtlcyBhIHZlcnkgbG9uZyB0aW1lIHRvIHJ1biBhbmQgdGhp cyBzaG91bGQKKyAgICAgICAgcmVkdWNlIHRoZSBhbW91bnQgb2YgdGltZXMgaXQgbmVlZHMgdG8g YmUgcnVuIGNvbnNlY3V0aXZlbHkuCisKKyAgICAgICAgKiBndGsvY29tbW9uLnB5OgorICAgICAg ICAoZ2V0X2J1aWxkX3BhdGguaXNfdmFsaWRfYnVpbGRfZGlyZWN0b3J5KTogR3Vlc3MgdGhlIHNv dXJjZSBkaXJlY3RvcnkKKyAgICAgICAgYnkgdGhlIGV4aXN0ZW5jZSBvZiB0aGUgR05VbWFrZWZp bGUgaW5zdGVhZCBvZiB0aGUgLmxpYnMgZGlyZWN0b3J5LiBUaGlzCisgICAgICAgIGFsbG93cyBv bmUgdG8gcnVuIHRoZSBzY3JpcHQgYWZ0ZXIgcnVubmluZyBhdXRvZ2VuLnNoIGJ1dCBiZWZvcmUg ZnVsbHkKKyAgICAgICAgYnVpbGRpbmcuCisgICAgICAgICogZ3RrL2ZpbmQtbWFrZS1kaXN0LWVy cm9yczogQWRkZWQuCisKIDIwMTEtMTEtMjggIEtlbnRhcm8gSGFyYSAgPGhhcmFrZW5AY2hyb21p dW0ub3JnPgogCiAgICAgICAgIHJ1bi1iaW5kaW5ncy10ZXN0cyBzaG93cyBkaWZmIGVycm9yIGZv ciBhIG5ld2x5IGFkZGVkIGJpbmRpbmcgdGVzdApkaWZmIC0tZ2l0IGEvVG9vbHMvZ3RrL2NvbW1v bi5weSBiL1Rvb2xzL2d0ay9jb21tb24ucHkKaW5kZXggYzQwMDNmMTMxMTljYmZmMzFhMTk5MTli ZTJiNjNkYmRiYWU2MjMxZi4uYjQzYzlmMDg5ODc5OTBiNjcxNDA0MzRmYjFmYjgzMjljZDYyYjFj NSAxMDA2NDQKLS0tIGEvVG9vbHMvZ3RrL2NvbW1vbi5weQorKysgYi9Ub29scy9ndGsvY29tbW9u LnB5CkBAIC00MCw3ICs0MCw3IEBAIGRlZiBnZXRfYnVpbGRfcGF0aCgpOgogICAgICAgICByZXR1 cm4gYnVpbGRfZGlyCiAKICAgICBkZWYgaXNfdmFsaWRfYnVpbGRfZGlyZWN0b3J5KHBhdGgpOgot ICAgICAgICByZXR1cm4gb3MucGF0aC5leGlzdHMob3MucGF0aC5qb2luKHBhdGgsICcubGlicycp KQorICAgICAgICByZXR1cm4gb3MucGF0aC5leGlzdHMob3MucGF0aC5qb2luKHBhdGgsICdHTlVt YWtlZmlsZScpKQogCiAgICAgYnVpbGRfZGlyID0gdG9wX2xldmVsX3BhdGgoJ1dlYktpdEJ1aWxk JywgJ1JlbGVhc2UnKQogICAgIGlmIGlzX3ZhbGlkX2J1aWxkX2RpcmVjdG9yeShidWlsZF9kaXIp OgpkaWZmIC0tZ2l0IGEvVG9vbHMvZ3RrL2ZpbmQtbWFrZS1kaXN0LWVycm9ycyBiL1Rvb2xzL2d0 ay9maW5kLW1ha2UtZGlzdC1lcnJvcnMKbmV3IGZpbGUgbW9kZSAxMDA3NTUKaW5kZXggMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uYTBhZDlkY2JkNDlkNGRlMjA2Njg4 OWJlNGJkY2QyYmJiNzdjYjg2MAotLS0gL2Rldi9udWxsCisrKyBiL1Rvb2xzL2d0ay9maW5kLW1h a2UtZGlzdC1lcnJvcnMKQEAgLTAsMCArMSwxMDUgQEAKKyMhL3Vzci9iaW4vcHl0aG9uCisjIENv cHlyaWdodCAoQykgMjAxMSBJZ2FsaWEgUy5MLgorIworIyBUaGlzIGxpYnJhcnkgaXMgZnJlZSBz b2Z0d2FyZTsgeW91IGNhbiByZWRpc3RyaWJ1dGUgaXQgYW5kL29yCisjIG1vZGlmeSBpdCB1bmRl ciB0aGUgdGVybXMgb2YgdGhlIEdOVSBMZXNzZXIgR2VuZXJhbCBQdWJsaWMKKyMgTGljZW5zZSBh cyBwdWJsaXNoZWQgYnkgdGhlIEZyZWUgU29mdHdhcmUgRm91bmRhdGlvbjsgZWl0aGVyCisjIHZl cnNpb24gMiBvZiB0aGUgTGljZW5zZSwgb3IgKGF0IHlvdXIgb3B0aW9uKSBhbnkgbGF0ZXIgdmVy c2lvbi4KKyMKKyMgVGhpcyBsaWJyYXJ5IGlzIGRpc3RyaWJ1dGVkIGluIHRoZSBob3BlIHRoYXQg aXQgd2lsbCBiZSB1c2VmdWwsCisjIGJ1dCBXSVRIT1VUIEFOWSBXQVJSQU5UWTsgd2l0aG91dCBl dmVuIHRoZSBpbXBsaWVkIHdhcnJhbnR5IG9mCisjIE1FUkNIQU5UQUJJTElUWSBvciBGSVRORVNT IEZPUiBBIFBBUlRJQ1VMQVIgUFVSUE9TRS4gIFNlZSB0aGUgR05VCisjIExlc3NlciBHZW5lcmFs IFB1YmxpYyBMaWNlbnNlIGZvciBtb3JlIGRldGFpbHMuCisjCisjIFlvdSBzaG91bGQgaGF2ZSBy ZWNlaXZlZCBhIGNvcHkgb2YgdGhlIEdOVSBMZXNzZXIgR2VuZXJhbCBQdWJsaWMKKyMgTGljZW5z ZSBhbG9uZyB3aXRoIHRoaXMgbGlicmFyeTsgaWYgbm90LCB3cml0ZSB0byB0aGUgRnJlZSBTb2Z0 d2FyZQorIyBGb3VuZGF0aW9uLCBJbmMuLCA1MSBGcmFua2xpbiBTdHJlZXQsIEZpZnRoIEZsb29y LCBCb3N0b24sIE1BICAwMjExMC0xMzAxICBVU0EKKworaW1wb3J0IGNvbW1vbgoraW1wb3J0IG9z CitpbXBvcnQgc3VicHJvY2VzcworCitkZWYgaXNfc291cmNlX2ZpbGVfbGlzdGluZyhsaW5lKToK KyAgICByZXR1cm4gbGluZS5zdHJpcCgpLnN0YXJ0c3dpdGgoJ1NvdXJjZScpCisKK2RlZiBnZXRf bGlzdGVkX21ha2VmaWxlX2hlYWRlcnMoKToKKyAgICBtYWtlZmlsZV90ZXh0ID0gb3Blbihvcy5w YXRoLmpvaW4oY29tbW9uLmJ1aWxkX3BhdGgoJ0dOVW1ha2VmaWxlJykpKS5yZWFkKCkKKworICAg ICMgQXV0b21ha2Ugb2Z0ZW4gcGxhY2VzIHNlcGFyYXRlIGluY2x1ZGVzIG9uIHRoZSBzYW1lIGxp bmUuCisgICAgbWFrZWZpbGVfdGV4dCA9IG1ha2VmaWxlX3RleHQucmVwbGFjZSgnICcsICdcbicp CisKKyAgICBoZWFkZXJzID0gW10KKyAgICBmb3IgbGluZSBpbiBtYWtlZmlsZV90ZXh0LnNwbGl0 bGluZXMoKToKKyAgICAgICAgIyAkKHNyY2RpcikvIGlzIHRoZSBzYW1lIGFzIGFuIGVtcHR5IHN0 cmluZyBpbiBhIHNvdXJjZSBmaWxlIGxpc3RpbmcuCisgICAgICAgIGxpbmUgPSBsaW5lLnJlcGxh Y2UoJyQoc3JjZGlyKS8nLCAnJykKKworICAgICAgICAjIElmIHRoZSBsaW5lIGRvZXNuJ3Qgc3Rh cnQgd2l0aCAnU291cmNlJyBpdCBpc24ndCBsaXN0aW5nIGZvcgorICAgICAgICAjIGEgc291cmNl IGZpbGUuCisgICAgICAgIGlmIG5vdCBpc19zb3VyY2VfZmlsZV9saXN0aW5nKGxpbmUpOgorICAg ICAgICAgICAgY29udGludWUKKworICAgICAgICAjIE1vc3Qgc291cmNlIGxpc3RpbmdzIGVuZCB3 aXRoIFwgaW5kaWNhdGluZyB0aGF0IHRoZSBsaXN0aW5nCisgICAgICAgICMgY29udGludWVzIG9u dG8gdGhlIG5leHQgbGluZS4KKyAgICAgICAgbGluZSA9IGxpbmUucmVwbGFjZSgnXFwnLCAnJykK KworICAgICAgICAjIFdlIG9ubHkgY2FyZSBhYm91dCBoZWFkZXIgZmlsZXMuIFNvdXJjZSBmaWxl cyByZXN1bHQgaW4gYnVpbGQKKyAgICAgICAgIyBicmVha2FnZSwgc28gd2Ugd2lsbCBkZXRlY3Qg dGhlbSB3aXRob3V0IHRoaXMgc2NyaXB0LgorICAgICAgICBsaW5lID0gbGluZS5zdHJpcCgpCisg ICAgICAgIGlmIG5vdCBsaW5lLmVuZHN3aXRoKCcuaCcpOgorICAgICAgICAgICAgY29udGludWUK KworICAgICAgICAjIElmIHRoZSBsaW5lIGNvbnRhaW5zIGEgbWFrZWZpbGUgdmFyaWFibGUgd2Ug ZG8gbm90IGNhcmUgYWJvdXQgaXQuCisgICAgICAgIGlmIGxpbmUuZmluZCgnJCcpICE9IC0xOgor ICAgICAgICAgICAgY29udGludWUKKworICAgICAgICBoZWFkZXJzLmFwcGVuZChsaW5lKQorCisg ICAgcmV0dXJuIGhlYWRlcnMKKworZGVmIHNjYW5faGVhZGVyc19mcm9tX2RlcGVkZW5jeV9maWxl cygpOgorICAgIHByb2Nlc3MgPSBzdWJwcm9jZXNzLlBvcGVuKFsnZmluZCAuIC1uYW1lICouUGxv IHwgeGFyZ3MgY2F0IHwgZ3JlcCAuaDokJ10sCisgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgY3dkPWNvbW1vbi5idWlsZF9wYXRoKCksCisgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgc3Rkb3V0PXN1YnByb2Nlc3MuUElQRSwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBzaGVsbD1UcnVlKQorICAgIHNhbml0aXplZF9saW5lcyA9IHNldCgpCisgICAgZm9yIGxpbmUg aW4gcHJvY2Vzcy5jb21tdW5pY2F0ZSgpWzBdLnNwbGl0bGluZXMoKToKKyAgICAgICAgIyBQYXRo cyBpbiBQbG8gZmlsZXMgYXJlIHJlbGF0aXZlIHRvIHRoZSBidWlsZCBkaXJlY3Rvcnkgc28gdGhl eSBtaWdodCBjb250YWluCisgICAgICAgICMgLi4vLi4gaWYgdGhlIGJ1aWxkIGRpcmVjdG9yeSBp cyBzb21ldGhpbmcgbGlrZSBXZWJLaXRCdWlsZC9SZWxlYXNlLgorICAgICAgICBsaW5lID0gbGlu ZS5yZXBsYWNlKCcuLi8uLi8nLCAnJykKKyAgICAgICAgaWYgbm90IGlzX3NvdXJjZV9maWxlX2xp c3RpbmcobGluZSk6CisgICAgICAgICAgICBjb250aW51ZQorCisgICAgICAgICMgVGhlIGxpbmVz IHdlIGNhcmUgYWJvdXQgZW5kIHdpdGggJzonLgorICAgICAgICBsaW5lID0gbGluZS5yZXBsYWNl KCc6JywgJycpCisgICAgICAgIGxpbmUgPSBsaW5lLnN0cmlwKCkKKyAgICAgICAgc2FuaXRpemVk X2xpbmVzLmFkZChsaW5lKQorICAgIHJldHVybiBzYW5pdGl6ZWRfbGluZXMKKworZGVmIGdldF91 bmxpc3RlZF9oZWFkZXJzKGxpc3RlZF9tYWtlZmlsZV9oZWFkZXJzKToKKyAgICB1bmxpc3RlZCA9 IHNldCgpCisgICAgZm9yIGhlYWRlciBpbiBzY2FuX2hlYWRlcnNfZnJvbV9kZXBlZGVuY3lfZmls ZXMoKToKKyAgICAgICAgaWYgbm90IGhlYWRlciBpbiBsaXN0ZWRfbWFrZWZpbGVfaGVhZGVyczoK KyAgICAgICAgICAgIHVubGlzdGVkLmFkZChoZWFkZXIpCisgICAgcmV0dXJuIHVubGlzdGVkCisK K2RlZiBnZXRfbWlzc2luZ19oZWFkZXJzKGxpc3RlZF9tYWtlZmlsZV9oZWFkZXJzKToKKyAgICBt aXNzaW5nID0gc2V0KCkKKyAgICBmb3IgaGVhZGVyIGluIGxpc3RlZF9tYWtlZmlsZV9oZWFkZXJz OgorICAgICAgICBpZiBub3Qgb3MucGF0aC5leGlzdHMoY29tbW9uLnRvcF9sZXZlbF9wYXRoKGhl YWRlcikpOgorICAgICAgICAgICAgbWlzc2luZy5hZGQoaGVhZGVyKQorICAgIHJldHVybiBtaXNz aW5nCisKK2xpc3RlZF9tYWtlZmlsZV9oZWFkZXJzID0gZ2V0X2xpc3RlZF9tYWtlZmlsZV9oZWFk ZXJzKCkKK3VubGlzdGVkX2hlYWRlcnMgPSBnZXRfdW5saXN0ZWRfaGVhZGVycyhsaXN0ZWRfbWFr ZWZpbGVfaGVhZGVycykKK21pc3NpbmdfaGVhZGVycyA9IGdldF9taXNzaW5nX2hlYWRlcnMobGlz dGVkX21ha2VmaWxlX2hlYWRlcnMpCitpZiB1bmxpc3RlZF9oZWFkZXJzOgorICAgIHByaW50ICdI ZWFkZXJzIG5vdCBsaXN0ZWQgaW4gdGhlIEdOVW1ha2VmaWxlczonCisgICAgZm9yIGhlYWRlciBp biBzb3J0ZWQodW5saXN0ZWRfaGVhZGVycyk6CisgICAgICAgIHByaW50ICdcdCVzJyAlIGhlYWRl cgorICAgIHByaW50CisKK2lmIG1pc3NpbmdfaGVhZGVyczoKKyAgICBwcmludCAnSGVhZGVycyBs aXN0ZWQgaW4gdGhlIEdOVW1ha2VmaWxlcyB0aGF0IGRvIG5vdCBleGlzdDonCisgICAgZm9yIGhl YWRlciBpbiBzb3J0ZWQobWlzc2luZ19oZWFkZXJzKToKKyAgICAgICAgcHJpbnQgJ1x0JXMnICUg aGVhZGVyCisgICAgcHJpbnQK