73197 2011-11-28 01:53:02 -0800 [GTK] JavaScriptCore generated sources should build in the DerivedSources directory 2011-11-28 03:05:09 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mrobinson mrobinson oldest_to_newest 509661 0 mrobinson 2011-11-28 01:53:02 -0800 This would standardize things a bit and make it easier to detect 'make dist' brokenness. 509684 1 116718 mrobinson 2011-11-28 02:31:09 -0800 Created attachment 116718 Patch 509688 2 116718 pnormand 2011-11-28 02:39:09 -0800 Comment on attachment 116718 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=116718&action=review Looks good, just a couple of remarks > Source/JavaScriptCore/GNUmakefile.am:77 > +$(shell mkdir -p DerivedSources/JavaScriptCore) It's a bit odd to have this here no? Maybe move it to the all-local target of the top level GNUMakefile.am ? Also maybe it'd be better like ($mkdir_p) $(top_builddir)/DerivedSources/JavaScriptCore > Source/JavaScriptCore/GNUmakefile.am:89 > + $(PYTHON) $^ > $@ Why remove $(AM_V_GEN) ? 509692 3 mrobinson 2011-11-28 02:53:21 -0800 (In reply to comment #2) > It's a bit odd to have this here no? Maybe move it to the all-local target of the top level GNUMakefile.am ? I tried this without luck. :( > Also maybe it'd be better like ($mkdir_p) This doesn't work since it's at the toplevel, I think. $(top_builddir)/DerivedSources/JavaScriptCore > > > Source/JavaScriptCore/GNUmakefile.am:89 > > + $(PYTHON) $^ > $@ > > Why remove $(AM_V_GEN) ? I don't know! Fixed. 509697 4 mrobinson 2011-11-28 03:05:09 -0800 Committed r101242: <http://trac.webkit.org/changeset/101242> 116718 2011-11-28 02:31:09 -0800 2011-11-28 02:39:09 -0800 Patch bug-73197-20111128113106.patch text/plain 7183 mrobinson U3VidmVyc2lvbiBSZXZpc2lvbjogMTAxMjM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBm Njc0ODY0NDc2NjI5NjZmNDBmMGViZGZhYjIxZGE5MTRkNThiZTZjLi5kNjcyMTUxY2E4NDMzODM5 MjU3NTNiMjQ2ZDE5YzA4ZDE5ZGRkNTBmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxMS0xMS0yOCAgTWFydGluIFJvYmluc29uICA8bXJvYmluc29uQGlnYWxp YS5jb20+CisKKyAgICAgICAgW0dUS10gSmF2YVNjcmlwdENvcmUgZ2VuZXJhdGVkIHNvdXJjZXMg c2hvdWxkIGJ1aWxkIGluIHRoZSBEZXJpdmVkU291cmNlcyBkaXJlY3RvcnkKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTczMTk3CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQnVpbGQgYWxsIEphdmFTY3JpcHRD b3JlIGdlbmVyYXRlZCBzb3VyY2VzIGluIERlcml2ZWRTb3VyY2VzLgorCisgICAgICAgICogR05V bWFrZWZpbGUuYW06IFVwZGF0ZSBnZW5lcmF0aW9uIHJ1bGVzLgorICAgICAgICAqIEdOVW1ha2Vm aWxlLmxpc3QuYW06IFVwZGF0ZSBzb3VyY2UgbGlzdHMuCisKIDIwMTEtMTEtMjcgIEZpbGlwIFBp emxvICA8ZnBpemxvQGFwcGxlLmNvbT4KIAogICAgICAgICBERkcgc2hvdWxkIG5vdCBlbWl0IEdl dE1ldGhvZCBub2RlCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvR05VbWFrZWZp bGUuYW0gYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvR05VbWFrZWZpbGUuYW0KaW5kZXggNmY4MDQ2 NDdhYThhZDVlYjlkYWJhYjFjNGNmZmI3NTBlN2NkNjMwZS4uYmNhMGRiNDYwNmNlNTMwODY1NzYy NDE3ODg5ODA3YzFmYTRlZWExYyAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0dO VW1ha2VmaWxlLmFtCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9HTlVtYWtlZmlsZS5hbQpA QCAtNjUsOSArNjUsNyBAQCBqYXZhc2NyaXB0Y29yZV9jcHBmbGFncyArPSBcCiAJLUkkKHNyY2Rp cikvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi90ZXh0IFwKIAktSSQoc3JjZGlyKS9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvd3RmL3VuaWNvZGUgXAogCS1JJChzcmNkaXIpL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS95YXJyIFwKLQktSSQodG9wX2J1aWxkZGlyKS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUg XAotCS1JJCh0b3BfYnVpbGRkaXIpL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9wYXJzZXIgXAotCS1J JCh0b3BfYnVpbGRkaXIpL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lCisJLUkkKHRvcF9i dWlsZGRpcikvRGVyaXZlZFNvdXJjZXMvSmF2YVNjcmlwdENvcmUKIAogamF2YXNjcmlwdGNvcmVf Y2ZsYWdzICs9IFwKIAkkKGdsb2JhbF9jZmxhZ3MpIFwKQEAgLTc2LDE3ICs3NCwxOSBAQCBqYXZh c2NyaXB0Y29yZV9jZmxhZ3MgKz0gXAogCiBwa2djb25maWdfREFUQSArPSBTb3VyY2UvSmF2YVNj cmlwdENvcmUvamF2YXNjcmlwdGNvcmVndGstQFdFQktJVEdUS19BUElfVkVSU0lPTkAucGMKIAot U291cmNlL0phdmFTY3JpcHRDb3JlL0xleGVyLmx1dC5oOiAkKHNyY2RpcikvU291cmNlL0phdmFT Y3JpcHRDb3JlL2NyZWF0ZV9oYXNoX3RhYmxlICQoc3JjZGlyKS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvcGFyc2VyL0tleXdvcmRzLnRhYmxlCiskKHNoZWxsIG1rZGlyIC1wIERlcml2ZWRTb3VyY2Vz L0phdmFTY3JpcHRDb3JlKQorCitEZXJpdmVkU291cmNlcy9KYXZhU2NyaXB0Q29yZS9MZXhlci5s dXQuaDogJChzcmNkaXIpL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9jcmVhdGVfaGFzaF90YWJsZSAk KHNyY2RpcikvU291cmNlL0phdmFTY3JpcHRDb3JlL3BhcnNlci9LZXl3b3Jkcy50YWJsZQogCSQo QU1fVl9HRU4pJChQRVJMKSAkXiA+ICRACiAKLVNvdXJjZS9KYXZhU2NyaXB0Q29yZS8lLmx1dC5o OiAkKHNyY2RpcikvU291cmNlL0phdmFTY3JpcHRDb3JlL2NyZWF0ZV9oYXNoX3RhYmxlICQoc3Jj ZGlyKS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvJS5jcHAKK0Rlcml2ZWRTb3VyY2VzL0phdmFTY3Jp cHRDb3JlLyUubHV0Lmg6ICQoc3JjZGlyKS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvY3JlYXRlX2hh c2hfdGFibGUgJChzcmNkaXIpL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lLyUuY3BwCiAJ JChBTV9WX0dFTikkKFBFUkwpICReIC1pID4gJEAKIAotU291cmNlL0phdmFTY3JpcHRDb3JlL1Jl Z0V4cEppdFRhYmxlcy5oOiAkKHNyY2RpcikvU291cmNlL0phdmFTY3JpcHRDb3JlL2NyZWF0ZV9y ZWdleF90YWJsZXMKK0Rlcml2ZWRTb3VyY2VzL0phdmFTY3JpcHRDb3JlL1JlZ0V4cEppdFRhYmxl cy5oOiAkKHNyY2RpcikvU291cmNlL0phdmFTY3JpcHRDb3JlL2NyZWF0ZV9yZWdleF90YWJsZXMK IAkkKEFNX1ZfR0VOKSQoUFlUSE9OKSAkXiA+ICRACiAKLVNvdXJjZS9KYXZhU2NyaXB0Q29yZS9L ZXl3b3JkTG9va3VwLmg6ICQoc3JjZGlyKS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvS2V5d29yZExv b2t1cEdlbmVyYXRvci5weSAkKHNyY2RpcikvU291cmNlL0phdmFTY3JpcHRDb3JlL3BhcnNlci9L ZXl3b3Jkcy50YWJsZQotCSQoQU1fVl9HRU4pJChQWVRIT04pICReID4gJEAKK0Rlcml2ZWRTb3Vy Y2VzL0phdmFTY3JpcHRDb3JlL0tleXdvcmRMb29rdXAuaDogJChzcmNkaXIpL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9LZXl3b3JkTG9va3VwR2VuZXJhdG9yLnB5ICQoc3JjZGlyKS9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvcGFyc2VyL0tleXdvcmRzLnRhYmxlCisJJChQWVRIT04pICReID4gJEAKIAog anNjOiAkKGphdmFzY3JpcHRjb3JlX2J1aWx0X25vc291cmNlcykgUHJvZ3JhbXMvanNjJChFWEVF WFQpCiAKQEAgLTE1MiwyOSArMTUyLDggQEAgRVhUUkFfRElTVCArPSBcCiAJU291cmNlL0phdmFT Y3JpcHRDb3JlL3BhcnNlci9LZXl3b3Jkcy50YWJsZSBcCiAJU291cmNlL0phdmFTY3JpcHRDb3Jl L1RIQU5LUwogCi0jIENsZWFuIHJ1bGVzIGZvciBKYXZhU2NyaXB0Q29yZQotIyBGSVhNRTogU2hv dWxkIHRoaXMgbGlzdCBiZSBnZW5lcmF0ZWQgZnJvbSBqYXZhc2NyaXB0Y29yZV9idWlsdF9ub3Nv dXJjZXM/CiBDTEVBTkZJTEVTICs9IFwKLQlTb3VyY2UvSmF2YVNjcmlwdENvcmUvTGV4ZXIubHV0 LmggXAotCVNvdXJjZS9KYXZhU2NyaXB0Q29yZS9SZWdFeHBKaXRUYWJsZXMuaCBcCi0JU291cmNl L0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvQXJyYXlDb25zdHJ1Y3Rvci5sdXQuaCBcCi0JU291cmNl L0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvQXJyYXlQcm90b3R5cGUubHV0LmggXAotCVNvdXJjZS9K YXZhU2NyaXB0Q29yZS9ydW50aW1lL0Jvb2xlYW5Qcm90b3R5cGUubHV0LmggXAotCVNvdXJjZS9K YXZhU2NyaXB0Q29yZS9ydW50aW1lL0RhdGVDb25zdHJ1Y3Rvci5sdXQuaCBcCi0JU291cmNlL0ph dmFTY3JpcHRDb3JlL3J1bnRpbWUvRGF0ZVByb3RvdHlwZS5sdXQuaCBcCi0JU291cmNlL0phdmFT Y3JpcHRDb3JlL3J1bnRpbWUvRXJyb3JQcm90b3R5cGUubHV0LmggXAotCVNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9ydW50aW1lL0pTR2xvYmFsT2JqZWN0Lmx1dC5oIFwKLQlTb3VyY2UvSmF2YVNjcmlw dENvcmUvcnVudGltZS9KU09OT2JqZWN0Lmx1dC5oIFwKLQlTb3VyY2UvSmF2YVNjcmlwdENvcmUv cnVudGltZS9NYXRoT2JqZWN0Lmx1dC5oIFwKLQlTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGlt ZS9OdW1iZXJDb25zdHJ1Y3Rvci5sdXQuaCBcCi0JU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRp bWUvTnVtYmVyUHJvdG90eXBlLmx1dC5oIFwKLQlTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGlt ZS9PYmplY3RDb25zdHJ1Y3Rvci5sdXQuaCBcCi0JU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRp bWUvT2JqZWN0UHJvdG90eXBlLmx1dC5oIFwKLQlTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGlt ZS9SZWdFeHBDb25zdHJ1Y3Rvci5sdXQuaCBcCi0JU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRp bWUvUmVnRXhwT2JqZWN0Lmx1dC5oIFwKLQlTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9S ZWdFeHBQcm90b3R5cGUubHV0LmggXAotCVNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1N0 cmluZ0NvbnN0cnVjdG9yLmx1dC5oIFwKLQlTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9T dHJpbmdQcm90b3R5cGUubHV0LmggXAorCSQoamF2YXNjcmlwdGNvcmVfYnVpbHRfbm9zb3VyY2Vz KSBcCiAJUHJvZ3JhbXMvanNjIFwKIAlQcm9ncmFtcy9qc2MtQFdFQktJVEdUS19BUElfTUFKT1Jf VkVSU0lPTkAgXAogCVByb2dyYW1zL21pbmlkb20KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9HTlVtYWtlZmlsZS5saXN0LmFtIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0dOVW1h a2VmaWxlLmxpc3QuYW0KaW5kZXggN2Q1ZmRkNWQ5ZGJhMDA3MWI5ODkxNDZjOTNlN2EwYjVmYzZi ZGQzMC4uZDViZGQ4YWI0ZWUxY2MwOWIwMjBkZjIyOTQ2NzFhNmQ1MGY3Mzc4YyAxMDA2NDQKLS0t IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0dOVW1ha2VmaWxlLmxpc3QuYW0KKysrIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL0dOVW1ha2VmaWxlLmxpc3QuYW0KQEAgLTExLDI3ICsxMSwyNyBAQCBq YXZhc2NyaXB0Y29yZV9oX2FwaSArPSBcCiAJU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS9XZWJL aXRBdmFpbGFiaWxpdHkuaAogCiBqYXZhc2NyaXB0Y29yZV9idWlsdF9ub3NvdXJjZXMgKz0gXAot CVNvdXJjZS9KYXZhU2NyaXB0Q29yZS9LZXl3b3JkTG9va3VwLmggXAotCVNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9MZXhlci5sdXQuaCBcCi0JU291cmNlL0phdmFTY3JpcHRDb3JlL1JlZ0V4cEppdFRh Ymxlcy5oIFwKLQlTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9BcnJheUNvbnN0cnVjdG9y Lmx1dC5oIFwKLQlTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9BcnJheVByb3RvdHlwZS5s dXQuaCBcCi0JU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvQm9vbGVhblByb3RvdHlwZS5s dXQuaCBcCi0JU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvRGF0ZUNvbnN0cnVjdG9yLmx1 dC5oIFwKLQlTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9EYXRlUHJvdG90eXBlLmx1dC5o IFwKLQlTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9FcnJvclByb3RvdHlwZS5sdXQuaCBc Ci0JU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNHbG9iYWxPYmplY3QubHV0LmggXAot CVNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTT05PYmplY3QubHV0LmggXAotCVNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL01hdGhPYmplY3QubHV0LmggXAotCVNvdXJjZS9KYXZh U2NyaXB0Q29yZS9ydW50aW1lL051bWJlckNvbnN0cnVjdG9yLmx1dC5oIFwKLQlTb3VyY2UvSmF2 YVNjcmlwdENvcmUvcnVudGltZS9OdW1iZXJQcm90b3R5cGUubHV0LmggXAotCVNvdXJjZS9KYXZh U2NyaXB0Q29yZS9ydW50aW1lL09iamVjdENvbnN0cnVjdG9yLmx1dC5oIFwKLQlTb3VyY2UvSmF2 YVNjcmlwdENvcmUvcnVudGltZS9PYmplY3RQcm90b3R5cGUubHV0LmggXAotCVNvdXJjZS9KYXZh U2NyaXB0Q29yZS9ydW50aW1lL1JlZ0V4cENvbnN0cnVjdG9yLmx1dC5oIFwKLQlTb3VyY2UvSmF2 YVNjcmlwdENvcmUvcnVudGltZS9SZWdFeHBPYmplY3QubHV0LmggXAotCVNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9ydW50aW1lL1JlZ0V4cFByb3RvdHlwZS5sdXQuaCBcCi0JU291cmNlL0phdmFTY3Jp cHRDb3JlL3J1bnRpbWUvU3RyaW5nQ29uc3RydWN0b3IubHV0LmggXAotCVNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9ydW50aW1lL1N0cmluZ1Byb3RvdHlwZS5sdXQuaAorCURlcml2ZWRTb3VyY2VzL0ph dmFTY3JpcHRDb3JlL0tleXdvcmRMb29rdXAuaCBcCisJRGVyaXZlZFNvdXJjZXMvSmF2YVNjcmlw dENvcmUvTGV4ZXIubHV0LmggXAorCURlcml2ZWRTb3VyY2VzL0phdmFTY3JpcHRDb3JlL1JlZ0V4 cEppdFRhYmxlcy5oIFwKKwlEZXJpdmVkU291cmNlcy9KYXZhU2NyaXB0Q29yZS9BcnJheUNvbnN0 cnVjdG9yLmx1dC5oIFwKKwlEZXJpdmVkU291cmNlcy9KYXZhU2NyaXB0Q29yZS9BcnJheVByb3Rv dHlwZS5sdXQuaCBcCisJRGVyaXZlZFNvdXJjZXMvSmF2YVNjcmlwdENvcmUvQm9vbGVhblByb3Rv dHlwZS5sdXQuaCBcCisJRGVyaXZlZFNvdXJjZXMvSmF2YVNjcmlwdENvcmUvRGF0ZUNvbnN0cnVj dG9yLmx1dC5oIFwKKwlEZXJpdmVkU291cmNlcy9KYXZhU2NyaXB0Q29yZS9EYXRlUHJvdG90eXBl Lmx1dC5oIFwKKwlEZXJpdmVkU291cmNlcy9KYXZhU2NyaXB0Q29yZS9FcnJvclByb3RvdHlwZS5s dXQuaCBcCisJRGVyaXZlZFNvdXJjZXMvSmF2YVNjcmlwdENvcmUvSlNHbG9iYWxPYmplY3QubHV0 LmggXAorCURlcml2ZWRTb3VyY2VzL0phdmFTY3JpcHRDb3JlL0pTT05PYmplY3QubHV0LmggXAor CURlcml2ZWRTb3VyY2VzL0phdmFTY3JpcHRDb3JlL01hdGhPYmplY3QubHV0LmggXAorCURlcml2 ZWRTb3VyY2VzL0phdmFTY3JpcHRDb3JlL051bWJlckNvbnN0cnVjdG9yLmx1dC5oIFwKKwlEZXJp dmVkU291cmNlcy9KYXZhU2NyaXB0Q29yZS9OdW1iZXJQcm90b3R5cGUubHV0LmggXAorCURlcml2 ZWRTb3VyY2VzL0phdmFTY3JpcHRDb3JlL09iamVjdENvbnN0cnVjdG9yLmx1dC5oIFwKKwlEZXJp dmVkU291cmNlcy9KYXZhU2NyaXB0Q29yZS9PYmplY3RQcm90b3R5cGUubHV0LmggXAorCURlcml2 ZWRTb3VyY2VzL0phdmFTY3JpcHRDb3JlL1JlZ0V4cENvbnN0cnVjdG9yLmx1dC5oIFwKKwlEZXJp dmVkU291cmNlcy9KYXZhU2NyaXB0Q29yZS9SZWdFeHBPYmplY3QubHV0LmggXAorCURlcml2ZWRT b3VyY2VzL0phdmFTY3JpcHRDb3JlL1JlZ0V4cFByb3RvdHlwZS5sdXQuaCBcCisJRGVyaXZlZFNv dXJjZXMvSmF2YVNjcmlwdENvcmUvU3RyaW5nQ29uc3RydWN0b3IubHV0LmggXAorCURlcml2ZWRT b3VyY2VzL0phdmFTY3JpcHRDb3JlL1N0cmluZ1Byb3RvdHlwZS5sdXQuaAogCiBqYXZhc2NyaXB0 Y29yZV9zb3VyY2VzICs9IFwKIAlTb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL0FQSUNhc3QuaCBc Cg==