73195 2011-11-28 01:28:06 -0800 [chromium] Disable compositing for RTL pages even in forceCompositingMode 2011-11-28 20:34:39 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 falken falken enne jamesr vangelis webkit.review.bot oldest_to_newest 509644 0 falken 2011-11-28 01:28:06 -0800 It seems the forceCompositingMode overrides the checks that normally disable GPU compositing on RTL pages, and this is causing renderer hangs. Since forceCompositingMode is on by default in Chrome OS R15 and R16, we probably don't want this. I have prepared a patch, but am not too sure it is the correct thing. I verified at least it stops the renderer hang on RTL pages on ToT Linux. The corresponding Chrome OS bug is http://code.google.com/p/chromium-os/issues/detail?id=20666 509646 1 116711 falken 2011-11-28 01:30:37 -0800 Created attachment 116711 Patch 509864 2 enne 2011-11-28 08:59:28 -0800 That check looks like something that should have been there in the first place. 509924 3 116778 vangelis 2011-11-28 10:19:58 -0800 Created attachment 116778 RTL-fix I think a better place for disabling forceCompositingMode is actually in RenderLayerCompositor::cacheAcceleratedCompositingFlags() . It just needs to be moved a bit further down, after the RTL check is done. 510421 4 116872 falken 2011-11-28 19:43:49 -0800 Created attachment 116872 rebase vangelis@ patch and add changelog 510444 5 116872 webkit.review.bot 2011-11-28 20:34:35 -0800 Comment on attachment 116872 rebase vangelis@ patch and add changelog Clearing flags on attachment: 116872 Committed r101322: <http://trac.webkit.org/changeset/101322> 510445 6 webkit.review.bot 2011-11-28 20:34:39 -0800 All reviewed patches have been landed. Closing bug. 116711 2011-11-28 01:30:37 -0800 2011-11-28 19:43:35 -0800 Patch bug-73195-20111128183036.patch text/plain 1542 falken U3VidmVyc2lvbiBSZXZpc2lvbjogMTAxMTY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWQxOTRiMjkwNWQwNDll OGQ1MjZlMmRmYzMyMmY5Mjc4ZDg1NzQzZS4uOGRiZTg1YTBmZGNmMDcyY2RhYzM0MTA1YjRkMTc1 Mzk3ZTAxZTE3ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDExLTExLTI4ICBNYXR0 IEZhbGtlbmhhZ2VuICA8ZmFsa2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBbY2hyb21pdW1d IERpc2FibGUgY29tcG9zaXRpbmcgZm9yIFJUTCBwYWdlcyBldmVuIGluIGZvcmNlQ29tcG9zaXRp bmdNb2RlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03 MzE5NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog cmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpS ZW5kZXJMYXllckNvbXBvc2l0b3I6OnVwZGF0ZUNvbXBvc2l0aW5nTGF5ZXJzKToKKwogMjAxMS0x MS0yNSAgWXVyeSBTZW1pa2hhdHNreSAgPHl1cnlzQGNocm9taXVtLm9yZz4KIAogICAgICAgICBb Q2hyb21pdW1dIFdlYiBJbnNwZWN0b3I6IGdldCByaWQgb2YgV2ViRGV2VG9vbHNGcm9udGVuZENs aWVudDo6c2VuZEZyb250ZW5kTG9hZGVkIG1ldGhvZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmNwcAppbmRleCBmOTNhMzk5YmUxMTNhNTdj NWVkNWZjMmVjZGVjZjlmMWNjYmFiMDc0Li5mMzJmZjkwZDZmYzBiYzAxNGIwOWNlMjFmZDllYWE2 NmExMjIwZmU2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5 ZXJDb21wb3NpdG9yLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5 ZXJDb21wb3NpdG9yLmNwcApAQCAtMjU2LDcgKzI1Niw3IEBAIHZvaWQgUmVuZGVyTGF5ZXJDb21w b3NpdG9yOjp1cGRhdGVDb21wb3NpdGluZ0xheWVycyhDb21wb3NpdGluZ1VwZGF0ZVR5cGUgdXBk YXRlCiAgICAgaWYgKCFtX3JlbmRlclZpZXctPmRvY3VtZW50KCktPnZpc3VhbFVwZGF0ZXNBbGxv d2VkKCkpCiAgICAgICAgIHJldHVybjsKIAotICAgIGlmIChtX2ZvcmNlQ29tcG9zaXRpbmdNb2Rl ICYmICFtX2NvbXBvc2l0aW5nKQorICAgIGlmIChtX2ZvcmNlQ29tcG9zaXRpbmdNb2RlICYmIG1f aGFzQWNjZWxlcmF0ZWRDb21wb3NpdGluZyAmJiAhbV9jb21wb3NpdGluZykKICAgICAgICAgZW5h YmxlQ29tcG9zaXRpbmdNb2RlKHRydWUpOwogCiAgICAgaWYgKCFtX2NvbXBvc2l0aW5nRGVwZW5k c09uR2VvbWV0cnkgJiYgIW1fY29tcG9zaXRpbmcgJiYgIW1fY29tcG9zaXRpbmdOZWVkc1VwZGF0 ZSkK 116778 2011-11-28 10:19:58 -0800 2011-11-28 19:43:38 -0800 RTL-fix RTL_fix.diff text/plain 2146 vangelis SW5kZXg6IFJlbmRlckxheWVyQ29tcG9zaXRvci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gUmVuZGVyTGF5 ZXJDb21wb3NpdG9yLmNwcAkocmV2aXNpb24gMTAwOTc4KQorKysgUmVuZGVyTGF5ZXJDb21wb3Np dG9yLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTM5LDYgKzEzOSwxOSBAQAogCiAgICAgaWYgKFNl dHRpbmdzKiBzZXR0aW5ncyA9IG1fcmVuZGVyVmlldy0+ZG9jdW1lbnQoKS0+c2V0dGluZ3MoKSkg ewogICAgICAgICBoYXNBY2NlbGVyYXRlZENvbXBvc2l0aW5nID0gc2V0dGluZ3MtPmFjY2VsZXJh dGVkQ29tcG9zaXRpbmdFbmFibGVkKCk7CisKKyAgICAgICAgLy8gV2UgYWxsb3cgdGhlIGNocm9t ZSB0byBvdmVycmlkZSB0aGUgc2V0dGluZ3MsIGluIGNhc2UgdGhlIHBhZ2UgaXMgcmVuZGVyZWQK KyAgICAgICAgLy8gb24gYSBjaHJvbWUgdGhhdCBkb2Vzbid0IGFsbG93IGFjY2VsZXJhdGVkIGNv bXBvc2l0aW5nLgorICAgICAgICBpZiAoaGFzQWNjZWxlcmF0ZWRDb21wb3NpdGluZykgeworICAg ICAgICAgICAgRnJhbWUqIGZyYW1lID0gbV9yZW5kZXJWaWV3LT5mcmFtZVZpZXcoKS0+ZnJhbWUo KTsKKyAgICAgICAgICAgIFBhZ2UqIHBhZ2UgPSBmcmFtZSA/IGZyYW1lLT5wYWdlKCkgOiAwOwor ICAgICAgICAgICAgaWYgKHBhZ2UpIHsKKyAgICAgICAgICAgICAgICBDaHJvbWVDbGllbnQqIGNo cm9tZUNsaWVudCA9IHBhZ2UtPmNocm9tZSgpLT5jbGllbnQoKTsKKyAgICAgICAgICAgICAgICBt X2NvbXBvc2l0aW5nVHJpZ2dlcnMgPSBjaHJvbWVDbGllbnQtPmFsbG93ZWRDb21wb3NpdGluZ1Ry aWdnZXJzKCk7CisgICAgICAgICAgICAgICAgaGFzQWNjZWxlcmF0ZWRDb21wb3NpdGluZyA9IG1f Y29tcG9zaXRpbmdUcmlnZ2VyczsKKyAgICAgICAgICAgIH0KKyAgICAgICAgfQorCiAgICAgICAg IHNob3dEZWJ1Z0JvcmRlcnMgPSBzZXR0aW5ncy0+c2hvd0RlYnVnQm9yZGVycygpOwogICAgICAg ICBzaG93UmVwYWludENvdW50ZXIgPSBzZXR0aW5ncy0+c2hvd1JlcGFpbnRDb3VudGVyKCk7CiAg ICAgICAgIGZvcmNlQ29tcG9zaXRpbmdNb2RlID0gc2V0dGluZ3MtPmZvcmNlQ29tcG9zaXRpbmdN b2RlKCkgJiYgaGFzQWNjZWxlcmF0ZWRDb21wb3NpdGluZzsKQEAgLTE0NywxOCArMTYwLDYgQEAK ICAgICAgICAgICAgIGZvcmNlQ29tcG9zaXRpbmdNb2RlID0gc2V0dGluZ3MtPmFjY2VsZXJhdGVk Q29tcG9zaXRpbmdGb3JTY3JvbGxhYmxlRnJhbWVzRW5hYmxlZCgpICYmIHJlcXVpcmVzQ29tcG9z aXRpbmdGb3JTY3JvbGxhYmxlRnJhbWUoKTsKICAgICB9CiAKLSAgICAvLyBXZSBhbGxvdyB0aGUg Y2hyb21lIHRvIG92ZXJyaWRlIHRoZSBzZXR0aW5ncywgaW4gY2FzZSB0aGUgcGFnZSBpcyByZW5k ZXJlZAotICAgIC8vIG9uIGEgY2hyb21lIHRoYXQgZG9lc24ndCBhbGxvdyBhY2NlbGVyYXRlZCBj b21wb3NpdGluZy4KLSAgICBpZiAoaGFzQWNjZWxlcmF0ZWRDb21wb3NpdGluZykgewotICAgICAg ICBGcmFtZSogZnJhbWUgPSBtX3JlbmRlclZpZXctPmZyYW1lVmlldygpLT5mcmFtZSgpOwotICAg ICAgICBQYWdlKiBwYWdlID0gZnJhbWUgPyBmcmFtZS0+cGFnZSgpIDogMDsKLSAgICAgICAgaWYg KHBhZ2UpIHsKLSAgICAgICAgICAgIENocm9tZUNsaWVudCogY2hyb21lQ2xpZW50ID0gcGFnZS0+ Y2hyb21lKCktPmNsaWVudCgpOwotICAgICAgICAgICAgbV9jb21wb3NpdGluZ1RyaWdnZXJzID0g Y2hyb21lQ2xpZW50LT5hbGxvd2VkQ29tcG9zaXRpbmdUcmlnZ2VycygpOwotICAgICAgICAgICAg aGFzQWNjZWxlcmF0ZWRDb21wb3NpdGluZyA9IG1fY29tcG9zaXRpbmdUcmlnZ2VyczsKLSAgICAg ICAgfQotICAgIH0KLQogICAgIGlmIChoYXNBY2NlbGVyYXRlZENvbXBvc2l0aW5nICE9IG1faGFz QWNjZWxlcmF0ZWRDb21wb3NpdGluZyB8fCBzaG93RGVidWdCb3JkZXJzICE9IG1fc2hvd0RlYnVn Qm9yZGVycyB8fCBzaG93UmVwYWludENvdW50ZXIgIT0gbV9zaG93UmVwYWludENvdW50ZXIgfHwg Zm9yY2VDb21wb3NpdGluZ01vZGUgIT0gbV9mb3JjZUNvbXBvc2l0aW5nTW9kZSkKICAgICAgICAg c2V0Q29tcG9zaXRpbmdMYXllcnNOZWVkUmVidWlsZCgpOwogCg== 116872 2011-11-28 19:43:49 -0800 2011-11-28 20:34:35 -0800 rebase vangelis@ patch and add changelog bug-73195-20111129124348.patch text/plain 3186 falken U3VidmVyc2lvbiBSZXZpc2lvbjogMTAxMzE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzhlN2Y5MGJlZDUyMjFj NGQ5MTEyOTI2MzEyMzEzNmJiYmU0MjMyNy4uMzllMDdiZjAwNDFiMWNmZWE5NzVmNmEzMjFlZTU4 YWJmODVmNjhhNCAxMDA3NTUKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDExLTExLTI4ICBWYW5n ZWxpcyBLb2trZXZpcyAgPHZhbmdlbGlzQGNocm9taXVtLm9yZz4KKworICAgICAgICBbY2hyb21p dW1dIERpc2FibGUgY29tcG9zaXRpbmcgZm9yIFJUTCBwYWdlcyBldmVuIGluIGZvcmNlQ29tcG9z aXRpbmdNb2RlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD03MzE5NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpSZW5kZXJMYXllckNvbXBvc2l0b3I6OmNhY2hlQWNjZWxlcmF0ZWRDb21wb3NpdGluZ0ZsYWdz KToKKwogMjAxMS0xMS0yOCAgVGltb3RoeSBIYXRjaGVyICA8dGltb3RoeUBhcHBsZS5jb20+CiAK ICAgICAgICAgQWRkIHN1cHBvcnQgZm9yIGtub3dpbmcgd2hlbiBhIFRyZWVFbGVtZW50IGlzIGFk ZGVkIG9yIGNoYW5nZWQgYW55d2hlcmUgaW4gYSBUcmVlT3V0bGluZS4KZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckNvbXBvc2l0b3IuY3BwIGIvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5jcHAKaW5kZXggZjkzYTM5 OWJlMTEzYTU3YzVlZDVmYzJlY2RlY2Y5ZjFjY2JhYjA3NC4uMTc0ZTJjYWM2MjY3NDRhNjRiMDY2 ZWE5ZWQ0NDBlNzk3NDFmYjEzZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlckxheWVyQ29tcG9zaXRvci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlckxheWVyQ29tcG9zaXRvci5jcHAKQEAgLTEzOSw2ICsxMzksMTkgQEAgdm9pZCBSZW5k ZXJMYXllckNvbXBvc2l0b3I6OmNhY2hlQWNjZWxlcmF0ZWRDb21wb3NpdGluZ0ZsYWdzKCkKIAog ICAgIGlmIChTZXR0aW5ncyogc2V0dGluZ3MgPSBtX3JlbmRlclZpZXctPmRvY3VtZW50KCktPnNl dHRpbmdzKCkpIHsKICAgICAgICAgaGFzQWNjZWxlcmF0ZWRDb21wb3NpdGluZyA9IHNldHRpbmdz LT5hY2NlbGVyYXRlZENvbXBvc2l0aW5nRW5hYmxlZCgpOworCisgICAgICAgIC8vIFdlIGFsbG93 IHRoZSBjaHJvbWUgdG8gb3ZlcnJpZGUgdGhlIHNldHRpbmdzLCBpbiBjYXNlIHRoZSBwYWdlIGlz IHJlbmRlcmVkCisgICAgICAgIC8vIG9uIGEgY2hyb21lIHRoYXQgZG9lc24ndCBhbGxvdyBhY2Nl bGVyYXRlZCBjb21wb3NpdGluZy4KKyAgICAgICAgaWYgKGhhc0FjY2VsZXJhdGVkQ29tcG9zaXRp bmcpIHsKKyAgICAgICAgICAgIEZyYW1lKiBmcmFtZSA9IG1fcmVuZGVyVmlldy0+ZnJhbWVWaWV3 KCktPmZyYW1lKCk7CisgICAgICAgICAgICBQYWdlKiBwYWdlID0gZnJhbWUgPyBmcmFtZS0+cGFn ZSgpIDogMDsKKyAgICAgICAgICAgIGlmIChwYWdlKSB7CisgICAgICAgICAgICAgICAgQ2hyb21l Q2xpZW50KiBjaHJvbWVDbGllbnQgPSBwYWdlLT5jaHJvbWUoKS0+Y2xpZW50KCk7CisgICAgICAg ICAgICAgICAgbV9jb21wb3NpdGluZ1RyaWdnZXJzID0gY2hyb21lQ2xpZW50LT5hbGxvd2VkQ29t cG9zaXRpbmdUcmlnZ2VycygpOworICAgICAgICAgICAgICAgIGhhc0FjY2VsZXJhdGVkQ29tcG9z aXRpbmcgPSBtX2NvbXBvc2l0aW5nVHJpZ2dlcnM7CisgICAgICAgICAgICB9CisgICAgICAgIH0K KwogICAgICAgICBzaG93RGVidWdCb3JkZXJzID0gc2V0dGluZ3MtPnNob3dEZWJ1Z0JvcmRlcnMo KTsKICAgICAgICAgc2hvd1JlcGFpbnRDb3VudGVyID0gc2V0dGluZ3MtPnNob3dSZXBhaW50Q291 bnRlcigpOwogICAgICAgICBmb3JjZUNvbXBvc2l0aW5nTW9kZSA9IHNldHRpbmdzLT5mb3JjZUNv bXBvc2l0aW5nTW9kZSgpICYmIGhhc0FjY2VsZXJhdGVkQ29tcG9zaXRpbmc7CkBAIC0xNDcsMTcg KzE2MCw2IEBAIHZvaWQgUmVuZGVyTGF5ZXJDb21wb3NpdG9yOjpjYWNoZUFjY2VsZXJhdGVkQ29t cG9zaXRpbmdGbGFncygpCiAgICAgICAgICAgICBmb3JjZUNvbXBvc2l0aW5nTW9kZSA9IHNldHRp bmdzLT5hY2NlbGVyYXRlZENvbXBvc2l0aW5nRm9yU2Nyb2xsYWJsZUZyYW1lc0VuYWJsZWQoKSAm JiByZXF1aXJlc0NvbXBvc2l0aW5nRm9yU2Nyb2xsYWJsZUZyYW1lKCk7CiAgICAgfQogCi0gICAg Ly8gV2UgYWxsb3cgdGhlIGNocm9tZSB0byBvdmVycmlkZSB0aGUgc2V0dGluZ3MsIGluIGNhc2Ug dGhlIHBhZ2UgaXMgcmVuZGVyZWQKLSAgICAvLyBvbiBhIGNocm9tZSB0aGF0IGRvZXNuJ3QgYWxs b3cgYWNjZWxlcmF0ZWQgY29tcG9zaXRpbmcuCi0gICAgaWYgKGhhc0FjY2VsZXJhdGVkQ29tcG9z aXRpbmcpIHsKLSAgICAgICAgRnJhbWUqIGZyYW1lID0gbV9yZW5kZXJWaWV3LT5mcmFtZVZpZXco KS0+ZnJhbWUoKTsKLSAgICAgICAgUGFnZSogcGFnZSA9IGZyYW1lID8gZnJhbWUtPnBhZ2UoKSA6 IDA7Ci0gICAgICAgIGlmIChwYWdlKSB7Ci0gICAgICAgICAgICBDaHJvbWVDbGllbnQqIGNocm9t ZUNsaWVudCA9IHBhZ2UtPmNocm9tZSgpLT5jbGllbnQoKTsKLSAgICAgICAgICAgIG1fY29tcG9z aXRpbmdUcmlnZ2VycyA9IGNocm9tZUNsaWVudC0+YWxsb3dlZENvbXBvc2l0aW5nVHJpZ2dlcnMo KTsKLSAgICAgICAgICAgIGhhc0FjY2VsZXJhdGVkQ29tcG9zaXRpbmcgPSBtX2NvbXBvc2l0aW5n VHJpZ2dlcnM7Ci0gICAgICAgIH0KLSAgICB9CiAKICAgICBpZiAoaGFzQWNjZWxlcmF0ZWRDb21w b3NpdGluZyAhPSBtX2hhc0FjY2VsZXJhdGVkQ29tcG9zaXRpbmcgfHwgc2hvd0RlYnVnQm9yZGVy cyAhPSBtX3Nob3dEZWJ1Z0JvcmRlcnMgfHwgc2hvd1JlcGFpbnRDb3VudGVyICE9IG1fc2hvd1Jl cGFpbnRDb3VudGVyIHx8IGZvcmNlQ29tcG9zaXRpbmdNb2RlICE9IG1fZm9yY2VDb21wb3NpdGlu Z01vZGUpCiAgICAgICAgIHNldENvbXBvc2l0aW5nTGF5ZXJzTmVlZFJlYnVpbGQoKTsK