73174 2011-11-27 13:53:41 -0800 Change set 101187 from bug 73154 removed already lower case optimization 2011-11-28 13:42:54 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 msaboff msaboff oldest_to_newest 509488 0 msaboff 2011-11-27 13:53:41 -0800 The patch landed in <http://trac.webkit.org/changeset/101187> did not include the prior "is already lower case" optimization. 509489 1 116679 msaboff 2011-11-27 13:59:26 -0800 Created attachment 116679 Patch 510028 2 116679 ggaren 2011-11-28 11:45:56 -0800 Comment on attachment 116679 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=116679&action=review r=me with one change below. > Source/JavaScriptCore/runtime/StringPrototype.cpp:1196 > + return JSValue::encode(jsString(exec, UString(lower))); lower.release() is the idiom for avoiding refcount churn here. 510130 3 msaboff 2011-11-28 13:42:54 -0800 Committed r101278: <http://trac.webkit.org/changeset/101278> 116679 2011-11-27 13:59:26 -0800 2011-11-28 11:45:56 -0800 Patch 73174.patch text/plain 1472 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTAxMjExKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDExLTExLTI3ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIENoYW5nZSBzZXQgMTAxMTg3IGZyb20gYnVnIDczMTU0IHJlbW92ZWQgYWxyZWFkeSBsb3dl ciBjYXNlIG9wdGltaXphdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NzMxNzQKKworICAgICAgICBBZGRlZCBiYWNrIHRoZSAic3RyaW5nIGlzIGFs cmVhZHkgbG93ZXIgY2FzZSIgb3B0aW1pemF0aW9uLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogcnVudGltZS9TdHJpbmdQcm90b3R5cGUuY3BwOgor ICAgICAgICAoSlNDOjpzdHJpbmdQcm90b0Z1bmNUb0xvd2VyQ2FzZSk6CisKIDIwMTEtMTEtMjYg IEhhamltZSBNb3JyaXRhICA8bW9ycml0YUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgTmVlZHMg V1RGX0lOTElORSBhbmQgSlNfSU5MSU5FCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVu dGltZS9TdHJpbmdQcm90b3R5cGUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9ydW50aW1lL1N0cmluZ1Byb3RvdHlwZS5jcHAJKHJldmlzaW9uIDEwMTE4NykKKysrIFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1N0cmluZ1Byb3RvdHlwZS5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTExODksNyArMTE4OSwxMSBAQCBFbmNvZGVkSlNWYWx1ZSBKU0NfSE9TVF9DQUxM IHN0cmluZ1Byb3RvCiAgICAgaWYgKCFzU2l6ZSkKICAgICAgICAgcmV0dXJuIEpTVmFsdWU6OmVu Y29kZShzVmFsKTsKIAotICAgIHJldHVybiBKU1ZhbHVlOjplbmNvZGUoanNTdHJpbmcoZXhlYywg VVN0cmluZyhzLmltcGwoKS0+bG93ZXIoKSkpKTsKKyAgICBTdHJpbmdJbXBsKiBvdXJJbXBsID0g cy5pbXBsKCk7ICAgCisgICAgUmVmUHRyPFN0cmluZ0ltcGw+IGxvd2VyID0gb3VySW1wbC0+bG93 ZXIoKTsKKyAgICBpZiAob3VySW1wbCA9PSBsb3dlci5nZXQoKSkKKyAgICAgICAgcmV0dXJuIEpT VmFsdWU6OmVuY29kZShzVmFsKTsKKyAgICByZXR1cm4gSlNWYWx1ZTo6ZW5jb2RlKGpzU3RyaW5n KGV4ZWMsIFVTdHJpbmcobG93ZXIpKSk7CiB9CiAKIEVuY29kZWRKU1ZhbHVlIEpTQ19IT1NUX0NB TEwgc3RyaW5nUHJvdG9GdW5jVG9VcHBlckNhc2UoRXhlY1N0YXRlKiBleGVjKQo=