73168 2011-11-27 07:40:09 -0800 CSSStyleRule: Pack m_sourceLine with CSSRule bits. 2011-11-27 19:52:00 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kling kling koivisto macpherson webkit.review.bot oldest_to_newest 509437 0 kling 2011-11-27 07:40:09 -0800 We can save one CPU word per instance by packing CSSStyleRule::m_sourceLine with the other bits in CSSRule. 509438 1 116672 kling 2011-11-27 07:48:17 -0800 Created attachment 116672 Patch 509440 2 webkit.review.bot 2011-11-27 07:57:05 -0800 Attachment 116672 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/css/CSSRule.h:125: Please declare integral type bitfields with either signed or unsigned. [runtime/bitfields] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 509451 3 116672 koivisto 2011-11-27 10:48:22 -0800 Comment on attachment 116672 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=116672&action=review r=me, with the stylebot fix. >> Source/WebCore/css/CSSRule.h:125 >> + // Only used by CSSStyleRule but kept here to maximize struct packing. >> + int m_sourceLine : 27; > > Please declare integral type bitfields with either signed or unsigned. [runtime/bitfields] [5] I think it is nicer to keep the fields together even if it means multiple private/protected sections. Especially when the fields are being packed. 509545 4 kling 2011-11-27 19:52:00 -0800 Committed r101218: <http://trac.webkit.org/changeset/101218> 116672 2011-11-27 07:48:17 -0800 2011-11-27 10:48:22 -0800 Patch bug-73168.diff text/plain 2759 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBmOTVjNWY0Li5lM2E1ZDY0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjIg QEAKIDIwMTEtMTEtMjcgIEFuZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgogCisgICAg ICAgIENTU1N0eWxlUnVsZTogUGFjayBtX3NvdXJjZUxpbmUgd2l0aCBDU1NSdWxlIGJpdHMuCisg ICAgICAgIDxodHRwOi8vd2Via2l0Lm9yZy9iLzczMTY4PgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1ha2UgQ1NTU3R5bGVSdWxlOjptX3NvdXJjZUxp bmUgYSAyNy1iaXQgaW50ZWdlciBhbmQgcGFjayBpdCB3aXRoIHRoZSByZXN0CisgICAgICAgIG9m IHRoZSBtZW1iZXJzIGluIENTU1J1bGUuIFRoaXMgc2hyaW5rcyBDU1NTdHlsZVJ1bGUgYnkgb25l IENQVSB3b3JkCisgICAgICAgIGFuZCByZWR1Y2VzIG1lbW9yeSBjb25zdW1wdGlvbiBieSA4MSBr QiBvbiB0aGUgR01haWwgaW5ib3ggKG9uIDY0LWJpdC4pCisKKyAgICAgICAgKiBjc3MvQ1NTUnVs ZS5oOgorICAgICAgICAoV2ViQ29yZTo6Q1NTUnVsZTo6Q1NTUnVsZSk6CisgICAgICAgICogY3Nz L0NTU1N0eWxlUnVsZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDU1NTdHlsZVJ1bGU6OkNTU1N0 eWxlUnVsZSk6CisgICAgICAgICogY3NzL0NTU1N0eWxlUnVsZS5oOgorCisyMDExLTExLTI3ICBB bmRyZWFzIEtsaW5nICA8a2xpbmdAd2Via2l0Lm9yZz4KKwogICAgICAgICBBZGQgYXNzZXJ0aW9u cyB0aGF0IENTU01hcHBlZEF0dHJpYnV0ZURlY2xhcmF0aW9ucyBhcmVuJ3QgdXNpbmcgc3RyaWN0 IHBhcnNpbmcuCiAgICAgICAgIDxodHRwOi8vd2Via2l0Lm9yZy9iLzczMTY3PgogCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUnVsZS5oIGIvU291cmNlL1dlYkNvcmUvY3NzL0NT U1J1bGUuaAppbmRleCBjYWE5MDVkLi45NjQ0NWFiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9jc3MvQ1NTUnVsZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NSdWxlLmgKQEAgLTEw OSw3ICsxMDksOCBAQCBwdWJsaWM6CiAKIHByb3RlY3RlZDoKICAgICBDU1NSdWxlKENTU1N0eWxl U2hlZXQqIHBhcmVudCwgVHlwZSB0eXBlKQotICAgICAgICA6IG1fcGFyZW50SXNSdWxlKGZhbHNl KQorICAgICAgICA6IG1fc291cmNlTGluZSgwKQorICAgICAgICAsIG1fcGFyZW50SXNSdWxlKGZh bHNlKQogICAgICAgICAsIG1fdHlwZSh0eXBlKQogICAgICAgICAsIG1fcGFyZW50U3R5bGVTaGVl dChwYXJlbnQpCiAgICAgewpAQCAtMTIwLDExICsxMjEsMTQgQEAgcHJvdGVjdGVkOgogCiAgICAg fkNTU1J1bGUoKSB7IH0KIAorICAgIC8vIE9ubHkgdXNlZCBieSBDU1NTdHlsZVJ1bGUgYnV0IGtl cHQgaGVyZSB0byBtYXhpbWl6ZSBzdHJ1Y3QgcGFja2luZy4KKyAgICBpbnQgbV9zb3VyY2VMaW5l IDogMjc7CisKIHByaXZhdGU6CiAgICAgdm9pZCBkZXN0cm95KCk7CiAKICAgICBib29sIG1fcGFy ZW50SXNSdWxlIDogMTsKLSAgICB1bnNpZ25lZCBtX3R5cGUgOiAzMTsgLy8gUGxlbnR5IG9mIHNw YWNlIGZvciBhZGRpdGlvbmFsIGZsYWdzIGhlcmUuCisgICAgdW5zaWduZWQgbV90eXBlIDogNDsK ICAgICB1bmlvbiB7CiAgICAgICAgIENTU1J1bGUqIG1fcGFyZW50UnVsZTsKICAgICAgICAgQ1NT U3R5bGVTaGVldCogbV9wYXJlbnRTdHlsZVNoZWV0OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvY3NzL0NTU1N0eWxlUnVsZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTU3R5bGVSdWxl LmNwcAppbmRleCBhYjEyY2JjLi5jMzg4MjNiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9j c3MvQ1NTU3R5bGVSdWxlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTU3R5bGVSdWxl LmNwcApAQCAtMzUsOCArMzUsMTEgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogCiBDU1NTdHlsZVJ1 bGU6OkNTU1N0eWxlUnVsZShDU1NTdHlsZVNoZWV0KiBwYXJlbnQsIGludCBzb3VyY2VMaW5lLCBD U1NSdWxlOjpUeXBlIHR5cGUpCiAgICAgOiBDU1NSdWxlKHBhcmVudCwgdHlwZSkKLSAgICAsIG1f c291cmNlTGluZShzb3VyY2VMaW5lKQogeworICAgIG1fc291cmNlTGluZSA9IHNvdXJjZUxpbmU7 CisKKyAgICAvLyBtX3NvdXJjZUxpbmUgaXMgYSBiaXRmaWVsZCwgc28gbGV0J3MgY2F0Y2ggYW55 IG92ZXJmbG93IGVhcmx5IGluIGRlYnVnIG1vZGUuCisgICAgQVNTRVJUKG1fc291cmNlTGluZSA9 PSBzb3VyY2VMaW5lKTsKIH0KIAogQ1NTU3R5bGVSdWxlOjp+Q1NTU3R5bGVSdWxlKCkKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NTdHlsZVJ1bGUuaCBiL1NvdXJjZS9XZWJDb3Jl L2Nzcy9DU1NTdHlsZVJ1bGUuaAppbmRleCBiODcyNDhjLi41NTU1NjRlIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9jc3MvQ1NTU3R5bGVSdWxlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvY3Nz L0NTU1N0eWxlUnVsZS5oCkBAIC02Myw3ICs2Myw2IEBAIHByb3RlY3RlZDoKIHByaXZhdGU6CiAg ICAgUmVmUHRyPENTU011dGFibGVTdHlsZURlY2xhcmF0aW9uPiBtX3N0eWxlOwogICAgIENTU1Nl bGVjdG9yTGlzdCBtX3NlbGVjdG9yTGlzdDsKLSAgICBpbnQgbV9zb3VyY2VMaW5lOwogfTsKIAog fSAvLyBuYW1lc3BhY2UgV2ViQ29yZQo=