73154 2011-11-25 21:16:03 -0800 String.prototype.toLower should be optimized for 8 bit strings 2011-11-26 09:40:21 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 msaboff msaboff darin oldest_to_newest 509318 0 msaboff 2011-11-25 21:16:03 -0800 String.protoype.toLower() uses UString.characters() and should be optimized for the underlying character size. 509319 1 116647 msaboff 2011-11-25 21:23:46 -0800 Created attachment 116647 Patch This speeds up sun spider string-tagcloud by 7%. 509322 2 116647 fpizlo 2011-11-25 21:36:05 -0800 Comment on attachment 116647 Patch Can you put the perf effect in the ChangeLog? 509327 3 msaboff 2011-11-25 22:17:39 -0800 Committed r101187: <http://trac.webkit.org/changeset/101187> 509365 4 darin 2011-11-26 08:30:38 -0800 This removes the optimization for the case where the string was already all lowercase. It seems we could easily retain that by checking if the result of s.impl()->lower() is == s.impl() and if so, returning JSValue::encode(sVal). 509369 5 msaboff 2011-11-26 09:40:21 -0800 (In reply to comment #4) > This removes the optimization for the case where the string was already all lowercase. It seems we could easily retain that by checking if the result of s.impl()->lower() is == s.impl() and if so, returning JSValue::encode(sVal). I had played with this a little and didn't get the return right so it failed some sputnik tests. I just coded up a correct "already lower case" return and will be posting it in another bug. It appears that the fast return is worth maybe a little in sun spider performance (.2ms overall). 116647 2011-11-25 21:23:46 -0800 2011-11-25 21:36:05 -0800 Patch 73154.patch text/plain 2192 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTAxMTg1KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDExLTExLTI1ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIFN0cmluZy5wcm90b3R5cGUudG9Mb3dlciBzaG91bGQgYmUgb3B0aW1pemVkIGZvciA4IGJp dCBzdHJpbmdzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD03MzE1NAorCisgICAgICAgIENoYW5nZWQgc3RyaW5nUHJvdG9GdW5jVG9Mb3dlckNhc2UgdG8g dXNlIFN0cmluZ0ltcGw6Omxvd2VyKCkgd2hpY2ggaGFzCisgICAgICAgIGJlZW4gb3B0aW1pemVk IGZvciA4IGJpdCBzdHJpbmdzLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogcnVudGltZS9TdHJpbmdQcm90b3R5cGUuY3BwOgorICAgICAgICAoSlND OjpzdHJpbmdQcm90b0Z1bmNUb0xvd2VyQ2FzZSk6CisKIDIwMTEtMTEtMjQgIE1pY2hhZWwgU2Fi b2ZmICA8bXNhYm9mZkBhcHBsZS5jb20+CiAKICAgICAgICAgVVN0cmluZyBtZXRob2RzIGFyZSBu b3QgY2hhcmFjdGVyIHNpemUgYXdhcmUKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50 aW1lL1N0cmluZ1Byb3RvdHlwZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRD b3JlL3J1bnRpbWUvU3RyaW5nUHJvdG90eXBlLmNwcAkocmV2aXNpb24gMTAxMTQ2KQorKysgU291 cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvU3RyaW5nUHJvdG90eXBlLmNwcAkod29ya2luZyBj b3B5KQpAQCAtMTE4OSwzMiArMTE4OSw3IEBAIEVuY29kZWRKU1ZhbHVlIEpTQ19IT1NUX0NBTEwg c3RyaW5nUHJvdG8KICAgICBpZiAoIXNTaXplKQogICAgICAgICByZXR1cm4gSlNWYWx1ZTo6ZW5j b2RlKHNWYWwpOwogCi0gICAgY29uc3QgVUNoYXIqIHNEYXRhID0gcy5jaGFyYWN0ZXJzKCk7Ci0g ICAgVmVjdG9yPFVDaGFyPiBidWZmZXIoc1NpemUpOwotCi0gICAgVUNoYXIgb3JlZCA9IDA7Ci0g ICAgZm9yIChpbnQgaSA9IDA7IGkgPCBzU2l6ZTsgaSsrKSB7Ci0gICAgICAgIFVDaGFyIGMgPSBz RGF0YVtpXTsKLSAgICAgICAgb3JlZCB8PSBjOwotICAgICAgICBidWZmZXJbaV0gPSB0b0FTQ0lJ TG93ZXIoYyk7Ci0gICAgfQotICAgIGlmICghKG9yZWQgJiB+MHg3ZikpCi0gICAgICAgIHJldHVy biBKU1ZhbHVlOjplbmNvZGUoanNTdHJpbmcoZXhlYywgVVN0cmluZzo6YWRvcHQoYnVmZmVyKSkp OwotCi0gICAgYm9vbCBlcnJvcjsKLSAgICBpbnQgbGVuZ3RoID0gVW5pY29kZTo6dG9Mb3dlcihi dWZmZXIuZGF0YSgpLCBzU2l6ZSwgc0RhdGEsIHNTaXplLCAmZXJyb3IpOwotICAgIGlmIChlcnJv cikgewotICAgICAgICBidWZmZXIucmVzaXplKGxlbmd0aCk7Ci0gICAgICAgIGxlbmd0aCA9IFVu aWNvZGU6OnRvTG93ZXIoYnVmZmVyLmRhdGEoKSwgbGVuZ3RoLCBzRGF0YSwgc1NpemUsICZlcnJv cik7Ci0gICAgICAgIGlmIChlcnJvcikKLSAgICAgICAgICAgIHJldHVybiBKU1ZhbHVlOjplbmNv ZGUoc1ZhbCk7Ci0gICAgfQotICAgIGlmIChsZW5ndGggPT0gc1NpemUpIHsKLSAgICAgICAgaWYg KG1lbWNtcChidWZmZXIuZGF0YSgpLCBzRGF0YSwgbGVuZ3RoICogc2l6ZW9mKFVDaGFyKSkgPT0g MCkKLSAgICAgICAgICAgIHJldHVybiBKU1ZhbHVlOjplbmNvZGUoc1ZhbCk7Ci0gICAgfSBlbHNl Ci0gICAgICAgIGJ1ZmZlci5yZXNpemUobGVuZ3RoKTsKLSAgICByZXR1cm4gSlNWYWx1ZTo6ZW5j b2RlKGpzU3RyaW5nKGV4ZWMsIFVTdHJpbmc6OmFkb3B0KGJ1ZmZlcikpKTsKKyAgICByZXR1cm4g SlNWYWx1ZTo6ZW5jb2RlKGpzU3RyaW5nKGV4ZWMsIFVTdHJpbmcocy5pbXBsKCktPmxvd2VyKCkp KSk7CiB9CiAKIEVuY29kZWRKU1ZhbHVlIEpTQ19IT1NUX0NBTEwgc3RyaW5nUHJvdG9GdW5jVG9V cHBlckNhc2UoRXhlY1N0YXRlKiBleGVjKQo=