73148 2011-11-25 15:20:16 -0800 WebGL Failing to Construct Shader: webgl-texture-binding-preserved.html 2013-05-22 15:48:58 -0700 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) Mac (Intel) Unspecified RESOLVED WORKSFORME P2 Normal --- 1 twiz cmarrin cmarrin kbr rniwa senorblanco twiz webkit.review.bot zmo oldest_to_newest 509278 0 twiz 2011-11-25 15:20:16 -0800 A Chromium webgl test is failing on Safari, due to an error condition when installing a shader. The vertex shader source is the following: attribute vec4 vPosition; attribute vec2 texCoord0; varying vec2 texCoord; void main() { gl_Position = vPosition; texCoord = texCoord0; } See the following issue for background on the test: https://bugs.webkit.org/show_bug.cgi?id=73033 509287 1 116642 twiz 2011-11-25 16:02:35 -0800 Created attachment 116642 Patch 510092 2 116642 kbr 2011-11-28 12:49:47 -0800 Comment on attachment 116642 Patch Looks OK. 510100 3 116642 webkit.review.bot 2011-11-28 12:55:49 -0800 Comment on attachment 116642 Patch Rejecting attachment 116642 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: t/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Kenneth Russell', u'--..." exit_code: 1 Parsed 2 diffs from patch file(s). patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/platform/mac/Skipped Hunk #1 FAILED at 499. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/mac/Skipped.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Kenneth Russell', u'--..." exit_code: 1 Full output: http://queues.webkit.org/results/10668856 510110 4 116806 twiz 2011-11-28 13:20:21 -0800 Created attachment 116806 Patch 510111 5 116806 twiz 2011-11-28 13:21:31 -0800 Comment on attachment 116806 Patch Trying again, after conflicts applying the patch via the commit queue. 510181 6 116806 kbr 2011-11-28 14:32:25 -0800 Comment on attachment 116806 Patch Let's try again. 510349 7 116806 webkit.review.bot 2011-11-28 17:11:56 -0800 Comment on attachment 116806 Patch Clearing flags on attachment: 116806 Committed r101308: <http://trac.webkit.org/changeset/101308> 510350 8 webkit.review.bot 2011-11-28 17:12:00 -0800 All reviewed patches have been landed. Closing bug. 510778 9 twiz 2011-11-29 08:09:31 -0800 Re-opening the bug, as the patch only suppressed the issue. Someone from the Mac WebGL team will have to address the shader compilation issue. 892578 10 rniwa 2013-05-22 15:48:58 -0700 Passes just fine on Mountain Lion. 116642 2011-11-25 16:02:35 -0800 2011-11-28 13:20:16 -0800 Patch bug-73148-20111125190233.patch text/plain 1124 twiz SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDEwMTE4MykKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDExLTExLTI1ICBKZWZmIFRpbWFudXMgIDx0 d2l6QGNocm9taXVtLm9yZz4KKworICAgICAgICBTdXBwcmVzc2luZyBhIGZhaWxpbmcgd2ViZ2wg Y29uZm9ybWFuY2UgdGVzdCBvbiBNYWMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD03MzE0OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogcGxhdGZvcm0vbWFjL1NraXBwZWQ6CisKIDIwMTEtMTEtMjUgIEtl bnRhcm8gSGFyYSAgPGhhcmFrZW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIEltcGxlbWVudCB0 aGUgV2ViR0xDb250ZXh0RXZlbnQgY29uc3RydWN0b3IKSW5kZXg6IExheW91dFRlc3RzL3BsYXRm b3JtL21hYy9Ta2lwcGVkCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9T a2lwcGVkCShyZXZpc2lvbiAxMDExODApCisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvU2tp cHBlZAkod29ya2luZyBjb3B5KQpAQCAtNDk5LDMgKzQ5OSw2IEBAIGZhc3QvZG9tL1dpbmRvdy93 aW5kb3ctcG9zdG1lc3NhZ2UtYXJyYXkKICMgW01hY10gZmFzdC9mb3Jtcy9maWxlL2ZpbGUtaW5w dXQtcmVzZXQuaHRtbCBmYWlsaW5nIGFmdGVyIGVuYWJsaW5nIHJlZnRlc3RzCiAjIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MjU3MQogZmFzdC9mb3Jtcy9maWxlL2Zp bGUtaW5wdXQtcmVzZXQuaHRtbAorCisjIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD03MzE0OAorZmFzdC9jYW52YXMvd2ViZ2wvd2ViZ2wtdGV4dHVyZS1iaW5kaW5nLXBy ZXNlcnZlZC5odG1sClwgTm8gbmV3bGluZSBhdCBlbmQgb2YgZmlsZQo= 116806 2011-11-28 13:20:21 -0800 2011-11-28 17:11:56 -0800 Patch bug-73148-20111128162020.patch text/plain 1048 twiz SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDEwMTI3NSkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDExLTExLTI1ICBKZWZmIFRpbWFudXMgIDx0 d2l6QGNocm9taXVtLm9yZz4KKworICAgICAgICBTdXBwcmVzc2luZyBhIGZhaWxpbmcgd2ViZ2wg Y29uZm9ybWFuY2UgdGVzdCBvbiBNYWMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD03MzE0OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogcGxhdGZvcm0vbWFjL1NraXBwZWQ6CisKIDIwMTEtMTEtMjggIEZh ZHkgU2FtdWVsICA8ZnNhbXVlbEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgRml4IEFzcGVjdCBS YXRpbyBQcm9wZXJ0eSBJbmhlcml0YW5jZSBBbmQgTWFrZSB0aGUgQ29tcHV0ZWQgVmFsdWUgRXF1 YWwgdGhlIFNwZWNpZmllZCBWYWx1ZQpJbmRleDogTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL1Nr aXBwZWQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL1NraXBwZWQJKHJl dmlzaW9uIDEwMTI3NSkKKysrIExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9Ta2lwcGVkCSh3b3Jr aW5nIGNvcHkpCkBAIC00OTUsMyArNDk1LDYgQEAgcG9pbnRlci1sb2NrLwogCiAjIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MjQzNQogZmFzdC9kb20vV2luZG93L3dp bmRvdy1wb3N0bWVzc2FnZS1hcnJheXMuaHRtbAorCisjIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD03MzE0OAorZmFzdC9jYW52YXMvd2ViZ2wvd2ViZ2wtdGV4dHVyZS1i aW5kaW5nLXByZXNlcnZlZC5odG1sCg==