73137 2011-11-25 08:21:32 -0800 [GTK] Fix some warnings in WebCore GTK+ 2011-11-26 02:16:56 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mrobinson mrobinson webkit.review.bot oldest_to_newest 509180 0 mrobinson 2011-11-25 08:21:32 -0800 There are some lingering warnings in WebCore with my version of gcc. 509183 1 116626 mrobinson 2011-11-25 08:26:15 -0800 Created attachment 116626 Patch 509189 2 116626 pnormand 2011-11-25 08:31:18 -0800 Comment on attachment 116626 Patch Nice catch! 509344 3 116626 webkit.review.bot 2011-11-26 02:16:52 -0800 Comment on attachment 116626 Patch Clearing flags on attachment: 116626 Committed r101190: <http://trac.webkit.org/changeset/101190> 509345 4 webkit.review.bot 2011-11-26 02:16:56 -0800 All reviewed patches have been landed. Closing bug. 116626 2011-11-25 08:26:15 -0800 2011-11-26 02:16:52 -0800 Patch bug-73137-20111125172613.patch text/plain 3442 mrobinson U3VidmVyc2lvbiBSZXZpc2lvbjogMTAxMDU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDE5NjY1NGRiMGJmNzQw YTFjNDA4NTVlMWQ4NzA5ZDU4ZTA3Y2RjZi4uOGNiZjI5MDRlZjQ4ZDkxYjMzZmMzYzgzM2IxMjQ5 YzJmYjEwMzlmYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDExLTExLTI1ICBNYXJ0 aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBGaXgg c29tZSB3YXJuaW5ncyBpbiBXZWJDb3JlIEdUSysKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTczMTM3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBUaGlzIHBhdGNoIGp1c3QgZml4ZXMg Y29tcGlsYXRpb24gd2FybmluZ3MuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ndGsvQ3Vyc29yR3Rr LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmNyZWF0ZU5hbWVkQ3Vyc29yKTogUmVtb3ZlIHVudXNl ZCB2YXJpYWJsZS4KKyAgICAgICAgKiBwbGF0Zm9ybS9ndGsvUmVuZGVyVGhlbWVHdGszLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRoZW1lR3RrOjpwYWludFNsaWRlclRyYWNrKTogQVNT RVJUX1VOVVNFRCBpbnN0ZWFkIG9mIEFTU0VSVC4KKyAgICAgICAgKiBwbGF0Zm9ybS9ndGsvU2hh cmVkVGltZXJHdGsuY3BwOiBEaXR0by4KKyAgICAgICAgKFdlYkNvcmU6OnN0b3BTaGFyZWRUaW1l cik6CisKIDIwMTEtMTEtMjMgIEFubmEgQ2F2ZW5kZXIgIDxhbm5hY2NAY2hyb21pdW0ub3JnPgog CiAgICAgICAgIE1vdmUgcmVhZHlTdGF0ZSBmcm9tIFRleHRUcmFjayB0byBIVE1MVHJhY2tFbGVt ZW50CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvQ3Vyc29yR3RrLmNw cCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9DdXJzb3JHdGsuY3BwCmluZGV4IDdhODVi ZjE2YjIwMGFlMzhiM2VkYTBlNWRkOTYzOTQ5ZTdiMjM4NWYuLmM0OTg4N2U1MzNiYzU4NzcyN2Vk Mzk1NTk0MzBkYWY3MDFmNzg3MjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2d0ay9DdXJzb3JHdGsuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9DdXJz b3JHdGsuY3BwCkBAIC00Niw3ICs0Niw2IEBAIHN0YXRpYyBHUmVmUHRyPEdka0N1cnNvcj4gY3Jl YXRlTmFtZWRDdXJzb3IoQ3VzdG9tQ3Vyc29yVHlwZSBjdXJzb3JUeXBlKQogICAgIGlmIChjKQog ICAgICAgICByZXR1cm4gYzsKIAotICAgIEludFNpemUgY3Vyc29yU2l6ZSA9IEludFNpemUoMzIs IDMyKTsKICAgICBSZWZQdHI8Y2Fpcm9fc3VyZmFjZV90PiBzb3VyY2UgPSBhZG9wdFJlZihjYWly b19pbWFnZV9zdXJmYWNlX2NyZWF0ZV9mb3JfZGF0YShjb25zdF9jYXN0PHVuc2lnbmVkIGNoYXIq PihjdXJzb3IuYml0cyksIENBSVJPX0ZPUk1BVF9BMSwgMzIsIDMyLCA0KSk7CiAgICAgUmVmUHRy PGNhaXJvX3N1cmZhY2VfdD4gbWFzayA9IGFkb3B0UmVmKGNhaXJvX2ltYWdlX3N1cmZhY2VfY3Jl YXRlX2Zvcl9kYXRhKGNvbnN0X2Nhc3Q8dW5zaWduZWQgY2hhcio+KGN1cnNvci5tYXNrX2JpdHMp LCBDQUlST19GT1JNQVRfQTEsIDMyLCAzMiwgNCkpOwogICAgIFJlZlB0cjxjYWlyb19zdXJmYWNl X3Q+IHN1cmZhY2UgPSBhZG9wdFJlZihjYWlyb19pbWFnZV9zdXJmYWNlX2NyZWF0ZShDQUlST19G T1JNQVRfQTEsIDMyLCAzMikpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3RrL1JlbmRlclRoZW1lR3RrMy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvUmVu ZGVyVGhlbWVHdGszLmNwcAppbmRleCBmNDIyOGZhNmM1M2M4NjY2Y2VjMTQ5MzExZDU1ODcxNmRk ZTkwY2FlLi4zNTA5MDUyMGVmMDAxODcwZTdlMTIxZTU3YmU1MzY4ZjdmYjc3OTYzIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvUmVuZGVyVGhlbWVHdGszLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvUmVuZGVyVGhlbWVHdGszLmNwcApAQCAtNTk2 LDcgKzU5Niw3IEBAIGJvb2wgUmVuZGVyVGhlbWVHdGs6OnBhaW50VGV4dEZpZWxkKFJlbmRlck9i amVjdCogcmVuZGVyT2JqZWN0LCBjb25zdCBQYWludEluZm8mCiBib29sIFJlbmRlclRoZW1lR3Rr OjpwYWludFNsaWRlclRyYWNrKFJlbmRlck9iamVjdCogcmVuZGVyT2JqZWN0LCBjb25zdCBQYWlu dEluZm8mIHBhaW50SW5mbywgY29uc3QgSW50UmVjdCYgcmVjdCkKIHsKICAgICBDb250cm9sUGFy dCBwYXJ0ID0gcmVuZGVyT2JqZWN0LT5zdHlsZSgpLT5hcHBlYXJhbmNlKCk7Ci0gICAgQVNTRVJU KHBhcnQgPT0gU2xpZGVySG9yaXpvbnRhbFBhcnQgfHwgcGFydCA9PSBTbGlkZXJWZXJ0aWNhbFBh cnQgfHwgcGFydCA9PSBNZWRpYVZvbHVtZVNsaWRlclBhcnQpOworICAgIEFTU0VSVF9VTlVTRUQo cGFydCwgcGFydCA9PSBTbGlkZXJIb3Jpem9udGFsUGFydCB8fCBwYXJ0ID09IFNsaWRlclZlcnRp Y2FsUGFydCB8fCBwYXJ0ID09IE1lZGlhVm9sdW1lU2xpZGVyUGFydCk7CiAKICAgICBHdGtTdHls ZUNvbnRleHQqIGNvbnRleHQgPSBnZXRTdHlsZUNvbnRleHQoR1RLX1RZUEVfU0NBTEUpOwogICAg IGd0a19zdHlsZV9jb250ZXh0X3NhdmUoY29udGV4dCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ndGsvU2hhcmVkVGltZXJHdGsuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3RrL1NoYXJlZFRpbWVyR3RrLmNwcAppbmRleCBiNDIxZmRhYzQ3ZWUxMGE5NWYwNDEx YTQ4YjI3ZGU1OTI1N2NlOTI3Li40MzFhMzUyZjczM2YwZWIzYTc2OGY5ODIxYTQwMjU2NDMwMzA0 ZjYyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvU2hhcmVkVGltZXJH dGsuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9TaGFyZWRUaW1lckd0ay5j cHAKQEAgLTYyLDEyICs2MiwxMSBAQCB2b2lkIHNldFNoYXJlZFRpbWVyRmlyZUludGVydmFsKGRv dWJsZSBpbnRlcnZhbCkKIAogdm9pZCBzdG9wU2hhcmVkVGltZXIoKQogewotICAgIGdib29sZWFu IHMgPSBGQUxTRTsKICAgICBpZiAoc2hhcmVkVGltZXIgPT0gMCkKICAgICAgICAgcmV0dXJuOwog Ci0gICAgcyA9IGdfc291cmNlX3JlbW92ZShzaGFyZWRUaW1lcik7Ci0gICAgQVNTRVJUKHMpOwor ICAgIGdib29sZWFuIHJlbW92ZWRTb3VyY2UgPSBnX3NvdXJjZV9yZW1vdmUoc2hhcmVkVGltZXIp OworICAgIEFTU0VSVF9VTlVTRUQocmVtb3ZlZFNvdXJjZSwgcmVtb3ZlZFNvdXJjZSk7CiAgICAg c2hhcmVkVGltZXIgPSAwOwogfQogCg==