73135 2011-11-25 07:57:55 -0800 Remove unnecessary asserts in HTMLTextAreaElement. 2011-11-30 07:28:26 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jknotten jknotten eric fishd ojan rniwa tkent tonyg webkit.review.bot oldest_to_newest 509169 0 jknotten 2011-11-25 07:57:55 -0800 [Chromium] Update document style before focusing textarea node. 509170 1 116621 jknotten 2011-11-25 07:58:50 -0800 Created attachment 116621 Patch 509200 2 eric 2011-11-25 09:39:48 -0800 Who authored the ASSERT that your'e hitting? Are they CC'd? 509205 3 tonyg 2011-11-25 10:02:00 -0800 (In reply to comment #2) > Who authored the ASSERT that your'e hitting? Are they CC'd? Yes. Ojan in http://trac.webkit.org/changeset/46437 509233 4 rniwa 2011-11-25 11:51:35 -0800 Could you post stack trace or something? I can't make sense of this bug because there's no description whatsoever as to why you're making this change. 509234 5 rniwa 2011-11-25 11:52:18 -0800 In fact, I'd argue that we shouldn't land this patch until we add some test or the reason for the change is explained in the changelog. 509539 6 116621 tkent 2011-11-27 19:24:37 -0800 Comment on attachment 116621 Patch > In fact, I'd argue that we shouldn't land this patch until we add some test or the reason for the change is explained in the changelog. Agree. ChangeLog should have a reason of the change. 509903 7 116772 jknotten 2011-11-28 09:54:01 -0800 Created attachment 116772 Patch 509904 8 jknotten 2011-11-28 09:57:13 -0800 I updated the ChangeLog with the following, which I think bares repeating here: http://code.google.com/p/chromium/issues/detail?id=103228 shows that sometimes we are hitting the following assert in HTMLTextAreaElement::updateFocusAppearance: ASSERT(!document()->childNeedsAndNotInStyleRecalc()); This assert was added by https://bugs.webkit.org/show_bug.cgi?id=27474 as part of a fix for a crash when the selection is set immediately after setting display:none. WebViewImpl::setFocus is caused as a result of an IPC from Chrome, so if the document can already be requiring a style update, it seems reasonable to do it now to satisfy the constraint of the HTMLTextAreaElement::updateFocusAppearance assert. I also discovered Document::updateLayoutIgnorePendingStylesheets which is called from HTMLTextFormControlElement::setSelectionRange, so I'm not sure whether I should be using that instead. I will try be to adapt Ojan's related test fast/dom/textarea-crash-on-focus.html for this case (coming soon). If anybody could comment if I'm on the right or wrong path here, it would be much appreciated. 510409 9 tkent 2011-11-28 19:23:38 -0800 (In reply to comment #8) > I also discovered Document::updateLayoutIgnorePendingStylesheets which is called from HTMLTextFormControlElement::setSelectionRange, so I'm not sure whether I should be using that instead. Hmm, the ASSERT was needed because updateFocusAppearance() calls setSelectionRange(), however setSeleectionRange() now has a updateLayoutIgnorePendingStylesheets() call. I guess the ASSERT is not needed anymore. Ojan, Niwa-san, what do you think? 510427 10 rniwa 2011-11-28 19:53:54 -0800 (In reply to comment #9) > (In reply to comment #8) > > I also discovered Document::updateLayoutIgnorePendingStylesheets which is called from HTMLTextFormControlElement::setSelectionRange, so I'm not sure whether I should be using that instead. > > Hmm, the ASSERT was needed because updateFocusAppearance() calls setSelectionRange(), however setSeleectionRange() now has a updateLayoutIgnorePendingStylesheets() call. I guess the ASSERT is not needed anymore. > > Ojan, Niwa-san, what do you think? Yeah, it seems like this assertion is no longer needed. 510860 11 ojan 2011-11-29 09:41:17 -0800 (In reply to comment #10) > (In reply to comment #9) > > (In reply to comment #8) > > > I also discovered Document::updateLayoutIgnorePendingStylesheets which is called from HTMLTextFormControlElement::setSelectionRange, so I'm not sure whether I should be using that instead. > > > > Hmm, the ASSERT was needed because updateFocusAppearance() calls setSelectionRange(), however setSeleectionRange() now has a updateLayoutIgnorePendingStylesheets() call. I guess the ASSERT is not needed anymore. > > > > Ojan, Niwa-san, what do you think? > > Yeah, it seems like this assertion is no longer needed. Yup, also the ASSERT(renderer()) right above it isn't needed either as best I can tell. Do we see a crash in release builds or is the bug just that we're hitting the assert? 510974 12 rniwa 2011-11-29 12:00:11 -0800 (In reply to comment #11) > Do we see a crash in release builds or is the bug just that we're hitting the assert? See http://code.google.com/p/chromium/issues/detail?id=103228 http://crbu.com/103228 510988 13 jknotten 2011-11-29 12:16:40 -0800 Hitting the assert is only an issue with the debug build. However, I did have a look at the crash reports and there are some crashes with WebCore::HTMLTextAreaElement::updateFocusAppearance in the callstack. Most are from version 15.x, but there is 1 for 16.x and 17.x. Since the crashes are for the release build of Chrome, I'm not sure whether they would be related to the asserted condition not holding and causing a problem later. (In reply to comment #12) > (In reply to comment #11) > > Do we see a crash in release builds or is the bug just that we're hitting the assert? > > See http://code.google.com/p/chromium/issues/detail?id=103228 > > http://crbu.com/103228 510989 14 rniwa 2011-11-29 12:18:30 -0800 (In reply to comment #13) > Hitting the assert is only an issue with the debug build. However, I did have a look at the crash reports and there are some crashes with WebCore::HTMLTextAreaElement::updateFocusAppearance in the callstack. Most are from version 15.x, but there is 1 for 16.x and 17.x. Since the crashes are for the release build of Chrome, I'm not sure whether they would be related to the asserted condition not holding and causing a problem later. With the same stack trace? 511509 15 jknotten 2011-11-30 01:34:25 -0800 I had another look, and I couldn't find any crashes with the same stack trace (i.e. with WebViewImpl::setFocus eventually calling HTMLTextAreaElement::updateFocusAppearance ). I'll upload a patch to remove the asserts. (In reply to comment #14) > (In reply to comment #13) > > Hitting the assert is only an issue with the debug build. However, I did have a look at the crash reports and there are some crashes with WebCore::HTMLTextAreaElement::updateFocusAppearance in the callstack. Most are from version 15.x, but there is 1 for 16.x and 17.x. Since the crashes are for the release build of Chrome, I'm not sure whether they would be related to the asserted condition not holding and causing a problem later. > > With the same stack trace? 511557 16 117151 jknotten 2011-11-30 02:31:49 -0800 Created attachment 117151 Patch 511558 17 117151 tkent 2011-11-30 02:32:41 -0800 Comment on attachment 117151 Patch ok 511560 18 117151 tkent 2011-11-30 02:34:42 -0800 Comment on attachment 117151 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=117151&action=review > Source/WebCore/ChangeLog:3 > + [Chromium] Remove unnecessary asserts in HTMLTextAreaElement This is not a Chromium-specific change. 511561 19 117152 jknotten 2011-11-30 02:39:34 -0800 Created attachment 117152 Patch 511733 20 117152 webkit.review.bot 2011-11-30 07:28:20 -0800 Comment on attachment 117152 Patch Clearing flags on attachment: 117152 Committed r101513: <http://trac.webkit.org/changeset/101513> 511734 21 webkit.review.bot 2011-11-30 07:28:26 -0800 All reviewed patches have been landed. Closing bug. 116621 2011-11-25 07:58:50 -0800 2011-11-28 09:53:55 -0800 Patch bug-73135-20111125155849.patch text/plain 1736 jknotten U3VidmVyc2lvbiBSZXZpc2lvbjogMTAxMTczCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGY5ODQ1ZTVjZTM4NTE4OTY1MmI5OTYxZWI1Mzg4MjczN2FjMjQxYTUuLjg5ZGIyMjQ1ZTM3ZmMy YTk4YmUwMWUyZDFmN2JhNDVkZTdiMzJhZGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTEtMTEtMjUgIEpvaG4gS25vdHRlbmJlbHQgIDxqa25vdHRlbkBj aHJvbWl1bS5vcmc+CisKKyAgICAgICAgW0Nocm9taXVtXSBVcGRhdGUgZG9jdW1lbnQgc3R5bGUg YmVmb3JlIGZvY3VzaW5nIHRleHRhcmVhIG5vZGUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MzEzNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogc3JjL1dlYlZpZXdJbXBsLmNwcDoKKyAgICAgICAgKFdl YktpdDo6V2ViVmlld0ltcGw6OnNldEZvY3VzKToKKwogMjAxMS0xMS0yNSAgWXVyeSBTZW1pa2hh dHNreSAgPHl1cnlzQGNocm9taXVtLm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLiBDaHJvbWl1 bSBidWlsZCBmaXguCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJW aWV3SW1wbC5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAK aW5kZXggNzc3MmQ5ODNhZTBjODNlOTg0ZjBjYmFjYTIwNmFkNDBlY2YyMmRmZS4uN2JhYjU3NTkw YzBkMzAyYTc0MzZiZThmODQxNTY0ZGM1YjgzOTBjMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21p dW0vc3JjL1dlYlZpZXdJbXBsLmNwcApAQCAtMTQyOSw4ICsxNDI5LDEwIEBAIHZvaWQgV2ViVmll d0ltcGw6OnNldEZvY3VzKGJvb2wgZW5hYmxlKQogICAgICAgICAgICAgICAgIC8vIGZvY3VzZWQs IHRoZW4gdGhlIGZvY3VzIGVsZW1lbnQgc2hvd3Mgd2l0aCBhIGZvY3VzIHJpbmcgYnV0CiAgICAg ICAgICAgICAgICAgLy8gbm8gY2FyZXQgYW5kIGRvZXMgcmVzcG9uZCB0byBrZXlib2FyZCBpbnB1 dHMuCiAgICAgICAgICAgICAgICAgRWxlbWVudCogZWxlbWVudCA9IHN0YXRpY19jYXN0PEVsZW1l bnQqPihmb2N1c2VkTm9kZSk7Ci0gICAgICAgICAgICAgICAgaWYgKGVsZW1lbnQtPmlzVGV4dEZv cm1Db250cm9sKCkpCisgICAgICAgICAgICAgICAgaWYgKGVsZW1lbnQtPmlzVGV4dEZvcm1Db250 cm9sKCkpIHsKKyAgICAgICAgICAgICAgICAgICAgZWxlbWVudC0+ZG9jdW1lbnQoKS0+dXBkYXRl U3R5bGVJZk5lZWRlZCgpOwogICAgICAgICAgICAgICAgICAgICBlbGVtZW50LT51cGRhdGVGb2N1 c0FwcGVhcmFuY2UodHJ1ZSk7CisgICAgICAgICAgICAgICAgfQogICAgICAgICAgICAgICAgIGVs c2UgaWYgKGZvY3VzZWROb2RlLT5pc0NvbnRlbnRFZGl0YWJsZSgpKSB7CiAgICAgICAgICAgICAg ICAgICAgIC8vIHVwZGF0ZUZvY3VzQXBwZWFyYW5jZSgpIHNlbGVjdHMgYWxsIHRoZSB0ZXh0IG9m CiAgICAgICAgICAgICAgICAgICAgIC8vIGNvbnRlbnRzZWRpdGFibGUgRElWcy4gU28gd2Ugc2V0 IHRoZSBzZWxlY3Rpb24gZXhwbGljaXRseQo= 116772 2011-11-28 09:54:01 -0800 2011-11-30 02:31:43 -0800 Patch bug-73135-20111128175400.patch text/plain 2728 jknotten U3VidmVyc2lvbiBSZXZpc2lvbjogMTAxMTczCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGY5ODQ1ZTVjZTM4NTE4OTY1MmI5OTYxZWI1Mzg4MjczN2FjMjQxYTUuLjhmYWZjNmU3ZWMzMmE1 OGRmZWY0NzEyMzJmMjNjZTM2OWY0MTNkMGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjggQEAKKzIwMTEtMTEtMjUgIEpvaG4gS25vdHRlbmJlbHQgIDxqa25vdHRlbkBj aHJvbWl1bS5vcmc+CisKKyAgICAgICAgW0Nocm9taXVtXSBVcGRhdGUgZG9jdW1lbnQgc3R5bGUg YmVmb3JlIGZvY3VzaW5nIHRleHRhcmVhIG5vZGUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MzEzNQorCisgICAgICAgIGh0dHA6Ly9jb2RlLmdvb2ds ZS5jb20vcC9jaHJvbWl1bS9pc3N1ZXMvZGV0YWlsP2lkPTEwMzIyOCBzaG93cyB0aGF0CisgICAg ICAgIHNvbWV0aW1lcyB3ZSBhcmUgaGl0dGluZyB0aGUgZm9sbG93aW5nIGFzc2VydCBpbgorICAg ICAgICBIVE1MVGV4dEFyZWFFbGVtZW50Ojp1cGRhdGVGb2N1c0FwcGVhcmFuY2U6CisKKyAgICAg ICAgQVNTRVJUKCFkb2N1bWVudCgpLT5jaGlsZE5lZWRzQW5kTm90SW5TdHlsZVJlY2FsYygpKTsK KworICAgICAgICBUaGlzIGFzc2VydCB3YXMgYWRkZWQgYnkgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTI3NDc0CisgICAgICAgIGFzIHBhcnQgb2YgYSBmaXggZm9yIGEg Y3Jhc2ggd2hlbiB0aGUgc2VsZWN0aW9uIGlzIHNldCBpbW1lZGlhdGVseQorICAgICAgICBhZnRl ciBzZXR0aW5nIGRpc3BsYXk6bm9uZS4KKworICAgICAgICBXZWJWaWV3SW1wbDo6c2V0Rm9jdXMg aXMgY2F1c2VkIGFzIGEgcmVzdWx0IG9mIGFuIElQQyBmcm9tIENocm9tZSwKKyAgICAgICAgc28g aWYgdGhlIGRvY3VtZW50IGNhbiBhbHJlYWR5IGJlIHJlcXVpcmluZyBhIHN0eWxlIHVwZGF0ZSwg aXQKKyAgICAgICAgc2VlbXMgcmVhc29uYWJsZSB0byBkbyBpdCBub3cgdG8gc2F0aXNmeSB0aGUg Y29uc3RyYWludCBvZiB0aGUKKyAgICAgICAgSFRNTFRleHRBcmVhRWxlbWVudDo6dXBkYXRlRm9j dXNBcHBlYXJhbmNlIGFzc2VydC4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIHNyYy9XZWJWaWV3SW1wbC5jcHA6CisgICAgICAgIChXZWJLaXQ6Oldl YlZpZXdJbXBsOjpzZXRGb2N1cyk6CisKIDIwMTEtMTEtMjUgIFl1cnkgU2VtaWtoYXRza3kgIDx5 dXJ5c0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZC4gQ2hyb21pdW0gYnVpbGQg Zml4LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwu Y3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwCmluZGV4IDc3 NzJkOTgzYWUwYzgzZTk4NGYwY2JhY2EyMDZhZDQwZWNmMjJkZmUuLmRkZGQ3N2IxNTk5Y2JmMDVk ZjRiYzI3Yjg3MDAxNWU5ZTE0ZjU2YzIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21p dW0vc3JjL1dlYlZpZXdJbXBsLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9X ZWJWaWV3SW1wbC5jcHAKQEAgLTE0MjksOCArMTQyOSwxMyBAQCB2b2lkIFdlYlZpZXdJbXBsOjpz ZXRGb2N1cyhib29sIGVuYWJsZSkKICAgICAgICAgICAgICAgICAvLyBmb2N1c2VkLCB0aGVuIHRo ZSBmb2N1cyBlbGVtZW50IHNob3dzIHdpdGggYSBmb2N1cyByaW5nIGJ1dAogICAgICAgICAgICAg ICAgIC8vIG5vIGNhcmV0IGFuZCBkb2VzIHJlc3BvbmQgdG8ga2V5Ym9hcmQgaW5wdXRzLgogICAg ICAgICAgICAgICAgIEVsZW1lbnQqIGVsZW1lbnQgPSBzdGF0aWNfY2FzdDxFbGVtZW50Kj4oZm9j dXNlZE5vZGUpOwotICAgICAgICAgICAgICAgIGlmIChlbGVtZW50LT5pc1RleHRGb3JtQ29udHJv bCgpKQorICAgICAgICAgICAgICAgIGlmIChlbGVtZW50LT5pc1RleHRGb3JtQ29udHJvbCgpKSB7 CisgICAgICAgICAgICAgICAgICAgIC8vIEZJWE1FOiBOb3Qgc3VyZSB3aGV0aGVyIHdlIHNob3Vs ZCBjYWxsIHVwZGF0ZVN0eWxlSWZOZWVkZWQoKQorICAgICAgICAgICAgICAgICAgICAvLyBvciB1 cGRhdGVMYXlvdXRJZ25vcmVQZW5kaW5nU3R5bGVzaGVldHMoKS4KKyAgICAgICAgICAgICAgICAg ICAgLy8gSFRNTFRleHRGb3JtQ29udHJvbEVsZW1lbnQ6OnNldFNlbGVjdGlvblJhbmdlIHVzZXMg dGhlIGxhdHRlci4KKyAgICAgICAgICAgICAgICAgICAgLy8gZWxlbWVudC0+ZG9jdW1lbnQoKS0+ dXBkYXRlTGF5b3V0SWdub3JlUGVuZGluZ1N0eWxlc2hlZXRzKCk7CiAgICAgICAgICAgICAgICAg ICAgIGVsZW1lbnQtPnVwZGF0ZUZvY3VzQXBwZWFyYW5jZSh0cnVlKTsKKyAgICAgICAgICAgICAg ICB9CiAgICAgICAgICAgICAgICAgZWxzZSBpZiAoZm9jdXNlZE5vZGUtPmlzQ29udGVudEVkaXRh YmxlKCkpIHsKICAgICAgICAgICAgICAgICAgICAgLy8gdXBkYXRlRm9jdXNBcHBlYXJhbmNlKCkg c2VsZWN0cyBhbGwgdGhlIHRleHQgb2YKICAgICAgICAgICAgICAgICAgICAgLy8gY29udGVudHNl ZGl0YWJsZSBESVZzLiBTbyB3ZSBzZXQgdGhlIHNlbGVjdGlvbiBleHBsaWNpdGx5Cg== 117151 2011-11-30 02:31:49 -0800 2011-11-30 02:39:27 -0800 Patch bug-73135-20111130103147.patch text/plain 2200 jknotten U3VidmVyc2lvbiBSZXZpc2lvbjogMTAxMzQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDExZjI3MDdhNmY0OWNl NTkyYzRjNjlmZDJmMTRkMzZhYzZjZDVhYy4uMWJiMmViMDFiNWVhY2Y0NDk0MmE3NmM4YzRhZjIx NzNhN2Q5OWU0MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDExLTExLTMwICBKb2hu IEtub3R0ZW5iZWx0ICA8amtub3R0ZW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtDaHJvbWl1 bV0gUmVtb3ZlIHVubmVjZXNzYXJ5IGFzc2VydHMgaW4gSFRNTFRleHRBcmVhRWxlbWVudAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzMxMzUKKworICAg ICAgICBodHRwOi8vY29kZS5nb29nbGUuY29tL3AvY2hyb21pdW0vaXNzdWVzL2RldGFpbD9pZD0x MDMyMjggc2hvd3MKKyAgICAgICAgdGhhdCBzb21ldGltZXMgd2UgYXJlIGhpdHRpbmcgdGhlIGZv bGxvd2luZyBhc3NlcnQgaW4KKyAgICAgICAgSFRNTFRleHRBcmVhRWxlbWVudDo6dXBkYXRlRm9j dXNBcHBlYXJhbmNlOgorCisgICAgICAgIEFTU0VSVCghZG9jdW1lbnQoKS0+Y2hpbGROZWVkc0Fu ZE5vdEluU3R5bGVSZWNhbGMoKSk7CisKKyAgICAgICAgVGhpcyBhc3NlcnQgd2FzIGFkZGVkIGJ5 IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNzQ3NAorICAgICAgICBh cyBwYXJ0IG9mIGEgZml4IGZvciBhIGNyYXNoIHdoZW4gdGhlIHNlbGVjdGlvbiBpcyBzZXQgaW1t ZWRpYXRlbHkKKyAgICAgICAgYWZ0ZXIgc2V0dGluZyBkaXNwbGF5Om5vbmUuCisKKyAgICAgICAg QWxsIHRoZSBtZXRob2RzIGNhbGxlZCBieSB1cGRhdGVGb2N1c0FwcGVhcmFuY2UgYWxyZWFkeSBo YW5kbGUgdGhlCisgICAgICAgIGNhc2Ugb2YgdGhlIGRvY3VtZW50IGhhdmluZyB0aGUgY2hpbGRO ZWVkc1N0eWxlUmVjYWxjIGZsYWcgc2V0LCBzbworICAgICAgICB0aGlzIGFzc2VydCBpcyB1bm5l Y2Vzc2FyeS4gVGhlIEFTU0VSVChyZW5kZXJlcigpKSBpcyBzaW1pbGFybHkKKyAgICAgICAgcmVk dW5kYW50LgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogaHRtbC9IVE1MVGV4dEFyZWFFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxU ZXh0QXJlYUVsZW1lbnQ6OnVwZGF0ZUZvY3VzQXBwZWFyYW5jZSk6CisKIDIwMTEtMTEtMjggIFBh dmVsIEZlbGRtYW4gIDxwZmVsZG1hbkBnb29nbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0 b3I6IHB1dCBpbnNwZWN0b3IgYWdlbnRzIGludG8gYSB2ZWN0b3IgaW4gdGhlIEluc3BlY3RvckNv bnRyb2xsZXIuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxUZXh0QXJlYUVs ZW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MVGV4dEFyZWFFbGVtZW50LmNwcApp bmRleCBjYWIwZWMzZDkzZDJlOTQ5NGFmNWU1NTJlYjhhOGQyOTYzZDY0NzgzLi44ZGZjMDg3ZjU5 NWU1MjQyNzE0OWQ3NjFmZGNmMDc2MjE4MzQ1OGQxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9odG1sL0hUTUxUZXh0QXJlYUVsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwv SFRNTFRleHRBcmVhRWxlbWVudC5jcHAKQEAgLTE5OCw5ICsxOTgsNiBAQCBib29sIEhUTUxUZXh0 QXJlYUVsZW1lbnQ6OmlzTW91c2VGb2N1c2FibGUoKSBjb25zdAogCiB2b2lkIEhUTUxUZXh0QXJl YUVsZW1lbnQ6OnVwZGF0ZUZvY3VzQXBwZWFyYW5jZShib29sIHJlc3RvcmVQcmV2aW91c1NlbGVj dGlvbikKIHsKLSAgICBBU1NFUlQocmVuZGVyZXIoKSk7Ci0gICAgQVNTRVJUKCFkb2N1bWVudCgp LT5jaGlsZE5lZWRzQW5kTm90SW5TdHlsZVJlY2FsYygpKTsKLQogICAgIGlmICghcmVzdG9yZVBy ZXZpb3VzU2VsZWN0aW9uIHx8ICFoYXNDYWNoZWRTZWxlY3Rpb24oKSkgewogICAgICAgICAvLyBJ ZiB0aGlzIGlzIHRoZSBmaXJzdCBmb2N1cywgc2V0IGEgY2FyZXQgYXQgdGhlIGJlZ2lubmluZyBv ZiB0aGUgdGV4dC4gIAogICAgICAgICAvLyBUaGlzIG1hdGNoZXMgc29tZSBicm93c2VycycgYmVo YXZpb3I7IHNlZSBidWcgMTE3NDYgQ29tbWVudCAjMTUuCg== 117152 2011-11-30 02:39:34 -0800 2011-11-30 07:28:20 -0800 Patch bug-73135-20111130103932.patch text/plain 2190 jknotten U3VidmVyc2lvbiBSZXZpc2lvbjogMTAxMzQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDExZjI3MDdhNmY0OWNl NTkyYzRjNjlmZDJmMTRkMzZhYzZjZDVhYy4uYmIwNzk1Nzk5OWQ2YzJmZDY4MGYyMTA1YzBkZjM3 Nzk4NDdjYjk3OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDExLTExLTMwICBKb2hu IEtub3R0ZW5iZWx0ICA8amtub3R0ZW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJlbW92ZSB1 bm5lY2Vzc2FyeSBhc3NlcnRzIGluIEhUTUxUZXh0QXJlYUVsZW1lbnQuCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MzEzNQorCisgICAgICAgIGh0dHA6 Ly9jb2RlLmdvb2dsZS5jb20vcC9jaHJvbWl1bS9pc3N1ZXMvZGV0YWlsP2lkPTEwMzIyOCBzaG93 cworICAgICAgICB0aGF0IHNvbWV0aW1lcyB3ZSBhcmUgaGl0dGluZyB0aGUgZm9sbG93aW5nIGFz c2VydCBpbgorICAgICAgICBIVE1MVGV4dEFyZWFFbGVtZW50Ojp1cGRhdGVGb2N1c0FwcGVhcmFu Y2U6CisKKyAgICAgICAgQVNTRVJUKCFkb2N1bWVudCgpLT5jaGlsZE5lZWRzQW5kTm90SW5TdHls ZVJlY2FsYygpKTsKKworICAgICAgICBUaGlzIGFzc2VydCB3YXMgYWRkZWQgYnkgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI3NDc0CisgICAgICAgIGFzIHBhcnQgb2Yg YSBmaXggZm9yIGEgY3Jhc2ggd2hlbiB0aGUgc2VsZWN0aW9uIGlzIHNldCBpbW1lZGlhdGVseQor ICAgICAgICBhZnRlciBzZXR0aW5nIGRpc3BsYXk6bm9uZS4KKworICAgICAgICBBbGwgdGhlIG1l dGhvZHMgY2FsbGVkIGJ5IHVwZGF0ZUZvY3VzQXBwZWFyYW5jZSBhbHJlYWR5IGhhbmRsZSB0aGUK KyAgICAgICAgY2FzZSBvZiB0aGUgZG9jdW1lbnQgaGF2aW5nIHRoZSBjaGlsZE5lZWRzU3R5bGVS ZWNhbGMgZmxhZyBzZXQsIHNvCisgICAgICAgIHRoaXMgYXNzZXJ0IGlzIHVubmVjZXNzYXJ5LiBU aGUgQVNTRVJUKHJlbmRlcmVyKCkpIGlzIHNpbWlsYXJseQorICAgICAgICByZWR1bmRhbnQuCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBodG1sL0hU TUxUZXh0QXJlYUVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTFRleHRBcmVhRWxl bWVudDo6dXBkYXRlRm9jdXNBcHBlYXJhbmNlKToKKwogMjAxMS0xMS0yOCAgUGF2ZWwgRmVsZG1h biAgPHBmZWxkbWFuQGdvb2dsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogcHV0IGlu c3BlY3RvciBhZ2VudHMgaW50byBhIHZlY3RvciBpbiB0aGUgSW5zcGVjdG9yQ29udHJvbGxlci4K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFRleHRBcmVhRWxlbWVudC5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxUZXh0QXJlYUVsZW1lbnQuY3BwCmluZGV4IGNhYjBl YzNkOTNkMmU5NDk0YWY1ZTU1MmViOGE4ZDI5NjNkNjQ3ODMuLjhkZmMwODdmNTk1ZTUyNDI3MTQ5 ZDc2MWZkY2YwNzYyMTgzNDU4ZDEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRN TFRleHRBcmVhRWxlbWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MVGV4dEFy ZWFFbGVtZW50LmNwcApAQCAtMTk4LDkgKzE5OCw2IEBAIGJvb2wgSFRNTFRleHRBcmVhRWxlbWVu dDo6aXNNb3VzZUZvY3VzYWJsZSgpIGNvbnN0CiAKIHZvaWQgSFRNTFRleHRBcmVhRWxlbWVudDo6 dXBkYXRlRm9jdXNBcHBlYXJhbmNlKGJvb2wgcmVzdG9yZVByZXZpb3VzU2VsZWN0aW9uKQogewot ICAgIEFTU0VSVChyZW5kZXJlcigpKTsKLSAgICBBU1NFUlQoIWRvY3VtZW50KCktPmNoaWxkTmVl ZHNBbmROb3RJblN0eWxlUmVjYWxjKCkpOwotCiAgICAgaWYgKCFyZXN0b3JlUHJldmlvdXNTZWxl Y3Rpb24gfHwgIWhhc0NhY2hlZFNlbGVjdGlvbigpKSB7CiAgICAgICAgIC8vIElmIHRoaXMgaXMg dGhlIGZpcnN0IGZvY3VzLCBzZXQgYSBjYXJldCBhdCB0aGUgYmVnaW5uaW5nIG9mIHRoZSB0ZXh0 LiAgCiAgICAgICAgIC8vIFRoaXMgbWF0Y2hlcyBzb21lIGJyb3dzZXJzJyBiZWhhdmlvcjsgc2Vl IGJ1ZyAxMTc0NiBDb21tZW50ICMxNS4K