73120 2011-11-25 02:54:26 -0800 [EFL] Added DEFAULT_CACHE_SIZE define 2011-11-30 01:22:30 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 t.morawski webkit-unassigned gyuyoung.kim hyuki.kim lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 509061 0 t.morawski 2011-11-25 02:54:26 -0800 Remove form code 40960000 value used in code directly and replaced it by DEFAULT_CACHE_SIZE define. The code looks more cleaner now. 509062 1 116588 t.morawski 2011-11-25 02:55:32 -0800 Created attachment 116588 Added DEFAULT_CACHE_SIZE define 509094 2 116588 rakuco 2011-11-25 04:45:03 -0800 Comment on attachment 116588 Added DEFAULT_CACHE_SIZE define View in context: https://bugs.webkit.org/attachment.cgi?id=116588&action=review > Source/WebKit/efl/ChangeLog:9 > + looks more cleaner now. more cleaner -> cleaner > Source/WebKit/efl/ewk/ewk_tiled_matrix.cpp:68 > +#define DEFAULT_CACHE_SIZE 40960000 I'd rather use a static const size_t instead of a #define here. 509095 3 rakuco 2011-11-25 04:45:54 -0800 (In reply to comment #2) > (From update of attachment 116588 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=116588&action=review > > Source/WebKit/efl/ewk/ewk_tiled_matrix.cpp:68 > > +#define DEFAULT_CACHE_SIZE 40960000 > > I'd rather use a static const size_t instead of a #define here. A comment next to it indicating how much this is in KB or MB would be helpful too. 509621 4 116706 t.morawski 2011-11-28 00:47:13 -0800 Created attachment 116706 Patch 2 509622 5 116706 gyuyoung.kim 2011-11-28 00:48:23 -0800 Comment on attachment 116706 Patch 2 LGTM. 509629 6 hyuki.kim 2011-11-28 00:59:36 -0800 LGTM too. :) 509753 7 116706 rakuco 2011-11-28 05:03:19 -0800 Comment on attachment 116706 Patch 2 View in context: https://bugs.webkit.org/attachment.cgi?id=116706&action=review > Source/WebKit/efl/ewk/ewk_tiled_matrix.cpp:68 > +const size_t DEFAULT_CACHE_SIZE = 40 * 1024 * 1024; static const, not const. 510567 8 116911 t.morawski 2011-11-29 00:40:58 -0800 Created attachment 116911 Patch 3 510742 9 116911 rakuco 2011-11-29 06:54:21 -0800 Comment on attachment 116911 Patch 3 LGTM. 511247 10 116911 gyuyoung.kim 2011-11-29 17:32:47 -0800 Comment on attachment 116911 Patch 3 LGTM too. 511478 11 116911 fpizlo 2011-11-30 00:48:53 -0800 Comment on attachment 116911 Patch 3 r=me 511497 12 116911 webkit.review.bot 2011-11-30 01:22:25 -0800 Comment on attachment 116911 Patch 3 Clearing flags on attachment: 116911 Committed r101462: <http://trac.webkit.org/changeset/101462> 511498 13 webkit.review.bot 2011-11-30 01:22:30 -0800 All reviewed patches have been landed. Closing bug. 116588 2011-11-25 02:55:32 -0800 2011-11-28 00:47:13 -0800 Added DEFAULT_CACHE_SIZE define patch.patch text/plain 1752 t.morawski ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCBmNmQxZjczLi4xMWQ2ZjYxIDEwMDc1NQotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTEtMTEtMjUgIFRvbWFzeiBNb3Jhd3NraSAgPHQubW9yYXdza2lA c2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VGTF0gQWRkZWQgREVGQVVMVF9DQUNIRV9TSVpFIGRl ZmluZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcz MTIwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVt b3ZlIGZvcm0gY29kZSA0MDk2MDAwMCB2YWx1ZSB1c2VkIGluIGNvZGUgZGlyZWN0bHkgYW5kIHJl cGxhY2VkIGl0IGJ5IERFRkFVTFRfQ0FDSEVfU0laRSBkZWZpbmUuIFRoZSBjb2RlCisgICAgICAg IGxvb2tzIG1vcmUgY2xlYW5lciBub3cuCisKKyAgICAgICAgKiBld2svZXdrX3RpbGVkX21hdHJp eC5jcHA6CisgICAgICAgIChld2tfdGlsZV9tYXRyaXhfbmV3KToKKwogMjAxMS0xMS0yNCAgS3dh bmdIeXVrIEtpbSAgPGh5dWtpLmtpbUBzYW1zdW5nLmNvbT4KIAogICAgICAgICBbRUZMXSBBZGQg aW1wbGVtZW50YXRpb24gY29uc2lkZXJpbmcgZXdrX3RpbGVkX2JhY2tpbmdfc3RvcmUncyB2aXNp YmxlIHN0YXR1cy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdGlsZWRf bWF0cml4LmNwcCBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdGlsZWRfbWF0cml4LmNwcApp bmRleCBlZjUzNjg4Li4yMGIyMzVjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2sv ZXdrX3RpbGVkX21hdHJpeC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a190aWxl ZF9tYXRyaXguY3BwCkBAIC02NCw2ICs2NCw5IEBAIHN0cnVjdCBfRXdrX1RpbGVfTWF0cml4IHsK ICNlbmRpZgogfTsKIAorLyogRGVmYXVsdCBzaXplIG9mIG5ld2x5IGNyZWF0ZWQgY2FjaGUgKi8K KyNkZWZpbmUgREVGQVVMVF9DQUNIRV9TSVpFIDQwOTYwMDAwCisKICNpZmRlZiBERUJVR19NRU1f TEVBS1MKIHN0YXRpYyB1aW50NjRfdCB0aWxlc19sZWFrZWQgPSAwOwogc3RhdGljIHVpbnQ2NF90 IGJ5dGVzX2xlYWtlZCA9IDA7CkBAIC0yMTAsNyArMjEzLDcgQEAgRXdrX1RpbGVfTWF0cml4KiBl d2tfdGlsZV9tYXRyaXhfbmV3KEV3a19UaWxlX1VudXNlZF9DYWNoZSogdGlsZVVudXNlZENhY2hl LCB1bnMKICAgICBpZiAodGlsZVVudXNlZENhY2hlKQogICAgICAgICB0aWxlTWF0cml4LT50aWxp ZVVudXNlZENhY2hlID0gZXdrX3RpbGVfdW51c2VkX2NhY2hlX3JlZih0aWxlVW51c2VkQ2FjaGUp OwogICAgIGVsc2UgewotICAgICAgICB0aWxlTWF0cml4LT50aWxpZVVudXNlZENhY2hlID0gZXdr X3RpbGVfdW51c2VkX2NhY2hlX25ldyg0MDk2MDAwMCk7CisgICAgICAgIHRpbGVNYXRyaXgtPnRp bGllVW51c2VkQ2FjaGUgPSBld2tfdGlsZV91bnVzZWRfY2FjaGVfbmV3KERFRkFVTFRfQ0FDSEVf U0laRSk7CiAgICAgICAgIGlmICghdGlsZU1hdHJpeC0+dGlsaWVVbnVzZWRDYWNoZSkgewogICAg ICAgICAgICAgRVJSKCJubyBjYWNoZSBvZiB1bnVzZWQgdGlsZSEiKTsKICAgICAgICAgICAgIGVp bmFfbWF0cml4c3BhcnNlX2ZyZWUodGlsZU1hdHJpeC0+bWF0cml4KTsK 116706 2011-11-28 00:47:13 -0800 2011-11-29 00:40:58 -0800 Patch 2 patch2.patch text/plain 1724 t.morawski ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCBkNTlmYmRjLi4yN2M2NjUwIDEwMDc1NQotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTEtMTEtMjcgIFRvbWFzeiBNb3Jhd3NraSAgPHQubW9yYXdza2lA c2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VGTF0gQWRkZWQgREVGQVVMVF9DQUNIRV9TSVpFIGRl ZmluZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcz MTIwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVt b3ZlIGZvcm0gY29kZSA0MDk2MDAwMCB2YWx1ZSB1c2VkIGluIGNvZGUgZGlyZWN0bHkgYW5kIHJl cGxhY2VkIGl0IGJ5IERFRkFVTFRfQ0FDSEVfU0laRSBkZWZpbmUuIFRoZSBjb2RlCisgICAgICAg IGxvb2tzIGNsZWFuZXIgbm93LgorCisgICAgICAgICogZXdrL2V3a190aWxlZF9tYXRyaXguY3Bw OgorICAgICAgICAoZXdrX3RpbGVfbWF0cml4X25ldyk6CisKIDIwMTEtMTEtMjYgIFNoZXJpZmYg Qm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQs IHJvbGxpbmcgb3V0IHIxMDExOTMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2sv ZXdrX3RpbGVkX21hdHJpeC5jcHAgYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3RpbGVkX21h dHJpeC5jcHAKaW5kZXggZWY1MzY4OC4uMzIzZWRhZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dC9lZmwvZXdrL2V3a190aWxlZF9tYXRyaXguY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3 ay9ld2tfdGlsZWRfbWF0cml4LmNwcApAQCAtNjQsNiArNjQsOSBAQCBzdHJ1Y3QgX0V3a19UaWxl X01hdHJpeCB7CiAjZW5kaWYKIH07CiAKKy8vIERlZmF1bHQgNDAgTUIgc2l6ZSBvZiBuZXdseSBj cmVhdGVkIGNhY2hlCitjb25zdCBzaXplX3QgREVGQVVMVF9DQUNIRV9TSVpFID0gNDAgKiAxMDI0 ICogMTAyNDsKKwogI2lmZGVmIERFQlVHX01FTV9MRUFLUwogc3RhdGljIHVpbnQ2NF90IHRpbGVz X2xlYWtlZCA9IDA7CiBzdGF0aWMgdWludDY0X3QgYnl0ZXNfbGVha2VkID0gMDsKQEAgLTIxMCw3 ICsyMTMsNyBAQCBFd2tfVGlsZV9NYXRyaXgqIGV3a190aWxlX21hdHJpeF9uZXcoRXdrX1RpbGVf VW51c2VkX0NhY2hlKiB0aWxlVW51c2VkQ2FjaGUsIHVucwogICAgIGlmICh0aWxlVW51c2VkQ2Fj aGUpCiAgICAgICAgIHRpbGVNYXRyaXgtPnRpbGllVW51c2VkQ2FjaGUgPSBld2tfdGlsZV91bnVz ZWRfY2FjaGVfcmVmKHRpbGVVbnVzZWRDYWNoZSk7CiAgICAgZWxzZSB7Ci0gICAgICAgIHRpbGVN YXRyaXgtPnRpbGllVW51c2VkQ2FjaGUgPSBld2tfdGlsZV91bnVzZWRfY2FjaGVfbmV3KDQwOTYw MDAwKTsKKyAgICAgICAgdGlsZU1hdHJpeC0+dGlsaWVVbnVzZWRDYWNoZSA9IGV3a190aWxlX3Vu dXNlZF9jYWNoZV9uZXcoREVGQVVMVF9DQUNIRV9TSVpFKTsKICAgICAgICAgaWYgKCF0aWxlTWF0 cml4LT50aWxpZVVudXNlZENhY2hlKSB7CiAgICAgICAgICAgICBFUlIoIm5vIGNhY2hlIG9mIHVu dXNlZCB0aWxlISIpOwogICAgICAgICAgICAgZWluYV9tYXRyaXhzcGFyc2VfZnJlZSh0aWxlTWF0 cml4LT5tYXRyaXgpOwo= 116911 2011-11-29 00:40:58 -0800 2011-11-30 01:22:25 -0800 Patch 3 patch3.patch text/plain 1751 t.morawski ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCAyNjU2OThlLi5mZjNkMTVhIDEwMDc1NQotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTEtMTEtMjkgIFRvbWFzeiBNb3Jhd3NraSAgPHQubW9yYXdza2lA c2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VGTF0gQWRkZWQgREVGQVVMVF9DQUNIRV9TSVpFIGRl ZmluZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcz MTIwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVt b3ZlIGZvcm0gY29kZSA0MDk2MDAwMCB2YWx1ZSB1c2VkIGluIGNvZGUgZGlyZWN0bHkgYW5kIHJl cGxhY2VkIGl0IGJ5IERFRkFVTFRfQ0FDSEVfU0laRSBkZWZpbmUuIFRoZSBjb2RlCisgICAgICAg IGxvb2tzIGNsZWFuZXIgbm93LgorCisgICAgICAgICogZXdrL2V3a190aWxlZF9tYXRyaXguY3Bw OgorICAgICAgICAoZXdrX3RpbGVfbWF0cml4X25ldyk6CisKIDIwMTEtMTEtMjggIEp1bmdKaWsg TGVlICA8anVuZ2ppay5sZWVAc2Ftc3VuZy5jb20+CiAKICAgICAgICAgW0VGTF0gUmVuYW1lIGFi YnJldmlhdGVkIHZhbHVlIG5hbWVzIHRvIGNwcCBzdHlsZSBuYW1lcy4KZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdGlsZWRfbWF0cml4LmNwcCBiL1NvdXJjZS9XZWJLaXQv ZWZsL2V3ay9ld2tfdGlsZWRfbWF0cml4LmNwcAppbmRleCBlZjUzNjg4Li5jM2E1OTZkIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3RpbGVkX21hdHJpeC5jcHAKKysrIGIv U291cmNlL1dlYktpdC9lZmwvZXdrL2V3a190aWxlZF9tYXRyaXguY3BwCkBAIC02NCw2ICs2NCw5 IEBAIHN0cnVjdCBfRXdrX1RpbGVfTWF0cml4IHsKICNlbmRpZgogfTsKIAorLy8gRGVmYXVsdCA0 MCBNQiBzaXplIG9mIG5ld2x5IGNyZWF0ZWQgY2FjaGUKK3N0YXRpYyBjb25zdCBzaXplX3QgREVG QVVMVF9DQUNIRV9TSVpFID0gNDAgKiAxMDI0ICogMTAyNDsKKwogI2lmZGVmIERFQlVHX01FTV9M RUFLUwogc3RhdGljIHVpbnQ2NF90IHRpbGVzX2xlYWtlZCA9IDA7CiBzdGF0aWMgdWludDY0X3Qg Ynl0ZXNfbGVha2VkID0gMDsKQEAgLTIxMCw3ICsyMTMsNyBAQCBFd2tfVGlsZV9NYXRyaXgqIGV3 a190aWxlX21hdHJpeF9uZXcoRXdrX1RpbGVfVW51c2VkX0NhY2hlKiB0aWxlVW51c2VkQ2FjaGUs IHVucwogICAgIGlmICh0aWxlVW51c2VkQ2FjaGUpCiAgICAgICAgIHRpbGVNYXRyaXgtPnRpbGll VW51c2VkQ2FjaGUgPSBld2tfdGlsZV91bnVzZWRfY2FjaGVfcmVmKHRpbGVVbnVzZWRDYWNoZSk7 CiAgICAgZWxzZSB7Ci0gICAgICAgIHRpbGVNYXRyaXgtPnRpbGllVW51c2VkQ2FjaGUgPSBld2tf dGlsZV91bnVzZWRfY2FjaGVfbmV3KDQwOTYwMDAwKTsKKyAgICAgICAgdGlsZU1hdHJpeC0+dGls aWVVbnVzZWRDYWNoZSA9IGV3a190aWxlX3VudXNlZF9jYWNoZV9uZXcoREVGQVVMVF9DQUNIRV9T SVpFKTsKICAgICAgICAgaWYgKCF0aWxlTWF0cml4LT50aWxpZVVudXNlZENhY2hlKSB7CiAgICAg ICAgICAgICBFUlIoIm5vIGNhY2hlIG9mIHVudXNlZCB0aWxlISIpOwogICAgICAgICAgICAgZWlu YV9tYXRyaXhzcGFyc2VfZnJlZSh0aWxlTWF0cml4LT5tYXRyaXgpOwo=