73114 2011-11-24 23:43:49 -0800 Upstream the QNX/RIM specific HistoryItemViewState 2011-11-25 02:58:03 -0800 1 1 1 Unclassified WebKit History 528+ (Nightly build) Unspecified Other RESOLVED FIXED P2 Normal --- 0 charles.wei webkit-unassigned dbates leo.yang staikos tonikitoo webkit.review.bot zimmermann oldest_to_newest 508990 0 charles.wei 2011-11-24 23:43:49 -0800 RIM's QNX porting for WebKit has it's own HistoryItemViewState extension to maintain the ViewState for a page so that could be restored when navigating back to that page. This is to upstream that to the WebKit repo. 509005 1 116575 charles.wei 2011-11-25 00:12:59 -0800 Created attachment 116575 Patch 509015 2 116575 dbates 2011-11-25 00:25:00 -0800 Comment on attachment 116575 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=116575&action=review > Source/WebCore/ChangeLog:4 > + This patch is to upstream RIM/QNX specific HistoryItemViewState extension > + To store some extra view state. Nit: This should be the bug title: "Upstream the QNX/RIM specific HistoryItemViewState". This reads more like a description which should be placed after the "Reviewed by" line. 509018 3 116579 charles.wei 2011-11-25 00:38:30 -0800 Created attachment 116579 Patch 509063 4 116579 webkit.review.bot 2011-11-25 02:57:58 -0800 Comment on attachment 116579 Patch Clearing flags on attachment: 116579 Committed r101161: <http://trac.webkit.org/changeset/101161> 509064 5 webkit.review.bot 2011-11-25 02:58:03 -0800 All reviewed patches have been landed. Closing bug. 116575 2011-11-25 00:12:59 -0800 2011-11-25 00:38:18 -0800 Patch bug-73114-20111125161335.patch text/plain 2553 charles.wei SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwMTE1MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDExLTExLTI1ICBXZWkgQ2hh cmxlcyAgPGNoYXJsZXMud2VpQHRvcmNobW9iaWxlLmNvbS5jbj4KKworICAgICAgICBUaGlzIHBh dGNoIGlzIHRvIHVwc3RyZWFtIFJJTS9RTlggc3BlY2lmaWMgSGlzdG9yeUl0ZW1WaWV3U3RhdGUg ZXh0ZW5zaW9uCisgICAgICAgIFRvIHN0b3JlIHNvbWUgZXh0cmEgdmlldyBzdGF0ZS4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTczMTE0CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCB0 aGlzIGp1c3QgYWRkcyBvbmUgbmV3IGZpbGUsIG5vdCBidWlsZCB5ZXQuCisKKyAgICAgICAgKiBo aXN0b3J5L2JsYWNrYmVycnk6IEFkZGVkLgorICAgICAgICAqIGhpc3RvcnkvYmxhY2tiZXJyeS9I aXN0b3J5SXRlbVZpZXdTdGF0ZS5oOiBBZGRlZC4KKyAgICAgICAgKFdlYkNvcmU6Okhpc3RvcnlJ dGVtVmlld1N0YXRlOjpIaXN0b3J5SXRlbVZpZXdTdGF0ZSk6CisKIDIwMTEtMTEtMjQgIEtlbnRh cm8gSGFyYSAgPGhhcmFrZW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIEluaXRpYWxpemUgZ2xv YmFsIHZhcmlhYmxlcyBkdXJpbmcgSURMUGFyc2VyIG9iamVjdCBjcmVhdGlvbgpJbmRleDogU291 cmNlL1dlYkNvcmUvaGlzdG9yeS9ibGFja2JlcnJ5L0hpc3RvcnlJdGVtVmlld1N0YXRlLmgKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvaGlzdG9yeS9ibGFja2JlcnJ5L0hpc3RvcnlJdGVt Vmlld1N0YXRlLmgJKHJldmlzaW9uIDApCisrKyBTb3VyY2UvV2ViQ29yZS9oaXN0b3J5L2JsYWNr YmVycnkvSGlzdG9yeUl0ZW1WaWV3U3RhdGUuaAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSw0NyBA QAorLyoKKyAqIENvcHlyaWdodCAoQykgMjAxMSBSZXNlYXJjaCBJbiBNb3Rpb24gTGltaXRlZC4g QWxsIHJpZ2h0cyByZXNlcnZlZC4KKyAqCisgKiBUaGlzIGxpYnJhcnkgaXMgZnJlZSBzb2Z0d2Fy ZTsgeW91IGNhbiByZWRpc3RyaWJ1dGUgaXQgYW5kL29yCisgKiBtb2RpZnkgaXQgdW5kZXIgdGhl IHRlcm1zIG9mIHRoZSBHTlUgTGVzc2VyIEdlbmVyYWwgUHVibGljCisgKiBMaWNlbnNlIGFzIHB1 Ymxpc2hlZCBieSB0aGUgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9uOyBlaXRoZXIKKyAqIHZlcnNp b24gMiBvZiB0aGUgTGljZW5zZSwgb3IgKGF0IHlvdXIgb3B0aW9uKSBhbnkgbGF0ZXIgdmVyc2lv bi4KKyAqCisgKiBUaGlzIGxpYnJhcnkgaXMgZGlzdHJpYnV0ZWQgaW4gdGhlIGhvcGUgdGhhdCBp dCB3aWxsIGJlIHVzZWZ1bCwKKyAqIGJ1dCBXSVRIT1VUIEFOWSBXQVJSQU5UWTsgd2l0aG91dCBl dmVuIHRoZSBpbXBsaWVkIHdhcnJhbnR5IG9mCisgKiBNRVJDSEFOVEFCSUxJVFkgb3IgRklUTkVT UyBGT1IgQSBQQVJUSUNVTEFSIFBVUlBPU0UuICBTZWUgdGhlIEdOVQorICogTGVzc2VyIEdlbmVy YWwgUHVibGljIExpY2Vuc2UgZm9yIG1vcmUgZGV0YWlscy4KKyAqCisgKiBZb3Ugc2hvdWxkIGhh dmUgcmVjZWl2ZWQgYSBjb3B5IG9mIHRoZSBHTlUgTGVzc2VyIEdlbmVyYWwgUHVibGljCisgKiBM aWNlbnNlIGFsb25nIHdpdGggdGhpcyBsaWJyYXJ5OyBpZiBub3QsIHdyaXRlIHRvIHRoZSBGcmVl IFNvZnR3YXJlCisgKiBGb3VuZGF0aW9uLCBJbmMuLCA1MSBGcmFua2xpbiBTdHJlZXQsIEZpZnRo IEZsb29yLCBCb3N0b24sIE1BICAwMjExMC0xMzAxICBVU0EKKyAqLworCisjaWZuZGVmIEhpc3Rv cnlJdGVtVmlld1N0YXRlX2gKKyNkZWZpbmUgSGlzdG9yeUl0ZW1WaWV3U3RhdGVfaAorCisjaW5j bHVkZSAiUGxhdGZvcm1TdHJpbmcuaCIKKworbmFtZXNwYWNlIFdlYkNvcmUgeworCitzdHJ1Y3Qg SGlzdG9yeUl0ZW1WaWV3U3RhdGUgeworCisgICAgSGlzdG9yeUl0ZW1WaWV3U3RhdGUoKQorICAg ICAgICA6IG9yaWVudGF0aW9uKDApCisgICAgICAgICwgc2NhbGUoMSkKKyAgICAgICAgLCBpc1pv b21Ub0ZpdFNjYWxlKGZhbHNlKQorICAgICAgICAsIHNob3VsZFJlZmxvd0Jsb2NrKGZhbHNlKQor ICAgICAgICAsIHNob3VsZFNhdmVWaWV3U3RhdGUodHJ1ZSkKKyAgICB7CisgICAgfQorCisgICAg aW50IG9yaWVudGF0aW9uOworICAgIGRvdWJsZSBzY2FsZTsKKyAgICBib29sIGlzWm9vbVRvRml0 U2NhbGU7CisgICAgYm9vbCBzaG91bGRSZWZsb3dCbG9jazsKKyAgICBib29sIHNob3VsZFNhdmVW aWV3U3RhdGU7CisgICAgU3RyaW5nIG5ldHdvcmtUb2tlbjsKK307CisKK30gLy8gbmFtZXNwYWNl IFdlYkNvcmUKKworI2VuZGlmIC8vIEhpc3RvcnlJdGVtVmlld1N0YXRlX2gK 116579 2011-11-25 00:38:30 -0800 2011-11-25 02:57:58 -0800 Patch bug-73114-20111125163906.patch text/plain 2591 charles.wei SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwMTE1MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDExLTExLTI1ICBXZWkgQ2hh cmxlcyAgPGNoYXJsZXMud2VpQHRvcmNobW9iaWxlLmNvbS5jbj4KKworICAgICAgICBVcHN0cmVh bSB0aGUgUU5YL1JJTSBzcGVjaWZpYyBIaXN0b3J5SXRlbVZpZXdTdGF0ZQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzMxMTQKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIHBhdGNoIGlzIHRvIHVwc3Ry ZWFtIFJJTS9RTlggc3BlY2lmaWMgSGlzdG9yeUl0ZW1WaWV3U3RhdGUgZXh0ZW5zaW9uCisgICAg ICAgIHRvIHN0b3JlIHNvbWUgZXh0cmEgdmlldyBzdGF0ZS4KKworICAgICAgICBObyBuZXcgdGVz dHMuIEl0J3Mgbm90IGJ1aWx0IHlldC4KKworICAgICAgICAqIGhpc3RvcnkvYmxhY2tiZXJyeTog QWRkZWQuCisgICAgICAgICogaGlzdG9yeS9ibGFja2JlcnJ5L0hpc3RvcnlJdGVtVmlld1N0YXRl Lmg6IEFkZGVkLgorICAgICAgICAoV2ViQ29yZTo6SGlzdG9yeUl0ZW1WaWV3U3RhdGU6Okhpc3Rv cnlJdGVtVmlld1N0YXRlKToKKwogMjAxMS0xMS0yNCAgS2VudGFybyBIYXJhICA8aGFyYWtlbkBj aHJvbWl1bS5vcmc+CiAKICAgICAgICAgSW5pdGlhbGl6ZSBnbG9iYWwgdmFyaWFibGVzIGR1cmlu ZyBJRExQYXJzZXIgb2JqZWN0IGNyZWF0aW9uCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9oaXN0b3J5 L2JsYWNrYmVycnkvSGlzdG9yeUl0ZW1WaWV3U3RhdGUuaAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViQ29yZS9oaXN0b3J5L2JsYWNrYmVycnkvSGlzdG9yeUl0ZW1WaWV3U3RhdGUuaAkocmV2aXNp b24gMCkKKysrIFNvdXJjZS9XZWJDb3JlL2hpc3RvcnkvYmxhY2tiZXJyeS9IaXN0b3J5SXRlbVZp ZXdTdGF0ZS5oCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDQ3IEBACisvKgorICogQ29weXJpZ2h0 IChDKSAyMDExIFJlc2VhcmNoIEluIE1vdGlvbiBMaW1pdGVkLiBBbGwgcmlnaHRzIHJlc2VydmVk LgorICoKKyAqIFRoaXMgbGlicmFyeSBpcyBmcmVlIHNvZnR3YXJlOyB5b3UgY2FuIHJlZGlzdHJp YnV0ZSBpdCBhbmQvb3IKKyAqIG1vZGlmeSBpdCB1bmRlciB0aGUgdGVybXMgb2YgdGhlIEdOVSBM ZXNzZXIgR2VuZXJhbCBQdWJsaWMKKyAqIExpY2Vuc2UgYXMgcHVibGlzaGVkIGJ5IHRoZSBGcmVl IFNvZnR3YXJlIEZvdW5kYXRpb247IGVpdGhlcgorICogdmVyc2lvbiAyIG9mIHRoZSBMaWNlbnNl LCBvciAoYXQgeW91ciBvcHRpb24pIGFueSBsYXRlciB2ZXJzaW9uLgorICoKKyAqIFRoaXMgbGli cmFyeSBpcyBkaXN0cmlidXRlZCBpbiB0aGUgaG9wZSB0aGF0IGl0IHdpbGwgYmUgdXNlZnVsLAor ICogYnV0IFdJVEhPVVQgQU5ZIFdBUlJBTlRZOyB3aXRob3V0IGV2ZW4gdGhlIGltcGxpZWQgd2Fy cmFudHkgb2YKKyAqIE1FUkNIQU5UQUJJTElUWSBvciBGSVRORVNTIEZPUiBBIFBBUlRJQ1VMQVIg UFVSUE9TRS4gIFNlZSB0aGUgR05VCisgKiBMZXNzZXIgR2VuZXJhbCBQdWJsaWMgTGljZW5zZSBm b3IgbW9yZSBkZXRhaWxzLgorICoKKyAqIFlvdSBzaG91bGQgaGF2ZSByZWNlaXZlZCBhIGNvcHkg b2YgdGhlIEdOVSBMZXNzZXIgR2VuZXJhbCBQdWJsaWMKKyAqIExpY2Vuc2UgYWxvbmcgd2l0aCB0 aGlzIGxpYnJhcnk7IGlmIG5vdCwgd3JpdGUgdG8gdGhlIEZyZWUgU29mdHdhcmUKKyAqIEZvdW5k YXRpb24sIEluYy4sIDUxIEZyYW5rbGluIFN0cmVldCwgRmlmdGggRmxvb3IsIEJvc3RvbiwgTUEg IDAyMTEwLTEzMDEgIFVTQQorICovCisKKyNpZm5kZWYgSGlzdG9yeUl0ZW1WaWV3U3RhdGVfaAor I2RlZmluZSBIaXN0b3J5SXRlbVZpZXdTdGF0ZV9oCisKKyNpbmNsdWRlICJQbGF0Zm9ybVN0cmlu Zy5oIgorCituYW1lc3BhY2UgV2ViQ29yZSB7CisKK3N0cnVjdCBIaXN0b3J5SXRlbVZpZXdTdGF0 ZSB7CisKKyAgICBIaXN0b3J5SXRlbVZpZXdTdGF0ZSgpCisgICAgICAgIDogb3JpZW50YXRpb24o MCkKKyAgICAgICAgLCBzY2FsZSgxKQorICAgICAgICAsIGlzWm9vbVRvRml0U2NhbGUoZmFsc2Up CisgICAgICAgICwgc2hvdWxkUmVmbG93QmxvY2soZmFsc2UpCisgICAgICAgICwgc2hvdWxkU2F2 ZVZpZXdTdGF0ZSh0cnVlKQorICAgIHsKKyAgICB9CisKKyAgICBpbnQgb3JpZW50YXRpb247Cisg ICAgZG91YmxlIHNjYWxlOworICAgIGJvb2wgaXNab29tVG9GaXRTY2FsZTsKKyAgICBib29sIHNo b3VsZFJlZmxvd0Jsb2NrOworICAgIGJvb2wgc2hvdWxkU2F2ZVZpZXdTdGF0ZTsKKyAgICBTdHJp bmcgbmV0d29ya1Rva2VuOworfTsKKworfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQorCisjZW5kaWYg Ly8gSGlzdG9yeUl0ZW1WaWV3U3RhdGVfaAo=