73104 2011-11-24 18:14:06 -0800 [EFL] Remove duplicated UA information function 2011-11-30 02:56:48 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 gyuyoung.kim gyuyoung.kim fpizlo gyuyoung.kim lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 508924 0 gyuyoung.kim 2011-11-24 18:14:06 -0800 Though ewk_setting already implemented an internal function for UA(user agent) information, FrameLoaderClientEfl has used duplicated function for UA information. 508925 1 116554 gyuyoung.kim 2011-11-24 18:15:39 -0800 Created attachment 116554 Patch 509091 2 116554 rakuco 2011-11-25 04:29:07 -0800 Comment on attachment 116554 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=116554&action=review > Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.cpp:78 > + return makeString(ewk_settings_default_user_agent_get()); makeString has been deprecated for some time, please either create the string directly or return ewk_settings_default_user_agent_get() and let the String object be implicitly created. > Source/WebKit/efl/ewk/ewk_settings.cpp:-72 > - I'd rather leave this empty line here for readability. > Source/WebKit/efl/ewk/ewk_settings.cpp:-77 > - Ditto. 509349 3 116653 gyuyoung.kim 2011-11-26 03:13:30 -0800 Created attachment 116653 Patch 509350 4 116554 gyuyoung.kim 2011-11-26 03:15:34 -0800 Comment on attachment 116554 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=116554&action=review >> Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.cpp:78 >> + return makeString(ewk_settings_default_user_agent_get()); > > makeString has been deprecated for some time, please either create the string directly or return ewk_settings_default_user_agent_get() and let the String object be implicitly created. Done. I use String directly. >> Source/WebKit/efl/ewk/ewk_settings.cpp:-72 >> - > > I'd rather leave this empty line here for readability. Done. >> Source/WebKit/efl/ewk/ewk_settings.cpp:-77 >> - > > Ditto. I think it is better to remove empty line on #elif. 509758 5 rakuco 2011-11-28 05:13:26 -0800 LGTM. 511485 6 116653 fpizlo 2011-11-30 00:59:18 -0800 Comment on attachment 116653 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=116653&action=review r=me > Source/WebKit/efl/ewk/ewk_settings.cpp:80 > + uaOsVersion = "PPC Mac OS X"; Slight nitpick: presumably CPU(X86) tells you that you were *built* on X86. So you could be running a PPC binary on an X86 Mac. You could query what kind of Mac you're on using sysctl(). hw.machine will tell you the kind of CPU. This is not a big deal, probably. 511511 7 gyuyoung.kim 2011-11-30 01:37:37 -0800 (In reply to comment #6) > (From update of attachment 116653 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=116653&action=review > > r=me > > > Source/WebKit/efl/ewk/ewk_settings.cpp:80 > > + uaOsVersion = "PPC Mac OS X"; > > Slight nitpick: presumably CPU(X86) tells you that you were *built* on X86. So you could be running a PPC binary on an X86 Mac. You could query what kind of Mac you're on using sysctl(). hw.machine will tell you the kind of CPU. This is not a big deal, probably. Ok, I will enhance this function according to your advice on new bug. Thank you. 511575 8 116653 webkit.review.bot 2011-11-30 02:56:43 -0800 Comment on attachment 116653 Patch Clearing flags on attachment: 116653 Committed r101471: <http://trac.webkit.org/changeset/101471> 511576 9 webkit.review.bot 2011-11-30 02:56:48 -0800 All reviewed patches have been landed. Closing bug. 116554 2011-11-24 18:15:39 -0800 2011-11-26 03:15:34 -0800 Patch bug-73104-20111125111537.patch text/plain 4780 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTAxMTQ2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Vm bC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cKaW5kZXggZjZkMWY3Mzc0 NjgzMzU5ZDNmNjMzYzA5OWI3ZWFmODZkNWI1YTIzMy4uOGFlOTRlMTUyNWYyN2RiNzFiMGUwMGFj NGJmOTk2MTRiOTk1Mjg3MyAxMDA3NTUKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEx LTExLTI0ICBHeXV5b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+CisKKyAgICAg ICAgW0VGTF0gUmVtb3ZlIGR1cGxpY2F0ZWQgVUEgaW5mb3JtYXRpb24gZnVuY3Rpb24uCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MzEwNAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRob3VnaCBld2tfc2V0 dGluZyBhbHJlYWR5IGltcGxlbWVudGVkIGFuIGludGVybmFsIGZ1bmN0aW9uIGZvciBVQSh1c2Vy IGFnZW50KSBpbmZvcm1hdGlvbiwKKyAgICAgICAgRnJhbWVMb2FkZXJDbGllbnRFZmwgaGFzIHVz ZWQgZHVwbGljYXRlZCBmdW5jdGlvbiBmb3IgVUEgaW5mb3JtYXRpb24uIFNvLCB0aGlzIHBhdGNo IHJlbW92ZXMKKyAgICAgICAgdGhlIFVBIGluZm9ybWF0aW9uIGZ1bmN0aW9uIG9mIEZyYW1lTG9h ZGVyQ2xpZW50RWZsIGFuZCB1c2VzIGFuIGludGVybmFsIFVBIGluZm9ybWF0aW9uIGZ1bmN0aW9u CisgICAgICAgIG9mIGV3a19zZXR0aW5nLiBJbiBhZGRpdGlvbiwgVUEgaW5mb21hdGlvbiBmdW5j dGlvbiBpcyBlbmhhbmNlZCBmb3Igb3RoZXIgcG9ydHMuCisKKyAgICAgICAgKiBXZWJDb3JlU3Vw cG9ydC9GcmFtZUxvYWRlckNsaWVudEVmbC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpjb21wb3Nl VXNlckFnZW50KToKKyAgICAgICAgKiBld2svZXdrX3NldHRpbmdzLmNwcDoKKyAgICAgICAgKGV3 a19zZXR0aW5nc19kZWZhdWx0X3VzZXJfYWdlbnRfZ2V0KToKKwogMjAxMS0xMS0yNCAgS3dhbmdI eXVrIEtpbSAgPGh5dWtpLmtpbUBzYW1zdW5nLmNvbT4KIAogICAgICAgICBbRUZMXSBBZGQgaW1w bGVtZW50YXRpb24gY29uc2lkZXJpbmcgZXdrX3RpbGVkX2JhY2tpbmdfc3RvcmUncyB2aXNpYmxl IHN0YXR1cy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL1dlYkNvcmVTdXBwb3J0L0Zy YW1lTG9hZGVyQ2xpZW50RWZsLmNwcCBiL1NvdXJjZS9XZWJLaXQvZWZsL1dlYkNvcmVTdXBwb3J0 L0ZyYW1lTG9hZGVyQ2xpZW50RWZsLmNwcAppbmRleCA0NGZiNjMwOTAyN2JlOWFmOGJiOGRkZDE3 ZjYxMjhjMWVjOTIxNjM0Li4wYTJkMmU3ZWI4NDI3MTA4OWQ4MmU3ZjMwOWM3NTkyZDUzZTU1NTNm IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9XZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRl ckNsaWVudEVmbC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9lZmwvV2ViQ29yZVN1cHBvcnQvRnJh bWVMb2FkZXJDbGllbnRFZmwuY3BwCkBAIC01NiwxMiArNTYsNiBAQAogI2luY2x1ZGUgPHd0Zi90 ZXh0L0NTdHJpbmcuaD4KICNpbmNsdWRlIDx3dGYvdGV4dC9TdHJpbmdDb25jYXRlbmF0ZS5oPgog Ci0jaWYgT1MoVU5JWCkKLSNpbmNsdWRlIDxzeXMvdXRzbmFtZS5oPgotI2VsaWYgT1MoV0lORE9X UykKLSNpbmNsdWRlICJTeXN0ZW1JbmZvLmgiCi0jZW5kaWYKLQogI2luY2x1ZGUgPEVjb3JlX0V2 YXMuaD4KIAogdXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU7CkBAIC03OSwzMiArNzMsOSBAQCBGcmFt ZUxvYWRlckNsaWVudEVmbDo6RnJhbWVMb2FkZXJDbGllbnRFZmwoRXZhc19PYmplY3QqIHZpZXcp CiB7CiB9CiAKLXN0YXRpYyBTdHJpbmcgYWdlbnRPUygpCi17Ci0jaWYgT1MoREFSV0lOKQotI2lm IENQVShYODYpCi0gICAgcmV0dXJuICJJbnRlbCBNYWMgT1MgWCI7Ci0jZWxzZQotICAgIHJldHVy biAiUFBDIE1hYyBPUyBYIjsKLSNlbmRpZgotI2VsaWYgT1MoVU5JWCkKLSAgICBzdHJ1Y3QgdXRz bmFtZSBuYW1lOwotICAgIGlmICh1bmFtZSgmbmFtZSkgIT0gLTEpCi0gICAgICAgIHJldHVybiBt YWtlU3RyaW5nKG5hbWUuc3lzbmFtZSwgJyAnLCBuYW1lLm1hY2hpbmUpOwotCi0gICAgcmV0dXJu ICJVbmtub3duIjsKLSNlbGlmIE9TKFdJTkRPV1MpCi0gICAgcmV0dXJuIHdpbmRvd3NWZXJzaW9u Rm9yVUFTdHJpbmcoKTsKLSNlbHNlCi0gICAgbm90SW1wbGVtZW50ZWQoKTsKLSAgICByZXR1cm4g IlVua25vd24iOwotI2VuZGlmCi19Ci0KIHN0YXRpYyBTdHJpbmcgY29tcG9zZVVzZXJBZ2VudCgp CiB7Ci0gICAgU3RyaW5nIHdlYktpdFZlcnNpb24gPSBTdHJpbmc6OmZvcm1hdCgiJWQuJWQiLCBX RUJLSVRfTUFKT1JfVkVSU0lPTiwgV0VCS0lUX01JTk9SX1ZFUlNJT04pOwotICAgIHJldHVybiBt YWtlU3RyaW5nKCJNb3ppbGxhLzUuMCAoIiwgYWdlbnRPUygpLCAiKSBBcHBsZVdlYktpdC8iLCB3 ZWJLaXRWZXJzaW9uLCAiIChLSFRNTCwgbGlrZSBHZWNrbykgU2FmYXJpLyIsIHdlYktpdFZlcnNp b24pOworICAgIHJldHVybiBtYWtlU3RyaW5nKGV3a19zZXR0aW5nc19kZWZhdWx0X3VzZXJfYWdl bnRfZ2V0KCkpOwogfQogCiB2b2lkIEZyYW1lTG9hZGVyQ2xpZW50RWZsOjpzZXRDdXN0b21Vc2Vy QWdlbnQoY29uc3QgU3RyaW5nJiBhZ2VudCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZs L2V3ay9ld2tfc2V0dGluZ3MuY3BwIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19zZXR0aW5n cy5jcHAKaW5kZXggMjFjYzU3NTg4ODEyYmZlZmMzYzFlYzBkZGIzMjkzNTVkY2UxM2Q2NC4uZjVk NjkzOWU3NGE2YTBlMzc3YjM0NjlkOWUyNTg2NGVhYTU0NGMxNiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9lZmwvZXdrL2V3a19zZXR0aW5ncy5jcHAKKysrIGIvU291cmNlL1dlYktpdC9lZmwv ZXdrL2V3a19zZXR0aW5ncy5jcHAKQEAgLTQwLDEzICs0MCwxOCBAQAogI2luY2x1ZGUgPGVpbmFf c2FmZXR5X2NoZWNrcy5oPgogI2luY2x1ZGUgPGVycm5vLmg+CiAjaW5jbHVkZSA8c3RyaW5nLmg+ Ci0jaW5jbHVkZSA8c3lzL3N0YXQuaD4KLSNpbmNsdWRlIDxzeXMvdHlwZXMuaD4KLSNpbmNsdWRl IDxzeXMvdXRzbmFtZS5oPgogI2luY2x1ZGUgPHVuaXN0ZC5oPgogI2luY2x1ZGUgPHd0Zi90ZXh0 L0NTdHJpbmcuaD4KICNpbmNsdWRlIDx3dGYvdGV4dC9TdHJpbmdDb25jYXRlbmF0ZS5oPgogCisj aWYgT1MoVU5JWCkKKyNpbmNsdWRlIDxzeXMvc3RhdC5oPgorI2luY2x1ZGUgPHN5cy90eXBlcy5o PgorI2luY2x1ZGUgPHN5cy91dHNuYW1lLmg+CisjZWxpZiBPUyhXSU5ET1dTKQorI2luY2x1ZGUg IlN5c3RlbUluZm8uaCIKKyNlbmRpZgorCiBzdGF0aWMgY29uc3QgY2hhciogc19vZmZsaW5lQXBw Q2FjaGVQYXRoID0gMDsKIAogc3RhdGljIGNvbnN0IGNoYXIqIF9ld2tfaWNvbl9kYXRhYmFzZV9w YXRoID0gMDsKQEAgLTY4LDEzICs3MywyMyBAQCBzdGF0aWMgV1RGOjpTdHJpbmcgX2V3a19zZXR0 aW5nc193ZWJraXRfcGxhdGZvcm1fZ2V0KCkKIHN0YXRpYyBXVEY6OlN0cmluZyBfZXdrX3NldHRp bmdzX3dlYmtpdF9vc192ZXJzaW9uX2dldCgpCiB7CiAgICAgV1RGOjpTdHJpbmcgdWFPc1ZlcnNp b247CisjaWYgT1MoREFSV0lOKQorI2lmIENQVShYODYpCisgICAgdWFPc1ZlcnNpb24gPSAiSW50 ZWwgTWFjIE9TIFgiOworI2Vsc2UKKyAgICB1YU9zVmVyc2lvbiA9ICJQUEMgTWFjIE9TIFgiOwor I2VuZGlmCisjZWxpZiBPUyhVTklYKQogICAgIHN0cnVjdCB1dHNuYW1lIG5hbWU7Ci0KICAgICBp ZiAodW5hbWUoJm5hbWUpICE9IC0xKQogICAgICAgICB1YU9zVmVyc2lvbiA9IG1ha2VTdHJpbmco bmFtZS5zeXNuYW1lLCAnICcsIG5hbWUubWFjaGluZSk7CiAgICAgZWxzZQogICAgICAgICB1YU9z VmVyc2lvbiA9ICJVbmtub3duIjsKLQorI2VsaWYgT1MoV0lORE9XUykKKyAgICB1YU9zVmVyc2lv biA9IHdpbmRvd3NWZXJzaW9uRnJvVUFTdHJpbmcoKTsKKyNlbHNlCisgICAgdWFPc1ZlcnNpb24g PSAiVW5rbm93biI7CisjZW5kaWYKICAgICByZXR1cm4gdWFPc1ZlcnNpb247CiB9CiAKQEAgLTI1 MCw3ICsyNjUsNyBAQCB2b2lkIGV3a19zZXR0aW5nc19yZXBhaW50X3Rocm90dGxpbmdfc2V0KGRv dWJsZSBkZWZlcnJlZFJlcGFpbnREZWxheSwgZG91YmxlIGluaQogICoKICAqIEByZXR1cm4gYSBw b2ludGVyIHRvIGFuIGVpbmFfc3RyaW5nc2hhcmUgY29udGFpbmluZyB0aGUgdXNlciBhZ2VudCBz dHJpbmcKICAqLwotY29uc3QgY2hhciogZXdrX3NldHRpbmdzX2RlZmF1bHRfdXNlcl9hZ2VudF9n ZXQodm9pZCkKK2NvbnN0IGNoYXIqIGV3a19zZXR0aW5nc19kZWZhdWx0X3VzZXJfYWdlbnRfZ2V0 KCkKIHsKICAgICBXVEY6OlN0cmluZyB1YVZlcnNpb24gPSBtYWtlU3RyaW5nKFN0cmluZzo6bnVt YmVyKFdFQktJVF9VU0VSX0FHRU5UX01BSk9SX1ZFUlNJT04pLCAnLicsIFN0cmluZzo6bnVtYmVy KFdFQktJVF9VU0VSX0FHRU5UX01JTk9SX1ZFUlNJT04pLCAnKycpOwogICAgIFdURjo6U3RyaW5n IHN0YXRpY1VhID0gbWFrZVN0cmluZygiTW96aWxsYS81LjAgKCIsIF9ld2tfc2V0dGluZ3Nfd2Vi a2l0X3BsYXRmb3JtX2dldCgpLCAiOyAiLCBfZXdrX3NldHRpbmdzX3dlYmtpdF9vc192ZXJzaW9u X2dldCgpLCAiKSBBcHBsZVdlYktpdC8iLCB1YVZlcnNpb24pICsgbWFrZVN0cmluZygiIChLSFRN TCwgbGlrZSBHZWNrbykgVmVyc2lvbi81LjAgU2FmYXJpLyIsIHVhVmVyc2lvbik7Cg== 116653 2011-11-26 03:13:30 -0800 2011-11-30 02:56:43 -0800 Patch bug-73104-20111126201328.patch text/plain 4776 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTAxMTg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Vm bC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cKaW5kZXggZjZkMWY3Mzc0 NjgzMzU5ZDNmNjMzYzA5OWI3ZWFmODZkNWI1YTIzMy4uNzY2ZmE3M2MxMWNkZmE2NjMzMzQyNmRi MzhmNjQwNjA0NWVhMzMwZCAxMDA3NTUKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEx LTExLTI1ICBHeXV5b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+CisKKyAgICAg ICAgW0VGTF0gUmVtb3ZlIGR1cGxpY2F0ZWQgVUEgaW5mb3JtYXRpb24gZnVuY3Rpb24uCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MzEwNAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRob3VnaCBld2tfc2V0 dGluZyBhbHJlYWR5IGltcGxlbWVudGVkIGFuIGludGVybmFsIGZ1bmN0aW9uIGZvciBVQSh1c2Vy IGFnZW50KSBpbmZvcm1hdGlvbiwKKyAgICAgICAgRnJhbWVMb2FkZXJDbGllbnRFZmwgaGFzIHVz ZWQgZHVwbGljYXRlZCBmdW5jdGlvbiBmb3IgVUEgaW5mb3JtYXRpb24uIFNvLCB0aGlzIHBhdGNo IHJlbW92ZXMKKyAgICAgICAgdGhlIFVBIGluZm9ybWF0aW9uIGZ1bmN0aW9uIG9mIEZyYW1lTG9h ZGVyQ2xpZW50RWZsIGFuZCB1c2VzIGFuIGludGVybmFsIFVBIGluZm9ybWF0aW9uIGZ1bmN0aW9u CisgICAgICAgIG9mIGV3a19zZXR0aW5nLiBJbiBhZGRpdGlvbiwgVUEgaW5mb21hdGlvbiBmdW5j dGlvbiBpcyBlbmhhbmNlZCBmb3Igb3RoZXIgcG9ydHMuCisKKyAgICAgICAgKiBXZWJDb3JlU3Vw cG9ydC9GcmFtZUxvYWRlckNsaWVudEVmbC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpjb21wb3Nl VXNlckFnZW50KToKKyAgICAgICAgKiBld2svZXdrX3NldHRpbmdzLmNwcDoKKyAgICAgICAgKGV3 a19zZXR0aW5nc19kZWZhdWx0X3VzZXJfYWdlbnRfZ2V0KToKKwogMjAxMS0xMS0yNCAgS3dhbmdI eXVrIEtpbSAgPGh5dWtpLmtpbUBzYW1zdW5nLmNvbT4KIAogICAgICAgICBbRUZMXSBBZGQgaW1w bGVtZW50YXRpb24gY29uc2lkZXJpbmcgZXdrX3RpbGVkX2JhY2tpbmdfc3RvcmUncyB2aXNpYmxl IHN0YXR1cy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL1dlYkNvcmVTdXBwb3J0L0Zy YW1lTG9hZGVyQ2xpZW50RWZsLmNwcCBiL1NvdXJjZS9XZWJLaXQvZWZsL1dlYkNvcmVTdXBwb3J0 L0ZyYW1lTG9hZGVyQ2xpZW50RWZsLmNwcAppbmRleCA0NGZiNjMwOTAyN2JlOWFmOGJiOGRkZDE3 ZjYxMjhjMWVjOTIxNjM0Li4yNTRkZjAyNGU2NDIzYWI5ODVmNDZlYzdjZjQ4MTFmYzBkZGUyOTZj IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9XZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRl ckNsaWVudEVmbC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9lZmwvV2ViQ29yZVN1cHBvcnQvRnJh bWVMb2FkZXJDbGllbnRFZmwuY3BwCkBAIC01NiwxMiArNTYsNiBAQAogI2luY2x1ZGUgPHd0Zi90 ZXh0L0NTdHJpbmcuaD4KICNpbmNsdWRlIDx3dGYvdGV4dC9TdHJpbmdDb25jYXRlbmF0ZS5oPgog Ci0jaWYgT1MoVU5JWCkKLSNpbmNsdWRlIDxzeXMvdXRzbmFtZS5oPgotI2VsaWYgT1MoV0lORE9X UykKLSNpbmNsdWRlICJTeXN0ZW1JbmZvLmgiCi0jZW5kaWYKLQogI2luY2x1ZGUgPEVjb3JlX0V2 YXMuaD4KIAogdXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU7CkBAIC03OSwzMiArNzMsOSBAQCBGcmFt ZUxvYWRlckNsaWVudEVmbDo6RnJhbWVMb2FkZXJDbGllbnRFZmwoRXZhc19PYmplY3QqIHZpZXcp CiB7CiB9CiAKLXN0YXRpYyBTdHJpbmcgYWdlbnRPUygpCi17Ci0jaWYgT1MoREFSV0lOKQotI2lm IENQVShYODYpCi0gICAgcmV0dXJuICJJbnRlbCBNYWMgT1MgWCI7Ci0jZWxzZQotICAgIHJldHVy biAiUFBDIE1hYyBPUyBYIjsKLSNlbmRpZgotI2VsaWYgT1MoVU5JWCkKLSAgICBzdHJ1Y3QgdXRz bmFtZSBuYW1lOwotICAgIGlmICh1bmFtZSgmbmFtZSkgIT0gLTEpCi0gICAgICAgIHJldHVybiBt YWtlU3RyaW5nKG5hbWUuc3lzbmFtZSwgJyAnLCBuYW1lLm1hY2hpbmUpOwotCi0gICAgcmV0dXJu ICJVbmtub3duIjsKLSNlbGlmIE9TKFdJTkRPV1MpCi0gICAgcmV0dXJuIHdpbmRvd3NWZXJzaW9u Rm9yVUFTdHJpbmcoKTsKLSNlbHNlCi0gICAgbm90SW1wbGVtZW50ZWQoKTsKLSAgICByZXR1cm4g IlVua25vd24iOwotI2VuZGlmCi19Ci0KIHN0YXRpYyBTdHJpbmcgY29tcG9zZVVzZXJBZ2VudCgp CiB7Ci0gICAgU3RyaW5nIHdlYktpdFZlcnNpb24gPSBTdHJpbmc6OmZvcm1hdCgiJWQuJWQiLCBX RUJLSVRfTUFKT1JfVkVSU0lPTiwgV0VCS0lUX01JTk9SX1ZFUlNJT04pOwotICAgIHJldHVybiBt YWtlU3RyaW5nKCJNb3ppbGxhLzUuMCAoIiwgYWdlbnRPUygpLCAiKSBBcHBsZVdlYktpdC8iLCB3 ZWJLaXRWZXJzaW9uLCAiIChLSFRNTCwgbGlrZSBHZWNrbykgU2FmYXJpLyIsIHdlYktpdFZlcnNp b24pOworICAgIHJldHVybiBTdHJpbmcoZXdrX3NldHRpbmdzX2RlZmF1bHRfdXNlcl9hZ2VudF9n ZXQoKSk7CiB9CiAKIHZvaWQgRnJhbWVMb2FkZXJDbGllbnRFZmw6OnNldEN1c3RvbVVzZXJBZ2Vu dChjb25zdCBTdHJpbmcmIGFnZW50KQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9lZmwvZXdr L2V3a19zZXR0aW5ncy5jcHAgYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3NldHRpbmdzLmNw cAppbmRleCAyMWNjNTc1ODg4MTJiZmVmYzNjMWVjMGRkYjMyOTM1NWRjZTEzZDY0Li44MTgxZjZj YzQyZDI0Njk3ZWU4MzBmOTViZjIyYTQ1NDkzMzA2OTE3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0L2VmbC9ld2svZXdrX3NldHRpbmdzLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2sv ZXdrX3NldHRpbmdzLmNwcApAQCAtNDAsMTMgKzQwLDE4IEBACiAjaW5jbHVkZSA8ZWluYV9zYWZl dHlfY2hlY2tzLmg+CiAjaW5jbHVkZSA8ZXJybm8uaD4KICNpbmNsdWRlIDxzdHJpbmcuaD4KLSNp bmNsdWRlIDxzeXMvc3RhdC5oPgotI2luY2x1ZGUgPHN5cy90eXBlcy5oPgotI2luY2x1ZGUgPHN5 cy91dHNuYW1lLmg+CiAjaW5jbHVkZSA8dW5pc3RkLmg+CiAjaW5jbHVkZSA8d3RmL3RleHQvQ1N0 cmluZy5oPgogI2luY2x1ZGUgPHd0Zi90ZXh0L1N0cmluZ0NvbmNhdGVuYXRlLmg+CiAKKyNpZiBP UyhVTklYKQorI2luY2x1ZGUgPHN5cy9zdGF0Lmg+CisjaW5jbHVkZSA8c3lzL3R5cGVzLmg+Cisj aW5jbHVkZSA8c3lzL3V0c25hbWUuaD4KKyNlbGlmIE9TKFdJTkRPV1MpCisjaW5jbHVkZSAiU3lz dGVtSW5mby5oIgorI2VuZGlmCisKIHN0YXRpYyBjb25zdCBjaGFyKiBzX29mZmxpbmVBcHBDYWNo ZVBhdGggPSAwOwogCiBzdGF0aWMgY29uc3QgY2hhciogX2V3a19pY29uX2RhdGFiYXNlX3BhdGgg PSAwOwpAQCAtNjgsMTMgKzczLDI0IEBAIHN0YXRpYyBXVEY6OlN0cmluZyBfZXdrX3NldHRpbmdz X3dlYmtpdF9wbGF0Zm9ybV9nZXQoKQogc3RhdGljIFdURjo6U3RyaW5nIF9ld2tfc2V0dGluZ3Nf d2Via2l0X29zX3ZlcnNpb25fZ2V0KCkKIHsKICAgICBXVEY6OlN0cmluZyB1YU9zVmVyc2lvbjsK KyNpZiBPUyhEQVJXSU4pCisjaWYgQ1BVKFg4NikKKyAgICB1YU9zVmVyc2lvbiA9ICJJbnRlbCBN YWMgT1MgWCI7CisjZWxzZQorICAgIHVhT3NWZXJzaW9uID0gIlBQQyBNYWMgT1MgWCI7CisjZW5k aWYKKyNlbGlmIE9TKFVOSVgpCiAgICAgc3RydWN0IHV0c25hbWUgbmFtZTsKIAogICAgIGlmICh1 bmFtZSgmbmFtZSkgIT0gLTEpCiAgICAgICAgIHVhT3NWZXJzaW9uID0gbWFrZVN0cmluZyhuYW1l LnN5c25hbWUsICcgJywgbmFtZS5tYWNoaW5lKTsKICAgICBlbHNlCiAgICAgICAgIHVhT3NWZXJz aW9uID0gIlVua25vd24iOwotCisjZWxpZiBPUyhXSU5ET1dTKQorICAgIHVhT3NWZXJzaW9uID0g d2luZG93c1ZlcnNpb25Gcm9VQVN0cmluZygpOworI2Vsc2UKKyAgICB1YU9zVmVyc2lvbiA9ICJV bmtub3duIjsKKyNlbmRpZgogICAgIHJldHVybiB1YU9zVmVyc2lvbjsKIH0KIApAQCAtMjUwLDcg KzI2Niw3IEBAIHZvaWQgZXdrX3NldHRpbmdzX3JlcGFpbnRfdGhyb3R0bGluZ19zZXQoZG91Ymxl IGRlZmVycmVkUmVwYWludERlbGF5LCBkb3VibGUgaW5pCiAgKgogICogQHJldHVybiBhIHBvaW50 ZXIgdG8gYW4gZWluYV9zdHJpbmdzaGFyZSBjb250YWluaW5nIHRoZSB1c2VyIGFnZW50IHN0cmlu ZwogICovCi1jb25zdCBjaGFyKiBld2tfc2V0dGluZ3NfZGVmYXVsdF91c2VyX2FnZW50X2dldCh2 b2lkKQorY29uc3QgY2hhciogZXdrX3NldHRpbmdzX2RlZmF1bHRfdXNlcl9hZ2VudF9nZXQoKQog ewogICAgIFdURjo6U3RyaW5nIHVhVmVyc2lvbiA9IG1ha2VTdHJpbmcoU3RyaW5nOjpudW1iZXIo V0VCS0lUX1VTRVJfQUdFTlRfTUFKT1JfVkVSU0lPTiksICcuJywgU3RyaW5nOjpudW1iZXIoV0VC S0lUX1VTRVJfQUdFTlRfTUlOT1JfVkVSU0lPTiksICcrJyk7CiAgICAgV1RGOjpTdHJpbmcgc3Rh dGljVWEgPSBtYWtlU3RyaW5nKCJNb3ppbGxhLzUuMCAoIiwgX2V3a19zZXR0aW5nc193ZWJraXRf cGxhdGZvcm1fZ2V0KCksICI7ICIsIF9ld2tfc2V0dGluZ3Nfd2Via2l0X29zX3ZlcnNpb25fZ2V0 KCksICIpIEFwcGxlV2ViS2l0LyIsIHVhVmVyc2lvbikgKyBtYWtlU3RyaW5nKCIgKEtIVE1MLCBs aWtlIEdlY2tvKSBWZXJzaW9uLzUuMCBTYWZhcmkvIiwgdWFWZXJzaW9uKTsK