73102 2011-11-24 17:09:57 -0800 Implement CSSPropertyTextAlign in CSSStyleApplyProperty. 2011-11-27 22:19:33 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 macpherson macpherson eric kling koivisto macpherson webkit.review.bot oldest_to_newest 508918 0 macpherson 2011-11-24 17:09:57 -0800 Implement CSSPropertyTextAlign in CSSStyleApplyProperty. 508920 1 116553 macpherson 2011-11-24 17:21:08 -0800 Created attachment 116553 Patch 509194 2 116553 kling 2011-11-25 08:56:17 -0800 Comment on attachment 116553 Patch r=me 509564 3 116553 webkit.review.bot 2011-11-27 22:19:28 -0800 Comment on attachment 116553 Patch Clearing flags on attachment: 116553 Committed r101221: <http://trac.webkit.org/changeset/101221> 509565 4 webkit.review.bot 2011-11-27 22:19:33 -0800 All reviewed patches have been landed. Closing bug. 116553 2011-11-24 17:21:08 -0800 2011-11-27 22:19:28 -0800 Patch bug-73102-20111125122105.patch text/plain 5022 macpherson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwMTE0NikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDExLTExLTI0ICBMdWtlIE1h Y3BoZXJzb24gICA8bWFjcGhlcnNvbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgSW1wbGVtZW50 IENTU1Byb3BlcnR5VGV4dEFsaWduIGluIENTU1N0eWxlQXBwbHlQcm9wZXJ0eS4KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTczMTAyCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ292ZXJlZCBieSBmYXN0L2Nz cy90ZXh0LWFsaWduKi5odG1sCisKKyAgICAgICAgKiBjc3MvQ1NTU3R5bGVBcHBseVByb3BlcnR5 LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkFwcGx5UHJvcGVydHlUZXh0QWxpZ246OmFwcGx5VmFs dWUpOgorICAgICAgICAoV2ViQ29yZTo6QXBwbHlQcm9wZXJ0eVRleHRBbGlnbjo6Y3JlYXRlSGFu ZGxlcik6CisgICAgICAgIChXZWJDb3JlOjpDU1NTdHlsZUFwcGx5UHJvcGVydHk6OkNTU1N0eWxl QXBwbHlQcm9wZXJ0eSk6CisgICAgICAgICogY3NzL0NTU1N0eWxlU2VsZWN0b3IuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6Q1NTU3R5bGVTZWxlY3Rvcjo6YXBwbHlQcm9wZXJ0eSk6CisKIDIwMTEt MTEtMjQgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+CiAKICAgICAgICAg W0NNYWtlXSBCdWlsZCBmaXggZm9yIE5PVCBFTkFCTEVfV0VCX1NPQ0tFVFMuCkluZGV4OiBTb3Vy Y2UvV2ViQ29yZS9jc3MvQ1NTU3R5bGVBcHBseVByb3BlcnR5LmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViQ29yZS9jc3MvQ1NTU3R5bGVBcHBseVByb3BlcnR5LmNwcAkocmV2aXNpb24gMTAx MTQ2KQorKysgU291cmNlL1dlYkNvcmUvY3NzL0NTU1N0eWxlQXBwbHlQcm9wZXJ0eS5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTY3Myw2ICs2NzMsMzEgQEAgcHVibGljOgogICAgIHN0YXRpYyBQcm9w ZXJ0eUhhbmRsZXIgY3JlYXRlSGFuZGxlcigpIHsgcmV0dXJuIFByb3BlcnR5SGFuZGxlcigmYXBw bHlJbmhlcml0VmFsdWUsICZhcHBseUluaXRpYWxWYWx1ZSwgJmFwcGx5VmFsdWUpOyB9CiB9Owog CitjbGFzcyBBcHBseVByb3BlcnR5VGV4dEFsaWduIHsKK3B1YmxpYzoKKyAgICBzdGF0aWMgdm9p ZCBhcHBseVZhbHVlKENTU1N0eWxlU2VsZWN0b3IqIHNlbGVjdG9yLCBDU1NWYWx1ZSogdmFsdWUp CisgICAgeworICAgICAgICBpZiAoIXZhbHVlLT5pc1ByaW1pdGl2ZVZhbHVlKCkpCisgICAgICAg ICAgICByZXR1cm47CisKKyAgICAgICAgQ1NTUHJpbWl0aXZlVmFsdWUqIHByaW1pdGl2ZVZhbHVl ID0gc3RhdGljX2Nhc3Q8Q1NTUHJpbWl0aXZlVmFsdWUqPih2YWx1ZSk7CisKKyAgICAgICAgaWYg KHByaW1pdGl2ZVZhbHVlLT5nZXRJZGVudCgpICE9IENTU1ZhbHVlV2Via2l0TWF0Y2hQYXJlbnQp CisgICAgICAgICAgICBzZWxlY3Rvci0+c3R5bGUoKS0+c2V0VGV4dEFsaWduKCpwcmltaXRpdmVW YWx1ZSk7CisgICAgICAgIGVsc2UgaWYgKHNlbGVjdG9yLT5wYXJlbnRTdHlsZSgpLT50ZXh0QWxp Z24oKSA9PSBUQVNUQVJUKQorICAgICAgICAgICAgc2VsZWN0b3ItPnN0eWxlKCktPnNldFRleHRB bGlnbihzZWxlY3Rvci0+cGFyZW50U3R5bGUoKS0+aXNMZWZ0VG9SaWdodERpcmVjdGlvbigpID8g TEVGVCA6IFJJR0hUKTsKKyAgICAgICAgZWxzZSBpZiAoc2VsZWN0b3ItPnBhcmVudFN0eWxlKCkt PnRleHRBbGlnbigpID09IFRBRU5EKQorICAgICAgICAgICAgc2VsZWN0b3ItPnN0eWxlKCktPnNl dFRleHRBbGlnbihzZWxlY3Rvci0+cGFyZW50U3R5bGUoKS0+aXNMZWZ0VG9SaWdodERpcmVjdGlv bigpID8gUklHSFQgOiBMRUZUKTsKKyAgICAgICAgZWxzZQorICAgICAgICAgICAgc2VsZWN0b3It PnN0eWxlKCktPnNldFRleHRBbGlnbihzZWxlY3Rvci0+cGFyZW50U3R5bGUoKS0+dGV4dEFsaWdu KCkpOworICAgIH0KKyAgICBzdGF0aWMgUHJvcGVydHlIYW5kbGVyIGNyZWF0ZUhhbmRsZXIoKQor ICAgIHsKKyAgICAgICAgUHJvcGVydHlIYW5kbGVyIGhhbmRsZXIgPSBBcHBseVByb3BlcnR5RGVm YXVsdEJhc2U8RVRleHRBbGlnbiwgJlJlbmRlclN0eWxlOjp0ZXh0QWxpZ24sIEVUZXh0QWxpZ24s ICZSZW5kZXJTdHlsZTo6c2V0VGV4dEFsaWduLCBFVGV4dEFsaWduLCAmUmVuZGVyU3R5bGU6Omlu aXRpYWxUZXh0QWxpZ24+OjpjcmVhdGVIYW5kbGVyKCk7CisgICAgICAgIHJldHVybiBQcm9wZXJ0 eUhhbmRsZXIoaGFuZGxlci5pbmhlcml0RnVuY3Rpb24oKSwgaGFuZGxlci5pbml0aWFsRnVuY3Rp b24oKSwgJmFwcGx5VmFsdWUpOworICAgIH0KK307CisKIGNsYXNzIEFwcGx5UHJvcGVydHlUZXh0 RW1waGFzaXNTdHlsZSB7CiBwdWJsaWM6CiAgICAgc3RhdGljIHZvaWQgYXBwbHlJbmhlcml0VmFs dWUoQ1NTU3R5bGVTZWxlY3Rvciogc2VsZWN0b3IpCkBAIC0xMDAwLDYgKzEwMjUsOCBAQCBDU1NT dHlsZUFwcGx5UHJvcGVydHk6OkNTU1N0eWxlQXBwbHlQcm9wCiAgICAgc2V0UHJvcGVydHlIYW5k bGVyKENTU1Byb3BlcnR5V2Via2l0VGV4dE9yaWVudGF0aW9uLCBBcHBseVByb3BlcnR5Rm9udDxU ZXh0T3JpZW50YXRpb24sICZGb250RGVzY3JpcHRpb246OnRleHRPcmllbnRhdGlvbiwgJkZvbnRE ZXNjcmlwdGlvbjo6c2V0VGV4dE9yaWVudGF0aW9uLCBUZXh0T3JpZW50YXRpb25WZXJ0aWNhbFJp Z2h0Pjo6Y3JlYXRlSGFuZGxlcigpKTsKICAgICBzZXRQcm9wZXJ0eUhhbmRsZXIoQ1NTUHJvcGVy dHlGb250V2VpZ2h0LCBBcHBseVByb3BlcnR5Rm9udFdlaWdodDo6Y3JlYXRlSGFuZGxlcigpKTsK IAorICAgIHNldFByb3BlcnR5SGFuZGxlcihDU1NQcm9wZXJ0eVRleHRBbGlnbiwgQXBwbHlQcm9w ZXJ0eVRleHRBbGlnbjo6Y3JlYXRlSGFuZGxlcigpKTsKKwogICAgIHNldFByb3BlcnR5SGFuZGxl cihDU1NQcm9wZXJ0eU91dGxpbmVTdHlsZSwgQXBwbHlQcm9wZXJ0eU91dGxpbmVTdHlsZTo6Y3Jl YXRlSGFuZGxlcigpKTsKICAgICBzZXRQcm9wZXJ0eUhhbmRsZXIoQ1NTUHJvcGVydHlPdXRsaW5l Q29sb3IsIEFwcGx5UHJvcGVydHlDb2xvcjxJbmhlcml0RnJvbVBhcmVudCwgJlJlbmRlclN0eWxl OjpvdXRsaW5lQ29sb3IsICZSZW5kZXJTdHlsZTo6c2V0T3V0bGluZUNvbG9yLCAmUmVuZGVyU3R5 bGU6OnNldFZpc2l0ZWRMaW5rT3V0bGluZUNvbG9yLCAmUmVuZGVyU3R5bGU6OmNvbG9yPjo6Y3Jl YXRlSGFuZGxlcigpKTsKICAgICBzZXRQcm9wZXJ0eUhhbmRsZXIoQ1NTUHJvcGVydHlPdXRsaW5l T2Zmc2V0LCBBcHBseVByb3BlcnR5Q29tcHV0ZUxlbmd0aDxpbnQsICZSZW5kZXJTdHlsZTo6b3V0 bGluZU9mZnNldCwgJlJlbmRlclN0eWxlOjpzZXRPdXRsaW5lT2Zmc2V0LCAmUmVuZGVyU3R5bGU6 OmluaXRpYWxPdXRsaW5lT2Zmc2V0Pjo6Y3JlYXRlSGFuZGxlcigpKTsKSW5kZXg6IFNvdXJjZS9X ZWJDb3JlL2Nzcy9DU1NTdHlsZVNlbGVjdG9yLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9jc3MvQ1NTU3R5bGVTZWxlY3Rvci5jcHAJKHJldmlzaW9uIDEwMTE0NikKKysrIFNvdXJj ZS9XZWJDb3JlL2Nzcy9DU1NTdHlsZVNlbGVjdG9yLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjc4 MSwyNSArMjc4MSw2IEBAIHZvaWQgQ1NTU3R5bGVTZWxlY3Rvcjo6YXBwbHlQcm9wZXJ0eShpbnQK ICAgICAgICAgcmV0dXJuOwogICAgIH0KIAotLy8gc3RyaW5nCi0gICAgY2FzZSBDU1NQcm9wZXJ0 eVRleHRBbGlnbjoKLSAgICB7Ci0gICAgICAgIEhBTkRMRV9JTkhFUklUX0FORF9JTklUSUFMKHRl eHRBbGlnbiwgVGV4dEFsaWduKQotICAgICAgICBpZiAoIXByaW1pdGl2ZVZhbHVlKQotICAgICAg ICAgICAgcmV0dXJuOwotICAgICAgICBpZiAocHJpbWl0aXZlVmFsdWUtPmdldElkZW50KCkgPT0g Q1NTVmFsdWVXZWJraXRNYXRjaFBhcmVudCkgewotICAgICAgICAgICAgaWYgKG1fcGFyZW50U3R5 bGUtPnRleHRBbGlnbigpID09IFRBU1RBUlQpCi0gICAgICAgICAgICAgICAgbV9zdHlsZS0+c2V0 VGV4dEFsaWduKG1fcGFyZW50U3R5bGUtPmlzTGVmdFRvUmlnaHREaXJlY3Rpb24oKSA/IExFRlQg OiBSSUdIVCk7Ci0gICAgICAgICAgICBlbHNlIGlmIChtX3BhcmVudFN0eWxlLT50ZXh0QWxpZ24o KSA9PSBUQUVORCkKLSAgICAgICAgICAgICAgICBtX3N0eWxlLT5zZXRUZXh0QWxpZ24obV9wYXJl bnRTdHlsZS0+aXNMZWZ0VG9SaWdodERpcmVjdGlvbigpID8gUklHSFQgOiBMRUZUKTsKLSAgICAg ICAgICAgIGVsc2UKLSAgICAgICAgICAgICAgICBtX3N0eWxlLT5zZXRUZXh0QWxpZ24obV9wYXJl bnRTdHlsZS0+dGV4dEFsaWduKCkpOwotICAgICAgICAgICAgcmV0dXJuOwotICAgICAgICB9Ci0g ICAgICAgIG1fc3R5bGUtPnNldFRleHRBbGlnbigqcHJpbWl0aXZlVmFsdWUpOwotICAgICAgICBy ZXR1cm47Ci0gICAgfQotCiAvLyByZWN0CiAgICAgY2FzZSBDU1NQcm9wZXJ0eUNsaXA6CiAgICAg ewpAQCAtNDAyNCw2ICs0MDA1LDcgQEAgdm9pZCBDU1NTdHlsZVNlbGVjdG9yOjphcHBseVByb3Bl cnR5KGludAogICAgIGNhc2UgQ1NTUHJvcGVydHlQYWRkaW5nQm90dG9tOgogICAgIGNhc2UgQ1NT UHJvcGVydHlQYWRkaW5nTGVmdDoKICAgICBjYXNlIENTU1Byb3BlcnR5UGFkZGluZzoKKyAgICBj YXNlIENTU1Byb3BlcnR5VGV4dEFsaWduOgogICAgIGNhc2UgQ1NTUHJvcGVydHlUZXh0SW5kZW50 OgogICAgIGNhc2UgQ1NTUHJvcGVydHlNYXhIZWlnaHQ6CiAgICAgY2FzZSBDU1NQcm9wZXJ0eUhl aWdodDoK