73085 2011-11-24 09:51:14 -0800 [chromium] composited layers are not invalidated correctly with a zoom-in page scale factor 2012-10-17 12:56:31 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED WORKSFORME P2 Normal --- 66687 1 klobag klobag abarth cc-bugs fsamuel hclam husky jamesr peter skyostil skyostil webkit.review.bot oldest_to_newest 508823 0 klobag 2011-11-24 09:51:14 -0800 This is the side effect of https://bugs.webkit.org/show_bug.cgi?id=71225. When page scale factor is greater than one, the invalidation area is not scale correctly. This caused some area are not updated correct when it needs. 511226 1 117074 klobag 2011-11-29 17:00:11 -0800 Created attachment 117074 Patch 511228 2 117074 jamesr 2011-11-29 17:02:46 -0800 Comment on attachment 117074 Patch Need a test! 672329 3 117074 danakj 2012-07-18 06:44:57 -0700 Comment on attachment 117074 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=117074&action=review > Source/WebCore/platform/graphics/chromium/GraphicsLayerChromium.cpp:684 > - return pageScaleFactor() * deviceScaleFactor(); > + return pageScaleFactor(); This is going to break ChromeOS, where pageScaleFactor is 1 but deviceScaleFactor is not (see NonCompositedContentHost.h) 672332 4 117074 danakj 2012-07-18 06:46:16 -0700 Comment on attachment 117074 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=117074&action=review >> Source/WebCore/platform/graphics/chromium/GraphicsLayerChromium.cpp:684 >> + return pageScaleFactor(); > > This is going to break ChromeOS, where pageScaleFactor is 1 but deviceScaleFactor is not (see NonCompositedContentHost.h) Also, note that deviceScaleFactor() would be 1 on non-ChromeOS already (see WebViewImpl.cpp:3685) 672335 5 skyostil 2012-07-18 06:52:38 -0700 I wonder if this is related: https://bugs.webkit.org/show_bug.cgi?id=88762 744518 6 abarth 2012-10-17 12:56:31 -0700 This patch appears to no longer be needed. 117074 2011-11-29 17:00:11 -0800 2012-07-18 06:46:16 -0700 Patch bug-73085-20111129170010.patch text/plain 5229 klobag U3VidmVyc2lvbiBSZXZpc2lvbjogMTAxNDA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTU5ODgwMGEyOWFkMjI5 YjNkYWZjODRhNzdiNmQ4ZTJiZjgyMTlhYi4uZTI4OTU3ZjgyMmVlNGQ1NWI3NmY1MjNhMmQ3M2Y4 MjFlYmViMjg1MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDExLTExLTI5ICBHcmFj ZSBLbG9iYSAgPGtsb2JhZ0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVtXSBjb21w b3NpdGVkIGxheWVycyBhcmUgbm90IGludmFsaWRhdGVkIGNvcnJlY3RseSB3aXRoIGEgem9vbS1p biBwYWdlIHNjYWxlIGZhY3RvcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NzMwODUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBUaGlzIGlzIGEgZm9sbG93IHVwIGZvciBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NzEyMjUuIFNpbWlsYXIgYXMgY29udGVudEJvdW5kcywgdGhlIGRp cnR5UmVjdAorICAgICAgICBuZWVkcyB0byBiZSBhZGp1c3RlZCB3aXRoIHRoZSBjb250ZW50c1Nj YWxlLiBBbmQgY29udGVudHNTY2FsZSBzaG91bGQganVzdCByZXR1cm4gcGFnZSBzY2FsZSBmYWN0 b3IgYXMgZGV2aWNlCisgICAgICAgIHNjYWxlIGZhY3RvciBpcyBhbHJlYWR5IGluY2x1ZGVkIGlu IHRoZSBwYWdlIHNjYWxlIGZhY3Rvci4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2No cm9taXVtL0NvbnRlbnRMYXllckNocm9taXVtLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNvbnRl bnRMYXllckNocm9taXVtOjpwYWludENvbnRlbnRzSWZEaXJ0eSk6CisgICAgICAgICogcGxhdGZv cm0vZ3JhcGhpY3MvY2hyb21pdW0vR3JhcGhpY3NMYXllckNocm9taXVtLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OkdyYXBoaWNzTGF5ZXJDaHJvbWl1bTo6Y29udGVudHNTY2FsZSk6CisgICAgICAg ICogcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vTGF5ZXJDaHJvbWl1bS5oOgorICAgICAgICAo V2ViQ29yZTo6TGF5ZXJDaHJvbWl1bTo6ZGlydHlSZWN0KToKKyAgICAgICAgKiBwbGF0Zm9ybS9n cmFwaGljcy9jaHJvbWl1bS9UaWxlZExheWVyQ2hyb21pdW0uY3BwOgorICAgICAgICAoV2ViQ29y ZTo6VGlsZWRMYXllckNocm9taXVtOjpkaXJ0eVJlY3QpOgorICAgICAgICAqIHBsYXRmb3JtL2dy YXBoaWNzL2Nocm9taXVtL1RpbGVkTGF5ZXJDaHJvbWl1bS5oOgorCiAyMDExLTExLTI4ICBSeW9z dWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIENyYXNoIGluIElzb2xhdGVU cmFja2VyOjphZGRGYWtlUnVuSWZOZWNlc3NhcnkoKSwgcHJlY2VkZWQgYnkgYXNzZXJ0aW9uIGZh aWx1cmUgKG1fbmVzdGVkSXNvbGF0ZUNvdW50ID49IDEpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9Db250ZW50TGF5ZXJDaHJvbWl1bS5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9Db250ZW50TGF5ZXJD aHJvbWl1bS5jcHAKaW5kZXggOWViMWQ3OTlmNmQ5MWVjZWM2Nzk4MTA2ZWM2MDI3YmI0MWU1MjUy MC4uNzVkNDJhNTIyYjZhMDk1ZTZhNzcxYmE5MTVkNjIwMzVkM2VmYjRiOSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vQ29udGVudExheWVyQ2hy b21pdW0uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVt L0NvbnRlbnRMYXllckNocm9taXVtLmNwcApAQCAtMTAzLDcgKzEwMyw3IEBAIHZvaWQgQ29udGVu dExheWVyQ2hyb21pdW06OnBhaW50Q29udGVudHNJZkRpcnR5KCkKICAgICBpZiAoZHJhd3NDb250 ZW50KCkpCiAgICAgICAgIGxheWVyUmVjdCA9IHZpc2libGVMYXllclJlY3QoKTsKIAotICAgIElu dFJlY3QgZGlydHkgPSBlbmNsb3NpbmdJbnRSZWN0KG1fZGlydHlSZWN0KTsKKyAgICBJbnRSZWN0 IGRpcnR5ID0gZW5jbG9zaW5nSW50UmVjdChkaXJ0eVJlY3QoKSk7CiAgICAgZGlydHkuaW50ZXJz ZWN0KEludFJlY3QoSW50UG9pbnQoKSwgY29udGVudEJvdW5kcygpKSk7CiAgICAgaW52YWxpZGF0 ZVJlY3QoZGlydHkpOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9jaHJvbWl1bS9HcmFwaGljc0xheWVyQ2hyb21pdW0uY3BwIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vR3JhcGhpY3NMYXllckNocm9taXVtLmNwcAppbmRl eCA0YmVhYTUyNTVjYTYyODgzOWZhNDdiYWQ2NWU2MTRiNmZjNTUxNzU4Li5mNzIyYmVhMTQzZTg1 MzAwOTdmZTRkMjVlNzMxOTFkMWNlN2FiYjAwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9HcmFwaGljc0xheWVyQ2hyb21pdW0uY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0dyYXBoaWNzTGF5ZXJD aHJvbWl1bS5jcHAKQEAgLTY4MSw3ICs2ODEsNyBAQCB2b2lkIEdyYXBoaWNzTGF5ZXJDaHJvbWl1 bTo6c2V0dXBDb250ZW50c0xheWVyKExheWVyQ2hyb21pdW0qIGNvbnRlbnRzTGF5ZXIpCiBmbG9h dCBHcmFwaGljc0xheWVyQ2hyb21pdW06OmNvbnRlbnRzU2NhbGUoKSBjb25zdAogewogICAgIGlm ICghYXBwbGllc1BhZ2VTY2FsZSgpKQotICAgICAgICByZXR1cm4gcGFnZVNjYWxlRmFjdG9yKCkg KiBkZXZpY2VTY2FsZUZhY3RvcigpOworICAgICAgICByZXR1cm4gcGFnZVNjYWxlRmFjdG9yKCk7 CiAgICAgcmV0dXJuIDE7CiB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2Nocm9taXVtL0xheWVyQ2hyb21pdW0uaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2Nocm9taXVtL0xheWVyQ2hyb21pdW0uaAppbmRleCA3MTNkZmIyNTIzMDEw ODZmZmE3ZTU4MWMwNDIwNDc1ZThiZGZmYjdkLi5jNGY3NDc3YTBiZTYzZmY3MjU4MzdmNDQ3OGQx YzMxYTk3MjE1YWE0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9jaHJvbWl1bS9MYXllckNocm9taXVtLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvY2hyb21pdW0vTGF5ZXJDaHJvbWl1bS5oCkBAIC0xMDcsNyArMTA3LDcgQEAgcHVi bGljOgogCiAgICAgdm9pZCBzZXROZWVkc0Rpc3BsYXkoY29uc3QgRmxvYXRSZWN0JiBkaXJ0eVJl Y3QpOwogICAgIHZvaWQgc2V0TmVlZHNEaXNwbGF5KCk7Ci0gICAgY29uc3QgRmxvYXRSZWN0JiBk aXJ0eVJlY3QoKSBjb25zdCB7IHJldHVybiBtX2RpcnR5UmVjdDsgfQorICAgIHZpcnR1YWwgRmxv YXRSZWN0IGRpcnR5UmVjdCgpIGNvbnN0IHsgcmV0dXJuIG1fZGlydHlSZWN0OyB9CiAgICAgdm9p ZCByZXNldE5lZWRzRGlzcGxheSgpOwogCiAgICAgdm9pZCBzZXRPcGFjaXR5KGZsb2F0IG9wYWNp dHkpIHsgbV9vcGFjaXR5ID0gb3BhY2l0eTsgc2V0TmVlZHNDb21taXQoKTsgfQpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vVGlsZWRMYXllckNo cm9taXVtLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL1Rp bGVkTGF5ZXJDaHJvbWl1bS5jcHAKaW5kZXggZmZhZDJmNWIxNzVjOTY2NWQ2NjU3NWJhZmNjMzli ZmNlZTBlMWU2YS4uMzZhOTVhNTczNTE3ZTNlMzBkMmRjNzViZjQzZmEyYjJjMzkzZTVjMCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vVGlsZWRM YXllckNocm9taXVtLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9j aHJvbWl1bS9UaWxlZExheWVyQ2hyb21pdW0uY3BwCkBAIC0xNTAsNiArMTUwLDE0IEBAIEludFNp emUgVGlsZWRMYXllckNocm9taXVtOjpjb250ZW50Qm91bmRzKCkgY29uc3QKICAgICByZXR1cm4g SW50U2l6ZShscm91bmRmKGJvdW5kcygpLndpZHRoKCkgKiBjb250ZW50c1NjYWxlKCkpLCBscm91 bmRmKGJvdW5kcygpLmhlaWdodCgpICogY29udGVudHNTY2FsZSgpKSk7CiB9CiAKK0Zsb2F0UmVj dCBUaWxlZExheWVyQ2hyb21pdW06OmRpcnR5UmVjdCgpIGNvbnN0Cit7CisgICAgLy8gVE9ETzog Y29uc2lkZXIgdG8gYWRqdXN0IHRoZSBwYWdlU2NhbGVGYWN0b3IgaW4gdGhlIExheWVyQ2hyb21p dW0gaW4gdGhlIGZ1dHVyZS4KKyAgICBGbG9hdFJlY3QgZGlydHlSZWN0ID0gbV9kaXJ0eVJlY3Q7 CisgICAgZGlydHlSZWN0LnNjYWxlKGNvbnRlbnRzU2NhbGUoKSk7CisgICAgcmV0dXJuIGRpcnR5 UmVjdDsKK30KKwogdm9pZCBUaWxlZExheWVyQ2hyb21pdW06OnNldExheWVyVHJlZUhvc3QoQ0NM YXllclRyZWVIb3N0KiBob3N0KQogewogICAgIExheWVyQ2hyb21pdW06OnNldExheWVyVHJlZUhv c3QoaG9zdCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9j aHJvbWl1bS9UaWxlZExheWVyQ2hyb21pdW0uaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2Nocm9taXVtL1RpbGVkTGF5ZXJDaHJvbWl1bS5oCmluZGV4IDM2M2RhNjE4NTgwMmVl ZGM3NGY1MTUyYWU0OWYzODdjOTJkYzBmOGUuLjQ2ODBhNDczNWZhOTFkYzZjNDA5MzZkNzAyYjg2 Y2Q3ZTk4NmQzMWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2Nocm9taXVtL1RpbGVkTGF5ZXJDaHJvbWl1bS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2Nocm9taXVtL1RpbGVkTGF5ZXJDaHJvbWl1bS5oCkBAIC01Miw2ICs1Miw3 IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIGJvb2wgbmVlZHNDb250ZW50c1NjYWxlKCkgY29uc3Q7 CiAKICAgICB2aXJ0dWFsIEludFNpemUgY29udGVudEJvdW5kcygpIGNvbnN0OworICAgIHZpcnR1 YWwgRmxvYXRSZWN0IGRpcnR5UmVjdCgpIGNvbnN0OwogCiAgICAgLy8gUmVzZXJ2ZXMgYWxsIGV4 aXN0aW5nIGFuZCB2YWxpZCB0aWxlIHRleHR1cmVzIHRvIHByb3RlY3QgdGhlbSBmcm9tIGJlaW5n CiAgICAgLy8gcmVjeWNsZWQgYnkgdGhlIHRleHR1cmUgbWFuYWdlci4K