73080 2011-11-24 07:17:45 -0800 [GTK] WebAudio wav resources access and management 2011-12-01 02:48:56 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 61355 1 pnormand webkit-unassigned donggwan.kim mrobinson oldest_to_newest 508767 0 pnormand 2011-11-24 07:17:45 -0800 We need to dist the platform/audio/resources and add a case in the GTK AudioBus implementation for accessing those in the uninstalled case. 509051 1 116585 pnormand 2011-11-25 02:21:55 -0800 Created attachment 116585 proposed patch 512069 2 116585 mrobinson 2011-11-30 13:27:02 -0800 Comment on attachment 116585 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=116585&action=review > Source/WebCore/platform/audio/gtk/AudioBusGtk.cpp:41 > + absoluteFilename.set(g_build_filename(UNINSTALLED_AUDIO_RESOURCES_DIR, filename.get(), NULL)); Maybe it's better to pass this as an environment variable similar to what we do for other variables like this. 512088 3 116585 pnormand 2011-11-30 13:44:39 -0800 Comment on attachment 116585 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=116585&action=review >> Source/WebCore/platform/audio/gtk/AudioBusGtk.cpp:41 >> + absoluteFilename.set(g_build_filename(UNINSTALLED_AUDIO_RESOURCES_DIR, filename.get(), NULL)); > > Maybe it's better to pass this as an environment variable similar to what we do for other variables like this. Hum I grepped around for getenv and failed to encounter such similar situation. That env var would be set by run-launcher? 512093 4 mrobinson 2011-11-30 13:46:39 -0800 They are typically in WebKit. One example is WEBKIT_INSPECTOR_PATH. 512658 5 pnormand 2011-12-01 02:48:56 -0800 Committed r101644: <http://trac.webkit.org/changeset/101644> 116585 2011-11-25 02:21:55 -0800 2011-11-30 13:44:39 -0800 proposed patch proposed-patch.patch text/plain 3544 pnormand RnJvbSA4NmQ5MjNhYjcyM2YwNmE3ZjE1YTg2MzgxMzNlOGNkYmFlYWIwZDM2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBUdWUsIDExIE9jdCAyMDExIDE0OjUwOjAwICswMjAwClN1YmplY3Q6IFtQQVRDSF0g cHJvcG9zZWQgcGF0Y2gKCi0tLQogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAg ICAgICAgICAgICAgICB8ICAgMTMgKysrKysrKysrKysrKwogU291cmNlL1dlYkNvcmUvR05VbWFr ZWZpbGUuYW0gICAgICAgICAgICAgICAgICAgICB8ICAgMTAgKysrKysrKysrLQogU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vYXVkaW8vZ3RrL0F1ZGlvQnVzR3RrLmNwcCB8ICAgIDYgKysrKysrCiAz IGZpbGVzIGNoYW5nZWQsIDI4IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb25zKC0pCgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9n CmluZGV4IGJjNjdkMjkuLmM5N2ZhMDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAx MS0xMS0yNSAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+CisKKyAgICAg ICAgW0dUS10gV2ViQXVkaW8gd2F2IHJlc291cmNlcyBhY2Nlc3MgYW5kIG1hbmFnZW1lbnQKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTczMDgwCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBHTlVtYWtlZmls ZS5hbTogSW5zdGFsbCBXQVYgcmVzb3VyY2VzIGFuZCBkZWZpbmUgYSBtYWNybyBmb3IKKyAgICAg ICAgYWNjZXNzIHRvIHVuaW5zdGFsbGVkIHJlc291cmNlcy4KKyAgICAgICAgKiBwbGF0Zm9ybS9h dWRpby9ndGsvQXVkaW9CdXNHdGsuY3BwOgorICAgICAgICAoV2ViQ29yZTo6QXVkaW9CdXM6Omxv YWRQbGF0Zm9ybVJlc291cmNlKTogU3VwcG9ydCBmb3IgbG9hZGluZworICAgICAgICB1bmluc3Rh bGxlZCByZXNvdXJjZXMuCisKIDIwMTEtMTAtMjcgIFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9ybWFu ZEBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHU3RyZWFtZXJdIFdlYkF1ZGlvIEF1ZGlvRGVzdGlu YXRpb24KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0dOVW1ha2VmaWxlLmFtIGIvU291cmNl L1dlYkNvcmUvR05VbWFrZWZpbGUuYW0KaW5kZXggNWEwZjBmOC4uZjAwY2VmNSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvR05VbWFrZWZpbGUuYW0KKysrIGIvU291cmNlL1dlYkNvcmUvR05V bWFrZWZpbGUuYW0KQEAgLTUwMCw3ICs1MDAsOCBAQCBEZXJpdmVkU291cmNlcy9XZWJDb3JlL1hM aW5rTmFtZXMuY3BwIDogJChXZWJDb3JlKS9kb20vbWFrZV9uYW1lcy5wbCAkKFdlYkNvcmUpLwog IyAtLS0tCiBpZiBFTkFCTEVfV0VCX0FVRElPCiBGRUFUVVJFX0RFRklORVMgKz0gRU5BQkxFX1dF Ql9BVURJTz0xCi13ZWJjb3JlX2NwcGZsYWdzICs9IC1ERU5BQkxFX1dFQl9BVURJTz0xCit3ZWJj b3JlX2NwcGZsYWdzICs9IC1ERU5BQkxFX1dFQl9BVURJTz0xIFwKKwktRFVOSU5TVEFMTEVEX0FV RElPX1JFU09VUkNFU19ESVI9XCIkKHNoZWxsIHB3ZCkvJHt0b3Bfc3JjZGlyfS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9hdWRpby9yZXNvdXJjZXNcIgogCiBpZiBVU0VfV0VCQVVESU9fRkZUVwog RkVBVFVSRV9ERUZJTkVTICs9IFdURl9VU0VfV0VCQVVESU9fRkZUVz0xCkBAIC03MTMsNiArNzE0 LDEzIEBAIERlcml2ZWRTb3VyY2VzL1dlYkNvcmUvSW5zcGVjdG9yQmFja2VuZERpc3BhdGNoZXIu aDogRGVyaXZlZFNvdXJjZXMvV2ViQ29yZS9JbnNwCiBEZXJpdmVkU291cmNlcy9XZWJDb3JlL0lu amVjdGVkU2NyaXB0U291cmNlLmg6ICQoV2ViQ29yZSkvaW5zcGVjdG9yL0luamVjdGVkU2NyaXB0 U291cmNlLmpzCiAJcGVybCAkKFdlYkNvcmUpL2luc3BlY3Rvci94eGQucGwgSW5qZWN0ZWRTY3Jp cHRTb3VyY2VfanMgJChXZWJDb3JlKS9pbnNwZWN0b3IvSW5qZWN0ZWRTY3JpcHRTb3VyY2UuanMg JChHRU5TT1VSQ0VTX1dFQkNPUkUpL0luamVjdGVkU2NyaXB0U291cmNlLmgKIAoraWYgRU5BQkxF X1dFQl9BVURJTworIyBJbnN0YWxsaW5nIEhSVEYgZGF0YWJhc2Ugd2F2IGZpbGVzCithdWRpb2Rp ciA9ICR7ZGF0YWRpcn0vd2Via2l0Z3RrLUBXRUJLSVRHVEtfQVBJX1ZFUlNJT05AL3Jlc291cmNl cy9hdWRpby8KK2F1ZGlvX0RBVEEgPSAkKFdlYkNvcmUpL3BsYXRmb3JtL2F1ZGlvL3Jlc291cmNl cy9Db21wb3NpdGUud2F2CitkaXN0X2F1ZGlvX0RBVEEgPSAkKGF1ZGlvX0RBVEEpCitlbmRpZiAg IyBFTkQgRU5BQkxFX1dFQl9BVURJTworCiAjIEFOR0xFIHRva2VuaXplciAmIHBhcnNlcgogRGVy aXZlZFNvdXJjZXMvQU5HTEUvZ2xzbGFuZy5jcHA6IFNvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL3Ny Yy9jb21waWxlci9nbHNsYW5nLmwKIAkkKEFNX1ZfR0VOKSQoRkxFWCkgLS1ub2xpbmUgLS1ub3Vu aXN0ZCAtLW91dGZpbGU9IiRAIiAiJDwiCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9hdWRpby9ndGsvQXVkaW9CdXNHdGsuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v YXVkaW8vZ3RrL0F1ZGlvQnVzR3RrLmNwcAppbmRleCAxYjA5ZTk4Li5lMTg0NTljIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9ndGsvQXVkaW9CdXNHdGsuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlvL2d0ay9BdWRpb0J1c0d0ay5jcHAKQEAg LTM0LDYgKzM0LDEyIEBAIFBhc3NPd25QdHI8QXVkaW9CdXM+IEF1ZGlvQnVzOjpsb2FkUGxhdGZv cm1SZXNvdXJjZShjb25zdCBjaGFyKiBuYW1lLCBmbG9hdCBzYW1wCiB7CiAgICAgR093blB0cjxn Y2hhcj4gZmlsZW5hbWUoZ19zdHJkdXBfcHJpbnRmKCIlcy53YXYiLCBuYW1lKSk7CiAgICAgR093 blB0cjxnY2hhcj4gYWJzb2x1dGVGaWxlbmFtZShnX2J1aWxkX2ZpbGVuYW1lKERBVEFfRElSLCAi d2Via2l0Z3RrLSJXRUJLSVRHVEtfQVBJX1ZFUlNJT05fU1RSSU5HLCAicmVzb3VyY2VzIiwgImF1 ZGlvIiwgZmlsZW5hbWUuZ2V0KCksIE5VTEwpKTsKKworICAgIEdGaWxlKiBmaWxlID0gZ19maWxl X25ld19mb3JfcGF0aChmaWxlbmFtZS5nZXQoKSk7CisgICAgaWYgKCFnX2ZpbGVfcXVlcnlfZXhp c3RzKGZpbGUsIDApKSB7CisgICAgICAgIC8vIFVuaW5zdGFsbGVkIGNhc2UsIGFzc3VtZSB3ZSdy ZSBpbiB0aGUgV2ViS2l0IHJvb3QgZGlyZWN0b3J5LgorICAgICAgICBhYnNvbHV0ZUZpbGVuYW1l LnNldChnX2J1aWxkX2ZpbGVuYW1lKFVOSU5TVEFMTEVEX0FVRElPX1JFU09VUkNFU19ESVIsIGZp bGVuYW1lLmdldCgpLCBOVUxMKSk7CisgICAgfQogICAgIHJldHVybiBjcmVhdGVCdXNGcm9tQXVk aW9GaWxlKGFic29sdXRlRmlsZW5hbWUuZ2V0KCksIGZhbHNlLCBzYW1wbGVSYXRlKTsKIH0KIAot LSAKMS43LjcuMw==