7308 2006-02-16 12:13:45 -0800 DumpRenderTree should be able to load files via HTTP 2006-02-19 01:46:25 -0800 1 1 1 Unclassified WebKit Tools / Tests 420+ Mac OS X 10.4 RESOLVED FIXED P2 Enhancement --- 6197 1 ap webkit-unassigned oldest_to_newest 33035 0 ap 2006-02-16 12:13:45 -0800 This is needed for tests that cannot function without a live HTTP server. 33036 1 6548 ap 2006-02-16 12:15:29 -0800 Created attachment 6548 proposed patch 33064 2 ggaren 2006-02-16 13:56:51 -0800 I thought the goal was to remove HTTP access from run-webkit-tests entirely, to immediately detect tests that incorrectly include non-local resources. 33067 3 ap 2006-02-16 14:31:11 -0800 (In reply to comment #2) I think this is orthogonal - it should hopefully be possible to disable HTTP selectively, only for tests that are loaded from the file system. 33217 4 6548 darin 2006-02-17 19:40:56 -0800 Comment on attachment 6548 proposed patch Seems fine. I was thinking, though, that we might go the other direction and forbid I/O completely inside DumpRenderTree, to avoid tests that accidentally use network resources. r=me 6548 2006-02-16 12:15:29 -0800 2006-02-17 19:40:56 -0800 proposed patch 7308r1_patch.txt text/plain 1946 ap SW5kZXg6IER1bXBSZW5kZXJUcmVlL0R1bXBSZW5kZXJUcmVlLm0KPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gRHVt cFJlbmRlclRyZWUvRHVtcFJlbmRlclRyZWUubQkocmV2aXNpb24gMTI4NDYpCisrKyBEdW1wUmVu ZGVyVHJlZS9EdW1wUmVuZGVyVHJlZS5tCSh3b3JraW5nIGNvcHkpCkBAIC05NCw3ICs5NCw3IEBA CiB9CiBAZW5kCiAKLXN0YXRpYyB2b2lkIGR1bXBSZW5kZXJUcmVlKGNvbnN0IGNoYXIgKmZpbGVu YW1lKTsKK3N0YXRpYyB2b2lkIGR1bXBSZW5kZXJUcmVlKGNvbnN0IGNoYXIgKnBhdGhPclVSTCk7 CiBzdGF0aWMgTlNTdHJpbmcgKm1kNUhhc2hTdHJpbmdGb3JCaXRtYXAoTlNCaXRtYXBJbWFnZVJl cCAqYml0bWFwKTsKIAogc3RhdGljIHZvbGF0aWxlIEJPT0wgZG9uZTsKQEAgLTczMiwxOCArNzMy LDIzIEBAIHN0YXRpYyB2b2lkIGR1bXAodm9pZCkKIAogQGVuZAogCi1zdGF0aWMgdm9pZCBkdW1w UmVuZGVyVHJlZShjb25zdCBjaGFyICpmaWxlbmFtZSkKK3N0YXRpYyB2b2lkIGR1bXBSZW5kZXJU cmVlKGNvbnN0IGNoYXIgKnBhdGhPclVSTCkKIHsKLSAgICBDRlN0cmluZ1JlZiBmaWxlbmFtZVN0 cmluZyA9IENGU3RyaW5nQ3JlYXRlV2l0aENTdHJpbmcoTlVMTCwgZmlsZW5hbWUsIGtDRlN0cmlu Z0VuY29kaW5nVVRGOCk7Ci0gICAgaWYgKCFmaWxlbmFtZVN0cmluZykgeworICAgIENGU3RyaW5n UmVmIHBhdGhPclVSTFN0cmluZyA9IENGU3RyaW5nQ3JlYXRlV2l0aENTdHJpbmcoTlVMTCwgcGF0 aE9yVVJMLCBrQ0ZTdHJpbmdFbmNvZGluZ1VURjgpOworICAgIGlmICghcGF0aE9yVVJMU3RyaW5n KSB7CiAgICAgICAgIGZwcmludGYoc3RkZXJyLCAiY2FuJ3QgcGFyc2UgZmlsZW5hbWUgYXMgVVRG LThcbiIpOwogICAgICAgICByZXR1cm47CiAgICAgfQogCi0gICAgQ0ZVUkxSZWYgVVJMID0gQ0ZV UkxDcmVhdGVXaXRoRmlsZVN5c3RlbVBhdGgoTlVMTCwgZmlsZW5hbWVTdHJpbmcsIGtDRlVSTFBP U0lYUGF0aFN0eWxlLCBGQUxTRSk7CisgICAgQ0ZVUkxSZWYgVVJMOworICAgIGlmIChDRlN0cmlu Z0hhc1ByZWZpeChwYXRoT3JVUkxTdHJpbmcsIENGU1RSKCJodHRwOi8vIikpKQorICAgICAgICBV UkwgPSBDRlVSTENyZWF0ZVdpdGhTdHJpbmcoTlVMTCwgcGF0aE9yVVJMU3RyaW5nLCBOVUxMKTsK KyAgICBlbHNlCisgICAgICAgIFVSTCA9IENGVVJMQ3JlYXRlV2l0aEZpbGVTeXN0ZW1QYXRoKE5V TEwsIHBhdGhPclVSTFN0cmluZywga0NGVVJMUE9TSVhQYXRoU3R5bGUsIEZBTFNFKTsKKyAgICAK ICAgICBpZiAoIVVSTCkgewotICAgICAgICBDRlJlbGVhc2UoZmlsZW5hbWVTdHJpbmcpOwotICAg ICAgICBmcHJpbnRmKHN0ZGVyciwgImNhbid0IHR1cm4gJXMgaW50byBhIENGVVJMXG4iLCBmaWxl bmFtZSk7CisgICAgICAgIENGUmVsZWFzZShwYXRoT3JVUkxTdHJpbmcpOworICAgICAgICBmcHJp bnRmKHN0ZGVyciwgImNhbid0IHR1cm4gJXMgaW50byBhIENGVVJMXG4iLCBwYXRoT3JVUkwpOwog ICAgICAgICByZXR1cm47CiAgICAgfQogCkBAIC03NTQsNyArNzU5LDcgQEAgc3RhdGljIHZvaWQg ZHVtcFJlbmRlclRyZWUoY29uc3QgY2hhciAqZgogICAgIGR1bXBUaXRsZUNoYW5nZXMgPSBOTzsK ICAgICBpZiAoY3VycmVudFRlc3QgIT0gbmlsKQogICAgICAgICBDRlJlbGVhc2UoY3VycmVudFRl c3QpOwotICAgIGN1cnJlbnRUZXN0ID0gKE5TU3RyaW5nICopZmlsZW5hbWVTdHJpbmc7CisgICAg Y3VycmVudFRlc3QgPSAoTlNTdHJpbmcgKilwYXRoT3JVUkxTdHJpbmc7CiAKICAgICBOU0F1dG9y ZWxlYXNlUG9vbCAqcG9vbCA9IFtbTlNBdXRvcmVsZWFzZVBvb2wgYWxsb2NdIGluaXRdOwogICAg IFtmcmFtZSBsb2FkUmVxdWVzdDpbTlNVUkxSZXF1ZXN0IHJlcXVlc3RXaXRoVVJMOihOU1VSTCAq KVVSTF1dOwo=