73065 2011-11-23 18:34:09 -0800 [Chromium] Remove unused WebSecurityOrigin::isEmpty from WebKit API 2011-11-23 23:03:22 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 abarth abarth eric fishd webkit.review.bot oldest_to_newest 508554 0 abarth 2011-11-23 18:34:09 -0800 [Chromium] Remove unused WebSecurityOrigin::isEmpty from WebKit API 508556 1 116465 abarth 2011-11-23 18:34:43 -0800 Created attachment 116465 Patch 508616 2 116465 eric 2011-11-23 21:56:16 -0800 Comment on attachment 116465 Patch LGTM. You may want fishd's approval as well. 508617 3 webkit.review.bot 2011-11-23 21:57:50 -0800 Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API. 508625 4 116465 abarth 2011-11-23 22:09:32 -0800 Comment on attachment 116465 Patch He reviewed the original patch with the FIXME. I'm not that worried about it. 508627 5 eric 2011-11-23 22:19:49 -0800 Oh reviewbot, you're so smart. 508636 6 fishd 2011-11-23 22:57:50 -0800 Yes, R+ 508638 7 116465 webkit.review.bot 2011-11-23 23:03:17 -0800 Comment on attachment 116465 Patch Clearing flags on attachment: 116465 Committed r101121: <http://trac.webkit.org/changeset/101121> 508639 8 webkit.review.bot 2011-11-23 23:03:22 -0800 All reviewed patches have been landed. Closing bug. 116465 2011-11-23 18:34:43 -0800 2011-11-23 23:03:17 -0800 Patch bug-73065-20111123183442.patch text/plain 2091 abarth SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiAxMDExMTUpCisrKyBTb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2 IEBACisyMDExLTExLTIzICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisKKyAgICAg ICAgW0Nocm9taXVtXSBSZW1vdmUgdW51c2VkIFdlYlNlY3VyaXR5T3JpZ2luOjppc0VtcHR5IGZy b20gV2ViS2l0IEFQSQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NzMwNjUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBUaGlzIEFQSSBubyBsb25nZXIgaGFzIGFueSBjYWxsZXJzLgorCisgICAgICAgICogcHVi bGljL1dlYlNlY3VyaXR5T3JpZ2luLmg6CisgICAgICAgICogc3JjL1dlYlNlY3VyaXR5T3JpZ2lu LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViU2VjdXJpdHlPcmlnaW46OmlzVW5pcXVlKToKKwog MjAxMS0xMS0yMyAgQW1pIEZpc2NobWFuICA8ZmlzY2htYW5AY2hyb21pdW0ub3JnPgogCiAgICAg ICAgIFRlYWNoIFZpZGVvTGF5ZXJDaHJvbWl1bSBob3cgdG8gcmVuZGVyIG5hdGl2ZSB0ZXh0dXJl ICh0byBzdXBwb3J0IEhXIHZpZGVvIGRlY29kZSkuCkluZGV4OiBTb3VyY2UvV2ViS2l0L2Nocm9t aXVtL3B1YmxpYy9XZWJTZWN1cml0eU9yaWdpbi5oCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvY2hyb21pdW0vcHVibGljL1dlYlNlY3VyaXR5T3JpZ2luLmgJKHJldmlzaW9uIDEwMTExMykK KysrIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlNlY3VyaXR5T3JpZ2luLmgJKHdv cmtpbmcgY29weSkKQEAgLTcwLDEwICs3MCw3IEBAIHB1YmxpYzoKICAgICBXRUJLSVRfRVhQT1JU IHVuc2lnbmVkIHNob3J0IHBvcnQoKSBjb25zdDsKIAogICAgIC8vIEEgdW5pcXVlIFdlYlNlY3Vy aXR5T3JpZ2luIGlzIHRoZSBsZWFzdCBwcml2aWxlZ2VkIFdlYlNlY3VyaXR5T3JpZ2luLgotICAg IGJvb2wgaXNVbmlxdWUoKSBjb25zdCB7IHJldHVybiBpc0VtcHR5KCk7IH0KLQotICAgIC8vIEZJ WE1FOiBSZW1vdmUgdGhpcyBmdW5jdGlvbiBvbmNlIHRoZXJlIGFyZSBubyBtb3JlIGNhbGxlcnMu Ci0gICAgV0VCS0lUX0VYUE9SVCBib29sIGlzRW1wdHkoKSBjb25zdDsKKyAgICBXRUJLSVRfRVhQ T1JUIGJvb2wgaXNVbmlxdWUoKSBjb25zdDsKIAogICAgIC8vIFJldHVybnMgdHJ1ZSBpZiB0aGlz IFdlYlNlY3VyaXR5T3JpZ2luIGNhbiBzY3JpcHQgb2JqZWN0cyBpbiB0aGUgZ2l2ZW4KICAgICAv LyBTZWN1cml0eU9yaWdpbi4gRm9yIGV4YW1wbGUsIGNhbGwgdGhpcyBmdW5jdGlvbiBiZWZvcmUg YWxsb3dpbmcKSW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlNlY3VyaXR5T3Jp Z2luLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJTZWN1 cml0eU9yaWdpbi5jcHAJKHJldmlzaW9uIDEwMTExMykKKysrIFNvdXJjZS9XZWJLaXQvY2hyb21p dW0vc3JjL1dlYlNlY3VyaXR5T3JpZ2luLmNwcAkod29ya2luZyBjb3B5KQpAQCAtOTAsOCArOTAs NyBAQCB1bnNpZ25lZCBzaG9ydCBXZWJTZWN1cml0eU9yaWdpbjo6cG9ydCgpCiAgICAgcmV0dXJu IG1fcHJpdmF0ZS0+cG9ydCgpOwogfQogCi0vLyBGSVhNRTogUmVuYW1lIHRoaXMgQVBJIHRvIGlz VW5pcXVlLgotYm9vbCBXZWJTZWN1cml0eU9yaWdpbjo6aXNFbXB0eSgpIGNvbnN0Citib29sIFdl YlNlY3VyaXR5T3JpZ2luOjppc1VuaXF1ZSgpIGNvbnN0CiB7CiAgICAgQVNTRVJUKG1fcHJpdmF0 ZSk7CiAgICAgcmV0dXJuIG1fcHJpdmF0ZS0+aXNVbmlxdWUoKTsK