73060 2011-11-23 16:33:36 -0800 Cleanup #if usage in V8GCController 2011-11-23 19:24:45 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rafaelw rafaelw ojan steveblock webkit.review.bot oldest_to_newest 508492 0 rafaelw 2011-11-23 16:33:36 -0800 Multiple patches have left checkMemoryUsage in a silly state 508494 1 116452 rafaelw 2011-11-23 16:35:10 -0800 Created attachment 116452 Patch 508496 2 116452 ojan 2011-11-23 16:38:20 -0800 Comment on attachment 116452 Patch This is fine, but I doubt we need the #if at all. AFAIK, V8GCController is only included by Chromium and QT anyways. 508569 3 116452 webkit.review.bot 2011-11-23 19:24:41 -0800 Comment on attachment 116452 Patch Clearing flags on attachment: 116452 Committed r101117: <http://trac.webkit.org/changeset/101117> 508570 4 webkit.review.bot 2011-11-23 19:24:45 -0800 All reviewed patches have been landed. Closing bug. 116452 2011-11-23 16:35:10 -0800 2011-11-23 19:24:41 -0800 Patch bug-73060-20111123163509.patch text/plain 1734 rafaelw U3VidmVyc2lvbiBSZXZpc2lvbjogMTAxMTAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWM0M2VkOGZmZWNkOWYx YWYwYTI4MzkzNzk0MjY1MzJlM2E1MjgyNy4uYjhhZmE3NDhiNmRiMTRhOGMwNzFkNWNmNjNhZTVj MzI5YTIzZmQ1OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDExLTExLTIzICBSYWZh ZWwgV2VpbnN0ZWluICA8cmFmYWVsd0BjaHJvbWl1bS5vcmc+CiAKKyAgICAgICAgQ2xlYW51cCAj aWYgdXNhZ2UgaW4gVjhHQ0NvbnRyb2xsZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTczMDYwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgT2phbiBWYWZh aS4KKworICAgICAgICBObyB0ZXN0cyBuZWVkZWQuIEp1c3QgY29kZSBjbGVhbnVwCisKKyAgICAg ICAgKiBiaW5kaW5ncy92OC9WOEdDQ29udHJvbGxlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpW OEdDQ29udHJvbGxlcjo6Y2hlY2tNZW1vcnlVc2FnZSk6CisKKzIwMTEtMTEtMjMgIFJhZmFlbCBX ZWluc3RlaW4gIDxyYWZhZWx3QGNocm9taXVtLm9yZz4KKwogICAgICAgICBbTXV0YXRpb25PYnNl cnZlcnNdIE1vZGlmaWNhdGlvbnMgdG8gdGhlIHN0eWxlIHByb3BlcnR5IGRvbid0IGRpc3BhdGNo ICJhdHRyaWJ1dGVzIiBNdXRhdGlvbiBSZWNvcmRzCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MDEzNwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy92OC9WOEdDQ29udHJvbGxlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5n cy92OC9WOEdDQ29udHJvbGxlci5jcHAKaW5kZXggOWI3ZDE0NGRmNzcwYWQ3MTNhMTZiYTk5N2U3 NzAxNGQ2N2Q1ZjViNi4uODI2ZWIzYTk0NTJkNGQwODQwOWE5N2I2YzVhZGIxN2Q3NWE1ZDk2NSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhHQ0NvbnRyb2xsZXIuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4R0NDb250cm9sbGVyLmNwcApAQCAt NTE2LDEzICs1MTYsMTAgQEAgdm9pZCBWOEdDQ29udHJvbGxlcjo6Y2hlY2tNZW1vcnlVc2FnZSgp CiAgICAgY29uc3QgaW50IGxvd01lbW9yeVVzYWdlTUIgPSBQbGF0Zm9ybVN1cHBvcnQ6Omxvd01l bW9yeVVzYWdlTUIoKTsKICAgICBjb25zdCBpbnQgaGlnaE1lbW9yeVVzYWdlTUIgPSBQbGF0Zm9y bVN1cHBvcnQ6OmhpZ2hNZW1vcnlVc2FnZU1CKCk7CiAgICAgY29uc3QgaW50IGhpZ2hVc2FnZURl bHRhTUIgPSBQbGF0Zm9ybVN1cHBvcnQ6OmhpZ2hVc2FnZURlbHRhTUIoKTsKLSNlbHNlCi0gICAg cmV0dXJuOwotI2VuZGlmCi0KICAgICBpbnQgbWVtb3J5VXNhZ2VNQiA9IGdldE1lbW9yeVVzYWdl SW5NQigpOwogICAgIGlmICgobWVtb3J5VXNhZ2VNQiA+IGxvd01lbW9yeVVzYWdlTUIgJiYgbWVt b3J5VXNhZ2VNQiA+IDIgKiB3b3JraW5nU2V0RXN0aW1hdGVNQikgfHwgKG1lbW9yeVVzYWdlTUIg PiBoaWdoTWVtb3J5VXNhZ2VNQiAmJiBtZW1vcnlVc2FnZU1CID4gd29ya2luZ1NldEVzdGltYXRl TUIgKyBoaWdoVXNhZ2VEZWx0YU1CKSkKICAgICAgICAgdjg6OlY4OjpMb3dNZW1vcnlOb3RpZmlj YXRpb24oKTsKKyNlbmRpZgogfQogCiAK