73014 2011-11-23 03:46:21 -0800 [GStreamer] improper usage of gst_object_ref_sink 2011-11-23 07:33:47 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 69835 1 pnormand webkit-unassigned oldest_to_newest 508046 0 pnormand 2011-11-23 03:46:21 -0800 To take ownership of GstObjects we should call gst_object_ref and gst_object_sink. Additionally we should ensure adoptGRef is used only on non-floating GstObjects. 508047 1 116338 pnormand 2011-11-23 03:51:49 -0800 Created attachment 116338 proposed patch 508051 2 116338 mrobinson 2011-11-23 03:59:18 -0800 Comment on attachment 116338 proposed patch Great! 508129 3 pnormand 2011-11-23 07:33:47 -0800 Committed r101082: <http://trac.webkit.org/changeset/101082> 116338 2011-11-23 03:51:49 -0800 2011-11-23 03:59:18 -0800 proposed patch proposed-patch.patch text/plain 3395 pnormand RnJvbSBjNmYxMDFjNTUyNTU1YmRhZTIyMzQwZTI5MWI1MTUzMjE3NmM4ZTMzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBXZWQsIDIzIE5vdiAyMDExIDEyOjUxOjI2ICswMTAwClN1YmplY3Q6IFtQQVRDSF0g cHJvcG9zZWQgcGF0Y2gKCi0tLQogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAg ICAgICAgICAgICAgICAgfCAgIDE2ICsrKysrKysrKysrKwogLi4uL2dyYXBoaWNzL2dzdHJlYW1l ci9HUmVmUHRyR1N0cmVhbWVyLmNwcCAgICAgICAgfCAgIDI1ICsrKysrKysrKysrKysrKystLS0K IC4uLi9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvR1JlZlB0ckdTdHJlYW1lci5oIHwgICAg MiArCiAzIGZpbGVzIGNoYW5nZWQsIDM5IGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0pCgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hh bmdlTG9nCmluZGV4IDQzN2FiMmMuLmVlYzM3NGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBA QAorMjAxMS0xMS0yMyAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+CisK KyAgICAgICAgW0dTdHJlYW1lcl0gaW1wcm9wZXIgdXNhZ2Ugb2YgZ3N0X29iamVjdF9yZWZfc2lu aworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzMwMTQK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcg dGVzdHMuIEV4aXN0aW5nIHRlc3RzIGNvdmVyIHRoaXMgYWxyZWFkeS4KKworICAgICAgICAqIHBs YXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9HUmVmUHRyR1N0cmVhbWVyLmNwcDoKKyAgICAgICAg KFdURjo6YWRvcHRHUmVmKTogRW5zdXJlIHRoaXMgaXMgY2FsbGVkIHdpdGggbm9uLWZsb2F0aW5n IEdzdE9iamVjdHMuCisgICAgICAgIChXVEY6OkdzdEVsZW1lbnQpOiBSZXBsYWNlIGdzdF9vYmpl Y3RfcmVmX3Npbmsgd2l0aAorICAgICAgICBnc3Rfb2JqZWN0X3JlZitnc3Rfb2JqZWN0X3Npbmsg bGlrZSBhZHZpc2VkIGluIHRoZSBHc3RPYmplY3QgZG9jdW1lbnRhdGlvbi4KKyAgICAgICAgKFdU Rjo6R3N0UGFkKTogRGl0dG8uCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVy L0dSZWZQdHJHU3RyZWFtZXIuaDoKKwogMjAxMS0xMS0yMyAgUmF1bCBIdWRlYSAgPHJodWRlYUBh ZG9iZS5jb20+CiAKICAgICAgICAgRmlyc3Qgc3RlcCB0b3dhcmRzIGh0dHA6Ly93ZWJraXQub3Jn L2IvNzAwMjUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dz dHJlYW1lci9HUmVmUHRyR1N0cmVhbWVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2dzdHJlYW1lci9HUmVmUHRyR1N0cmVhbWVyLmNwcAppbmRleCAxOTZlYTQ4Li5hNmIw YTFlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFt ZXIvR1JlZlB0ckdTdHJlYW1lci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvZ3N0cmVhbWVyL0dSZWZQdHJHU3RyZWFtZXIuY3BwCkBAIC0yNSwxMCArMjUsMTkgQEAK IAogbmFtZXNwYWNlIFdURiB7CiAKK3RlbXBsYXRlIDw+IEdSZWZQdHI8R3N0RWxlbWVudD4gYWRv cHRHUmVmKEdzdEVsZW1lbnQqIHB0cikKK3sKKyAgICBBU1NFUlQoIUdTVF9PQkpFQ1RfSVNfRkxP QVRJTkcoR1NUX09CSkVDVChwdHIpKSk7CisgICAgcmV0dXJuIEdSZWZQdHI8R3N0RWxlbWVudD4o cHRyLCBHUmVmUHRyQWRvcHQpOworfQorCiB0ZW1wbGF0ZSA8PiBHc3RFbGVtZW50KiByZWZHUHRy PEdzdEVsZW1lbnQ+KEdzdEVsZW1lbnQqIHB0cikKIHsKLSAgICBpZiAocHRyKQotICAgICAgICBn c3Rfb2JqZWN0X3JlZl9zaW5rKHB0cik7CisgICAgaWYgKHB0cikgeworICAgICAgICBnc3Rfb2Jq ZWN0X3JlZihHU1RfT0JKRUNUKHB0cikpOworICAgICAgICBnc3Rfb2JqZWN0X3NpbmsoR1NUX09C SkVDVChwdHIpKTsKKyAgICB9CisKICAgICByZXR1cm4gcHRyOwogfQogCkBAIC0zOCwxMCArNDcs MTggQEAgdGVtcGxhdGUgPD4gdm9pZCBkZXJlZkdQdHI8R3N0RWxlbWVudD4oR3N0RWxlbWVudCog cHRyKQogICAgICAgICBnc3Rfb2JqZWN0X3VucmVmKHB0cik7CiB9CiAKK3RlbXBsYXRlIDw+IEdS ZWZQdHI8R3N0UGFkPiBhZG9wdEdSZWYoR3N0UGFkKiBwdHIpCit7CisgICAgQVNTRVJUKCFHU1Rf T0JKRUNUX0lTX0ZMT0FUSU5HKEdTVF9PQkpFQ1QocHRyKSkpOworICAgIHJldHVybiBHUmVmUHRy PEdzdFBhZD4ocHRyLCBHUmVmUHRyQWRvcHQpOworfQorCiB0ZW1wbGF0ZSA8PiBHc3RQYWQqIHJl ZkdQdHI8R3N0UGFkPihHc3RQYWQqIHB0cikKIHsKLSAgICBpZiAocHRyKQotICAgICAgICBnc3Rf b2JqZWN0X3JlZl9zaW5rKEdTVF9PQkpFQ1QocHRyKSk7CisgICAgaWYgKHB0cikgeworICAgICAg ICBnc3Rfb2JqZWN0X3JlZihHU1RfT0JKRUNUKHB0cikpOworICAgICAgICBnc3Rfb2JqZWN0X3Np bmsoR1NUX09CSkVDVChwdHIpKTsKKyAgICB9CiAgICAgcmV0dXJuIHB0cjsKIH0KIApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL0dSZWZQdHJH U3RyZWFtZXIuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9H UmVmUHRyR1N0cmVhbWVyLmgKaW5kZXggM2Q0MzEyNy4uNzhlNTExMSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL0dSZWZQdHJHU3RyZWFtZXIu aAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvR1JlZlB0 ckdTdHJlYW1lci5oCkBAIC0yOSw5ICsyOSwxMSBAQCB0eXBlZGVmIHN0cnVjdCBfR3N0Q2FwcyBH c3RDYXBzOwogCiBuYW1lc3BhY2UgV1RGIHsKIAordGVtcGxhdGU8PiBHUmVmUHRyPEdzdEVsZW1l bnQ+IGFkb3B0R1JlZihHc3RFbGVtZW50KiBwdHIpOwogdGVtcGxhdGU8PiBHc3RFbGVtZW50KiBy ZWZHUHRyPEdzdEVsZW1lbnQ+KEdzdEVsZW1lbnQqIHB0cik7CiB0ZW1wbGF0ZTw+IHZvaWQgZGVy ZWZHUHRyPEdzdEVsZW1lbnQ+KEdzdEVsZW1lbnQqIHB0cik7CiAKK3RlbXBsYXRlPD4gR1JlZlB0 cjxHc3RQYWQ+IGFkb3B0R1JlZihHc3RQYWQqIHB0cik7CiB0ZW1wbGF0ZTw+IEdzdFBhZCogcmVm R1B0cjxHc3RQYWQ+KEdzdFBhZCogcHRyKTsKIHRlbXBsYXRlPD4gdm9pZCBkZXJlZkdQdHI8R3N0 UGFkPihHc3RQYWQqIHB0cik7CiAKLS0gCjEuNy43LjM=