73004 2011-11-22 23:10:47 -0800 DRT isn't updating on chromium linux build.webkit.org bot 2011-11-22 23:59:55 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dpranke dpranke adamk koz scottmg thakis tony oldest_to_newest 507951 0 dpranke 2011-11-22 23:10:47 -0800 There appears to be a bug in the Makefile generator for GYP that is causing the chromium linux build on build.webkit.org to not include DRT in the "all" target; the issue seems to be that the DRT target is being resolved two different ways, leading to the DumpRenderTree.target.chromium.mk file getting generated twice; the second time is not pulled in from WebKit.gyp, so it isn't considered to be part of the "all" target. The bug was introduced with the change in chromium r111360 to enable appcache and content to be build as DLLs (this introduced a dependency on WebKit.gyp to the appcache target, causing the problem). 507952 1 116322 dpranke 2011-11-22 23:12:39 -0800 Created attachment 116322 Patch 507953 2 dpranke 2011-11-22 23:13:17 -0800 Committed r101044: <http://trac.webkit.org/changeset/101044> 116322 2011-11-22 23:12:39 -0800 2011-11-22 23:59:55 -0800 Patch bug-73004-20111122231237.patch text/plain 1245 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogMTAxMDQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDQzODNlMjhmN2VlMGU4YmYwNTcwMjVlZGMwZDRiZWU1NGNmZjE2OWMuLmMzNWFlZWVjYzFkYmI4 ZDY1N2NlNWNhZjdlYjc4ODhiNzhhZjRiNmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTEtMTEtMjIgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1 bS5vcmc+CisKKyAgICAgICAgUm9sbCBERVBTIHRvIHIxMTEzMjUgdG8gZml4IGFuIGlzc3VlIHdp dGggdGhlIGxpbnV4IGJ1aWxkCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTczMDA0CisKKyAgICAgICAgVW5yZXZpZXdlZCwgYnVpbGQgZml4LgorCisg ICAgICAgIFRoZXJlIGFwcGVhcnMgdG8gYmUgYSBidWcgaW4gdGhlIE1ha2VmaWxlIGdlbmVyYXRv ciBmb3IgZ3lwCisgICAgICAgIHRoYXQgaXMgY2F1c2luZyBtYWtlIHRvIG5vdCByZWJ1aWxkIERS VCBvbiBMaW51eC4KKworICAgICAgICAqIERFUFM6CisKIDIwMTEtMTEtMjIgIEtlbm5ldGggUnVz c2VsbCAgPGtickBnb29nbGUuY29tPgogCiAgICAgICAgIFtjaHJvbWl1bV0gU3VwcG9ydCBDb3Jl IEFuaW1hdGlvbiBwbHVnaW5zIGluIGNvbXBvc2l0b3IKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvY2hyb21pdW0vREVQUyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vREVQUwppbmRleCA3NWZi NDEyNTA3YjRkMDcyNGI4OWFmMjcxY2YwMDA0N2RmZjU0YWNkLi4yODA4ZTNjMzM0MWJiY2EwZmZh MDhiYTFhODc0MzE2M2Y3NjhkZTdmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVt L0RFUFMKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9ERVBTCkBAIC0zMiw3ICszMiw3IEBA CiAKIHZhcnMgPSB7CiAgICdjaHJvbWl1bV9zdm4nOiAnaHR0cDovL3NyYy5jaHJvbWl1bS5vcmcv c3ZuL3RydW5rL3NyYycsCi0gICdjaHJvbWl1bV9yZXYnOiAnMTExMTc4JywKKyAgJ2Nocm9taXVt X3Jldic6ICcxMTEzMjUnLAogICAnbmFjbF9zdm4nOiAnaHR0cDovL3NyYy5jaHJvbWl1bS5vcmcv bmF0aXZlX2NsaWVudC90cnVuaycsCiAgICduYWNsX3Jldic6ICc3MTY5JywKIH0K