72992 2011-11-22 17:03:41 -0800 garden-o-matic should explain more clearly what the builder lists at the top of the page mean 2011-11-23 05:39:10 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 69227 1 abarth abarth dglazkov webkit.review.bot oldest_to_newest 507876 0 abarth 2011-11-22 17:03:41 -0800 garden-o-matic should explain more clearly what the builder lists at the top of the page mean 507877 1 116297 abarth 2011-11-22 17:04:58 -0800 Created attachment 116297 Patch 507885 2 116297 dglazkov 2011-11-22 17:51:01 -0800 Comment on attachment 116297 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=116297&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:334 > + '<div class="problem">Disasterifying:' + Excellent word. Or is it "Disasterrifying"? 508084 3 116297 webkit.review.bot 2011-11-23 05:39:05 -0800 Comment on attachment 116297 Patch Clearing flags on attachment: 116297 Committed r101072: <http://trac.webkit.org/changeset/101072> 508085 4 webkit.review.bot 2011-11-23 05:39:10 -0800 All reviewed patches have been landed. Closing bug. 116297 2011-11-22 17:04:58 -0800 2011-11-23 05:39:05 -0800 Patch bug-72992-20111122170521.patch text/plain 6988 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogMTAxMDI4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNjM5ZDg4NGY1MjkyNjcwMDUzNDU3ZmFjN2FjMDEwMDgy ODY3ZTViYi4uMTI0YzYyNTBiNDAwZDM3M2QwZWI5YzUxOTA4N2U3ZTlkNzMyZWY1ZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIw IEBACiAyMDExLTExLTIyICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKKyAgICAg ICAgZ2FyZGVuLW8tbWF0aWMgc2hvdWxkIGV4cGxhaW4gbW9yZSBjbGVhcmx5IHdoYXQgdGhlIGJ1 aWxkZXIgbGlzdHMgYXQgdGhlIHRvcCBvZiB0aGUgcGFnZSBtZWFuCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03Mjk5MgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgcGF0Y2ggYWxzbyBwcmVwYXJlcyB1 cyB0byBsaXN0IG90aGVyIHNvcnRzIG9mIGZhaWx1cmVzLCBsaWtlCisgICAgICAgIHBlcmZvcm1h bmNlIGFuZCB1bml0IHRlc3QuCisKKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53 ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9UZXN0RmFpbHVyZXMvc2NyaXB0cy9jb250cm9s bGVycy5qczoKKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNv bmZpZy9wdWJsaWNfaHRtbC9UZXN0RmFpbHVyZXMvc2NyaXB0cy9nYXJkZW4tby1tYXRpYy5qczoK KyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJs aWNfaHRtbC9UZXN0RmFpbHVyZXMvc2NyaXB0cy91aS9ub3RpZmljYXRpb25zLmpzOgorICAgICAg ICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1s L1Rlc3RGYWlsdXJlcy9zY3JpcHRzL3VpL25vdGlmaWNhdGlvbnNfdW5pdHRlc3RzLmpzOgorCisy MDExLTExLTIyICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisKICAgICAgICAgZ2Fy ZGVuLW8tbWF0aWMgc2hvdWxkIGRpc3BsYXkgYSBtZXNzYWdlIGlmIGl0IGNhbid0IGZpbmQgcmVz dWx0cyB0byBkaXNwbGF5CiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD03Mjk5MQogCmRpZmYgLS1naXQgYS9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWls ZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9UZXN0RmFpbHVyZXMvc2NyaXB0cy9jb250 cm9sbGVycy5qcyBiL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29u ZmlnL3B1YmxpY19odG1sL1Rlc3RGYWlsdXJlcy9zY3JpcHRzL2NvbnRyb2xsZXJzLmpzCmluZGV4 IDBlOThhMWQzZjlmZTYwYTk4YjM1ZDBlZTY4NjMyYWRiZDAzNDFkMTMuLmUxNjFlYWY2NTU5NDA5 ZWZmYjlmODVkNGZiOTQyMTY2M2FiOTdmMGIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0J1aWxkU2xhdmVT dXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL1Rlc3RGYWlsdXJlcy9z Y3JpcHRzL2NvbnRyb2xsZXJzLmpzCisrKyBiL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxk LndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL1Rlc3RGYWlsdXJlcy9zY3JpcHRzL2NvbnRy b2xsZXJzLmpzCkBAIC0yMzIsOSArMjMyLDEwIEBAIGNvbnRyb2xsZXJzLkZhaWx1cmVzID0gYmFz ZS5leHRlbmRzKEZhaWx1cmVTdHJlYW1Db250cm9sbGVyLCB7CiB9KTsKIAogY29udHJvbGxlcnMu RmFpbGluZ0J1aWxkZXJzID0gYmFzZS5leHRlbmRzKE9iamVjdCwgewotICAgIGluaXQ6IGZ1bmN0 aW9uKHZpZXcpCisgICAgaW5pdDogZnVuY3Rpb24odmlldywgbWVzc2FnZSkKICAgICB7CiAgICAg ICAgIHRoaXMuX3ZpZXcgPSB2aWV3OworICAgICAgICB0aGlzLl9tZXNzYWdlID0gbWVzc2FnZTsK ICAgICAgICAgdGhpcy5fbm90aWZpY2F0aW9uID0gbnVsbDsKICAgICB9LAogICAgIHVwZGF0ZTog ZnVuY3Rpb24oYnVpbGRlck5hbWVMaXN0KQpAQCAtMjQ3LDcgKzI0OCw3IEBAIGNvbnRyb2xsZXJz LkZhaWxpbmdCdWlsZGVycyA9IGJhc2UuZXh0ZW5kcyhPYmplY3QsIHsKICAgICAgICAgICAgIHJl dHVybjsKICAgICAgICAgfQogICAgICAgICBpZiAoIXRoaXMuX25vdGlmaWNhdGlvbikgewotICAg ICAgICAgICAgdGhpcy5fbm90aWZpY2F0aW9uID0gbmV3IHVpLm5vdGlmaWNhdGlvbnMuQnVpbGRl cnNGYWlsaW5nKCk7CisgICAgICAgICAgICB0aGlzLl9ub3RpZmljYXRpb24gPSBuZXcgdWkubm90 aWZpY2F0aW9ucy5CdWlsZGVyc0ZhaWxpbmcodGhpcy5fbWVzc2FnZSk7CiAgICAgICAgICAgICB0 aGlzLl92aWV3LmFkZCh0aGlzLl9ub3RpZmljYXRpb24pOwogICAgICAgICB9CiAgICAgICAgIC8v IEZJWE1FOiBXZSBzaG91bGQgcHJvdmlkZSByZWdyZXNzaW9uIHJhbmdlcyBmb3IgdGhlIGZhaWxp bmcgYnVpbGRlcnMuCmRpZmYgLS1naXQgYS9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53 ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9UZXN0RmFpbHVyZXMvc2NyaXB0cy9nYXJkZW4t by1tYXRpYy5qcyBiL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29u ZmlnL3B1YmxpY19odG1sL1Rlc3RGYWlsdXJlcy9zY3JpcHRzL2dhcmRlbi1vLW1hdGljLmpzCmlu ZGV4IGUzNmZiMWMzYjZhYzYyODRlZWQ1YmI5ZDYxMTkxYmI4YWYxMGI3MTAuLjkwMDk1MDBlYjE3 MmVkYzU5MTk0ZDBlYzQzY2Y5OGNkOTk2NTk5YjUgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0J1aWxkU2xh dmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL1Rlc3RGYWlsdXJl cy9zY3JpcHRzL2dhcmRlbi1vLW1hdGljLmpzCisrKyBiL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0 L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL1Rlc3RGYWlsdXJlcy9zY3JpcHRz L2dhcmRlbi1vLW1hdGljLmpzCkBAIC0zMiw3ICszMiw3IEBAIHZhciBnX2J1aWxkZXJzRmFpbGlu ZyA9IG51bGw7CiAKIHZhciBnX3VuZXhwZWN0ZWRGYWlsdXJlc0NvbnRyb2xsZXIgPSBudWxsOwog Ci12YXIgZ19mYWlsaW5nQnVpbGRlcnMgPSBudWxsOwordmFyIGdfbG9zaW5nVGVzdENvdmVyYWdl QnVpbGRlcnMgPSBudWxsOwogCiBmdW5jdGlvbiB1cGRhdGUoKQogewpAQCAtNDIsNyArNDIsNyBA QCBmdW5jdGlvbiB1cGRhdGUoKQogCiAgICAgZ19pbmZvLmFkZCh1cGRhdGluZyk7CiAKLSAgICBi dWlsZGVycy5idWlsZGVyc0ZhaWxpbmdTdGVwUmVxdXJlZEZvclRlc3RDb3ZlcmFnZShnX2ZhaWxp bmdCdWlsZGVycy51cGRhdGUuYmluZChnX2ZhaWxpbmdCdWlsZGVycykpOworICAgIGJ1aWxkZXJz LmJ1aWxkZXJzRmFpbGluZ1N0ZXBSZXF1cmVkRm9yVGVzdENvdmVyYWdlKGdfbG9zaW5nVGVzdENv dmVyYWdlQnVpbGRlcnMudXBkYXRlLmJpbmQoZ19sb3NpbmdUZXN0Q292ZXJhZ2VCdWlsZGVycykp OwogCiAgICAgYmFzZS5jYWxsSW5QYXJhbGxlbChbbW9kZWwudXBkYXRlUmVjZW50Q29tbWl0cywg bW9kZWwudXBkYXRlUmVzdWx0c0J5QnVpbGRlcl0sIGZ1bmN0aW9uKCkgewogICAgICAgICB1cGRh dGluZy51cGRhdGUoJ0FuYWx5emluZyB0ZXN0IGZhaWx1cmVzIC4uLicpOwpAQCAtODMsNyArODMs NyBAQCAkKGRvY3VtZW50KS5yZWFkeShmdW5jdGlvbigpIHsKICAgICBnX3VuZXhwZWN0ZWRGYWls dXJlc0NvbnRyb2xsZXIgPSBuZXcgY29udHJvbGxlcnMuVW5leHBlY3RlZEZhaWx1cmVzKG1vZGVs LnN0YXRlLCB1bmV4cGVjdGVkRmFpbHVyZXNWaWV3LCBvbmViYXJDb250cm9sbGVyKTsKIAogICAg IGdfaW5mbyA9IG5ldyB1aS5ub3RpZmljYXRpb25zLlN0cmVhbSgpOwotICAgIGdfZmFpbGluZ0J1 aWxkZXJzID0gbmV3IGNvbnRyb2xsZXJzLkZhaWxpbmdCdWlsZGVycyhnX2luZm8pOworICAgIGdf bG9zaW5nVGVzdENvdmVyYWdlQnVpbGRlcnMgPSBuZXcgY29udHJvbGxlcnMuRmFpbGluZ0J1aWxk ZXJzKGdfaW5mbywgJ0xvc2luZyB0ZXN0IGNvdmVyYWdlJyk7CiAKICAgICAvLyBGSVhNRTogVGhp cyBzaG91bGQgYmUgYW4gQWN0aW9uIG9iamVjdC4KICAgICB2YXIgdXBkYXRlQnV0dG9uID0gZG9j dW1lbnQuYm9keS5pbnNlcnRCZWZvcmUoZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgnYnV0dG9uJyks IGRvY3VtZW50LmJvZHkuZmlyc3RDaGlsZCk7CmRpZmYgLS1naXQgYS9Ub29scy9CdWlsZFNsYXZl U3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9UZXN0RmFpbHVyZXMv c2NyaXB0cy91aS9ub3RpZmljYXRpb25zLmpzIGIvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVp bGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvVGVzdEZhaWx1cmVzL3NjcmlwdHMvdWkv bm90aWZpY2F0aW9ucy5qcwppbmRleCBmNjU5Mzg5ODAxOGMzMzczNGFlYzAyOGI3MmJhOTgwZWYx NTE2NWUyLi40ZDQyZGVmMzExZjhlMTZjODY4ZTVjMWQ3ZTIwYmYzMGJkNjQ4M2M1IDEwMDY0NAot LS0gYS9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJs aWNfaHRtbC9UZXN0RmFpbHVyZXMvc2NyaXB0cy91aS9ub3RpZmljYXRpb25zLmpzCisrKyBiL1Rv b2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1s L1Rlc3RGYWlsdXJlcy9zY3JpcHRzL3VpL25vdGlmaWNhdGlvbnMuanMKQEAgLTI0OCw5ICsyNDgs OSBAQCB1aS5ub3RpZmljYXRpb25zLkZhaWxpbmdUZXN0c1N1bW1hcnkgPSBiYXNlLmV4dGVuZHMo dWkubm90aWZpY2F0aW9ucy5GYWlsaW5nVGVzdAogfSk7CiAKIHVpLm5vdGlmaWNhdGlvbnMuQnVp bGRlcnNGYWlsaW5nID0gYmFzZS5leHRlbmRzKHVpLm5vdGlmaWNhdGlvbnMuRmFpbHVyZSwgewot ICAgIGluaXQ6IGZ1bmN0aW9uKCkKKyAgICBpbml0OiBmdW5jdGlvbihtZXNzYWdlKQogICAgIHsK LSAgICAgICAgdGhpcy5fcHJvYmxlbS5pbnNlcnRCZWZvcmUoZG9jdW1lbnQuY3JlYXRlVGV4dE5v ZGUoJ0J1aWxkIEZhaWxlZDonKSwgdGhpcy5fcHJvYmxlbS5maXJzdENoaWxkKTsKKyAgICAgICAg dGhpcy5fcHJvYmxlbS5pbnNlcnRCZWZvcmUoZG9jdW1lbnQuY3JlYXRlVGV4dE5vZGUobWVzc2Fn ZSArICc6JyksIHRoaXMuX3Byb2JsZW0uZmlyc3RDaGlsZCk7CiAgICAgfSwKICAgICBzZXRGYWls aW5nQnVpbGRlcnM6IGZ1bmN0aW9uKGJ1aWxkZXJOYW1lTGlzdCkKICAgICB7CmRpZmYgLS1naXQg YS9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNf aHRtbC9UZXN0RmFpbHVyZXMvc2NyaXB0cy91aS9ub3RpZmljYXRpb25zX3VuaXR0ZXN0cy5qcyBi L1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19o dG1sL1Rlc3RGYWlsdXJlcy9zY3JpcHRzL3VpL25vdGlmaWNhdGlvbnNfdW5pdHRlc3RzLmpzCmlu ZGV4IDNkZDlhZmY2MmI0NDM3YmViZTZkMmI2Mzg4ZGEwOWQxNDQ2MDE3NGMuLmRjY2ZmMGEyMDJk M2FlNjdhYmQ3NjUwMzMyYzFlMjBmN2JiN2U1MzEgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0J1aWxkU2xh dmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL1Rlc3RGYWlsdXJl cy9zY3JpcHRzL3VpL25vdGlmaWNhdGlvbnNfdW5pdHRlc3RzLmpzCisrKyBiL1Rvb2xzL0J1aWxk U2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL1Rlc3RGYWls dXJlcy9zY3JpcHRzL3VpL25vdGlmaWNhdGlvbnNfdW5pdHRlc3RzLmpzCkBAIC0zMjQsMTQgKzMy NCwxNCBAQCB0ZXN0KCdGYWlsaW5nVGVzdHNTdW1tYXJ5IChncm91cGluZyknLCAxLCBmdW5jdGlv bigpIHsKIH0pOwogCiB0ZXN0KCdCdWlsZGVyc0ZhaWxpbmcnLCAxLCBmdW5jdGlvbigpIHsKLSAg ICB2YXIgYnVpbGRlckZhaWxpbmcgPSBuZXcgdWkubm90aWZpY2F0aW9ucy5CdWlsZGVyc0ZhaWxp bmcoKTsKKyAgICB2YXIgYnVpbGRlckZhaWxpbmcgPSBuZXcgdWkubm90aWZpY2F0aW9ucy5CdWls ZGVyc0ZhaWxpbmcoJ0Rpc2FzdGVyaWZ5aW5nJyk7CiAgICAgYnVpbGRlckZhaWxpbmcuc2V0RmFp bGluZ0J1aWxkZXJzKFsnV2Via2l0IExpbnV4JywgJ1dlYmtpdCBWaXN0YSddKTsKICAgICBlcXVh bChidWlsZGVyRmFpbGluZy5pbm5lckhUTUwsCiAgICAgICAgICc8ZGl2IGNsYXNzPSJob3ciPicg KwogICAgICAgICAgICAgJzx0aW1lIGNsYXNzPSJyZWxhdGl2ZSI+PC90aW1lPicgKwogICAgICAg ICAnPC9kaXY+JyArCiAgICAgICAgICc8ZGl2IGNsYXNzPSJ3aGF0Ij4nICsKLSAgICAgICAgICAg ICc8ZGl2IGNsYXNzPSJwcm9ibGVtIj5CdWlsZCBGYWlsZWQ6JyArCisgICAgICAgICAgICAnPGRp diBjbGFzcz0icHJvYmxlbSI+RGlzYXN0ZXJpZnlpbmc6JyArCiAgICAgICAgICAgICAgICAgJzx1 bCBjbGFzcz0iZWZmZWN0cyI+JyArCiAgICAgICAgICAgICAgICAgICAgICc8bGkgY2xhc3M9ImJ1 aWxkZXIiPjxhIGNsYXNzPSJmYWlsaW5nLWJ1aWxkZXIiIHRhcmdldD0iX2JsYW5rIiBocmVmPSJo dHRwOi8vYnVpbGQuY2hyb21pdW0ub3JnL3AvY2hyb21pdW0ud2Via2l0L3dhdGVyZmFsbD9idWls ZGVyPVdlYmtpdCtMaW51eCI+PHNwYW4gY2xhc3M9InZlcnNpb24iPmx1Y2lkPC9zcGFuPjxzcGFu IGNsYXNzPSJhcmNoaXRlY3R1cmUiPjY0LWJpdDwvc3Bhbj48L2E+PC9saT4nICsKICAgICAgICAg ICAgICAgICAgICAgJzxsaSBjbGFzcz0iYnVpbGRlciI+PGEgY2xhc3M9ImZhaWxpbmctYnVpbGRl ciIgdGFyZ2V0PSJfYmxhbmsiIGhyZWY9Imh0dHA6Ly9idWlsZC5jaHJvbWl1bS5vcmcvcC9jaHJv bWl1bS53ZWJraXQvd2F0ZXJmYWxsP2J1aWxkZXI9V2Via2l0K1Zpc3RhIj48c3BhbiBjbGFzcz0i dmVyc2lvbiI+dmlzdGE8L3NwYW4+PC9hPjwvbGk+JyArCg==