72975 2011-11-22 10:58:26 -0800 UString methods are not character size aware 2011-11-24 22:55:52 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 msaboff msaboff oldest_to_newest 507694 0 msaboff 2011-11-22 10:58:26 -0800 Various UString methods do not take into account the character size of their arguments. Also the constructors that convert numbers to strings create 16 bit strings. 507702 1 116252 msaboff 2011-11-22 11:07:24 -0800 Created attachment 116252 Patch 508844 2 116252 fpizlo 2011-11-24 11:10:15 -0800 Comment on attachment 116252 Patch What is the performance effect, if any? 508975 3 msaboff 2011-11-24 22:55:14 -0800 (In reply to comment #2) > (From update of attachment 116252 [details]) > What is the performance effect, if any? This change appears neutral on SunSpider. Together with other changes it provides a benefit on SunSpider. 508976 4 msaboff 2011-11-24 22:55:52 -0800 Committed r101152: <http://trac.webkit.org/changeset/101152> 116252 2011-11-22 11:07:24 -0800 2011-11-24 11:10:15 -0800 Patch 72975.patch text/plain 4779 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTAxMDE2KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBA CisyMDExLTExLTIyICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIFVTdHJpbmcgbWV0aG9kcyBhcmUgbm90IGNoYXJhY3RlciBzaXplIGF3YXJlCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03Mjk3NQorCisgICAgICAg IENoYW5nZWQgdGhlIFVTdHJpbmcgbnVtYmVyIGNvbnN0cnVjdG9ycyB0byBidWlsZCA4IGJpdCBz dHJpbmdzLgorICAgICAgICBNb2RpZmllZCB0aGUgb3RoZXIgbWV0aG9kcyB0byBjaGVjayBzdHJp bmcgYml0bmVzcyBhbmQgcHJvY2VzcworICAgICAgICB3aXRoIDggYml0cyB3aGVycmUgYXBwcm9w cmlhdGUuCisKKyAgICAgICAgKiBydW50aW1lL1VTdHJpbmcuY3BwOgorICAgICAgICAoSlNDOjpV U3RyaW5nOjpudW1iZXIpOgorICAgICAgICAoSlNDOjpvcGVyYXRvcj09KToKKyAgICAgICAgKEpT Qzo6b3BlcmF0b3I8KToKKyAgICAgICAgKEpTQzo6VVN0cmluZzo6YXNjaWkpOgorCiAyMDExLTEx LTIyICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KIAogICAgICAg ICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTAwOTg4LgpJbmRleDogU291cmNlL0phdmFTY3Jp cHRDb3JlL3J1bnRpbWUvVVN0cmluZy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3Jp cHRDb3JlL3J1bnRpbWUvVVN0cmluZy5jcHAJKHJldmlzaW9uIDEwMDY3OSkKKysrIFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9ydW50aW1lL1VTdHJpbmcuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC05Niw5 ICs5Niw5IEBAIFVTdHJpbmc6OlVTdHJpbmcoY29uc3QgY2hhciogY2hhcmFjdGVycykKIAogVVN0 cmluZyBVU3RyaW5nOjpudW1iZXIoaW50IGkpCiB7Ci0gICAgVUNoYXIgYnVmWzEgKyBzaXplb2Yo aSkgKiAzXTsKLSAgICBVQ2hhciogZW5kID0gYnVmICsgV1RGX0FSUkFZX0xFTkdUSChidWYpOwot ICAgIFVDaGFyKiBwID0gZW5kOworICAgIExDaGFyIGJ1ZlsxICsgc2l6ZW9mKGkpICogM107Cisg ICAgTENoYXIqIGVuZCA9IGJ1ZiArIFdURl9BUlJBWV9MRU5HVEgoYnVmKTsKKyAgICBMQ2hhciog cCA9IGVuZDsKIAogICAgIGlmIChpID09IDApCiAgICAgICAgICotLXAgPSAnMCc7CkBAIC0xMjUs OSArMTI1LDkgQEAgVVN0cmluZyBVU3RyaW5nOjpudW1iZXIoaW50IGkpCiAKIFVTdHJpbmcgVVN0 cmluZzo6bnVtYmVyKGxvbmcgbG9uZyBpKQogewotICAgIFVDaGFyIGJ1ZlsxICsgc2l6ZW9mKGkp ICogM107Ci0gICAgVUNoYXIqIGVuZCA9IGJ1ZiArIFdURl9BUlJBWV9MRU5HVEgoYnVmKTsKLSAg ICBVQ2hhciogcCA9IGVuZDsKKyAgICBMQ2hhciBidWZbMSArIHNpemVvZihpKSAqIDNdOworICAg IExDaGFyKiBlbmQgPSBidWYgKyBXVEZfQVJSQVlfTEVOR1RIKGJ1Zik7CisgICAgTENoYXIqIHAg PSBlbmQ7CiAKICAgICBpZiAoaSA9PSAwKQogICAgICAgICAqLS1wID0gJzAnOwpAQCAtMTU4LDkg KzE1OCw5IEBAIFVTdHJpbmcgVVN0cmluZzo6bnVtYmVyKGxvbmcgbG9uZyBpKQogCiBVU3RyaW5n IFVTdHJpbmc6Om51bWJlcih1bnNpZ25lZCB1KQogewotICAgIFVDaGFyIGJ1ZltzaXplb2YodSkg KiAzXTsKLSAgICBVQ2hhciogZW5kID0gYnVmICsgV1RGX0FSUkFZX0xFTkdUSChidWYpOwotICAg IFVDaGFyKiBwID0gZW5kOworICAgIExDaGFyIGJ1ZltzaXplb2YodSkgKiAzXTsKKyAgICBMQ2hh ciogZW5kID0gYnVmICsgV1RGX0FSUkFZX0xFTkdUSChidWYpOworICAgIExDaGFyKiBwID0gZW5k OwogCiAgICAgaWYgKHUgPT0gMCkKICAgICAgICAgKi0tcCA9ICcwJzsKQEAgLTE3Niw5ICsxNzYs OSBAQCBVU3RyaW5nIFVTdHJpbmc6Om51bWJlcih1bnNpZ25lZCB1KQogCiBVU3RyaW5nIFVTdHJp bmc6Om51bWJlcihsb25nIGwpCiB7Ci0gICAgVUNoYXIgYnVmWzEgKyBzaXplb2YobCkgKiAzXTsK LSAgICBVQ2hhciogZW5kID0gYnVmICsgV1RGX0FSUkFZX0xFTkdUSChidWYpOwotICAgIFVDaGFy KiBwID0gZW5kOworICAgIExDaGFyIGJ1ZlsxICsgc2l6ZW9mKGwpICogM107CisgICAgTENoYXIq IGVuZCA9IGJ1ZiArIFdURl9BUlJBWV9MRU5HVEgoYnVmKTsKKyAgICBMQ2hhciogcCA9IGVuZDsK IAogICAgIGlmIChsID09IDApCiAgICAgICAgICotLXAgPSAnMCc7CkBAIC0yMjQsMTkgKzIyNCwx MCBAQCBVU3RyaW5nIFVTdHJpbmc6OnN1YnN0cmluZ1NoYXJpbmdJbXBsKHVuCiAKIGJvb2wgb3Bl cmF0b3I9PShjb25zdCBVU3RyaW5nJiBzMSwgY29uc3QgY2hhciAqczIpCiB7Ci0gICAgaWYgKHMy ID09IDApCi0gICAgICAgIHJldHVybiBzMS5pc0VtcHR5KCk7CisgICAgaWYgKHMxLmlzRW1wdHko KSkKKyAgICAgICAgcmV0dXJuICFzMjsKIAotICAgIGNvbnN0IFVDaGFyKiB1ID0gczEuY2hhcmFj dGVycygpOwotICAgIGNvbnN0IFVDaGFyKiB1ZW5kID0gdSArIHMxLmxlbmd0aCgpOwotICAgIHdo aWxlICh1ICE9IHVlbmQgJiYgKnMyKSB7Ci0gICAgICAgIGlmICh1WzBdICE9ICh1bnNpZ25lZCBj aGFyKSpzMikKLSAgICAgICAgICAgIHJldHVybiBmYWxzZTsKLSAgICAgICAgczIrKzsKLSAgICAg ICAgdSsrOwotICAgIH0KLQotICAgIHJldHVybiB1ID09IHVlbmQgJiYgKnMyID09IDA7CisgICAg cmV0dXJuIGVxdWFsKHMxLmltcGwoKSwgczIpOwogfQogCiAvLyBUaGlzIG1ldGhvZCBhc3N1bWVz IHRoYXQgYWxsIHNpbXBsZSBjaGVja3MgaGF2ZSBiZWVuIHBlcmZvcm1lZCBieQpAQCAtMzE1LDE1 ICszMDYsMjkgQEAgYm9vbCBvcGVyYXRvcjwoY29uc3QgVVN0cmluZyYgczEsIGNvbnN0IAogICAg IGNvbnN0IHVuc2lnbmVkIGwxID0gczEubGVuZ3RoKCk7CiAgICAgY29uc3QgdW5zaWduZWQgbDIg PSBzMi5sZW5ndGgoKTsKICAgICBjb25zdCB1bnNpZ25lZCBsbWluID0gbDEgPCBsMiA/IGwxIDog bDI7CisgICAgaWYgKHMxLmlzOEJpdCgpICYmIHMyLmlzOEJpdCgpKSB7CisgICAgICAgIGNvbnN0 IExDaGFyKiBjMSA9IHMxLmNoYXJhY3RlcnM4KCk7CisgICAgICAgIGNvbnN0IExDaGFyKiBjMiA9 IHMyLmNoYXJhY3RlcnM4KCk7CisgICAgICAgIHVuc2lnbmVkIGxlbmd0aCA9IDA7CisgICAgICAg IHdoaWxlIChsZW5ndGggPCBsbWluICYmICpjMSA9PSAqYzIpIHsKKyAgICAgICAgICAgIGMxKys7 CisgICAgICAgICAgICBjMisrOworICAgICAgICAgICAgbGVuZ3RoKys7CisgICAgICAgIH0KKyAg ICAgICAgaWYgKGxlbmd0aCA8IGxtaW4pCisgICAgICAgICAgICByZXR1cm4gKGMxWzBdIDwgYzJb MF0pOworCisgICAgICAgIHJldHVybiAobDEgPCBsMik7ICAgICAgICAKKyAgICB9CiAgICAgY29u c3QgVUNoYXIqIGMxID0gczEuY2hhcmFjdGVycygpOwogICAgIGNvbnN0IFVDaGFyKiBjMiA9IHMy LmNoYXJhY3RlcnMoKTsKLSAgICB1bnNpZ25lZCBsID0gMDsKLSAgICB3aGlsZSAobCA8IGxtaW4g JiYgKmMxID09ICpjMikgeworICAgIHVuc2lnbmVkIGxlbmd0aCA9IDA7CisgICAgd2hpbGUgKGxl bmd0aCA8IGxtaW4gJiYgKmMxID09ICpjMikgewogICAgICAgICBjMSsrOwogICAgICAgICBjMisr OwotICAgICAgICBsKys7CisgICAgICAgIGxlbmd0aCsrOwogICAgIH0KLSAgICBpZiAobCA8IGxt aW4pCisgICAgaWYgKGxlbmd0aCA8IGxtaW4pCiAgICAgICAgIHJldHVybiAoYzFbMF0gPCBjMlsw XSk7CiAKICAgICByZXR1cm4gKGwxIDwgbDIpOwpAQCAtMzU0LDcgKzM1OSwyMiBAQCBDU3RyaW5n IFVTdHJpbmc6OmFzY2lpKCkgY29uc3QKICAgICAvLyBwcmVzZXJ2ZWQsIGNoYXJhY3RlcnMgb3V0 c2lkZSBvZiB0aGlzIHJhbmdlIGFyZSBjb252ZXJ0ZWQgdG8gJz8nLgogCiAgICAgdW5zaWduZWQg bGVuZ3RoID0gdGhpcy0+bGVuZ3RoKCk7Ci0gICAgY29uc3QgVUNoYXIqIGNoYXJhY3RlcnMgPSB0 aGlzLT5jaGFyYWN0ZXJzKCk7CisKKyAgICBpZiAodGhpcy0+aXM4Qml0KCkpIHsKKyAgICAgICAg Y29uc3QgTENoYXIqIGNoYXJhY3RlcnMgPSB0aGlzLT5jaGFyYWN0ZXJzOCgpOworICAgICAgICAK KyAgICAgICAgY2hhciogY2hhcmFjdGVyQnVmZmVyOworICAgICAgICBDU3RyaW5nIHJlc3VsdCA9 IENTdHJpbmc6Om5ld1VuaW5pdGlhbGl6ZWQobGVuZ3RoLCBjaGFyYWN0ZXJCdWZmZXIpOworICAg ICAgICAKKyAgICAgICAgZm9yICh1bnNpZ25lZCBpID0gMDsgaSA8IGxlbmd0aDsgKytpKSB7Cisg ICAgICAgICAgICBMQ2hhciBjaCA9IGNoYXJhY3RlcnNbaV07CisgICAgICAgICAgICBjaGFyYWN0 ZXJCdWZmZXJbaV0gPSBjaCAmJiAoY2ggPCAweDIwIHx8IGNoID4gMHg3ZikgPyAnPycgOiBjaDsK KyAgICAgICAgfQorICAgICAgICAKKyAgICAgICAgcmV0dXJuIHJlc3VsdDsgICAgICAgIAorICAg IH0KKworICAgIGNvbnN0IFVDaGFyKiBjaGFyYWN0ZXJzID0gdGhpcy0+Y2hhcmFjdGVyczE2KCk7 CiAKICAgICBjaGFyKiBjaGFyYWN0ZXJCdWZmZXI7CiAgICAgQ1N0cmluZyByZXN1bHQgPSBDU3Ry aW5nOjpuZXdVbmluaXRpYWxpemVkKGxlbmd0aCwgY2hhcmFjdGVyQnVmZmVyKTsK