72974 2011-11-22 10:47:57 -0800 JavaScript string to number conversion functions use characters() 2011-11-24 22:48:03 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 msaboff msaboff oldest_to_newest 507687 0 msaboff 2011-11-22 10:47:57 -0800 The JavaScript string to number routines should process strings in their native 8 or 16 bitness. 507691 1 116247 msaboff 2011-11-22 10:53:27 -0800 Created attachment 116247 Patch 508843 2 116247 fpizlo 2011-11-24 11:07:36 -0800 Comment on attachment 116247 Patch What is the performance effect, if any? 508971 3 msaboff 2011-11-24 22:47:06 -0800 (In reply to comment #2) > (From update of attachment 116247 [details]) > What is the performance effect, if any? This change appears to be performance neutral by itself. 508972 4 msaboff 2011-11-24 22:48:03 -0800 Committed r101151: <http://trac.webkit.org/changeset/101151> 116247 2011-11-22 10:53:27 -0800 2011-11-24 11:07:35 -0800 Patch 72974.patch text/plain 5376 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTAxMDE0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBA CisyMDExLTExLTIyICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIEphdmFTY3JpcHQgc3RyaW5nIHRvIG51bWJlciBjb252ZXJzaW9uIGZ1bmN0aW9ucyB1c2Ug Y2hhcmFjdGVycygpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD03Mjk3NAorCisgICAgICAgIENoYW5nZSB0aGUgdmFyaW91cyBKUyB0byBudW1iZXIgcm91 dGluZXMgdG8gcHJvY2VzcyBzdHJpbmdzCisgICAgICAgIHVzaW5nIGNoYXJhY3RlcnM4KCkgb3Ig Y2hhcmFjdGVyczE2KCkgYXMgYXBwcm9wcmlhdGUuCisgICAgICAgIEltcGxlbWVudGVkIHVzaW5n IHN0YXRpYyB0ZW1wbGF0ZSBtZXRob2RzLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogcnVudGltZS9KU0dsb2JhbE9iamVjdEZ1bmN0aW9ucy5jcHA6 CisgICAgICAgIChKU0M6OmlzSW5maW5pdHkpOgorICAgICAgICAoSlNDOjpqc0hleEludGVnZXJM aXRlcmFsKToKKyAgICAgICAgKEpTQzo6anNTdHJEZWNpbWFsTGl0ZXJhbCk6CisgICAgICAgIChK U0M6OnRvRG91YmxlKToKKyAgICAgICAgKEpTQzo6anNUb051bWJlcik6CisKIDIwMTEtMTEtMjIg IFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPgogCiAgICAgICAgIFVu cmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxMDA5ODguCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENv cmUvcnVudGltZS9KU0dsb2JhbE9iamVjdEZ1bmN0aW9ucy5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNHbG9iYWxPYmplY3RGdW5jdGlvbnMuY3BwCShy ZXZpc2lvbiAxMDA2NzkpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0dsb2Jh bE9iamVjdEZ1bmN0aW9ucy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI3Nyw3ICsyNzcsOCBAQCBz dGF0aWMgZG91YmxlIHBhcnNlSW50KGNvbnN0IFVTdHJpbmcmIHMsCiAKIHN0YXRpYyBjb25zdCBp bnQgU2l6ZU9mSW5maW5pdHkgPSA4OwogCi1zdGF0aWMgYm9vbCBpc0luZmluaXR5KGNvbnN0IFVD aGFyKiBkYXRhLCBjb25zdCBVQ2hhciogZW5kKQordGVtcGxhdGUgPHR5cGVuYW1lIENoYXJUeXBl Pgorc3RhdGljIGJvb2wgaXNJbmZpbml0eShjb25zdCBDaGFyVHlwZSogZGF0YSwgY29uc3QgQ2hh clR5cGUqIGVuZCkKIHsKICAgICByZXR1cm4gKGVuZCAtIGRhdGEpID49IFNpemVPZkluZmluaXR5 CiAgICAgICAgICYmIGRhdGFbMF0gPT0gJ0knCkBAIC0yOTEsMTEgKzI5MiwxMiBAQCBzdGF0aWMg Ym9vbCBpc0luZmluaXR5KGNvbnN0IFVDaGFyKiBkYXRhCiB9CiAKIC8vIFNlZSBlY21hLTI2MiA5 LjMuMQotc3RhdGljIGRvdWJsZSBqc0hleEludGVnZXJMaXRlcmFsKGNvbnN0IFVDaGFyKiYgZGF0 YSwgY29uc3QgVUNoYXIqIGVuZCkKK3RlbXBsYXRlIDx0eXBlbmFtZSBDaGFyVHlwZT4KK3N0YXRp YyBkb3VibGUganNIZXhJbnRlZ2VyTGl0ZXJhbChjb25zdCBDaGFyVHlwZSomIGRhdGEsIGNvbnN0 IENoYXJUeXBlKiBlbmQpCiB7CiAgICAgLy8gSGV4IG51bWJlci4KICAgICBkYXRhICs9IDI7Ci0g ICAgY29uc3QgVUNoYXIqIGZpcnN0RGlnaXRQb3NpdGlvbiA9IGRhdGE7CisgICAgY29uc3QgQ2hh clR5cGUqIGZpcnN0RGlnaXRQb3NpdGlvbiA9IGRhdGE7CiAgICAgZG91YmxlIG51bWJlciA9IDA7 CiAgICAgd2hpbGUgKHRydWUpIHsKICAgICAgICAgbnVtYmVyID0gbnVtYmVyICogMTYgKyB0b0FT Q0lJSGV4VmFsdWUoKmRhdGEpOwpAQCAtMzEyLDE1ICszMTQsMTYgQEAgc3RhdGljIGRvdWJsZSBq c0hleEludGVnZXJMaXRlcmFsKGNvbnN0IAogfQogCiAvLyBTZWUgZWNtYS0yNjIgOS4zLjEKLXN0 YXRpYyBkb3VibGUganNTdHJEZWNpbWFsTGl0ZXJhbChjb25zdCBVQ2hhciomIGRhdGEsIGNvbnN0 IFVDaGFyKiBlbmQpCit0ZW1wbGF0ZSA8dHlwZW5hbWUgQ2hhclR5cGU+CitzdGF0aWMgZG91Ymxl IGpzU3RyRGVjaW1hbExpdGVyYWwoY29uc3QgQ2hhclR5cGUqJiBkYXRhLCBjb25zdCBDaGFyVHlw ZSogZW5kKQogewogICAgIEFTU0VSVChkYXRhIDwgZW5kKTsKIAogICAgIC8vIENvcHkgdGhlIHN0 aW5nIGludG8gYSBudWxsLXRlcm1pbmF0ZWQgYnl0ZSBidWZmZXIsIGFuZCBjYWxsIHN0cnRvZC4K ICAgICBWZWN0b3I8Y2hhciwgMzI+IGJ5dGVCdWZmZXI7Ci0gICAgZm9yIChjb25zdCBVQ2hhciog Y2hhcmFjdGVycyA9IGRhdGE7IGNoYXJhY3RlcnMgPCBlbmQ7ICsrY2hhcmFjdGVycykgewotICAg ICAgICBVQ2hhciBjaGFyYWN0ZXIgPSAqY2hhcmFjdGVyczsKLSAgICAgICAgYnl0ZUJ1ZmZlci5h cHBlbmQoaXNBU0NJSShjaGFyYWN0ZXIpID8gY2hhcmFjdGVyIDogMCk7CisgICAgZm9yIChjb25z dCBDaGFyVHlwZSogY2hhcmFjdGVycyA9IGRhdGE7IGNoYXJhY3RlcnMgPCBlbmQ7ICsrY2hhcmFj dGVycykgeworICAgICAgICBDaGFyVHlwZSBjaGFyYWN0ZXIgPSAqY2hhcmFjdGVyczsKKyAgICAg ICAgYnl0ZUJ1ZmZlci5hcHBlbmQoaXNBU0NJSShjaGFyYWN0ZXIpID8gc3RhdGljX2Nhc3Q8Y2hh cj4oY2hhcmFjdGVyKSA6IDApOwogICAgIH0KICAgICBieXRlQnVmZmVyLmFwcGVuZCgwKTsKICAg ICBjaGFyKiBlbmRPZk51bWJlcjsKQEAgLTM2MSw1MCArMzY0LDU3IEBAIHN0YXRpYyBkb3VibGUg anNTdHJEZWNpbWFsTGl0ZXJhbChjb25zdCAKICAgICByZXR1cm4gc3RkOjpudW1lcmljX2xpbWl0 czxkb3VibGU+OjpxdWlldF9OYU4oKTsKIH0KIAotLy8gU2VlIGVjbWEtMjYyIDkuMy4xCi1kb3Vi bGUganNUb051bWJlcihjb25zdCBVU3RyaW5nJiBzKQordGVtcGxhdGUgPHR5cGVuYW1lIENoYXJU eXBlPgorc3RhdGljIGRvdWJsZSB0b0RvdWJsZShjb25zdCBDaGFyVHlwZSogY2hhcmFjdGVycywg dW5zaWduZWQgc2l6ZSkKIHsKLSAgICB1bnNpZ25lZCBzaXplID0gcy5sZW5ndGgoKTsKLQotICAg IGlmIChzaXplID09IDEpIHsKLSAgICAgICAgVUNoYXIgYyA9IHNbMF07Ci0gICAgICAgIGlmIChp c0FTQ0lJRGlnaXQoYykpCi0gICAgICAgICAgICByZXR1cm4gYyAtICcwJzsKLSAgICAgICAgaWYg KGlzU3RyV2hpdGVTcGFjZShjKSkKLSAgICAgICAgICAgIHJldHVybiAwOwotICAgICAgICByZXR1 cm4gc3RkOjpudW1lcmljX2xpbWl0czxkb3VibGU+OjpxdWlldF9OYU4oKTsKLSAgICB9Ci0KLSAg ICBjb25zdCBVQ2hhciogZGF0YSA9IHMuY2hhcmFjdGVycygpOwotICAgIGNvbnN0IFVDaGFyKiBl bmQgPSBkYXRhICsgc2l6ZTsKKyAgICBjb25zdCBDaGFyVHlwZSogZW5kQ2hhcmFjdGVycyA9IGNo YXJhY3RlcnMgKyBzaXplOwogCiAgICAgLy8gU2tpcCBsZWFkaW5nIHdoaXRlIHNwYWNlLgotICAg IGZvciAoOyBkYXRhIDwgZW5kOyArK2RhdGEpIHsKLSAgICAgICAgaWYgKCFpc1N0cldoaXRlU3Bh Y2UoKmRhdGEpKQorICAgIGZvciAoOyBjaGFyYWN0ZXJzIDwgZW5kQ2hhcmFjdGVyczsgKytjaGFy YWN0ZXJzKSB7CisgICAgICAgIGlmICghaXNTdHJXaGl0ZVNwYWNlKCpjaGFyYWN0ZXJzKSkKICAg ICAgICAgICAgIGJyZWFrOwogICAgIH0KLQorICAgIAogICAgIC8vIEVtcHR5IHN0cmluZy4KLSAg ICBpZiAoZGF0YSA9PSBlbmQpCisgICAgaWYgKGNoYXJhY3RlcnMgPT0gZW5kQ2hhcmFjdGVycykK ICAgICAgICAgcmV0dXJuIDAuMDsKLQorICAgIAogICAgIGRvdWJsZSBudW1iZXI7Ci0gICAgaWYg KGRhdGFbMF0gPT0gJzAnICYmIGRhdGEgKyAyIDwgZW5kICYmIChkYXRhWzFdIHwgMHgyMCkgPT0g J3gnICYmIGlzQVNDSUlIZXhEaWdpdChkYXRhWzJdKSkKLSAgICAgICAgbnVtYmVyID0ganNIZXhJ bnRlZ2VyTGl0ZXJhbChkYXRhLCBlbmQpOworICAgIGlmIChjaGFyYWN0ZXJzWzBdID09ICcwJyAm JiBjaGFyYWN0ZXJzICsgMiA8IGVuZENoYXJhY3RlcnMgJiYgKGNoYXJhY3RlcnNbMV0gfCAweDIw KSA9PSAneCcgJiYgaXNBU0NJSUhleERpZ2l0KGNoYXJhY3RlcnNbMl0pKQorICAgICAgICBudW1i ZXIgPSBqc0hleEludGVnZXJMaXRlcmFsKGNoYXJhY3RlcnMsIGVuZENoYXJhY3RlcnMpOwogICAg IGVsc2UKLSAgICAgICAgbnVtYmVyID0ganNTdHJEZWNpbWFsTGl0ZXJhbChkYXRhLCBlbmQpOwot CisgICAgICAgIG51bWJlciA9IGpzU3RyRGVjaW1hbExpdGVyYWwoY2hhcmFjdGVycywgZW5kQ2hh cmFjdGVycyk7CisgICAgCiAgICAgLy8gQWxsb3cgdHJhaWxpbmcgd2hpdGUgc3BhY2UuCi0gICAg Zm9yICg7IGRhdGEgPCBlbmQ7ICsrZGF0YSkgewotICAgICAgICBpZiAoIWlzU3RyV2hpdGVTcGFj ZSgqZGF0YSkpCisgICAgZm9yICg7IGNoYXJhY3RlcnMgPCBlbmRDaGFyYWN0ZXJzOyArK2NoYXJh Y3RlcnMpIHsKKyAgICAgICAgaWYgKCFpc1N0cldoaXRlU3BhY2UoKmNoYXJhY3RlcnMpKQogICAg ICAgICAgICAgYnJlYWs7CiAgICAgfQotICAgIGlmIChkYXRhICE9IGVuZCkKKyAgICBpZiAoY2hh cmFjdGVycyAhPSBlbmRDaGFyYWN0ZXJzKQogICAgICAgICByZXR1cm4gc3RkOjpudW1lcmljX2xp bWl0czxkb3VibGU+OjpxdWlldF9OYU4oKTsKLQorICAgIAogICAgIHJldHVybiBudW1iZXI7CiB9 CiAKKy8vIFNlZSBlY21hLTI2MiA5LjMuMQorZG91YmxlIGpzVG9OdW1iZXIoY29uc3QgVVN0cmlu ZyYgcykKK3sKKyAgICB1bnNpZ25lZCBzaXplID0gcy5sZW5ndGgoKTsKKworICAgIGlmIChzaXpl ID09IDEpIHsKKyAgICAgICAgVUNoYXIgYyA9IHNbMF07CisgICAgICAgIGlmIChpc0FTQ0lJRGln aXQoYykpCisgICAgICAgICAgICByZXR1cm4gYyAtICcwJzsKKyAgICAgICAgaWYgKGlzU3RyV2hp dGVTcGFjZShjKSkKKyAgICAgICAgICAgIHJldHVybiAwOworICAgICAgICByZXR1cm4gc3RkOjpu dW1lcmljX2xpbWl0czxkb3VibGU+OjpxdWlldF9OYU4oKTsKKyAgICB9CisKKyAgICBpZiAocy5p czhCaXQoKSkKKyAgICAgICAgcmV0dXJuIHRvRG91YmxlKHMuY2hhcmFjdGVyczgoKSwgc2l6ZSk7 CisgICAgcmV0dXJuIHRvRG91YmxlKHMuY2hhcmFjdGVyczE2KCksIHNpemUpOworfQorCiBzdGF0 aWMgZG91YmxlIHBhcnNlRmxvYXQoY29uc3QgVVN0cmluZyYgcykKIHsKICAgICB1bnNpZ25lZCBz aXplID0gcy5sZW5ndGgoKTsK