72969 2011-11-22 10:32:24 -0800 Array.toString always uses StringImpl::characters() 2011-11-25 22:08:46 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 72968 1 msaboff msaboff oldest_to_newest 507675 0 msaboff 2011-11-22 10:32:24 -0800 arrayProtoFuncToString should determine the element's toString size and if all are 8 bit, then the results should be constructed as an 8 bit string. 508980 1 116566 msaboff 2011-11-24 23:10:06 -0800 Created attachment 116566 Patch 509320 2 116566 fpizlo 2011-11-25 21:34:09 -0800 Comment on attachment 116566 Patch Can you put the performance effect in the ChangeLog (even if it's neutral). 509326 3 msaboff 2011-11-25 22:08:46 -0800 Committed r101186: <http://trac.webkit.org/changeset/101186> 116566 2011-11-24 23:10:06 -0800 2011-11-25 21:34:09 -0800 Patch 72969.patch text/plain 2399 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTAxMTUyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDExLTExLTI0ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIEFycmF5LnRvU3RyaW5nIGFsd2F5cyB1c2VzIFN0cmluZ0ltcGw6OmNoYXJhY3RlcnMoKQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzI5NjkKKwor ICAgICAgICBJZiBhbGwgY29tcG9uZW50IHN0cmluZ3MgYXJlIDggYml0LCBjcmVhdGUgYW4gOCBi aXQgcmVzdWx0IHN0cmluZyBmb3IgdG9TdHJpbmcoKS4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHJ1bnRpbWUvQXJyYXlQcm90b3R5cGUuY3BwOgor ICAgICAgICAoSlNDOjphcnJheVByb3RvRnVuY1RvU3RyaW5nKToKKwogMjAxMS0xMS0yNCAgTWlj aGFlbCBTYWJvZmYgIDxtc2Fib2ZmQGFwcGxlLmNvbT4KIAogICAgICAgICBVU3RyaW5nIG1ldGhv ZHMgYXJlIG5vdCBjaGFyYWN0ZXIgc2l6ZSBhd2FyZQpJbmRleDogU291cmNlL0phdmFTY3JpcHRD b3JlL3J1bnRpbWUvQXJyYXlQcm90b3R5cGUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9ydW50aW1lL0FycmF5UHJvdG90eXBlLmNwcAkocmV2aXNpb24gMTAxMTQ2KQor KysgU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvQXJyYXlQcm90b3R5cGUuY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC0xODUsNiArMTg1LDcgQEAgRW5jb2RlZEpTVmFsdWUgSlNDX0hPU1RfQ0FM TCBhcnJheVByb3RvRgogCiAgICAgdW5zaWduZWQgdG90YWxTaXplID0gbGVuZ3RoID8gbGVuZ3Ro IC0gMSA6IDA7CiAgICAgVmVjdG9yPFJlZlB0cjxTdHJpbmdJbXBsPiwgMjU2PiBzdHJCdWZmZXIo bGVuZ3RoKTsKKyAgICBib29sIGFsbFN0cmluZ3M4Qml0ID0gdHJ1ZTsKIAogICAgIGZvciAodW5z aWduZWQgayA9IDA7IGsgPCBsZW5ndGg7IGsrKykgewogICAgICAgICBKU1ZhbHVlIGVsZW1lbnQ7 CkBAIC0xOTksNiArMjAwLDcgQEAgRW5jb2RlZEpTVmFsdWUgSlNDX0hPU1RfQ0FMTCBhcnJheVBy b3RvRgogICAgICAgICBVU3RyaW5nIHN0ciA9IGVsZW1lbnQudG9TdHJpbmcoZXhlYyk7CiAgICAg ICAgIHN0ckJ1ZmZlcltrXSA9IHN0ci5pbXBsKCk7CiAgICAgICAgIHRvdGFsU2l6ZSArPSBzdHIu bGVuZ3RoKCk7CisgICAgICAgIGFsbFN0cmluZ3M4Qml0ID0gYWxsU3RyaW5nczhCaXQgJiYgc3Ry LmlzOEJpdCgpOwogICAgICAgICAKICAgICAgICAgaWYgKCFzdHJCdWZmZXIuZGF0YSgpKSB7CiAg ICAgICAgICAgICB0aHJvd091dE9mTWVtb3J5RXJyb3IoZXhlYyk7CkBAIC0yMDksNiArMjExLDIz IEBAIEVuY29kZWRKU1ZhbHVlIEpTQ19IT1NUX0NBTEwgYXJyYXlQcm90b0YKICAgICB9CiAgICAg aWYgKCF0b3RhbFNpemUpCiAgICAgICAgIHJldHVybiBKU1ZhbHVlOjplbmNvZGUoanNFbXB0eVN0 cmluZyhleGVjKSk7CisKKyAgICBpZiAoYWxsU3RyaW5nczhCaXQpIHsKKyAgICAgICAgVmVjdG9y PExDaGFyPiBidWZmZXI7CisgICAgICAgIGJ1ZmZlci5yZXNlcnZlQ2FwYWNpdHkodG90YWxTaXpl KTsKKyAgICAgICAgaWYgKCFidWZmZXIuZGF0YSgpKQorICAgICAgICAgICAgcmV0dXJuIEpTVmFs dWU6OmVuY29kZSh0aHJvd091dE9mTWVtb3J5RXJyb3IoZXhlYykpOworICAgICAgICAKKyAgICAg ICAgZm9yICh1bnNpZ25lZCBpID0gMDsgaSA8IGxlbmd0aDsgaSsrKSB7CisgICAgICAgICAgICBp ZiAoaSkKKyAgICAgICAgICAgICAgICBidWZmZXIuYXBwZW5kKCcsJyk7CisgICAgICAgICAgICBp ZiAoUmVmUHRyPFN0cmluZ0ltcGw+IHJlcCA9IHN0ckJ1ZmZlcltpXSkKKyAgICAgICAgICAgICAg ICBidWZmZXIuYXBwZW5kKHJlcC0+Y2hhcmFjdGVyczgoKSwgcmVwLT5sZW5ndGgoKSk7CisgICAg ICAgIH0KKyAgICAgICAgQVNTRVJUKGJ1ZmZlci5zaXplKCkgPT0gdG90YWxTaXplKTsKKyAgICAg ICAgcmV0dXJuIEpTVmFsdWU6OmVuY29kZShqc1N0cmluZyhleGVjLCBVU3RyaW5nOjphZG9wdChi dWZmZXIpKSk7ICAgICAgICAKKyAgICB9CisKICAgICBWZWN0b3I8VUNoYXI+IGJ1ZmZlcjsKICAg ICBidWZmZXIucmVzZXJ2ZUNhcGFjaXR5KHRvdGFsU2l6ZSk7CiAgICAgaWYgKCFidWZmZXIuZGF0 YSgpKQo=