72968 2011-11-22 10:25:26 -0800 Empty JSStrings are created as 16 bit 2011-11-24 22:36:16 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 72969 1 msaboff msaboff oldest_to_newest 507668 0 msaboff 2011-11-22 10:25:26 -0800 An empty JSString is created with the m_is8Bit member clear. Therefore if an empty string is created and an 8 bit JSString is appended, the resulting JSString will have the 8 bit flag cleared but it should be 8 bit. 507677 1 116244 msaboff 2011-11-22 10:35:57 -0800 Created attachment 116244 Patch 508842 2 116244 fpizlo 2011-11-24 11:05:45 -0800 Comment on attachment 116244 Patch What is the performance effect if any? 508961 3 msaboff 2011-11-24 22:28:19 -0800 (In reply to comment #2) > (From update of attachment 116244 [details]) > What is the performance effect if any? BY itself, this patch is a wash. It provides a benefit together with other changes. 508962 4 msaboff 2011-11-24 22:36:16 -0800 Committed r101148: <http://trac.webkit.org/changeset/101148> 116244 2011-11-22 10:35:57 -0800 2011-11-24 11:05:45 -0800 Patch 72968.patch text/plain 1124 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTAxMDEyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDExLTExLTIyICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIEVtcHR5IEpTU3RyaW5ncyBhcmUgY3JlYXRlZCBhcyAxNiBiaXQKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcyOTY4CisKKyAgICAgICAgQ2xlYXIg bV9pczhCaXQgZmxhZyBmb3IgZW1wdHkgc3RyaW5ncy4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHJ1bnRpbWUvSlNTdHJpbmcuaDoKKyAgICAgICAg KEpTQzo6Um9wZUJ1aWxkZXI6OmZpbmlzaENyZWF0aW9uKToKKwogMjAxMS0xMS0yMiAgU2hlcmlm ZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdl ZCwgcm9sbGluZyBvdXQgcjEwMDk4OC4KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50 aW1lL0pTU3RyaW5nLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRp bWUvSlNTdHJpbmcuaAkocmV2aXNpb24gMTAwNjc5KQorKysgU291cmNlL0phdmFTY3JpcHRDb3Jl L3J1bnRpbWUvSlNTdHJpbmcuaAkod29ya2luZyBjb3B5KQpAQCAtMTIwLDYgKzEyMCw3IEBAIG5h bWVzcGFjZSBKU0MgewogICAgICAgICB7CiAgICAgICAgICAgICBCYXNlOjpmaW5pc2hDcmVhdGlv bihnbG9iYWxEYXRhKTsKICAgICAgICAgICAgIG1fbGVuZ3RoID0gMDsKKyAgICAgICAgICAgIG1f aXM4Qml0ID0gdHJ1ZTsKICAgICAgICAgfQogCiAgICAgICAgIHZvaWQgZmluaXNoQ3JlYXRpb24o SlNHbG9iYWxEYXRhJiBnbG9iYWxEYXRhLCBzaXplX3QgbGVuZ3RoKQo=