72955 2011-11-22 06:51:16 -0800 Implement command API 2023-12-11 07:27:19 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Normal --- 0 rakeshchaitan webkit-unassigned abarth annevk ap arv eoconnor rakeshchaitan rniwa simon.fraser webkit.review.bot oldest_to_newest 507584 0 rakeshchaitan 2011-11-22 06:51:16 -0800 Implement command API. Specs are http://dev.w3.org/html5/spec/Overview.html#commands 507597 1 116224 rakeshchaitan 2011-11-22 07:08:21 -0800 Created attachment 116224 Proposed patch This patch implments basic command apis, the specific case of http://dev.w3.org/html5/spec/Overview.html#using-the-accesskey-attribute-to-define-a-command-on-other-elements 507670 2 ap 2011-11-22 10:28:51 -0800 Did you e-mail webkit-dev about this feature? We need to discuss if it's wanted in WebKit, and whether it should be behind an ifdef. 507997 3 rakeshchaitan 2011-11-23 01:15:57 -0800 (In reply to comment #2) > Did you e-mail webkit-dev about this feature? We need to discuss if it's wanted in WebKit, and whether it should be behind an ifdef. Thanks for your inputs, I sent a e-mail on webkit-dev about this. 606192 4 116224 rniwa 2012-04-19 16:55:54 -0700 Comment on attachment 116224 Proposed patch I don't think we want to land this patch as is. 1998640 5 annevk 2023-12-11 07:27:19 -0800 No follow-up for over a decade, closing. 116224 2011-11-22 07:08:21 -0800 2012-04-19 16:55:54 -0700 Proposed patch bug-72955-20111122203223.patch text/plain 7488 rakeshchaitan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwMTAwMCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDMyIEBACisyMDExLTExLTIyICBSYWtlc2gg S04gIDxyYWtlc2gua25AbW90b3JvbGEuY29tPgorCisgICAgICAgIEltcGxlbWVudCBjb21tYW5k IEFQSQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzI5 NTUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbXBs ZW1lbnQgQ29tbWFuZCBBcGkuCisgICAgICAgIGh0dHA6Ly9kZXYudzMub3JnL2h0bWw1L3NwZWMv T3ZlcnZpZXcuaHRtbCNjb21tYW5kcworCisgICAgICAgIFRlc3Q6IGZhc3QvZm9ybXMvY29tbWFu ZC1hcGktYXR0cmlidXRlcy5odG1sCisKKyAgICAgICAgKiBodG1sL0hUTUxFbGVtZW50LmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OkhUTUxFbGVtZW50Ojpjb21tYW5kVHlwZSk6CisgICAgICAgIFJl dHVybnMgVHlwZSBmYWNldCBvZiBjb21tYW5kLgorICAgICAgICAoV2ViQ29yZTo6SFRNTEVsZW1l bnQ6OmNvbW1hbmRMYWJlbCk6CisgICAgICAgIFJldHVybnMgTGFiZWwgZmFjZXQgb2YgY29tbWFu ZC4KKyAgICAgICAgKFdlYkNvcmU6OkhUTUxFbGVtZW50Ojpjb21tYW5kSWNvbik6CisgICAgICAg IFJldHVybnMgSWNvbiBmYWNldCBvZiBjb21tYW5kCisgICAgICAgIChXZWJDb3JlOjpIVE1MRWxl bWVudDo6Y29tbWFuZEhpZGRlbik6CisgICAgICAgIFJldHVybnMgSGlkZGVuIHN0YXRlIG9mIGNv bW1hbmQuCisgICAgICAgIChXZWJDb3JlOjpIVE1MRWxlbWVudDo6Y29tbWFuZERpc2FibGVkKToK KyAgICAgICAgUmV0dXJucyBEaXNhYmxlZCBzdGF0ZSBvZiBjb21tYW5kLgorICAgICAgICAoV2Vi Q29yZTo6SFRNTEVsZW1lbnQ6OmNvbW1hbmRDaGVja2VkKToKKyAgICAgICAgUmV0dXJucyBDaGVj a2VkIHN0YXRlIG9mIGNvbW1hbmQuCisgICAgICAgICogaHRtbC9IVE1MRWxlbWVudC5oOgorICAg ICAgICAqIGh0bWwvSFRNTEVsZW1lbnQuaWRsOgorICAgICAgICBBZGRlZCBjb21tYW5kIGFwaSBh dHRyaWJ1dGVzLgorCiAyMDExLTExLTIyICBBbGV4YW5kZXIgUGF2bG92ICA8YXBhdmxvdkBjaHJv bWl1bS5vcmc+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogW1N1Z2dlc3RCb3hdIEdyYXllZCBw cm9tcHQgZGlzcGxheWVkIHdpdGggbm9uLWNvbGxhcHNlZCBzZWxlY3Rpb24gaW4gcGxhY2UKSW5k ZXg6IFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEVsZW1lbnQuY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJDb3JlL2h0bWwvSFRNTEVsZW1lbnQuY3BwCShyZXZpc2lvbiAxMDA4OTMpCisrKyBT b3VyY2UvV2ViQ29yZS9odG1sL0hUTUxFbGVtZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDMs NiArNDMsNyBAQAogI2luY2x1ZGUgIkhUTUxOYW1lcy5oIgogI2luY2x1ZGUgIkhUTUxQYXJzZXJJ ZGlvbXMuaCIKICNpbmNsdWRlICJIVE1MVGV4dEZvcm1Db250cm9sRWxlbWVudC5oIgorI2luY2x1 ZGUgIk5vZGVMaXN0LmgiCiAjaW5jbHVkZSAiUmVuZGVyV29yZEJyZWFrLmgiCiAjaW5jbHVkZSAi U2NyaXB0RXZlbnRMaXN0ZW5lci5oIgogI2luY2x1ZGUgIlNldHRpbmdzLmgiCkBAIC0xMDc3LDYg KzEwNzgsNTIgQEAgdm9pZCBIVE1MRWxlbWVudDo6c2V0SXRlbVR5cGUoY29uc3QgU3RyaQogfQog I2VuZGlmCiAKKy8vIENvbW1hbmQgQVBJCisKK1N0cmluZyBIVE1MRWxlbWVudDo6Y29tbWFuZFR5 cGUoKQoreworICAgIGlmICghZmFzdEhhc0F0dHJpYnV0ZShhY2Nlc3NrZXlBdHRyKSkKKyAgICAg ICAgcmV0dXJuIG51bGxBdG9tOworCisgICAgcmV0dXJuICJjb21tYW5kIjsKK30KKworU3RyaW5n IEhUTUxFbGVtZW50Ojpjb21tYW5kTGFiZWwoKQoreworICAgIGlmICghZmFzdEhhc0F0dHJpYnV0 ZShhY2Nlc3NrZXlBdHRyKSkKKyAgICAgICAgcmV0dXJuIG51bGxBdG9tOworICAgIAorICAgIGlm IChpc0VsZW1lbnROb2RlKCkgJiYgc3RhdGljX2Nhc3Q8RWxlbWVudCo+KHRoaXMpLT5pc0Zvcm1D b250cm9sRWxlbWVudCgpKSB7CisgICAgICAgIEhUTUxGb3JtQ29udHJvbEVsZW1lbnQqIGZvcm0g PSBzdGF0aWNfY2FzdDxIVE1MRm9ybUNvbnRyb2xFbGVtZW50Kj4odGhpcyk7CisgICAgICAgIHJl dHVybiBmb3JtLT5sYWJlbHMoKS0+aXRlbSgwKS0+dGV4dENvbnRlbnQoZmFsc2UpOworICAgIH0K KworICAgIHJldHVybiB0ZXh0Q29udGVudChmYWxzZSk7Cit9CisKK1N0cmluZyBIVE1MRWxlbWVu dDo6Y29tbWFuZEljb24oKQoreworICAgIHJldHVybiBudWxsQXRvbTsKK30KKworYm9vbCBIVE1M RWxlbWVudDo6Y29tbWFuZEhpZGRlbigpCit7CisgICAgaWYgKCFmYXN0SGFzQXR0cmlidXRlKGFj Y2Vzc2tleUF0dHIpKQorICAgICAgICByZXR1cm4gZmFsc2U7CisKKyAgICByZXR1cm4gZmFzdEhh c0F0dHJpYnV0ZShoaWRkZW5BdHRyKTsKK30KKworYm9vbCBIVE1MRWxlbWVudDo6Y29tbWFuZERp c2FibGVkKCkKK3sKKyAgICByZXR1cm4gZmFsc2U7Cit9CisKK2Jvb2wgSFRNTEVsZW1lbnQ6OmNv bW1hbmRDaGVja2VkKCkKK3sKKyAgICByZXR1cm4gZmFsc2U7Cit9CisKIH0gLy8gbmFtZXNwYWNl IFdlYkNvcmUKIAogI2lmbmRlZiBOREVCVUcKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRN TEVsZW1lbnQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxFbGVtZW50 LmgJKHJldmlzaW9uIDEwMDg5MykKKysrIFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEVsZW1lbnQu aAkod29ya2luZyBjb3B5KQpAQCAtOTgsNiArOTgsMTQgQEAgcHVibGljOgogICAgIFBhc3NSZWZQ dHI8TWljcm9EYXRhSXRlbVZhbHVlPiBpdGVtVmFsdWUoKSBjb25zdDsKICNlbmRpZgogCisgICAg Ly8gQ29tbWFuZCBhcGkKKyAgICB2aXJ0dWFsIFN0cmluZyBjb21tYW5kVHlwZSgpOworICAgIHZp cnR1YWwgU3RyaW5nIGNvbW1hbmRMYWJlbCgpOworICAgIHZpcnR1YWwgU3RyaW5nIGNvbW1hbmRJ Y29uKCk7CisgICAgdmlydHVhbCBib29sIGNvbW1hbmRIaWRkZW4oKTsKKyAgICB2aXJ0dWFsIGJv b2wgY29tbWFuZERpc2FibGVkKCk7CisgICAgdmlydHVhbCBib29sIGNvbW1hbmRDaGVja2VkKCk7 CisKIHByb3RlY3RlZDoKICAgICBIVE1MRWxlbWVudChjb25zdCBRdWFsaWZpZWROYW1lJiB0YWdO YW1lLCBEb2N1bWVudCopOwogCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxFbGVtZW50 LmlkbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxFbGVtZW50LmlkbAko cmV2aXNpb24gMTAwODkzKQorKysgU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MRWxlbWVudC5pZGwJ KHdvcmtpbmcgY29weSkKQEAgLTM5LDYgKzM5LDEzIEBAIG1vZHVsZSBodG1sIHsKICAgICAgICAg ICAgICAgICAgYXR0cmlidXRlIFtSZWZsZWN0XSBib29sZWFuIGhpZGRlbjsKICAgICAgICAgICAg ICAgICAgYXR0cmlidXRlIFtSZWZsZWN0XSBET01TdHJpbmcgYWNjZXNzS2V5OwogCisgICAgICAg ICAgICAgICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBET01TdHJpbmcgY29tbWFuZFR5cGU7CisgICAg ICAgICAgICAgICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBET01TdHJpbmcgY29tbWFuZExhYmVsOwor ICAgICAgICAgICAgICAgICByZWFkb25seSBhdHRyaWJ1dGUgRE9NU3RyaW5nIGNvbW1hbmRJY29u OworICAgICAgICAgICAgICAgICByZWFkb25seSBhdHRyaWJ1dGUgYm9vbGVhbiBjb21tYW5kSGlk ZGVuOworICAgICAgICAgICAgICAgICByZWFkb25seSBhdHRyaWJ1dGUgYm9vbGVhbiBjb21tYW5k RGlzYWJsZWQ7CisgICAgICAgICAgICAgICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBib29sZWFuIGNv bW1hbmRDaGVja2VkOworCiAgICAgICAgIC8vIEV4dGVuc2lvbnMKICAgICAgICAgICAgICAgICAg YXR0cmlidXRlIFtDb252ZXJ0TnVsbFRvTnVsbFN0cmluZ10gRE9NU3RyaW5nIGlubmVySFRNTAog ICAgICAgICAgICAgICAgICAgICAgc2V0dGVyIHJhaXNlcyhET01FeGNlcHRpb24pOwpJbmRleDog TGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxv ZwkocmV2aXNpb24gMTAxMDAwKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMTEtMjIgIFJha2VzaCBLTiAgPHJha2VzaC5rbkBt b3Rvcm9sYS5jb20+CisKKyAgICAgICAgSW1wbGVtZW50IGNvbW1hbmQgQVBJCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03Mjk1NQorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEltcGxlbWVudCBDb21tYW5kIEFw aS4KKyAgICAgICAgaHR0cDovL2Rldi53My5vcmcvaHRtbDUvc3BlYy9PdmVydmlldy5odG1sI2Nv bW1hbmRzCisKKyAgICAgICAgKiBmYXN0L2Zvcm1zL2NvbW1hbmQtYXBpLWF0dHJpYnV0ZXMtZXhw ZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2Zvcm1zL2NvbW1hbmQtYXBpLWF0dHJp YnV0ZXMuaHRtbDogQWRkZWQuCisKIDIwMTEtMTEtMjIgIFZzZXZvbG9kIFZsYXNvdiAgPHZzZXZp a0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogRXh0cmFjdCBTcGxpdFZp ZXcgZnJvbSBQYW5lbC5jcmVhdGVTaWRlYmFyKCkgbWV0aG9kIGFuZCByZXVzZSBpbiBFbGVtZW50 cyBhbmQgU2NyaXB0cyBwYW5lbHMuCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2NvbW1h bmQtYXBpLWF0dHJpYnV0ZXMtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3Rz L2Zhc3QvZm9ybXMvY29tbWFuZC1hcGktYXR0cmlidXRlcy1leHBlY3RlZC50eHQJKHJldmlzaW9u IDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2NvbW1hbmQtYXBpLWF0dHJpYnV0ZXMtZXhw ZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDIxIEBACitUaGlzIHRlc3RzIHRoZSBj b21tYW5kIGFwaQorCitJIGFtIGEgY29tbWFuZAorTm90IGEgY29tbWFuZAorUEFTUyBkaXZjbWQu Y29tbWFuZFR5cGUgaXMgImNvbW1hbmQiCitQQVNTIGRpdmNtZC5jb21tYW5kTGFiZWwgaXMgIkkg YW0gYSBjb21tYW5kIgorUEFTUyBkaXZjbWQuY29tbWFuZEljb24gaXMgIiIKK1BBU1MgZGl2Y21k LmNvbW1hbmRIaWRkZW4gaXMgZmFsc2UKK1BBU1MgZGl2Y21kLmNvbW1hbmREaXNhYmxlZCBpcyBm YWxzZQorUEFTUyBkaXZjbWQuY29tbWFuZENoZWNrZWQgaXMgZmFsc2UKK1BBU1MgZGl2aGlkZGVu LmNvbW1hbmRIaWRkZW4gaXMgdHJ1ZQorUEFTUyBkaXZwbGFpbi5jb21tYW5kVHlwZSBpcyAiIgor UEFTUyBkaXZwbGFpbi5jb21tYW5kTGFiZWwgaXMgIiIKK1BBU1MgZGl2cGxhaW4uY29tbWFuZElj b24gaXMgIiIKK1BBU1MgZGl2cGxhaW4uY29tbWFuZEhpZGRlbiBpcyBmYWxzZQorUEFTUyBkaXZw bGFpbi5jb21tYW5kRGlzYWJsZWQgaXMgZmFsc2UKK1BBU1MgZGl2cGxhaW4uY29tbWFuZENoZWNr ZWQgaXMgZmFsc2UKK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKKworVEVTVCBDT01Q TEVURQorCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2NvbW1hbmQtYXBpLWF0dHJpYnV0 ZXMuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2NvbW1hbmQtYXBp LWF0dHJpYnV0ZXMuaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvZm9ybXMv Y29tbWFuZC1hcGktYXR0cmlidXRlcy5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDM5IEBA Cis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPGhlYWQ+Cis8bWV0YSBjaGFyc2V0PSJ1dGYtOCI+ Cis8c2NyaXB0IHNyYz0iLi4vanMvcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4K KzwvaGVhZD4KKzxib2R5PgorPHA+VGhpcyB0ZXN0cyB0aGUgY29tbWFuZCBhcGk8L3A+Cis8ZGl2 IGlkPSJkaXZjb21tYW5kIiBhY2Nlc3NrZXk9ImEiPkkgYW0gYSBjb21tYW5kPC9kaXY+Cis8ZGl2 IGlkPSJoaWRkZW5jb21tYW5kIiBhY2Nlc3NrZXk9ImgiIGhpZGRlbj0iaGlkZGVuIj5JIGFtIGhp ZGRlbjwvZGl2PgorPGRpdiBpZD0icGxhaW5kaXYiPk5vdCBhIGNvbW1hbmQ8L2Rpdj4KKworPGRp diBpZD0iY29uc29sZSI+PC9kaXY+Cis8c2NyaXB0PgordmFyIGRpdmNtZCA9IGRvY3VtZW50Lmdl dEVsZW1lbnRCeUlkKCJkaXZjb21tYW5kIik7CisKK3Nob3VsZEJlKCdkaXZjbWQuY29tbWFuZFR5 cGUnLCAnImNvbW1hbmQiJyk7CitzaG91bGRCZSgnZGl2Y21kLmNvbW1hbmRMYWJlbCcsICciSSBh bSBhIGNvbW1hbmQiJyk7CitzaG91bGRCZSgnZGl2Y21kLmNvbW1hbmRJY29uJywgJyIiJyk7Citz aG91bGRCZUZhbHNlKCdkaXZjbWQuY29tbWFuZEhpZGRlbicpOworc2hvdWxkQmVGYWxzZSgnZGl2 Y21kLmNvbW1hbmREaXNhYmxlZCcpOworc2hvdWxkQmVGYWxzZSgnZGl2Y21kLmNvbW1hbmRDaGVj a2VkJyk7CisKK3ZhciBkaXZoaWRkZW4gPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiaGlkZGVu Y29tbWFuZCIpOworc2hvdWxkQmVUcnVlKCdkaXZoaWRkZW4uY29tbWFuZEhpZGRlbicpOworCit2 YXIgZGl2cGxhaW4gPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgicGxhaW5kaXYiKTsKK3Nob3Vs ZEJlKCdkaXZwbGFpbi5jb21tYW5kVHlwZScsICciIicpOworc2hvdWxkQmUoJ2RpdnBsYWluLmNv bW1hbmRMYWJlbCcsICciIicpOworc2hvdWxkQmUoJ2RpdnBsYWluLmNvbW1hbmRJY29uJywgJyIi Jyk7CitzaG91bGRCZUZhbHNlKCdkaXZwbGFpbi5jb21tYW5kSGlkZGVuJyk7CitzaG91bGRCZUZh bHNlKCdkaXZwbGFpbi5jb21tYW5kRGlzYWJsZWQnKTsKK3Nob3VsZEJlRmFsc2UoJ2RpdnBsYWlu LmNvbW1hbmRDaGVja2VkJyk7CisKK3N1Y2Nlc3NmdWxseVBhcnNlZCA9IHRydWU7Cis8L3Njcmlw dD4KKzxzY3JpcHQgc3JjPSIuLi9qcy9yZXNvdXJjZXMvanMtdGVzdC1wb3N0LmpzIj48L3Njcmlw dD4KKzwvYm9keT4KKzwvaHRtbD4K