72950 2011-11-22 06:28:02 -0800 [DRT Chromium] Set right default value to baseURL in LayoutTestController::queueLoadHTMLString 2011-11-23 06:12:33 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jnd jnd satish tkent tony tonyg webkit.review.bot oldest_to_newest 507563 0 jnd 2011-11-22 06:28:02 -0800 fast/loader/non-deferred-substitute-load.html was crashed on the debug version of DRT Chromium port. The crash was caused by ASSERT(!newRequest.isNull()) in MainResourceLoader::willSendRequest. After investigation, test non-deferred-substitute-load.html calls LayoutTestController::queueLoadHTMLString to load some HTML contents, however DRT Chromium port sets a empty URL as default base URL in LayoutTestController::queueLoadHTMLString, which causes the assert. By looking at the general DRT implementation, (see http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/LayoutTestController.cpp#L1016.) it sets a "" string as default value to baseURL to avoid the assert, DRT Chromium port should follow it. A patch is on the way 507569 1 116216 jnd 2011-11-22 06:33:47 -0800 Created attachment 116216 patch v1 507642 2 116216 tony 2011-11-22 09:35:27 -0800 Comment on attachment 116216 patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=116216&action=review > Tools/DumpRenderTree/chromium/LayoutTestController.cpp:575 > + // FIXME: Should use the URL of current document as default if it is specified? Nit: I would remove this comment since it seems like this is intentional. 507907 3 116307 jnd 2011-11-22 19:17:11 -0800 Created attachment 116307 patch v1 with addressing tony's nit. 508097 4 116307 webkit.review.bot 2011-11-23 06:12:29 -0800 Comment on attachment 116307 patch v1 with addressing tony's nit. Clearing flags on attachment: 116307 Committed r101076: <http://trac.webkit.org/changeset/101076> 508098 5 webkit.review.bot 2011-11-23 06:12:33 -0800 All reviewed patches have been landed. Closing bug. 116216 2011-11-22 06:33:47 -0800 2011-11-22 19:17:11 -0800 patch v1 baseurl.patch text/plain 2912 jnd SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDEwMDk5NikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDExLTExLTIyICBKb2hubnkgRGluZyAgPGpuZEBjaHJvbWl1bS5vcmc+CisK KyAgICAgICAgU2V0IHJpZ2h0IGRlZmF1bHQgdmFsdWUgdG8gYmFzZVVSTCBpbiBMYXlvdXRUZXN0 Q29udHJvbGxlcjo6cXVldWVMb2FkSFRNTFN0cmluZy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcyOTUwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9MYXlvdXRU ZXN0Q29udHJvbGxlci5jcHA6CisgICAgICAgIChMYXlvdXRUZXN0Q29udHJvbGxlcjo6cXVldWVM b2FkSFRNTFN0cmluZyk6CisKIDIwMTEtMTEtMjEgIFl1dGEgS2l0YW11cmEgIDx5dXRha0BjaHJv bWl1bS5vcmc+CiAKICAgICAgICAgW0dUS10gRW5hYmxlIFdlYlNvY2tldCBoeWJpIHRlc3RzCklu ZGV4OiBUb29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9MYXlvdXRUZXN0Q29udHJvbGxlci5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vTGF5b3V0VGVz dENvbnRyb2xsZXIuY3BwCShyZXZpc2lvbiAxMDA5OTEpCisrKyBUb29scy9EdW1wUmVuZGVyVHJl ZS9jaHJvbWl1bS9MYXlvdXRUZXN0Q29udHJvbGxlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTU3 Miw3ICs1NzIsOCBAQCB2b2lkIExheW91dFRlc3RDb250cm9sbGVyOjpxdWV1ZUxvYWRIVE1MCiB7 CiAgICAgaWYgKGFyZ3VtZW50cy5zaXplKCkgPiAwICYmIGFyZ3VtZW50c1swXS5pc1N0cmluZygp KSB7CiAgICAgICAgIHN0cmluZyBodG1sID0gYXJndW1lbnRzWzBdLnRvU3RyaW5nKCk7Ci0gICAg ICAgIFdlYlVSTCBiYXNlVVJMOworICAgICAgICAvLyBGSVhNRTogU2hvdWxkIHVzZSB0aGUgVVJM IG9mIGN1cnJlbnQgZG9jdW1lbnQgYXMgZGVmYXVsdCBpZiBpdCBpcyBzcGVjaWZpZWQ/CisgICAg ICAgIFdlYlVSTCBiYXNlVVJMKEdVUkwoIiIpKTsKICAgICAgICAgaWYgKGFyZ3VtZW50cy5zaXpl KCkgPiAxICYmIGFyZ3VtZW50c1sxXS5pc1N0cmluZygpKQogICAgICAgICAgICAgYmFzZVVSTCA9 IFdlYlVSTChHVVJMKGFyZ3VtZW50c1sxXS50b1N0cmluZygpKSk7CiAgICAgICAgIGlmIChhcmd1 bWVudHMuc2l6ZSgpID4gMiAmJiBhcmd1bWVudHNbMl0uaXNTdHJpbmcoKSkKSW5kZXg6IExheW91 dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDEwMDk5NikKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEyIEBACisyMDExLTExLTIyICBKb2hubnkgRGluZyAgPGpuZEBjaHJvbWl1bS5v cmc+CisKKyAgICAgICAgU2V0IHJpZ2h0IGRlZmF1bHQgdmFsdWUgdG8gYmFzZVVSTCBpbiBMYXlv dXRUZXN0Q29udHJvbGxlcjo6cXVldWVMb2FkSFRNTFN0cmluZy4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcyOTUwCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4 cGVjdGF0aW9ucy50eHQ6CisKIDIwMTEtMTEtMjIgIFZzZXZvbG9kIFZsYXNvdiAgPHZzZXZpa0Bj aHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogRXh0cmFjdCBTcGxpdFZpZXcg ZnJvbSBQYW5lbC5jcmVhdGVTaWRlYmFyKCkgbWV0aG9kIGFuZCByZXVzZSBpbiBFbGVtZW50cyBh bmQgU2NyaXB0cyBwYW5lbHMuCkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90 ZXN0X2V4cGVjdGF0aW9ucy50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0v Y2hyb21pdW0vdGVzdF9leHBlY3RhdGlvbnMudHh0CShyZXZpc2lvbiAxMDA5OTEpCisrKyBMYXlv dXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQJKHdvcmtpbmcg Y29weSkKQEAgLTI0ODIsNyArMjQ4Miw2IEBAIEJVR19EUlQgREVCVUcgOiBmYXN0L2ZyYW1lcy9j YWxjdWxhdGUtcm8KIEJVR0NSNDM4OTAgU0xPVyBERUJVRyA6IGZhc3QvZm9ybXMvaW1wbGljaXQt c3VibWlzc2lvbi5odG1sID0gUEFTUyBURVhUCiBCVUdfRFJUIEJVR0NSMjExNDEgTElOVVggOiBm YXN0L2Zvcm1zL3NlbGVjdC1kb3VibGUtb25jaGFuZ2UuaHRtbCA9IEZBSUwKIEJVR19EUlQgQlVH Q1IyMTE0MSBMSU5VWCA6IGZhc3QvZm9ybXMvc2VsZWN0LXNjcmlwdC1vbmNoYW5nZS5odG1sID0g RkFJTAotQlVHX0RSVCBERUJVRyA6IGZhc3QvbG9hZGVyL25vbi1kZWZlcnJlZC1zdWJzdGl0dXRl LWxvYWQuaHRtbCA9IENSQVNICiBCVUdfRFJUIDogZmFzdC9yZXBhaW50L2lmcmFtZS1zY3JvbGwt cmVwYWludC5odG1sID0gSU1BR0UKIEJVR19EUlQgTElOVVggOiBmYXN0L3JlcGFpbnQvcmVwYWlu dC1hY3Jvc3Mtd3JpdGluZy1tb2RlLWJvdW5kYXJ5Lmh0bWwgPSBJTUFHRQogQlVHX0RSVCBMSU5V WCA6IGZhc3QvdGV4dC9qdXN0aWZpY2F0aW9uLXBhZGRpbmctbWlkLXdvcmQuaHRtbCA9IFBBU1Mg VEVYVAo= 116307 2011-11-22 19:17:11 -0800 2011-11-23 06:12:29 -0800 patch v1 with addressing tony's nit. baseurl.patch text/plain 2815 jnd SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDEwMDk5NikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDExLTExLTIyICBKb2hubnkgRGluZyAgPGpuZEBjaHJvbWl1bS5vcmc+CisK KyAgICAgICAgU2V0IHJpZ2h0IGRlZmF1bHQgdmFsdWUgdG8gYmFzZVVSTCBpbiBMYXlvdXRUZXN0 Q29udHJvbGxlcjo6cXVldWVMb2FkSFRNTFN0cmluZy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcyOTUwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgVG9u eSBDaGFuZy4KKworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL2Nocm9taXVtL0xheW91dFRlc3RD b250cm9sbGVyLmNwcDoKKyAgICAgICAgKExheW91dFRlc3RDb250cm9sbGVyOjpxdWV1ZUxvYWRI VE1MU3RyaW5nKToKKwogMjAxMS0xMS0yMSAgWXV0YSBLaXRhbXVyYSAgPHl1dGFrQGNocm9taXVt Lm9yZz4KIAogICAgICAgICBbR1RLXSBFbmFibGUgV2ViU29ja2V0IGh5YmkgdGVzdHMKSW5kZXg6 IFRvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL0xheW91dFRlc3RDb250cm9sbGVyLmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBUb29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9MYXlvdXRUZXN0Q29u dHJvbGxlci5jcHAJKHJldmlzaW9uIDEwMDk5MSkKKysrIFRvb2xzL0R1bXBSZW5kZXJUcmVlL2No cm9taXVtL0xheW91dFRlc3RDb250cm9sbGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTcyLDcg KzU3Miw3IEBAIHZvaWQgTGF5b3V0VGVzdENvbnRyb2xsZXI6OnF1ZXVlTG9hZEhUTUwKIHsKICAg ICBpZiAoYXJndW1lbnRzLnNpemUoKSA+IDAgJiYgYXJndW1lbnRzWzBdLmlzU3RyaW5nKCkpIHsK ICAgICAgICAgc3RyaW5nIGh0bWwgPSBhcmd1bWVudHNbMF0udG9TdHJpbmcoKTsKLSAgICAgICAg V2ViVVJMIGJhc2VVUkw7CisgICAgICAgIFdlYlVSTCBiYXNlVVJMKEdVUkwoIiIpKTsKICAgICAg ICAgaWYgKGFyZ3VtZW50cy5zaXplKCkgPiAxICYmIGFyZ3VtZW50c1sxXS5pc1N0cmluZygpKQog ICAgICAgICAgICAgYmFzZVVSTCA9IFdlYlVSTChHVVJMKGFyZ3VtZW50c1sxXS50b1N0cmluZygp KSk7CiAgICAgICAgIGlmIChhcmd1bWVudHMuc2l6ZSgpID4gMiAmJiBhcmd1bWVudHNbMl0uaXNT dHJpbmcoKSkKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlv dXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwMDk5NikKKysrIExheW91dFRlc3RzL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDExLTExLTIyICBKb2hubnkg RGluZyAgPGpuZEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgU2V0IHJpZ2h0IGRlZmF1bHQgdmFs dWUgdG8gYmFzZVVSTCBpbiBMYXlvdXRUZXN0Q29udHJvbGxlcjo6cXVldWVMb2FkSFRNTFN0cmlu Zy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcyOTUw CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgVG9ueSBDaGFuZy4KKworICAgICAgICAqIHBsYXRmb3Jt L2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dDoKKwogMjAxMS0xMS0yMiAgVnNldm9sb2Qg Vmxhc292ICA8dnNldmlrQGNocm9taXVtLm9yZz4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBF eHRyYWN0IFNwbGl0VmlldyBmcm9tIFBhbmVsLmNyZWF0ZVNpZGViYXIoKSBtZXRob2QgYW5kIHJl dXNlIGluIEVsZW1lbnRzIGFuZCBTY3JpcHRzIHBhbmVscy4KSW5kZXg6IExheW91dFRlc3RzL3Bs YXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlv dXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQJKHJldmlzaW9u IDEwMDk5MSkKKysrIExheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRp b25zLnR4dAkod29ya2luZyBjb3B5KQpAQCAtMjQ4Miw3ICsyNDgyLDYgQEAgQlVHX0RSVCBERUJV RyA6IGZhc3QvZnJhbWVzL2NhbGN1bGF0ZS1ybwogQlVHQ1I0Mzg5MCBTTE9XIERFQlVHIDogZmFz dC9mb3Jtcy9pbXBsaWNpdC1zdWJtaXNzaW9uLmh0bWwgPSBQQVNTIFRFWFQKIEJVR19EUlQgQlVH Q1IyMTE0MSBMSU5VWCA6IGZhc3QvZm9ybXMvc2VsZWN0LWRvdWJsZS1vbmNoYW5nZS5odG1sID0g RkFJTAogQlVHX0RSVCBCVUdDUjIxMTQxIExJTlVYIDogZmFzdC9mb3Jtcy9zZWxlY3Qtc2NyaXB0 LW9uY2hhbmdlLmh0bWwgPSBGQUlMCi1CVUdfRFJUIERFQlVHIDogZmFzdC9sb2FkZXIvbm9uLWRl ZmVycmVkLXN1YnN0aXR1dGUtbG9hZC5odG1sID0gQ1JBU0gKIEJVR19EUlQgOiBmYXN0L3JlcGFp bnQvaWZyYW1lLXNjcm9sbC1yZXBhaW50Lmh0bWwgPSBJTUFHRQogQlVHX0RSVCBMSU5VWCA6IGZh c3QvcmVwYWludC9yZXBhaW50LWFjcm9zcy13cml0aW5nLW1vZGUtYm91bmRhcnkuaHRtbCA9IElN QUdFCiBCVUdfRFJUIExJTlVYIDogZmFzdC90ZXh0L2p1c3RpZmljYXRpb24tcGFkZGluZy1taWQt d29yZC5odG1sID0gUEFTUyBURVhUCg==