72905 2011-11-21 12:52:42 -0800 [Qt] Remove unnecessary initialize method from QQuickWebView. 2011-11-21 13:07:03 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 menard menard hausmann kenneth vestbo webkit.review.bot zoltan oldest_to_newest 507142 0 menard 2011-11-21 12:52:42 -0800 [Qt] Remove unnecessary initialize method from QQuickWebView. 507143 1 116117 menard 2011-11-21 12:53:24 -0800 Created attachment 116117 Patch 507163 2 menard 2011-11-21 13:07:03 -0800 Committed r100950: <http://trac.webkit.org/changeset/100950> 116117 2011-11-21 12:53:24 -0800 2011-11-21 13:00:12 -0800 Patch bug-72905-20111121175322.patch text/plain 5412 menard U3VidmVyc2lvbiBSZXZpc2lvbjogMTAwOTA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMmQ0MTI1M2ZkNjJjYzI5 OTE0MzE1ZGMyMGRkOGIzNmRhYTlkMzdhMC4uZTA4ZTY2NjlhNGM1ZmJjMDZhN2U1ZTM4NDNiZWNm NDkwNDFhMmUyZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDExLTExLTIxICBBbGV4 aXMgTWVuYXJkICA8YWxleGlzLm1lbmFyZEBvcGVuYm9zc2Eub3JnPgorCisgICAgICAgIFtRdF0g UmVtb3ZlIHVubmVjZXNzYXJ5IGluaXRpYWxpemUgbWV0aG9kIGZyb20gUVF1aWNrV2ViVmlldy4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcyOTA1CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2UgZG9uJ3Qg bmVlZCB0aGlzIGxldmVsIG9mIGluZGlyZWN0aW9uLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQ SS9xdC9xcXVpY2t3ZWJ2aWV3LmNwcDoKKyAgICAgICAgKFFRdWlja1dlYlZpZXdQcml2YXRlOjpR UXVpY2tXZWJWaWV3UHJpdmF0ZSk6CisgICAgICAgIChRUXVpY2tXZWJWaWV3OjpRUXVpY2tXZWJW aWV3KToKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL3F0L3FxdWlja3dlYnZpZXdfcF9wLmg6CisK IDIwMTEtMTEtMjEgIENhaW8gTWFyY2VsbyBkZSBPbGl2ZWlyYSBGaWxobyAgPGNhaW8ub2xpdmVp cmFAb3BlbmJvc3NhLm9yZz4KIAogICAgICAgICBbUXRdIEFkZCBXZWJWaWV3LnZpZXcgYXR0YWNo ZWQgcHJvcGVydHkgc3VwcG9ydCBmb3IgZGlhbG9ncyBpbiBRTUwKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXF1aWNrd2Vidmlldy5jcHAgYi9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3FxdWlja3dlYnZpZXcuY3BwCmluZGV4IDgyYTllMTllZDRh OWIyMWY1MWQxZDE4YTFkMTVmOGUzOTY0OTJmNGIuLjk3MDIwMGY5ZmU5Mjk3NzBmNzNmMjZjM2I4 NDE2OTZkZWViMmJlZWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkv cXQvcXF1aWNrd2Vidmlldy5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9x dC9xcXVpY2t3ZWJ2aWV3LmNwcApAQCAtMzYsOCArMzYsOCBAQAogI2luY2x1ZGUgPFF0V2lkZ2V0 cy9RSW5wdXREaWFsb2c+CiAjaW5jbHVkZSA8V0tPcGVuUGFuZWxSZXN1bHRMaXN0ZW5lci5oPgog Ci1RUXVpY2tXZWJWaWV3UHJpdmF0ZTo6UVF1aWNrV2ViVmlld1ByaXZhdGUoKQotICAgIDogcV9w dHIoMCkKK1FRdWlja1dlYlZpZXdQcml2YXRlOjpRUXVpY2tXZWJWaWV3UHJpdmF0ZShRUXVpY2tX ZWJWaWV3KiB2aWV3cG9ydCwgV0tDb250ZXh0UmVmIGNvbnRleHRSZWYsIFdLUGFnZUdyb3VwUmVm IHBhZ2VHcm91cFJlZikKKyAgICA6IHFfcHRyKHZpZXdwb3J0KQogICAgICwgYWxlcnREaWFsb2co MCkKICAgICAsIGNvbmZpcm1EaWFsb2coMCkKICAgICAsIHByb21wdERpYWxvZygwKQpAQCAtNDUs NiArNDUsMTkgQEAgUVF1aWNrV2ViVmlld1ByaXZhdGU6OlFRdWlja1dlYlZpZXdQcml2YXRlKCkK ICAgICAsIHRyYW5zaXRpb25pbmdUb05ld1BhZ2UoZmFsc2UpCiAgICAgLCB1c2VUcmFkaXRpb25h bERlc2t0b3BCZWhhdmlvdXIoZmFsc2UpCiB7CisgICAgdmlld3BvcnQtPnNldEZsYWdzKFFRdWlj a0l0ZW06Okl0ZW1DbGlwc0NoaWxkcmVuVG9TaGFwZSk7CisKKyAgICBRT2JqZWN0Ojpjb25uZWN0 KHZpZXdwb3J0LCBTSUdOQUwodmlzaWJsZUNoYW5nZWQoKSksIHZpZXdwb3J0LCBTTE9UKF9xX29u VmlzaWJsZUNoYW5nZWQoKSkpOworICAgIHBhZ2VWaWV3LnJlc2V0KG5ldyBRUXVpY2tXZWJQYWdl KHZpZXdwb3J0KSk7CisKKyAgICBRUXVpY2tXZWJQYWdlUHJpdmF0ZSogY29uc3QgcGFnZVZpZXdQ cml2YXRlID0gcGFnZVZpZXcuZGF0YSgpLT5kOworICAgIHNldFBhZ2VQcm94eShuZXcgUXRXZWJQ YWdlUHJveHkocGFnZVZpZXcuZGF0YSgpLCBxX3B0ciwgMCwgdGhpcywgY29udGV4dFJlZiwgcGFn ZUdyb3VwUmVmKSk7CisgICAgcGFnZVZpZXdQcml2YXRlLT5zZXRQYWdlUHJveHkocGFnZVByb3h5 LmRhdGEoKSk7CisKKyAgICBRV2ViUHJlZmVyZW5jZXNQcml2YXRlOjpnZXQocGFnZVByb3h5LT5w cmVmZXJlbmNlcygpKS0+c2V0QXR0cmlidXRlKFFXZWJQcmVmZXJlbmNlc1ByaXZhdGU6OkFjY2Vs ZXJhdGVkQ29tcG9zaXRpbmdFbmFibGVkLCB0cnVlKTsKKyAgICBwYWdlUHJveHktPmluaXQoKTsK KworICAgIFFPYmplY3Q6OmNvbm5lY3QocGFnZVByb3h5LmRhdGEoKSwgU0lHTkFMKHVwZGF0ZU5h dmlnYXRpb25TdGF0ZSgpKSwgcV9wdHIsIFNJR05BTChuYXZpZ2F0aW9uU3RhdGVDaGFuZ2VkKCkp KTsKIH0KIAogdm9pZCBRUXVpY2tXZWJWaWV3UHJpdmF0ZTo6ZW5hYmxlTW91c2VFdmVudHMoKQpA QCAtNjUsMjQgKzc4LDYgQEAgdm9pZCBRUXVpY2tXZWJWaWV3UHJpdmF0ZTo6ZGlzYWJsZU1vdXNl RXZlbnRzKCkKICAgICBwYWdlVmlldy0+c2V0QWNjZXB0SG92ZXJFdmVudHMoZmFsc2UpOwogfQog Ci12b2lkIFFRdWlja1dlYlZpZXdQcml2YXRlOjppbml0aWFsaXplKFFRdWlja1dlYlZpZXcqIHZp ZXdwb3J0LCBXS0NvbnRleHRSZWYgY29udGV4dFJlZiwgV0tQYWdlR3JvdXBSZWYgcGFnZUdyb3Vw UmVmKQotewotICAgIHFfcHRyID0gdmlld3BvcnQ7Ci0gICAgdmlld3BvcnQtPnNldEZsYWdzKFFR dWlja0l0ZW06Okl0ZW1DbGlwc0NoaWxkcmVuVG9TaGFwZSk7Ci0KLSAgICBRT2JqZWN0Ojpjb25u ZWN0KHZpZXdwb3J0LCBTSUdOQUwodmlzaWJsZUNoYW5nZWQoKSksIHZpZXdwb3J0LCBTTE9UKF9x X29uVmlzaWJsZUNoYW5nZWQoKSkpOwotICAgIHBhZ2VWaWV3LnJlc2V0KG5ldyBRUXVpY2tXZWJQ YWdlKHZpZXdwb3J0KSk7Ci0KLSAgICBRUXVpY2tXZWJQYWdlUHJpdmF0ZSogY29uc3QgcGFnZVZp ZXdQcml2YXRlID0gcGFnZVZpZXcuZGF0YSgpLT5kOwotICAgIHNldFBhZ2VQcm94eShuZXcgUXRX ZWJQYWdlUHJveHkocGFnZVZpZXcuZGF0YSgpLCBxX3B0ciwgMCwgdGhpcywgY29udGV4dFJlZiwg cGFnZUdyb3VwUmVmKSk7Ci0gICAgcGFnZVZpZXdQcml2YXRlLT5zZXRQYWdlUHJveHkocGFnZVBy b3h5LmRhdGEoKSk7Ci0KLSAgICBRV2ViUHJlZmVyZW5jZXNQcml2YXRlOjpnZXQocGFnZVByb3h5 LT5wcmVmZXJlbmNlcygpKS0+c2V0QXR0cmlidXRlKFFXZWJQcmVmZXJlbmNlc1ByaXZhdGU6OkFj Y2VsZXJhdGVkQ29tcG9zaXRpbmdFbmFibGVkLCB0cnVlKTsKLSAgICBwYWdlUHJveHktPmluaXQo KTsKLQotICAgIFFPYmplY3Q6OmNvbm5lY3QocGFnZVByb3h5LmRhdGEoKSwgU0lHTkFMKHVwZGF0 ZU5hdmlnYXRpb25TdGF0ZSgpKSwgcV9wdHIsIFNJR05BTChuYXZpZ2F0aW9uU3RhdGVDaGFuZ2Vk KCkpKTsKLX0KLQogdm9pZCBRUXVpY2tXZWJWaWV3UHJpdmF0ZTo6aW5pdGlhbGl6ZURlc2t0b3Ao UVF1aWNrV2ViVmlldyogdmlld3BvcnQpCiB7CiAgICAgaWYgKGludGVyYWN0aW9uRW5naW5lKSB7 CkBAIC00NzQsMjEgKzQ2OSwxOSBAQCB2b2lkIFFRdWlja1dlYlZpZXdFeHBlcmltZW50YWw6OnNl dFByb21wdERpYWxvZyhRRGVjbGFyYXRpdmVDb21wb25lbnQqIHByb21wdERpYQogCiBRUXVpY2tX ZWJWaWV3OjpRUXVpY2tXZWJWaWV3KFFRdWlja0l0ZW0qIHBhcmVudCkKICAgICA6IFFRdWlja0l0 ZW0ocGFyZW50KQotICAgICwgZF9wdHIobmV3IFFRdWlja1dlYlZpZXdQcml2YXRlKQorICAgICwg ZF9wdHIobmV3IFFRdWlja1dlYlZpZXdQcml2YXRlKHRoaXMpKQogICAgICwgbV9leHBlcmltZW50 YWwobmV3IFFRdWlja1dlYlZpZXdFeHBlcmltZW50YWwodGhpcykpCiB7CiAgICAgUV9EKFFRdWlj a1dlYlZpZXcpOwotICAgIGQtPmluaXRpYWxpemUodGhpcyk7CiAgICAgZC0+aW5pdGlhbGl6ZVRv dWNoKHRoaXMpOwogfQogCiBRUXVpY2tXZWJWaWV3OjpRUXVpY2tXZWJWaWV3KFdLQ29udGV4dFJl ZiBjb250ZXh0UmVmLCBXS1BhZ2VHcm91cFJlZiBwYWdlR3JvdXBSZWYsIFFRdWlja0l0ZW0qIHBh cmVudCkKICAgICA6IFFRdWlja0l0ZW0ocGFyZW50KQotICAgICwgZF9wdHIobmV3IFFRdWlja1dl YlZpZXdQcml2YXRlKQorICAgICwgZF9wdHIobmV3IFFRdWlja1dlYlZpZXdQcml2YXRlKHRoaXMs IGNvbnRleHRSZWYsIHBhZ2VHcm91cFJlZikpCiAgICAgLCBtX2V4cGVyaW1lbnRhbChuZXcgUVF1 aWNrV2ViVmlld0V4cGVyaW1lbnRhbCh0aGlzKSkKIHsKICAgICBRX0QoUVF1aWNrV2ViVmlldyk7 Ci0gICAgZC0+aW5pdGlhbGl6ZSh0aGlzLCBjb250ZXh0UmVmLCBwYWdlR3JvdXBSZWYpOwogICAg IC8vIFVzZWQgYnkgV2ViS2l0VGVzdFJ1bm5lci4KICAgICBkLT5zZXRVc2VUcmFkaXRpb25hbERl c2t0b3BCZWhhdmlvdXIodHJ1ZSk7CiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvQVBJL3F0L3FxdWlja3dlYnZpZXdfcF9wLmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvQVBJL3F0L3FxdWlja3dlYnZpZXdfcF9wLmgKaW5kZXggZTY0NmM4MGQwY2I3ZmFlODI5MGY3 NTUxOTI5NDAxZWQzNzE4MjgyNy4uM2FlMjU2MTlkNTQwODk0ZWI5OGUyZThiMzFjMDExZWRmOThh YmEzYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xcXVpY2t3 ZWJ2aWV3X3BfcC5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXF1aWNr d2Vidmlld19wX3AuaApAQCAtNDUsMTAgKzQ1LDkgQEAgY2xhc3MgUVF1aWNrV2ViVmlld1ByaXZh dGUgOiBwdWJsaWMgV2ViS2l0OjpRdFBvbGljeUludGVyZmFjZSB7CiAgICAgZnJpZW5kIGNsYXNz IFFRdWlja1dlYlZpZXdFeHBlcmltZW50YWw7CiAKIHB1YmxpYzoKLSAgICBRUXVpY2tXZWJWaWV3 UHJpdmF0ZSgpOworICAgIFFRdWlja1dlYlZpZXdQcml2YXRlKFFRdWlja1dlYlZpZXcqIHZpZXdw b3J0LCBXS0NvbnRleHRSZWYgY29udGV4dFJlZiA9IDAsIFdLUGFnZUdyb3VwUmVmIHBhZ2VHcm91 cFJlZiA9IDApOwogICAgIHZpcnR1YWwgflFRdWlja1dlYlZpZXdQcml2YXRlKCkgeyB9CiAgICAg dm9pZCBzZXRQYWdlUHJveHkoUXRXZWJQYWdlUHJveHkqKTsKLSAgICB2b2lkIGluaXRpYWxpemUo UVF1aWNrV2ViVmlldyogdmlld3BvcnQsIFdLQ29udGV4dFJlZiBjb250ZXh0UmVmID0gMCwgV0tQ YWdlR3JvdXBSZWYgcGFnZUdyb3VwUmVmID0gMCk7CiAgICAgdm9pZCBpbml0aWFsaXplVG91Y2go UVF1aWNrV2ViVmlldyogdmlld3BvcnQpOwogICAgIHZvaWQgaW5pdGlhbGl6ZURlc2t0b3AoUVF1 aWNrV2ViVmlldyogdmlld3BvcnQpOwogICAgIHZvaWQgZW5hYmxlTW91c2VFdmVudHMoKTsK