72879 2011-11-21 06:51:56 -0800 [GTK] Add a way to skip unit tests in the bots 2011-11-21 11:12:19 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned gustavo pnormand oldest_to_newest 506922 0 cgarcia 2011-11-21 06:51:56 -0800 testdownload is currently failing in the bots, but not for us, it would be great to be able to skip tests in the bots. It would be even better to be able to skip paths of the tests, but gtester doesn't implement it, so we need to skip full tests for now. 506924 1 116078 cgarcia 2011-11-21 06:56:58 -0800 Created attachment 116078 Patch I've rewritten the whole script in python to make it easier to modify for everybody. Last time we had to change this script we already agreed with kov to port it to python, but we didn't do it in the end. 506946 2 116078 pnormand 2011-11-21 07:28:47 -0800 Comment on attachment 116078 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=116078&action=review Looks good, thanks! Just a little nit to fix before landing. > Tools/Scripts/run-gtk-tests:79 > + raise I don't think this works, raise needs a following exception, you should use the traceback module: import traceback traceback.print_exc() 506975 3 cgarcia 2011-11-21 08:10:12 -0800 (In reply to comment #2) > (From update of attachment 116078 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=116078&action=review > > Looks good, thanks! Just a little nit to fix before landing. > > > Tools/Scripts/run-gtk-tests:79 > > + raise > > I don't think this works, raise needs a following exception, you should use the traceback module: > > import traceback > traceback.print_exc() that raise was just for debugging, I forgot to remove it before sending the patch. 506988 4 cgarcia 2011-11-21 08:22:11 -0800 Committed r100919: <http://trac.webkit.org/changeset/100919> 507075 5 pnormand 2011-11-21 10:57:13 -0800 Borked our Debug bots! Traceback (most recent call last): File "./Tools/Scripts/run-gtk-tests", line 84, in <module> sys.exit(TestRunner().run()) File "./Tools/Scripts/run-gtk-tests", line 38, in __init__ for test_file in os.listdir(os.path.join(self._programs_path, test_dir)): OSError: [Errno 2] No such file or directory: '/home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Release/Programs/unittests That's because we never call set-webkit-configuration it seems. So webkit-build-directory always returns Release. 507087 6 pnormand 2011-11-21 11:10:28 -0800 (In reply to comment #5) > Borked our Debug bots! > > Traceback (most recent call last): > File "./Tools/Scripts/run-gtk-tests", line 84, in <module> > sys.exit(TestRunner().run()) > File "./Tools/Scripts/run-gtk-tests", line 38, in __init__ > for test_file in os.listdir(os.path.join(self._programs_path, test_dir)): > OSError: [Errno 2] No such file or directory: '/home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Release/Programs/unittests > > That's because we never call set-webkit-configuration it seems. So webkit-build-directory always returns Release. Landed a temporary workaround http://trac.webkit.org/changeset/100938 507091 7 pnormand 2011-11-21 11:12:19 -0800 See also bug 72902 116078 2011-11-21 06:56:58 -0800 2011-11-21 07:28:47 -0800 Patch wk-skip-unit-tests.diff text/plain 4764 cgarcia ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAxZmU2 OTIzLi5hYTIyYmQzIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMTEtMjEgIENhcmxvcyBHYXJjaWEgQ2FtcG9z ICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIEFkZCBhIHdheSB0byBza2lw IHVuaXQgdGVzdHMgaW4gdGhlIGJvdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTcyODc5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgUmV3cml0ZSB0aGUgc2NyaXB0IGluIHB5dGhvbiB0byBtYWtlIGl0IGVh c2llciBmb3IgZXZlcnlib2R5IHRvCisgICAgICAgIGNoYW5nZSBpdCBhbmQgYWRkIHN1cHBvcnQg Zm9yIHNraXBwaW5nIHRlc3RzLgorCisgICAgICAgICogU2NyaXB0cy9ydW4tZ3RrLXRlc3RzOgor CiAyMDExLTExLTIxICBEb21pbmljIE1henpvbmkgIDxkbWF6em9uaUBnb29nbGUuY29tPgogCiAg ICAgICAgIEFjY2Vzc2liaWxpdHk6IE11bHRpc2VsZWN0IGxpc3QgYm94ZXMgbmVlZCB0byByZXBv cnQgdGhlIGFjdGl2ZSBvcHRpb24gaW4gYWRkaXRpb24gdG8gd2hpY2ggaXRlbXMgYXJlIHNlbGVj dGVkLgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy9ydW4tZ3RrLXRlc3RzIGIvVG9vbHMvU2Ny aXB0cy9ydW4tZ3RrLXRlc3RzCmluZGV4IDFkYjlhZTIuLjU0OWQ3MjggMTAwNzU1Ci0tLSBhL1Rv b2xzL1NjcmlwdHMvcnVuLWd0ay10ZXN0cworKysgYi9Ub29scy9TY3JpcHRzL3J1bi1ndGstdGVz dHMKQEAgLTEsNiArMSw2IEBACi0jIS91c3IvYmluL3BlcmwKKyMhL3Vzci9iaW4vZW52IHB5dGhv bgogIwotIyBDb3B5cmlnaHQgKEMpIDIwMDkgR3VzdGF2byBOb3JvbmhhIFNpbHZhIDxnbnNAZ25v bWUub3JnPgorIyBDb3B5cmlnaHQgKEMpIDIwMTEgSWdhbGlhIFMuTC4KICMKICMgVGhpcyBsaWJy YXJ5IGlzIGZyZWUgc29mdHdhcmU7IHlvdSBjYW4gcmVkaXN0cmlidXRlIGl0IGFuZC9vcgogIyBt b2RpZnkgaXQgdW5kZXIgdGhlIHRlcm1zIG9mIHRoZSBHTlUgTGlicmFyeSBHZW5lcmFsIFB1Ymxp YwpAQCAtMTcsNTIgKzE3LDcxIEBACiAjIHRoZSBGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb24sIElu Yy4sIDUxIEZyYW5rbGluIFN0cmVldCwgRmlmdGggRmxvb3IsCiAjIEJvc3RvbiwgTUEgMDIxMTAt MTMwMSwgVVNBLgogCi11c2Ugc3RyaWN0OwotdXNlIHdhcm5pbmdzOworZnJvbSB3ZWJraXRweS5j b21tb24uc3lzdGVtLmV4ZWN1dGl2ZSBpbXBvcnQgRXhlY3V0aXZlCitpbXBvcnQgc3VicHJvY2Vz cworaW1wb3J0IG9zLCBzeXMKIAotdXNlIEZpbmRCaW47Ci11c2UgbGliICRGaW5kQmluOjpCaW47 Ci11c2Ugd2Via2l0ZGlyczsKK2NsYXNzIFRlc3RSdW5uZXI6CiAKLSMgVGhpcyBpbml0aWFsaXpl cyB0aGUgY29ycmVjdCBjb25maWd1cmF0aW9uIChSZWxlYXNlL0RlYnVnKQotc2V0Q29uZmlndXJh dGlvbigpOworICAgIFRFU1RfRElSUyA9IFsgInVuaXR0ZXN0cyIsICJXZWJLaXQyQVBJVGVzdHMi IF0KKyAgICBTS0lQUEVEID0gWyAidW5pdHRlc3RzL3Rlc3Rkb3dubG9hZCIgXQogCi1teSBAdW5p dFRlc3RzOwotbXkgJHByb2dyYW1zRGlyZWN0b3J5ID0gcHJvZHVjdERpcigpIC4gIi9Qcm9ncmFt cyI7Ci1wdXNoKEB1bml0VGVzdHMsIGdsb2IoJHByb2dyYW1zRGlyZWN0b3J5IC4gIi91bml0dGVz dHMvKiIpKTsKLXB1c2goQHVuaXRUZXN0cywgZ2xvYigkcHJvZ3JhbXNEaXJlY3RvcnkgLiAiL1dl YktpdDJBUElUZXN0cy8qIikpOworICAgIGRlZiBfX2luaXRfXyhzZWxmKToKKyAgICAgICAgc2Vs Zi5fZXhlY3V0aXZlID0gRXhlY3V0aXZlKCkKIAotaWYgKCQjdW5pdFRlc3RzIDwgMSkgewotICAg IGRpZSAiRVJST1I6IHRlc3RzIG5vdCBmb3VuZCBpbiAkcHJvZ3JhbXNEaXJlY3RvcnkuXG4iOwot fQorICAgICAgICBidWlsZF9kaXJlY3Rvcnlfc2NyaXB0ID0gb3MucGF0aC5qb2luKG9zLnBhdGgu ZGlybmFtZShfX2ZpbGVfXyksICJ3ZWJraXQtYnVpbGQtZGlyZWN0b3J5IikKKyAgICAgICAgYnVp bGRfZGlyZWN0b3J5ID0gc2VsZi5fZXhlY3V0aXZlLnJ1bl9jb21tYW5kKFtidWlsZF9kaXJlY3Rv cnlfc2NyaXB0LCAiLS1jb25maWd1cmF0aW9uIl0pLnJzdHJpcCgpCiAKLW15ICRwaWQgPSBmb3Jr KCk7Ci1pZiAoJHBpZCA9PSAwKSB7Ci0gICAgY2xvc2UoU1RET1VUKSBvciBkaWUgIkNhbid0IGNs b3NlIFNURE9VVDogJCFcbiI7Ci0gICAgY2xvc2UoU1RERVJSKSBvciBkaWUgIkNhbid0IGNsb3Nl IFNUREVSUjogJCFcbiI7Ci0gICAgZXhlYygiWHZmYiA6MzEgLXNjcmVlbiAwIDgwMHg2MDB4MjQg LW5vbGlzdGVuIHRjcCIpOwotICAgIGV4aXQgMTsKLX0gZWxzaWYgKCRwaWQgPT0gLTEpIHsKLSAg ICBwcmludCAiRmFpbGVkIHRvIGZvcmsgWHZmYi4iOwotICAgIGV4aXQgMTsKLX0KKyAgICAgICAg c2VsZi5fcHJvZ3JhbXNfcGF0aCA9IG9zLnBhdGguam9pbihidWlsZF9kaXJlY3RvcnksICJQcm9n cmFtcyIpCisgICAgICAgIHNlbGYuX3Rlc3RzID0gW10KKyAgICAgICAgZm9yIHRlc3RfZGlyIGlu IHNlbGYuVEVTVF9ESVJTOgorICAgICAgICAgICAgZm9yIHRlc3RfZmlsZSBpbiBvcy5saXN0ZGly KG9zLnBhdGguam9pbihzZWxmLl9wcm9ncmFtc19wYXRoLCB0ZXN0X2RpcikpOgorICAgICAgICAg ICAgICAgIHRlc3RfcmVsYXRpdmVfcGF0aCA9IG9zLnBhdGguam9pbih0ZXN0X2RpciwgdGVzdF9m aWxlKQorICAgICAgICAgICAgICAgIGlmIHRlc3RfcmVsYXRpdmVfcGF0aCBpbiBzZWxmLlNLSVBQ RUQ6CisgICAgICAgICAgICAgICAgICAgIHN5cy5zdGRvdXQud3JpdGUoIlNraXBwaW5nIHRlc3Qg JXNcbiIgJSAodGVzdF9yZWxhdGl2ZV9wYXRoKSkKKyAgICAgICAgICAgICAgICAgICAgc3lzLnN0 ZG91dC5mbHVzaCgpCisgICAgICAgICAgICAgICAgICAgIGNvbnRpbnVlCiAKLSRFTlZ7IkRJU1BM QVkifSA9ICc6MzEnOworICAgICAgICAgICAgICAgIHRlc3RfcGF0aCA9IG9zLnBhdGguam9pbihz ZWxmLl9wcm9ncmFtc19wYXRoLCB0ZXN0X3JlbGF0aXZlX3BhdGgpCisgICAgICAgICAgICAgICAg aWYgb3MucGF0aC5pc2ZpbGUodGVzdF9wYXRoKSBhbmQgb3MuYWNjZXNzKHRlc3RfcGF0aCwgb3Mu WF9PSyk6CisgICAgICAgICAgICAgICAgICAgIHNlbGYuX3Rlc3RzLmFwcGVuZCh0ZXN0X3BhdGgp CiAKLW15ICRleGl0U3RhdHVzID0gMDsKLWZvcmVhY2ggbXkgJHVuaXRUZXN0IChAdW5pdFRlc3Rz KQotewotICAgIG5leHQgdW5sZXNzICgtZiAkdW5pdFRlc3QgYW5kIC14ICR1bml0VGVzdCk7Cisg ICAgZGVmIHJ1bihzZWxmKToKKyAgICAgICAgaWYgbm90IHNlbGYuX3Rlc3RzOgorICAgICAgICAg ICAgc3lzLnN0ZGVyci53cml0ZSgiRVJST1I6IHRlc3RzIG5vdCBmb3VuZCBpbiAlcy5cbiIgJSAo c2VsZi5fcHJvZ3JhbXNfcGF0aCkpCisgICAgICAgICAgICBzeXMuc3RkZXJyLmZsdXNoKCkKKyAg ICAgICAgICAgIHJldHVybiAxCiAKLSAgICBzeXN0ZW0gImd0ZXN0ZXIgJHVuaXRUZXN0IjsKLSAg ICBpZiAoJD8pIHsKLSAgICAgICAgJGV4aXRTdGF0dXMgPSAkPzsKLSAgICB9Ci19CisgICAgICAg IHRlc3RfZW52ID0gb3MuZW52aXJvbgorICAgICAgICB0ZXN0X2VudlsiRElTUExBWSJdID0gIjoz MSIKIAota2lsbCA5LCAkcGlkIHVubGVzcyAkcGlkIDw9IDA7CisgICAgICAgIGV4aXRfc3RhdHVz ID0gWzBdCisgICAgICAgIGRlZiBfZXJyb3JfaGFuZGxlcihlcnJvcik6CisgICAgICAgICAgICBl eGl0X3N0YXR1c1swXSA9IGVycm9yLmV4aXRfY29kZQogCi1pZiAoJGV4aXRTdGF0dXMpIHsKLSAg ICBwcmludCAiVGVzdHMgZmFpbGVkXG4iOwotICAgIGV4aXQgJGV4aXRTdGF0dXM7Ci19CisgICAg ICAgIGZvciB0ZXN0IGluIHNlbGYuX3Rlc3RzOgorICAgICAgICAgICAgb3V0ID0gc2VsZi5fZXhl Y3V0aXZlLnJ1bl9jb21tYW5kKFsnZ3Rlc3RlcicsIHRlc3RdLCBlbnY9dGVzdF9lbnYsCisgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZXJyb3JfaGFuZGxlcj1f ZXJyb3JfaGFuZGxlcikKKyAgICAgICAgICAgIHN5cy5zdGRvdXQud3JpdGUob3V0KQorICAgICAg ICAgICAgc3lzLnN0ZG91dC5mbHVzaCgpCisKKyAgICAgICAgaWYgZXhpdF9zdGF0dXNbMF06Cisg ICAgICAgICAgICBzeXMuc3Rkb3V0LndyaXRlKCJUZXN0cyBmYWlsZWRcbiIpCisgICAgICAgICAg ICBzeXMuc3Rkb3V0LmZsdXNoKCkKKworICAgICAgICByZXR1cm4gZXhpdF9zdGF0dXNbMF0KKwor aWYgX19uYW1lX18gPT0gIl9fbWFpbl9fIjoKKyAgICB0cnk6CisgICAgICAgIHh2ZmIgPSBFeGVj dXRpdmUoKS5wb3BlbihbIlh2ZmIiLCAiOjMxIiwgIi1zY3JlZW4iLCAiMCIsICI4MDB4NjAweDI0 IiwgIi1ub2xpc3RlbiIsICJ0Y3AiXSwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IHN0ZG91dD1zdWJwcm9jZXNzLlBJUEUsIHN0ZGVycj1zdWJwcm9jZXNzLlBJUEUpCisgICAgZXhj ZXB0OgorICAgICAgICByYWlzZQorICAgICAgICBzeXMuc3RkZXJyLndyaXRlKCJGYWlsZWQgdG8g cnVuIFh2ZmJcbiIpCisgICAgICAgIHN5cy5zdGRlcnIuZmx1c2goKQorICAgICAgICBzeXMuZXhp dCgxKQorCisgICAgdHJ5OgorICAgICAgICBzeXMuZXhpdChUZXN0UnVubmVyKCkucnVuKCkpCisg ICAgZmluYWxseToKKyAgICAgICAgeHZmYi5raWxsKCkK