72870 2011-11-21 04:14:26 -0800 [GTK] Enable WebSocket hybi tests 2011-11-21 19:39:19 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P3 Normal --- 1 yutak yutak webkit.review.bot oldest_to_newest 506861 0 yutak 2011-11-21 04:14:26 -0800 Implement LayoutTestController.overridePreference("WebKitHixie76WebSocketProtocolEnabled", bool) and enable WebSocket hybi tests (tests under http/tests/websocket/tests/hybi/). 506874 1 116067 yutak 2011-11-21 04:32:26 -0800 Created attachment 116067 Patch 507065 2 116067 xan.lopez 2011-11-21 10:46:36 -0800 Comment on attachment 116067 Patch Looks good to me. Thanks! 507374 3 yutak 2011-11-21 19:20:14 -0800 Thanks! 507377 4 116067 webkit.review.bot 2011-11-21 19:39:15 -0800 Comment on attachment 116067 Patch Clearing flags on attachment: 116067 Committed r100978: <http://trac.webkit.org/changeset/100978> 507378 5 webkit.review.bot 2011-11-21 19:39:19 -0800 All reviewed patches have been landed. Closing bug. 116067 2011-11-21 04:32:26 -0800 2011-11-21 19:39:15 -0800 Patch bug-72870-20111121213224.patch text/plain 6901 yutak U3VidmVyc2lvbiBSZXZpc2lvbjogMTAwODk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2d0 ay9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKaW5kZXggOGEzODE5ZjVl YzBlZWUxZTc3NmI3ZGFiNjQ2ZTVkNTlkMGI2ZjRlOS4uMDNkNTVhMzBhZDU1MWM2ZWRiNGYwYzMw NjhkZjYxNjUzZGUyMjMzMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEx LTExLTIxICBZdXRhIEtpdGFtdXJhICA8eXV0YWtAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtH VEtdIEVuYWJsZSBXZWJTb2NrZXQgaHliaSB0ZXN0cworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzI4NzAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBDaGFuZ2UgdGhlIHNldHRpbmdzIHZhbHVlIHRocm91Z2gg RHVtcFJlbmRlclRyZWVTdXBwb3J0R3RrLCBiZWNhdXNlIHdlIGRvIG5vdAorICAgICAgICB3YW50 IHRvIGV4cG9zZSB0aGlzIGFzIGEgcHVibGljIEFQSS4KKworICAgICAgICAqIFdlYkNvcmVTdXBw b3J0L0R1bXBSZW5kZXJUcmVlU3VwcG9ydEd0ay5jcHA6CisgICAgICAgIChEdW1wUmVuZGVyVHJl ZVN1cHBvcnRHdGs6OnNldEhpeGllNzZXZWJTb2NrZXRQcm90b2NvbEVuYWJsZWQpOgorICAgICAg ICBDaGFuZ2UgdGhlIHZhbHVlIG9mIGEgZmxhZyBpbiBXZWJDb3JlOjpTZXR0aW5ncy4KKyAgICAg ICAgKiBXZWJDb3JlU3VwcG9ydC9EdW1wUmVuZGVyVHJlZVN1cHBvcnRHdGsuaDoKKwogMjAxMS0x MC0xNyAgQW50b25pbyBHb21lcyAgPGFnb21lc0ByaW0uY29tPgogCiAgICAgICAgIFBhc3MgYSBG cmFtZSogcGFyYW1ldGVyIGluIEVkaXRvckNsaWVudDo6cmVzcG9uZFRvQ2hhbmdlZFNlbGVjdGlv bgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvRHVtcFJlbmRl clRyZWVTdXBwb3J0R3RrLmNwcCBiL1NvdXJjZS9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0R1 bXBSZW5kZXJUcmVlU3VwcG9ydEd0ay5jcHAKaW5kZXggODcwYTUyZTg5NzE0ODU0Yzc2ZTlhODll ODk5OTA0NTY5NDZhZTNkYi4uZmY3ZGMxYTM5ZGE4MTY5MDNjYTA3NGQ0ZmNmOTI2MzE5ZDQ2Yzhl OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvRHVtcFJlbmRl clRyZWVTdXBwb3J0R3RrLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9y dC9EdW1wUmVuZGVyVHJlZVN1cHBvcnRHdGsuY3BwCkBAIC04OTAsMyArODkwLDEzIEBAIGludCBE dW1wUmVuZGVyVHJlZVN1cHBvcnRHdGs6Om51bWJlck9mUGVuZGluZ0dlb2xvY2F0aW9uUGVybWlz c2lvblJlcXVlc3RzKFdlYktpCiAgICAgcmV0dXJuIDA7CiAjZW5kaWYKIH0KKwordm9pZCBEdW1w UmVuZGVyVHJlZVN1cHBvcnRHdGs6OnNldEhpeGllNzZXZWJTb2NrZXRQcm90b2NvbEVuYWJsZWQo V2ViS2l0V2ViVmlldyogd2ViVmlldywgYm9vbCBlbmFibGVkKQoreworI2lmIEVOQUJMRShXRUJf U09DS0VUUykKKyAgICBjb3JlKHdlYlZpZXcpLT5zZXR0aW5ncygpLT5zZXRVc2VIaXhpZTc2V2Vi U29ja2V0UHJvdG9jb2woZW5hYmxlZCk7CisjZWxzZQorICAgIFVOVVNFRF9QQVJBTSh3ZWJWaWV3 KTsKKyAgICBVTlVTRURfUEFSQU0oZW5hYmxlZCk7CisjZW5kaWYKK30KZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0R1bXBSZW5kZXJUcmVlU3VwcG9ydEd0ay5o IGIvU291cmNlL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvRHVtcFJlbmRlclRyZWVTdXBwb3J0 R3RrLmgKaW5kZXggY2M5Y2M5N2NjNmFlYTM1MmEzNGFiMzIyM2IzNzIyZjQ3NjQzOGM4Mi4uOTMw OWE5MmZlNWE4OGMyMTI5OTk1NWFjOWJhMzUwMmEzMTQ2NWNhOSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvRHVtcFJlbmRlclRyZWVTdXBwb3J0R3RrLmgKKysr IGIvU291cmNlL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvRHVtcFJlbmRlclRyZWVTdXBwb3J0 R3RrLmgKQEAgLTEyNiw2ICsxMjYsOCBAQCBwdWJsaWM6CiAgICAgc3RhdGljIHZvaWQgc2V0TW9j a0dlb2xvY2F0aW9uRXJyb3IoV2ViS2l0V2ViVmlldyosIGludCBlcnJvckNvZGUsIGNvbnN0IGdj aGFyKiBlcnJvck1lc3NhZ2UpOwogICAgIHN0YXRpYyBpbnQgbnVtYmVyT2ZQZW5kaW5nR2VvbG9j YXRpb25QZXJtaXNzaW9uUmVxdWVzdHMoV2ViS2l0V2ViVmlldyopOwogCisgICAgc3RhdGljIHZv aWQgc2V0SGl4aWU3NldlYlNvY2tldFByb3RvY29sRW5hYmxlZChXZWJLaXRXZWJWaWV3KiwgYm9v bCBlbmFibGVkKTsKKwogcHJpdmF0ZToKICAgICBzdGF0aWMgYm9vbCBzX2RydFJ1bjsKICAgICBz dGF0aWMgYm9vbCBzX2xpbmtzSW5jbHVkZWRJblRhYkNoYWluOwpkaWZmIC0tZ2l0IGEvVG9vbHMv Q2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IDFmZTY5MjNhOWRkZmZmNGJlNjdmOTBh N2JiOWJkYTg2YjUzZGVlOWUuLmFkOTQzOGY5ZjYzOWU3MGVjMmJmOWRlYzNlZGFmYmVjMDFmNWRh OWMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxNyBAQAorMjAxMS0xMS0yMSAgWXV0YSBLaXRhbXVyYSAgPHl1dGFrQGNocm9taXVt Lm9yZz4KKworICAgICAgICBbR1RLXSBFbmFibGUgV2ViU29ja2V0IGh5YmkgdGVzdHMKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcyODcwCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJl ZS9ndGsvRHVtcFJlbmRlclRyZWUuY3BwOgorICAgICAgICAocmVzZXREZWZhdWx0c1RvQ29uc2lz dGVudFZhbHVlcyk6CisgICAgICAgIFJlc2V0IHRoZSBzZXR0aW5nIHZhbHVlIHRvIHRoZSBkZWZh dWx0IHZhbHVlICh0cnVlKS4KKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9ndGsvTGF5b3V0VGVz dENvbnRyb2xsZXJHdGsuY3BwOgorICAgICAgICAoTGF5b3V0VGVzdENvbnRyb2xsZXI6Om92ZXJy aWRlUHJlZmVyZW5jZSk6CisgICAgICAgIENoYW5nZSB0aGUgc2V0dGluZyB2YWx1ZSB0aHJvdWdo IGEgZnVuY3Rpb24gaW4gRHVtcFJlbmRlclRyZWVTdXBwb3J0R3RrLgorCiAyMDExLTExLTIxICBE b21pbmljIE1henpvbmkgIDxkbWF6em9uaUBnb29nbGUuY29tPgogCiAgICAgICAgIEFjY2Vzc2li aWxpdHk6IE11bHRpc2VsZWN0IGxpc3QgYm94ZXMgbmVlZCB0byByZXBvcnQgdGhlIGFjdGl2ZSBv cHRpb24gaW4gYWRkaXRpb24gdG8gd2hpY2ggaXRlbXMgYXJlIHNlbGVjdGVkLgpkaWZmIC0tZ2l0 IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvZ3RrL0R1bXBSZW5kZXJUcmVlLmNwcCBiL1Rvb2xzL0R1 bXBSZW5kZXJUcmVlL2d0ay9EdW1wUmVuZGVyVHJlZS5jcHAKaW5kZXggNWFmMTQwZGI4NzY0M2Zm YTc1YmJiYjRlY2ViNTc3NTRmZWY2NWEzZi4uYzk4NDExZTY1OGNmOWIyMGQzN2UxN2E5Mzg1Yzg3 NjhkMjk0NmFmOSAxMDA2NDQKLS0tIGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvZ3RrL0R1bXBSZW5k ZXJUcmVlLmNwcAorKysgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9ndGsvRHVtcFJlbmRlclRyZWUu Y3BwCkBAIC00NzYsNiArNDc2LDggQEAgc3RhdGljIHZvaWQgcmVzZXREZWZhdWx0c1RvQ29uc2lz dGVudFZhbHVlcygpCiAgICAgRHVtcFJlbmRlclRyZWVTdXBwb3J0R3RrOjpjbGVhck9wZW5lciht YWluRnJhbWUpOwogCiAgICAgRHVtcFJlbmRlclRyZWVTdXBwb3J0R3RrOjpyZXNldEdlb2xvY2F0 aW9uQ2xpZW50TW9jayh3ZWJWaWV3KTsKKworICAgIER1bXBSZW5kZXJUcmVlU3VwcG9ydEd0azo6 c2V0SGl4aWU3NldlYlNvY2tldFByb3RvY29sRW5hYmxlZCh3ZWJWaWV3LCB0cnVlKTsKIH0KIAog c3RhdGljIGJvb2wgdXNlTG9uZ1J1bm5pbmdTZXJ2ZXJNb2RlKGludCBhcmdjLCBjaGFyICphcmd2 W10pCmRpZmYgLS1naXQgYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9ndGsvTGF5b3V0VGVzdENvbnRy b2xsZXJHdGsuY3BwIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvZ3RrL0xheW91dFRlc3RDb250cm9s bGVyR3RrLmNwcAppbmRleCA3NzU1MjhiNTk1NDk4M2ViMTBmOTE3Yzg2YTk2MWYxNGM2OTgyZDI5 Li41MjkwNGZkYmM2NzQ0ZjY2NmE1NjI3ZDcxMDhiZDg0NzI3OGVjYzFjIDEwMDY0NAotLS0gYS9U b29scy9EdW1wUmVuZGVyVHJlZS9ndGsvTGF5b3V0VGVzdENvbnRyb2xsZXJHdGsuY3BwCisrKyBi L1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9MYXlvdXRUZXN0Q29udHJvbGxlckd0ay5jcHAKQEAg LTgzMCw2ICs4MzAsOSBAQCB2b2lkIExheW91dFRlc3RDb250cm9sbGVyOjpvdmVycmlkZVByZWZl cmVuY2UoSlNTdHJpbmdSZWYga2V5LCBKU1N0cmluZ1JlZiB2YWx1ZQogICAgIGVsc2UgaWYgKGdf c3RyX2VxdWFsKG9yaWdpbmFsTmFtZS5nZXQoKSwgIldlYktpdFRhYlRvTGlua3NQcmVmZXJlbmNl S2V5IikpIHsKICAgICAgICAgRHVtcFJlbmRlclRyZWVTdXBwb3J0R3RrOjpzZXRMaW5rc0luY2x1 ZGVkSW5Gb2N1c0NoYWluKCFnX2FzY2lpX3N0cmNhc2VjbXAodmFsdWVBc1N0cmluZy5nZXQoKSwg InRydWUiKSB8fCAhZ19hc2NpaV9zdHJjYXNlY21wKHZhbHVlQXNTdHJpbmcuZ2V0KCksICIxIikp OwogICAgICAgICByZXR1cm47CisgICAgfSBlbHNlIGlmIChnX3N0cl9lcXVhbChvcmlnaW5hbE5h bWUuZ2V0KCksICJXZWJLaXRIaXhpZTc2V2ViU29ja2V0UHJvdG9jb2xFbmFibGVkIikpIHsKKyAg ICAgICAgRHVtcFJlbmRlclRyZWVTdXBwb3J0R3RrOjpzZXRIaXhpZTc2V2ViU29ja2V0UHJvdG9j b2xFbmFibGVkKHdlYmtpdF93ZWJfZnJhbWVfZ2V0X3dlYl92aWV3KG1haW5GcmFtZSksICFnX2Fz Y2lpX3N0cmNhc2VjbXAodmFsdWVBc1N0cmluZy5nZXQoKSwgInRydWUiKSB8fCAhZ19hc2NpaV9z dHJjYXNlY21wKHZhbHVlQXNTdHJpbmcuZ2V0KCksICIxIikpOworICAgICAgICByZXR1cm47CiAg ICAgfSBlbHNlIHsKICAgICAgICAgZnByaW50ZihzdGRlcnIsICJMYXlvdXRUZXN0Q29udHJvbGxl cjo6b3ZlcnJpZGVQcmVmZXJlbmNlIHRyaWVkIHRvIG92ZXJyaWRlICIKICAgICAgICAgICAgICAg ICAidW5rbm93biBwcmVmZXJlbmNlICclcycuXG4iLCBvcmlnaW5hbE5hbWUuZ2V0KCkpOwpkaWZm IC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmlu ZGV4IGQ5NTY4NmZjNjJhYTIzZGI5OWMzYjQxYWYwMjFjZmE4ODdkMTlhNjkuLmFkNThmYzIyMmJk MmMwMTY5YmQxNmM5ODZjZmQwMjYyZDUxZjBhZmUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0No YW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAx MS0xMS0yMSAgWXV0YSBLaXRhbXVyYSAgPHl1dGFrQGNocm9taXVtLm9yZz4KKworICAgICAgICBb R1RLXSBFbmFibGUgV2ViU29ja2V0IGh5YmkgdGVzdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcyODcwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ndGsvU2tpcHBlZDoKKyAgICAgICAg VW5za2lwIFdlYlNvY2tldCBoeWJpIHRlc3RzLiBTa2lwIHR3byB0ZXN0cyB1c2luZyBGaWxlU3lz dGVtIEFQSSwgd2hpY2ggaXMgbm90IHlldAorICAgICAgICBzdXBwb3J0ZWQgaW4gR1RLIHBvcnQu CisKIDIwMTEtMTEtMjEgIFN0ZXZlIEJsb2NrICA8c3RldmVibG9ja0Bnb29nbGUuY29tPgogCiAg ICAgICAgIEFTU0VSVElPTiBGQUlMRUQ6IGZvbnRDYWNoZSgpLT5nZW5lcmF0aW9uKCkgPT0gbV9n ZW5lcmF0aW9uIChydW5uaW5nIG5ldy1ydW4td2Via2l0LXRlc3RzKQpkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1NraXBwZWQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsv U2tpcHBlZAppbmRleCA4ZTMzOTlkZTlmM2IyYjJiNDM1MjQ3Mzc4MDdkZThmMGQzMjc4NWQ4Li5j N2U2NzRmYjZiNzgyOTA3MDFjODVhZGM0NjdmZTUyMzNkZmI3ODRhIDEwMDY0NAotLS0gYS9MYXlv dXRUZXN0cy9wbGF0Zm9ybS9ndGsvU2tpcHBlZAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9n dGsvU2tpcHBlZApAQCAtMjgzLDYgKzI4Myw4IEBAIGh0dHAvdGVzdHMvbWlzYy93ZWJ0aW1pbmct dHdvLXJlZGlyZWN0cy5waHAKIGZhc3QvZmlsZXN5c3RlbQogaHR0cC90ZXN0cy9maWxlc3lzdGVt CiBodHRwL3Rlc3RzL3NlY3VyaXR5L2ZpbGVzeXN0ZW0taWZyYW1lLWZyb20tcmVtb3RlLmh0bWwK K2h0dHAvdGVzdHMvd2Vic29ja2V0L3Rlc3RzL2h5Ymkvc2VuZC1maWxlLWJsb2IuaHRtbAoraHR0 cC90ZXN0cy93ZWJzb2NrZXQvdGVzdHMvaHliaS9zZW5kLWZpbGUtYmxvYi1mYWlsLmh0bWwKIAog IyBSZXF1aXJlcyBXZWJQIHN1cHBvcnQuCiBmYXN0L2NhbnZhcy9jYW52YXMtdG9EYXRhVVJMLXdl YnAuaHRtbApAQCAtMTQ3OCw5ICsxNDgwLDYgQEAgaHR0cC90ZXN0cy9pbnNwZWN0b3IKIGh0dHAv dGVzdHMvaW5zcGVjdG9yLWVuYWJsZWQKIGluc3BlY3Rvci8KIAotIyBTa2lwcGVkIHVudGlsIG5l dyBXZWJTb2NrZXQgcHJvdG9jb2wgaXMgaW1wbGVtZW50ZWQuIGh0dHA6Ly93ZWJraXQub3JnL2Iv NTAwOTkKLWh0dHAvdGVzdHMvd2Vic29ja2V0L3Rlc3RzL2h5YmkvCi0KICMgVGV4dCBzaGFkb3cg ZXh0ZW50cyBhcmUgY2FsY3VsYXRlZCBpbmNvcnJlY3RseQogIyBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjUwMzUKIGZhc3QvY2FudmFzL2ZpbGxUZXh0LXNoYWRvdy5o dG1sCg==