72869 2011-11-21 04:05:52 -0800 [Qt] Clean up MiniBrowser project file after recent changes 2011-11-21 07:00:13 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED Qt P3 Normal --- 1 abecsi abecsi vestbo webkit.review.bot oldest_to_newest 506853 0 abecsi 2011-11-21 04:05:52 -0800 We use OTHER_FILES for the QML files to be listed in Qt Creator. Remove nonexistent files from OTHER_FILES and add the remainig only QML file as a dependency of the project. 506854 1 116063 abecsi 2011-11-21 04:07:37 -0800 Created attachment 116063 proposed patch 506856 2 webkit.review.bot 2011-11-21 04:10:14 -0800 Attachment 116063 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/MiniBrowser/qt/M..." exit_code: 1 Tools/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 506870 3 116063 vestbo 2011-11-21 04:25:57 -0800 Comment on attachment 116063 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=116063&action=review > Tools/MiniBrowser/qt/MiniBrowser.pro:40 > +PRE_TARGETDEPS += $$OTHER_FILES This should be handled by CONFIG += resources. If that's broken we should look at what's going on. 506877 4 116069 abecsi 2011-11-21 04:35:45 -0800 Created attachment 116069 proposed patch rcc should take care of the dependency, so the dependency bug should not be the scope of this change. 506926 5 116069 abecsi 2011-11-21 07:00:06 -0800 Comment on attachment 116069 proposed patch Clearing flags on attachment: 116069 Committed r100910: <http://trac.webkit.org/changeset/100910> 506928 6 abecsi 2011-11-21 07:00:13 -0800 All reviewed patches have been landed. Closing bug. 116063 2011-11-21 04:07:37 -0800 2011-11-21 04:35:45 -0800 proposed patch minibrowser.patch text/plain 1161 abecsi ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAxZmU2 OTIzLi43ZjkyMTI0IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMTEtMjEgIEFuZHJhcyBCZWNzaSAgPGFuZHJh cy5iZWNzaUBub2tpYS5jb20+CisKKyAgICAgICAgW1F0XSBDbGVhbiB1cCBNaW5pQnJvd3NlciBw cm9qZWN0IGZpbGUgYWZ0ZXIgcmVjZW50IGNoYW5nZXMKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZSB1c2UgT1RIRVJfRklMRVMgZm9yIHRoZSBRTUwg ZmlsZXMgdG8gYmUgbGlzdGVkIGluIFF0IENyZWF0b3IuCisgICAgICAgIFJlbW92ZSBub25leGlz dGVudCBmaWxlcyBmcm9tIE9USEVSX0ZJTEVTIGFuZCBhZGQgdGhlIHJlbWFpbmlnIG9ubHkKKyAg ICAgICAgUU1MIGZpbGUgYXMgYSBkZXBlbmRlbmN5IG9mIHRoZSBwcm9qZWN0LgorCisgICAgICAg ICogTWluaUJyb3dzZXIvcXQvTWluaUJyb3dzZXIucHJvOgorCiAyMDExLTExLTIxICBEb21pbmlj IE1henpvbmkgIDxkbWF6em9uaUBnb29nbGUuY29tPgogCiAgICAgICAgIEFjY2Vzc2liaWxpdHk6 IE11bHRpc2VsZWN0IGxpc3QgYm94ZXMgbmVlZCB0byByZXBvcnQgdGhlIGFjdGl2ZSBvcHRpb24g aW4gYWRkaXRpb24gdG8gd2hpY2ggaXRlbXMgYXJlIHNlbGVjdGVkLgpkaWZmIC0tZ2l0IGEvVG9v bHMvTWluaUJyb3dzZXIvcXQvTWluaUJyb3dzZXIucHJvIGIvVG9vbHMvTWluaUJyb3dzZXIvcXQv TWluaUJyb3dzZXIucHJvCmluZGV4IDhjYWQxN2MuLmUwZTY0NDQgMTAwNjQ0Ci0tLSBhL1Rvb2xz L01pbmlCcm93c2VyL3F0L01pbmlCcm93c2VyLnBybworKysgYi9Ub29scy9NaW5pQnJvd3Nlci9x dC9NaW5pQnJvd3Nlci5wcm8KQEAgLTM1LDYgKzM1LDYgQEAgbWFjeDogUVQgKz0geG1sCiBSRVNP VVJDRVMgKz0gTWluaUJyb3dzZXIucXJjCiAKIE9USEVSX0ZJTEVTICs9IFwKLSAgICBxbWwvQnJv d3NlcldpbmRvdy5xbWwgXAotICAgIHFtbC9EZXNrdG9wVmlldy5xbWwgXAotICAgIHFtbC9Ub3Vj aFZpZXcucW1sCisgICAgJCRQV0QvcW1sL0Jyb3dzZXJXaW5kb3cucW1sCisKK1BSRV9UQVJHRVRE RVBTICs9ICQkT1RIRVJfRklMRVMK 116069 2011-11-21 04:35:45 -0800 2011-11-21 07:00:06 -0800 proposed patch minibrowser.patch text/plain 1075 abecsi ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAxZmU2 OTIzLi4yNjQ5NDk2IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMTEtMjEgIEFuZHJhcyBCZWNzaSAgPGFuZHJh cy5iZWNzaUBub2tpYS5jb20+CisKKyAgICAgICAgW1F0XSBDbGVhbiB1cCBNaW5pQnJvd3NlciBw cm9qZWN0IGZpbGUgYWZ0ZXIgcmVjZW50IGNoYW5nZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcyODY5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgUmVtb3ZlIG5vbmV4aXN0ZW50IGZpbGVzIGZyb20gT1RI RVJfRklMRVMgYWZ0ZXIgb3VyIHRvdWNoIGFuZCBkZXNrdG9wIHdlYnZpZXdzIHdlcmUgbWVyZ2Vk LgorCisgICAgICAgICogTWluaUJyb3dzZXIvcXQvTWluaUJyb3dzZXIucHJvOgorCiAyMDExLTEx LTIxICBEb21pbmljIE1henpvbmkgIDxkbWF6em9uaUBnb29nbGUuY29tPgogCiAgICAgICAgIEFj Y2Vzc2liaWxpdHk6IE11bHRpc2VsZWN0IGxpc3QgYm94ZXMgbmVlZCB0byByZXBvcnQgdGhlIGFj dGl2ZSBvcHRpb24gaW4gYWRkaXRpb24gdG8gd2hpY2ggaXRlbXMgYXJlIHNlbGVjdGVkLgpkaWZm IC0tZ2l0IGEvVG9vbHMvTWluaUJyb3dzZXIvcXQvTWluaUJyb3dzZXIucHJvIGIvVG9vbHMvTWlu aUJyb3dzZXIvcXQvTWluaUJyb3dzZXIucHJvCmluZGV4IDhjYWQxN2MuLjVjNDMxOTggMTAwNjQ0 Ci0tLSBhL1Rvb2xzL01pbmlCcm93c2VyL3F0L01pbmlCcm93c2VyLnBybworKysgYi9Ub29scy9N aW5pQnJvd3Nlci9xdC9NaW5pQnJvd3Nlci5wcm8KQEAgLTM1LDYgKzM1LDQgQEAgbWFjeDogUVQg Kz0geG1sCiBSRVNPVVJDRVMgKz0gTWluaUJyb3dzZXIucXJjCiAKIE9USEVSX0ZJTEVTICs9IFwK LSAgICBxbWwvQnJvd3NlcldpbmRvdy5xbWwgXAotICAgIHFtbC9EZXNrdG9wVmlldy5xbWwgXAot ICAgIHFtbC9Ub3VjaFZpZXcucW1sCisgICAgcW1sL0Jyb3dzZXJXaW5kb3cucW1sCg==