72867 2011-11-21 03:05:48 -0800 REGRESSION(r100856): New test fast/css/style-tag-display-none.html fails on Chromium (Requested by steveblock on #webkit). 2011-11-21 14:52:52 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 71703 1 webkit.review.bot webkit.review.bot davidbarr dglazkov eric koivisto macpherson mikelawther oldest_to_newest 506827 0 webkit.review.bot 2011-11-21 03:05:48 -0800 http://trac.webkit.org/changeset/100856 broke the build: New test fast/css/style-tag-display-none.html fails on Chromium (Requested by steveblock on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear 506828 1 116058 webkit.review.bot 2011-11-21 03:06:21 -0800 Created attachment 116058 ROLLOUT of r100856 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. 506829 2 116058 webkit.review.bot 2011-11-21 03:11:18 -0800 Comment on attachment 116058 ROLLOUT of r100856 Clearing flags on attachment: 116058 Committed r100896: <http://trac.webkit.org/changeset/100896> 506830 3 webkit.review.bot 2011-11-21 03:11:22 -0800 All reviewed patches have been landed. Closing bug. 507109 4 eric 2011-11-21 11:40:33 -0800 Did it need a rebaseline? What was the issue? Please comment in the original bug when you roll out changes to explain why you're rolling them out. :( 507212 5 mikelawther 2011-11-21 14:31:17 -0800 I chatted with Steve on IRC after the rollback. He said it was because the result was labelled as 'MISSING', rather than any tests actually failing. I don't know why the bots were thinking the test result was missing, since the test and the result were committed at the same time into the same directory. 507215 6 dglazkov 2011-11-21 14:33:43 -0800 (In reply to comment #5) > I chatted with Steve on IRC after the rollback. He said it was because the result was labelled as 'MISSING', rather than any tests actually failing. > > I don't know why the bots were thinking the test result was missing, since the test and the result were committed at the same time into the same directory. It looks like the were no pixel results submitted with the test. Actually -- this test could totally be dumpAsText, no need for platform-specific pixel results. 507233 7 koivisto 2011-11-21 14:51:55 -0800 (In reply to comment #6) > Actually -- this test could totally be dumpAsText, no need for platform-specific pixel results. I don't think so. The bug tested is very sensitive to the exact document structure. Inclusion of <script> in the head likely to make the bug disappear. 507239 8 koivisto 2011-11-21 14:52:52 -0800 It would actually be good to mention that in the test case. 116058 2011-11-21 03:06:21 -0800 2011-11-21 03:11:18 -0800 ROLLOUT of r100856 bug-72867-20111121110708.patch text/plain 3520 webkit.review.bot U3VidmVyc2lvbiBSZXZpc2lvbjogMTAwODk1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjNjNzBmZGNkN2I3NmQ5 NjYyN2JkODY4OTUzMTlmZWEyNWMxMDA4Ni4uYjI1YzZiNDQ1ZGQwMTY0MzU1YTJjMDZjNTY0Nzkz NjIwZjlmNTU3ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDExLTExLTIxICBTaGVy aWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KKworICAgICAgICBVbnJldmll d2VkLCByb2xsaW5nIG91dCByMTAwODU2LgorICAgICAgICBodHRwOi8vdHJhYy53ZWJraXQub3Jn L2NoYW5nZXNldC8xMDA4NTYKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTcyODY3CisKKyAgICAgICAgTmV3IHRlc3QgZmFzdC9jc3Mvc3R5bGUtdGFnLWRp c3BsYXktbm9uZS5odG1sIGZhaWxzIG9uCisgICAgICAgIENocm9taXVtIChSZXF1ZXN0ZWQgYnkg c3RldmVibG9jayBvbiAjd2Via2l0KS4KKworICAgICAgICAqIGNzcy9DU1NTdHlsZVNlbGVjdG9y LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNTU1N0eWxlU2VsZWN0b3I6Om1hdGNoVUFSdWxlcyk6 CisKIDIwMTEtMTEtMjEgIEpvY2hlbiBFaXNpbmdlciAgPGpvY2hlbkBjaHJvbWl1bS5vcmc+CiAK ICAgICAgICAgSW1wbGVtZW50IE1ldGEgcmVmZXJyZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2Nzcy9DU1NTdHlsZVNlbGVjdG9yLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NTdHls ZVNlbGVjdG9yLmNwcAppbmRleCBkM2Q1Mjg5NTNmYTFiNTI3MjFhMTMxNjQ5YzczMDYzODc3NWMy MmE4Li44YWNlZDA3YmM4NGQwMDBlNWZiYTYwNTYwYWIzNmM5OWQxYjlmNTI5IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTU3R5bGVTZWxlY3Rvci5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvY3NzL0NTU1N0eWxlU2VsZWN0b3IuY3BwCkBAIC0xMTM1LDggKzExMzUsNiBAQCB2b2lk IENTU1N0eWxlU2VsZWN0b3I6Om1hdGNoVUFSdWxlcyhNYXRjaFJlc3VsdCYgcmVzdWx0KQogICAg IE1hdGNoaW5nVUFSdWxlc1Njb3BlIHNjb3BlOwogCiAgICAgLy8gRmlyc3Qgd2UgbWF0Y2ggcnVs ZXMgZnJvbSB0aGUgdXNlciBhZ2VudCBzaGVldC4KLSAgICBpZiAoc2ltcGxlRGVmYXVsdFN0eWxl U2hlZXQpCi0gICAgICAgIHJlc3VsdC5pc0NhY2hlYWJsZSA9IGZhbHNlOwogICAgIFJ1bGVTZXQq IHVzZXJBZ2VudFN0eWxlU2hlZXQgPSBtX21lZGl1bS0+bWVkaWFUeXBlTWF0Y2hTcGVjaWZpYygi cHJpbnQiKQogICAgICAgICA/IGRlZmF1bHRQcmludFN0eWxlIDogZGVmYXVsdFN0eWxlOwogICAg IG1hdGNoUnVsZXModXNlckFnZW50U3R5bGVTaGVldCwgcmVzdWx0LmZpcnN0VUFSdWxlLCByZXN1 bHQubGFzdFVBUnVsZSwgZmFsc2UpOwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9n IGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGRmZTViODUzODg4MWE5MWQ1ZmM0MTY0NmIx MTRhYWU4YmZlYzUzYjEuLjEzNWE5ZTQ5NzllZTBlMDhmZjIwMGJhNGFjMDhiOTNiODYxOGUxNTEg MTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMS0xMS0yMSAgU2hlcmlmZiBCb3QgIDx3ZWJraXQu cmV2aWV3LmJvdEBnbWFpbC5jb20+CisKKyAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQg cjEwMDg1Ni4KKyAgICAgICAgaHR0cDovL3RyYWMud2Via2l0Lm9yZy9jaGFuZ2VzZXQvMTAwODU2 CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03Mjg2Nwor CisgICAgICAgIE5ldyB0ZXN0IGZhc3QvY3NzL3N0eWxlLXRhZy1kaXNwbGF5LW5vbmUuaHRtbCBm YWlscyBvbgorICAgICAgICBDaHJvbWl1bSAoUmVxdWVzdGVkIGJ5IHN0ZXZlYmxvY2sgb24gI3dl YmtpdCkuCisKKyAgICAgICAgKiBmYXN0L2Nzcy9zdHlsZS10YWctZGlzcGxheS1ub25lLWV4cGVj dGVkLnR4dDogUmVtb3ZlZC4KKyAgICAgICAgKiBmYXN0L2Nzcy9zdHlsZS10YWctZGlzcGxheS1u b25lLmh0bWw6IFJlbW92ZWQuCisKIDIwMTEtMTEtMjEgIEpvY2hlbiBFaXNpbmdlciAgPGpvY2hl bkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgSW1wbGVtZW50IE1ldGEgcmVmZXJyZXIKZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvY3NzL3N0eWxlLXRhZy1kaXNwbGF5LW5vbmUtZXhwZWN0 ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9jc3Mvc3R5bGUtdGFnLWRpc3BsYXktbm9uZS1leHBl Y3RlZC50eHQKZGVsZXRlZCBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDY0ODdhZWUyMjBmMzg1MGM1 Njc3YjNlMDA3ZDNlYzg4ZGZmMjRkZTcuLjAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9jc3Mvc3R5bGUtdGFnLWRpc3BsYXktbm9u ZS1leHBlY3RlZC50eHQKKysrIC9kZXYvbnVsbApAQCAtMSw4ICswLDAgQEAKLWxheWVyIGF0ICgw LDApIHNpemUgODAweDYwMAotICBSZW5kZXJWaWV3IGF0ICgwLDApIHNpemUgODAweDYwMAotbGF5 ZXIgYXQgKDAsMCkgc2l6ZSA4MDB4OAotICBSZW5kZXJCbG9jayB7SFRNTH0gYXQgKDAsMCkgc2l6 ZSA4MDB4OAotICAgIFJlbmRlckJvZHkge0JPRFl9IGF0ICg4LDgpIHNpemUgNzg0eDAKLSAgICAg IFJlbmRlcklubGluZSB7QX0gYXQgKDAsMCkgc2l6ZSAweDAgW2NvbG9yPSM1NTFBOEJdCi0gICAg ICBSZW5kZXJUZXh0IHsjdGV4dH0gYXQgKDAsMCkgc2l6ZSAweDAKLSAgICAgIFJlbmRlclRleHQg eyN0ZXh0fSBhdCAoMCwwKSBzaXplIDB4MApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9j c3Mvc3R5bGUtdGFnLWRpc3BsYXktbm9uZS5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9jc3Mvc3R5 bGUtdGFnLWRpc3BsYXktbm9uZS5odG1sCmRlbGV0ZWQgZmlsZSBtb2RlIDEwMDY0NAppbmRleCBh MjI4YzdkY2QzMTU5ZGQxYzE1NzY4YjQ3MjJlMDczMGQ4MWM1NDExLi4wMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwCi0tLSBhL0xheW91dFRlc3RzL2Zhc3QvY3NzL3N0eWxl LXRhZy1kaXNwbGF5LW5vbmUuaHRtbAorKysgL2Rldi9udWxsCkBAIC0xLDE3ICswLDAgQEAKLTwh RE9DVFlQRSBIVE1MPgotPGh0bWw+Ci0gIDxoZWFkPgotICAgIDxzdHlsZT4KLSAgICAgIC5oZWFk ZXIgewotICAgICAgICBvdmVyZmxvdzogYXV0bzsKLSAgICAgICAgY2xlYXI6IGJvdGg7Ci0gICAg ICB9Ci0gICAgPC9zdHlsZT4KLSAgPC9oZWFkPgotPGJvZHk+Ci0gIDxhIGhyZWY9IiI+PC9hPgot ICA8c2NyaXB0PgotICAgIGRvY3VtZW50LmRvY3VtZW50RWxlbWVudC5zZXRBdHRyaWJ1dGUoImRp ciIsICJsdHIiKTsKLSAgPC9zY3JpcHQ+Ci08L2JvZHk+Ci08L2h0bWw+Cg==