72865 2011-11-21 00:44:53 -0800 [Qt] WebSocket close tests are failing 2011-11-21 01:43:18 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) All All RESOLVED FIXED Qt P3 Normal --- 1 yutak yutak hausmann webkit.review.bot yael oldest_to_newest 506775 0 yutak 2011-11-21 00:44:53 -0800 The following five tests are failing: - http/tests/websocket/tests/hybi/close-before-open.html - http/tests/websocket/tests/hybi/close-code-and-reason.html - http/tests/websocket/tests/hybi/close.html - http/tests/websocket/tests/hybi/workers/close.html - http/tests/websocket/tests/hybi/workers/close-code-and-reason.html These tests are failing because SocketStreamHandleQt::platformClose() does not emit didCloseSocketStream() callback when it is called before the connection is established. I'm going to post a patch shortly. 506780 1 116048 yutak 2011-11-21 00:59:46 -0800 Created attachment 116048 Patch 506792 2 116048 hausmann 2011-11-21 01:24:25 -0800 Comment on attachment 116048 Patch Thanks! 506803 3 116048 webkit.review.bot 2011-11-21 01:43:14 -0800 Comment on attachment 116048 Patch Clearing flags on attachment: 116048 Committed r100891: <http://trac.webkit.org/changeset/100891> 506804 4 webkit.review.bot 2011-11-21 01:43:18 -0800 All reviewed patches have been landed. Closing bug. 116048 2011-11-21 00:59:46 -0800 2011-11-21 01:43:13 -0800 Patch bug-72865-20111121175944.patch text/plain 3872 yutak U3VidmVyc2lvbiBSZXZpc2lvbjogMTAwODg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDU0YTE3YzQ4OTQ2M2Y2 ZjVjMmQxODIwYWE1Njg3NmEwMDdkOWVhOS4uM2IxZDkxZjUxYTFhYjUwZDMxMWUxZmRlNTU4MTVm YmNkMDU5OTJjYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDExLTExLTIxICBZdXRh IEtpdGFtdXJhICA8eXV0YWtAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtRdF0gV2ViU29ja2V0 IGNsb3NlIHRlc3RzIGFyZSBmYWlsaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD03Mjg2NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9xdC9Tb2NrZXRTdHJlYW1IYW5kbGVR dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTb2NrZXRTdHJlYW1IYW5kbGVQcml2YXRlOjpjbG9z ZSk6CisgICAgICAgIEVtaXQgZGlkQ2xvc2VTb2NrZXRTdHJlYW0oKSBjYWxsYmFjayBldmVuIGJl Zm9yZSB0aGUgY29ubmVjdGlvbiBpcyBlc3RhYmxpc2hlZC4KKyAgICAgICAgQ2FsbCBtX3NvY2tl dC0+YWJvcnQoKSB0byBwcmV2ZW50ICJjb25uZWN0ZWQiIHNpZ25hbCBmcm9tIGZpcmluZy4KKwog MjAxMS0xMS0yMCAgS2VuaWNoaSBJc2hpYmFzaGkgIDxiYXNoaUBjaHJvbWl1bS5vcmc+CiAKICAg ICAgICAgW0Nocm9taXVtXSBSZW1vdmUgb2xkIGdldEZvbnRGYW1pbHlGb3JDaGFyYWN0ZXJzKCkg YW5kIGZhbWlseUZvckNoYXJzKCkgQVBJcy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL25ldHdvcmsvcXQvU29ja2V0U3RyZWFtSGFuZGxlUXQuY3BwIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vbmV0d29yay9xdC9Tb2NrZXRTdHJlYW1IYW5kbGVRdC5jcHAKaW5kZXggMjk0 MjA0MWNmZDExYTEyNmViMDY1MmQyMTA2YzZhZTRmMWQ0OTMyZi4uZDQ2MzkwOWU3NWQwZGQwMmIx MGVlY2IwZWFiYWM2MDliZTFiNWI5OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vbmV0d29yay9xdC9Tb2NrZXRTdHJlYW1IYW5kbGVRdC5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vbmV0d29yay9xdC9Tb2NrZXRTdHJlYW1IYW5kbGVRdC5jcHAKQEAgLTEwNiw2 ICsxMDYsMTEgQEAgaW50IFNvY2tldFN0cmVhbUhhbmRsZVByaXZhdGU6OnNlbmQoY29uc3QgY2hh ciogZGF0YSwgaW50IGxlbikKIAogdm9pZCBTb2NrZXRTdHJlYW1IYW5kbGVQcml2YXRlOjpjbG9z ZSgpCiB7CisgICAgaWYgKG1fc3RyZWFtSGFuZGxlLT5tX3N0YXRlID09IFNvY2tldFN0cmVhbUhh bmRsZUJhc2U6OkNvbm5lY3RpbmcpIHsKKyAgICAgICAgbV9zb2NrZXQtPmFib3J0KCk7CisgICAg ICAgIG1fc3RyZWFtSGFuZGxlLT5jbGllbnQoKS0+ZGlkQ2xvc2VTb2NrZXRTdHJlYW0obV9zdHJl YW1IYW5kbGUpOworICAgICAgICByZXR1cm47CisgICAgfQogICAgIGlmIChtX3NvY2tldCAmJiBt X3NvY2tldC0+c3RhdGUoKSA9PSBRQWJzdHJhY3RTb2NrZXQ6OkNvbm5lY3RlZFN0YXRlKQogICAg ICAgICBtX3NvY2tldC0+Y2xvc2UoKTsKIH0KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA2OWE4NjBiMTNiYzk4ODk1OGU3NTlj MmY4ODYwZjUyNzNjMzFiZjQ0Li5kYjg5MjcyYmMxNjQwZjQ5NDQzMTQzOWZjYTQzNzNlZDBmYTM1 MmMzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMTEtMjEgIFl1dGEgS2l0YW11cmEgIDx5 dXRha0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW1F0XSBXZWJTb2NrZXQgY2xvc2UgdGVzdHMg YXJlIGZhaWxpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTcyODY1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBwbGF0Zm9ybS9xdC9Ta2lwcGVkOgorICAgICAgICBVbnNraXAgZml2ZSBXZWJTb2NrZXQg dGVzdHMuIFJlbW92ZSAiZmFpbGluZyB3ZWJzb2NrZXQgdGVzdHMiIHNlY3Rpb24sCisgICAgICAg IGFzIHRoZXJlIGFyZSBubyB0ZXN0cyBpbiB0aGlzIHNlY3Rpb24uCisKIDIwMTEtMTEtMjAgIFNo aW55YSBLYXdhbmFrYSAgPHNoaW55YWtAZ29vZ2xlLmNvbT4KIAogICAgICAgICBbQ2hyb21pdW1d IExheW91dCB0ZXN0IGRvZXMgbm90IHJldHVybiBjb3JyZWN0IG1pc3NwZWxsaW5nIHBvc2l0aW9u cyBpZiB0aGVyZSBhcmUgbXVsdGlwbGUgbWlzc3BlbGxlZCB3b3Jkcy4KZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL3BsYXRmb3JtL3F0L1NraXBwZWQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9T a2lwcGVkCmluZGV4IGUyMjkzYzY3NjMxMDlhYWZlN2E0YmExZGI0N2Y4MDc5ODY5MjIyZWUuLjJh NTk1MjA0NDEzYTVmMGE5MDM4ZjgzMGRlNDBkZGIzOTY1NWMwM2EgMTAwNjQ0Ci0tLSBhL0xheW91 dFRlc3RzL3BsYXRmb3JtL3F0L1NraXBwZWQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQv U2tpcHBlZApAQCAtNDQsNyArNDQsNiBAQAogIyAtIEZhaWxlZCBjYW52YXMgdGVzdHMgZnJvbSBo dHRwOi8vcGhpbGlwLmh0bWw1Lm9yZy90ZXN0cy9jYW52YXMvc3VpdGUvdGVzdHMvCiAjIC0gZmFp bGluZyB0cmFuc2Zvcm1zIHRlc3RzCiAjIC0gZmFpbGluZyBwcmludGluZyB0ZXN0cwotIyAtIGZh aWxpbmcgd2Vic29ja2V0IHRlc3RzCiAjIC0gbmV3IHRlc3RzIHdpdGhvdXQgZXhwZWN0ZWQgcmVz dWx0cwogIyAtIFF0IDQuNyByZWxhdGVkIGJ1Z3MKICMgLSBRdCA0LjggcmVsYXRlZCBidWdzCkBA IC0xNjAyLDE3ICsxNjAxLDYgQEAgcHJpbnRpbmcvY29tcG9zaXRpbmctbGF5ZXItcHJpbnRpbmcu aHRtbAogcHJpbnRpbmcvbWVkaWEtcXVlcmllcy1wcmludC5odG1sCiAKICMgPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0gIwotIyBmYWlsaW5nIHdlYnNvY2tldCB0ZXN0cwotIyA9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PSAjCi0KLSMgU29ja2V0U3RyZWFtSGFuZGxlUXQgc2VlbXMgdG8gaGF2ZSBzb21lIGJ1ZyBp biBwbGF0Zm9ybUNsb3NlKCkgYmVoYXZpb3IuCi1odHRwL3Rlc3RzL3dlYnNvY2tldC90ZXN0cy9o eWJpL2Nsb3NlLWJlZm9yZS1vcGVuLmh0bWwKLWh0dHAvdGVzdHMvd2Vic29ja2V0L3Rlc3RzL2h5 YmkvY2xvc2UtY29kZS1hbmQtcmVhc29uLmh0bWwKLWh0dHAvdGVzdHMvd2Vic29ja2V0L3Rlc3Rz L2h5YmkvY2xvc2UuaHRtbAotaHR0cC90ZXN0cy93ZWJzb2NrZXQvdGVzdHMvaHliaS93b3JrZXJz L2Nsb3NlLmh0bWwKLWh0dHAvdGVzdHMvd2Vic29ja2V0L3Rlc3RzL2h5Ymkvd29ya2Vycy9jbG9z ZS1jb2RlLWFuZC1yZWFzb24uaHRtbAotCi0jID09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ICMKICMgbmV3 IHRlc3RzIHdpdGhvdXQgZXhwZWN0ZWQgcmVzdWx0cwogIyA9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PSAj CiBlZGl0aW5nL3NlbGVjdGlvbi90cmFuc2Zvcm1lZC1zZWxlY3Rpb24tcmVjdHMuaHRtbAo=