72862 2011-11-20 23:41:32 -0800 [Mac] check-for-weak-vtables-and-externals should ignore symbols from system headers. 2011-11-21 03:20:22 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Normal --- 67852 1 morrita morrita mitz mrowe oldest_to_newest 506736 0 morrita 2011-11-20 23:41:32 -0800 heck-for-weak-vtables-and-externals should ignore symbols from system headers because the system header forces them to export and we cannot control it when we use WTF_EXPORT-based symbol visibility control. For example, /usr/include/c++/4.2.1/new contains following line: #pragma GCC visibility push(default) Fortunately JSC depends on very few such C++ symbols so I think this relaxation doesn't harm. 506743 1 116038 morrita 2011-11-20 23:55:16 -0800 Created attachment 116038 Patch 506818 2 mrowe 2011-11-21 02:38:09 -0800 I don’t think silently allowing these symbols to be exported this is the right solution. Our frameworks should only be exporting symbols that they provide, not random symbols from system headers. Take a look at the definition of OTHER_LDFLAGS in WebKit2/Configurations/Base.xcconfig for the approach that we use to address this in the one framework we currently have that does not use an explicit symbol export list. 506819 3 116038 mrowe 2011-11-21 02:38:46 -0800 Comment on attachment 116038 Patch Marking as r- per above comment. 506836 4 morrita 2011-11-21 03:20:22 -0800 (In reply to comment #2) > I don’t think silently allowing these symbols to be exported this is the right solution. Our frameworks should only be exporting symbols that they provide, not random symbols from system headers. Take a look at the definition of OTHER_LDFLAGS in WebKit2/Configurations/Base.xcconfig for the approach that we use to address this in the one framework we currently have that does not use an explicit symbol export list. Wow, this is exactly what I want. Thanks much for your advice! Closing the bug since we don't need this change. 116038 2011-11-20 23:55:16 -0800 2011-11-21 03:20:43 -0800 Patch bug-72862-20111121165514.patch text/plain 1684 morrita U3VidmVyc2lvbiBSZXZpc2lvbjogMTAwODg2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMGNmNjkyZjY3OTZkMWViNzEyODYwMDE4ZWU2OGYzYTg0 YWJkYjk3MC4uNmY3NDZiZTVkMTc5ODg5NmY3ODQ4Y2VjOGQ2ODQzZDQ4NTdlM2UwZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDExLTExLTIwICBIYWppbWUgTW9ycml0YSAgPG1vcnJpdGFAY2hyb21pdW0ub3JnPgor CisgICAgICAgIFtNYWNdIGhlY2stZm9yLXdlYWstdnRhYmxlcy1hbmQtZXh0ZXJuYWxzIHNob3Vs ZCBpZ25vcmUgc3ltYm9scyBmcm9tIHN5c3RlbSBoZWFkZXJzLgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzI4NjIKKworICAgICAgICBBZGQgc29tZSBy ZWd4cCBwYXR0ZXJucyB0byBhbGxvdyBzeW1ib2xzIGZyb20gJ3N0ZCcgbmFtZXNwYWNlCisgICAg ICAgIGFuZCBnbG9iYWwgZGVmYXVsdCBvcGVyYXRvciBuZXcuCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL2NoZWNrLWZvci13ZWFrLXZ0 YWJsZXMtYW5kLWV4dGVybmFsczoKKwogMjAxMS0xMS0yMCAgT2phbiBWYWZhaSAgPG9qYW5AY2hy b21pdW0ub3JnPgogCiAgICAgICAgIENoYW5nZSB0aGUgZmluYWwgcGxhY2Ugd2hlcmUgd2UgdXNl IHZlcnNpb24gMyBvZiB0aGUgcmVzdWx0cyBqc29uIG91dHB1dApkaWZmIC0tZ2l0IGEvVG9vbHMv U2NyaXB0cy9jaGVjay1mb3Itd2Vhay12dGFibGVzLWFuZC1leHRlcm5hbHMgYi9Ub29scy9TY3Jp cHRzL2NoZWNrLWZvci13ZWFrLXZ0YWJsZXMtYW5kLWV4dGVybmFscwppbmRleCBkZmJmODlmZWZm NDU1NDhiYTBmY2VlYTRiZGFmOGJmMTllNDYxNGRjLi4zM2FmOWJiOTY5NmEzMmE0YmQwOWM5OWYy NjJlZTgxMDgyYzdjOGNjIDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL2NoZWNrLWZvci13ZWFr LXZ0YWJsZXMtYW5kLWV4dGVybmFscworKysgYi9Ub29scy9TY3JpcHRzL2NoZWNrLWZvci13ZWFr LXZ0YWJsZXMtYW5kLWV4dGVybmFscwpAQCAtNjYsOCArNjYsOCBAQCBpZiAoIWRlZmluZWQgJGV4 ZWN1dGFibGVQYXRoQWdlIHx8ICFkZWZpbmVkICRidWlsZFRpbWVzdGFtcEFnZSB8fCAkZXhlY3V0 YWJsZVBhdAogICAgIG15IEB3ZWFrRXh0ZXJuYWxTeW1ib2xzID0gKCk7CiAgICAgd2hpbGUgKDxO TT4pIHsKICAgICAgICAgaWYgKC9eU1RET1VUOi8pIHsKLSAgICAgICAgICAgICMgSWdub3JlIHVu ZGVmaW5lZCwgUlRUSSBhbmQgdHlwZWluZm8gc3ltYm9scy4KLSAgICAgICAgICAgIG5leHQgaWYg L1xidW5kZWZpbmVkXGIvIG9yIC9cYl9fWlRbSVNdLzsKKyAgICAgICAgICAgICMgSWdub3JlIHVu ZGVmaW5lZCwgUlRUSSBhbmQgdHlwZWluZm8gc3ltYm9scy4gU1RMIG9yaWdpbiBzeW1ib2xzIGFy ZSBhbHNvIGlnbm9yZWQuCisgICAgICAgICAgICBuZXh0IGlmIC9cYnVuZGVmaW5lZFxiLyBvciAv XGJfX1pUW0lTXS8gb3IgL1xic3RkOjovIG9yIC9vcGVyYXRvciBuZXcvOwogCiAgICAgICAgICAg ICBpZiAoL3dlYWsgZXh0ZXJuYWwgdnRhYmxlIGZvciAoLiopJC8pIHsKICAgICAgICAgICAgICAg ICBwdXNoIEB3ZWFrVlRhYmxlQ2xhc3NlcywgJDE7Cg==