72859 2011-11-20 23:23:33 -0800 new-run-webkit-websocketserver must use Host().port_factory, too 2011-11-21 01:12:28 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Major --- 0 toyoshim webkit-unassigned abarth eric webkit.review.bot yutak oldest_to_newest 506725 0 toyoshim 2011-11-20 23:23:33 -0800 Eric landed a change related to port factory as follows. https://bugs.webkit.org/show_bug.cgi?id=71961 This change miss to fix new-run-webkit-websocketserver. 506728 1 116033 toyoshim 2011-11-20 23:25:58 -0800 Created attachment 116033 Patch 506730 2 116033 eric 2011-11-20 23:28:44 -0800 Comment on attachment 116033 Patch Thank you. We should consider moving the guts of this script into webkitpy/websocketserver/main.py or similar to avoid breaking. Keeping our python code all under one directory makes dependency tracking easier. 506731 3 eric 2011-11-20 23:29:41 -0800 I might also recommend putting the host in a local variable, as you're likely to want the filesystem or executive off it. Also, currently you have to call host._initialize_scm() after creating the host if you want it to have an SCM or Checkout object. 506737 4 116035 toyoshim 2011-11-20 23:45:16 -0800 Created attachment 116035 Patch 506738 5 toyoshim 2011-11-20 23:48:17 -0800 Thank you Eric. For now, I just change to keep host in a local variable. We'll put them into webkitpy/websocketserver/... in future. 506783 6 116035 webkit.review.bot 2011-11-21 01:12:23 -0800 Comment on attachment 116035 Patch Clearing flags on attachment: 116035 Committed r100889: <http://trac.webkit.org/changeset/100889> 506784 7 webkit.review.bot 2011-11-21 01:12:28 -0800 All reviewed patches have been landed. Closing bug. 116033 2011-11-20 23:25:58 -0800 2011-11-20 23:45:08 -0800 Patch bug-72859-20111121162556.patch text/plain 1593 toyoshim U3VidmVyc2lvbiBSZXZpc2lvbjogMTAwODgxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMGNmNjkyZjY3OTZkMWViNzEyODYwMDE4ZWU2OGYzYTg0 YWJkYjk3MC4uY2U5NTIwM2ZlNzBjYWQ1NGMxYjVkOGE3YWNiZmNhYjM3MTAzZTQ2MCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEy IEBACisyMDExLTExLTIwICBUYWthc2hpIFRveW9zaGltYSAgPHRveW9zaGltQGNocm9taXVtLm9y Zz4KKworICAgICAgICBVc2UgSG9zdCgpLnBvcnRfZmFjdG9yeSBpbnN0ZWFkIG9mIHdlYmtpdHB5 LmxheW91dF90ZXN0cy5wb3J0LmZhY3RvcnkuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD03Mjg1OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorICAgICAgICAKKyAgICAgICAgKiBTY3JpcHRzL25ldy1ydW4td2Via2l0LXdlYnNv Y2tldHNlcnZlcjoKKwogMjAxMS0xMS0yMCAgT2phbiBWYWZhaSAgPG9qYW5AY2hyb21pdW0ub3Jn PgogCiAgICAgICAgIENoYW5nZSB0aGUgZmluYWwgcGxhY2Ugd2hlcmUgd2UgdXNlIHZlcnNpb24g MyBvZiB0aGUgcmVzdWx0cyBqc29uIG91dHB1dApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy9u ZXctcnVuLXdlYmtpdC13ZWJzb2NrZXRzZXJ2ZXIgYi9Ub29scy9TY3JpcHRzL25ldy1ydW4td2Vi a2l0LXdlYnNvY2tldHNlcnZlcgppbmRleCA4ZTg4YWYzMWVjZDcyYzMzOWJlZTAzYzM5OTAwMzQw OTFiNjNiODJlLi5lMzIwZmNlYjQwM2JlZmMyZWJkODY5N2U5NzYyODJiZDU0OWNmOTc0IDEwMDc1 NQotLS0gYS9Ub29scy9TY3JpcHRzL25ldy1ydW4td2Via2l0LXdlYnNvY2tldHNlcnZlcgorKysg Yi9Ub29scy9TY3JpcHRzL25ldy1ydW4td2Via2l0LXdlYnNvY2tldHNlcnZlcgpAQCAtMzQsOCAr MzQsOCBAQCBpbXBvcnQgbG9nZ2luZwogaW1wb3J0IG9wdHBhcnNlCiBpbXBvcnQgdGVtcGZpbGUK IAotaW1wb3J0IHdlYmtpdHB5LmxheW91dF90ZXN0cy5wb3J0LmZhY3RvcnkgYXMgZmFjdG9yeQot aW1wb3J0IHdlYmtpdHB5LmxheW91dF90ZXN0cy5zZXJ2ZXJzLndlYnNvY2tldF9zZXJ2ZXIgYXMg d2Vic29ja2V0X3NlcnZlcgorZnJvbSB3ZWJraXRweS5jb21tb24uaG9zdCBpbXBvcnQgSG9zdAor ZnJvbSB3ZWJraXRweS5sYXlvdXRfdGVzdHMuc2VydmVycyBpbXBvcnQgd2Vic29ja2V0X3NlcnZl cgogCiAKIGRlZiBtYWluKCk6CkBAIC05MSw3ICs5MSw3IEBAIGRlZiBtYWluKCk6CiAgICAgaWYg b3B0aW9ucy5waWRmaWxlOgogICAgICAgICBrd2RzWydwaWRmaWxlJ10gPSBvcHRpb25zLnBpZGZp bGUKIAotICAgIHBvcnRfb2JqID0gZmFjdG9yeS5nZXQob3B0aW9ucz1vcHRpb25zKQorICAgIHBv cnRfb2JqID0gSG9zdCgpLnBvcnRfZmFjdG9yeS5nZXQob3B0aW9ucz1vcHRpb25zKQogICAgIHB5 d2Vic29ja2V0ID0gd2Vic29ja2V0X3NlcnZlci5QeVdlYlNvY2tldChwb3J0X29iaiwgb3B0aW9u cy5vdXRwdXRfZGlyLCAqKmt3ZHMpCiAKICAgICBsb2dfbGV2ZWwgPSBsb2dnaW5nLldBUk4K 116035 2011-11-20 23:45:16 -0800 2011-11-21 01:12:23 -0800 Patch bug-72859-20111121164514.patch text/plain 1607 toyoshim U3VidmVyc2lvbiBSZXZpc2lvbjogMTAwODgxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMGNmNjkyZjY3OTZkMWViNzEyODYwMDE4ZWU2OGYzYTg0 YWJkYjk3MC4uYmQzOTE1ZWRiODgyM2Y1YWYyMzI4OTM1ZjRhNTRlYTM3Y2UwYTY1ZCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEy IEBACisyMDExLTExLTIwICBUYWthc2hpIFRveW9zaGltYSAgPHRveW9zaGltQGNocm9taXVtLm9y Zz4KKworICAgICAgICBVc2UgSG9zdCgpLnBvcnRfZmFjdG9yeSBpbnN0ZWFkIG9mIHdlYmtpdHB5 LmxheW91dF90ZXN0cy5wb3J0LmZhY3RvcnkuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD03Mjg1OQorCisgICAgICAgIFJldmlld2VkIGJ5IEVyaWMgU2Vp ZGVsLgorICAgICAgICAKKyAgICAgICAgKiBTY3JpcHRzL25ldy1ydW4td2Via2l0LXdlYnNvY2tl dHNlcnZlcjoKKwogMjAxMS0xMS0yMCAgT2phbiBWYWZhaSAgPG9qYW5AY2hyb21pdW0ub3JnPgog CiAgICAgICAgIENoYW5nZSB0aGUgZmluYWwgcGxhY2Ugd2hlcmUgd2UgdXNlIHZlcnNpb24gMyBv ZiB0aGUgcmVzdWx0cyBqc29uIG91dHB1dApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy9uZXct cnVuLXdlYmtpdC13ZWJzb2NrZXRzZXJ2ZXIgYi9Ub29scy9TY3JpcHRzL25ldy1ydW4td2Via2l0 LXdlYnNvY2tldHNlcnZlcgppbmRleCA4ZTg4YWYzMWVjZDcyYzMzOWJlZTAzYzM5OTAwMzQwOTFi NjNiODJlLi44NjIxNWIyNzI2NTZlN2VjY2Q0ZDI3MDNiNTYzNjQyMWU5YmI0ODc1IDEwMDc1NQot LS0gYS9Ub29scy9TY3JpcHRzL25ldy1ydW4td2Via2l0LXdlYnNvY2tldHNlcnZlcgorKysgYi9U b29scy9TY3JpcHRzL25ldy1ydW4td2Via2l0LXdlYnNvY2tldHNlcnZlcgpAQCAtMzQsOCArMzQs OCBAQCBpbXBvcnQgbG9nZ2luZwogaW1wb3J0IG9wdHBhcnNlCiBpbXBvcnQgdGVtcGZpbGUKIAot aW1wb3J0IHdlYmtpdHB5LmxheW91dF90ZXN0cy5wb3J0LmZhY3RvcnkgYXMgZmFjdG9yeQotaW1w b3J0IHdlYmtpdHB5LmxheW91dF90ZXN0cy5zZXJ2ZXJzLndlYnNvY2tldF9zZXJ2ZXIgYXMgd2Vi c29ja2V0X3NlcnZlcgorZnJvbSB3ZWJraXRweS5jb21tb24uaG9zdCBpbXBvcnQgSG9zdAorZnJv bSB3ZWJraXRweS5sYXlvdXRfdGVzdHMuc2VydmVycyBpbXBvcnQgd2Vic29ja2V0X3NlcnZlcgog CiAKIGRlZiBtYWluKCk6CkBAIC05MSw3ICs5MSw4IEBAIGRlZiBtYWluKCk6CiAgICAgaWYgb3B0 aW9ucy5waWRmaWxlOgogICAgICAgICBrd2RzWydwaWRmaWxlJ10gPSBvcHRpb25zLnBpZGZpbGUK IAotICAgIHBvcnRfb2JqID0gZmFjdG9yeS5nZXQob3B0aW9ucz1vcHRpb25zKQorICAgIGhvc3Qg PSBIb3N0KCkKKyAgICBwb3J0X29iaiA9IGhvc3QucG9ydF9mYWN0b3J5LmdldChvcHRpb25zPW9w dGlvbnMpCiAgICAgcHl3ZWJzb2NrZXQgPSB3ZWJzb2NrZXRfc2VydmVyLlB5V2ViU29ja2V0KHBv cnRfb2JqLCBvcHRpb25zLm91dHB1dF9kaXIsICoqa3dkcykKIAogICAgIGxvZ19sZXZlbCA9IGxv Z2dpbmcuV0FSTgo=