72858 2011-11-20 22:15:10 -0800 WTF::String has extra WTF_EXPORT_PRIVATE 2011-11-23 01:11:17 -0800 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 67852 1 morrita morrita kevino webkit.review.bot oldest_to_newest 506711 0 morrita 2011-11-20 22:15:10 -0800 Some inline method on WTF::String has declared as WTF_EXPORT_PRIVATE, which is incompatible against Mac port. Mac port forbid inline exported functions. 506837 1 116060 morrita 2011-11-21 03:33:53 -0800 Created attachment 116060 Patch 506838 2 webkit.review.bot 2011-11-21 03:35:19 -0800 Attachment 116060 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/wtf/text/WTFString.h:114: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 506841 3 morrita 2011-11-21 03:41:18 -0800 The style error was a false charge. It was already there. 507432 4 morrita 2011-11-22 00:11:21 -0800 Hi Kevin, could you take a look? I guess you added these WTF_EXPORT_PRIVATE. 507644 5 kevino 2011-11-22 09:37:46 -0800 (In reply to comment #4) > Hi Kevin, could you take a look? I guess you added these WTF_EXPORT_PRIVATE. Sure, will do, but it might be a day or two because I want to double-check that wx still links okay after removing them. I vaguely remember having some sort of error when I didn't declare those symbols exported, but it's been a long time so I need to double-check it. 507921 6 116060 kevino 2011-11-22 20:26:14 -0800 Comment on attachment 116060 Patch Okay, I double-checked wx compilation and it looks fine, so these can go. 507994 7 116060 webkit.review.bot 2011-11-23 01:11:11 -0800 Comment on attachment 116060 Patch Clearing flags on attachment: 116060 Committed r101054: <http://trac.webkit.org/changeset/101054> 507995 8 webkit.review.bot 2011-11-23 01:11:17 -0800 All reviewed patches have been landed. Closing bug. 116060 2011-11-21 03:33:53 -0800 2011-11-23 01:11:11 -0800 Patch bug-72858-20111121203351.patch text/plain 1921 morrita U3VidmVyc2lvbiBSZXZpc2lvbjogMTAwODg2CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBm NmRkZWE3N2E3OGE3ZDliZWQ3ZDYzMTVmYjcxOTk5ODY2NDk5ZGYxLi42NTI2MWQyN2Y0MDY4ZmE4 ZGVhZThmZjM4NmU0NThkMjk0MmFmMDcxIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxMS0xMS0yMCAgSGFqaW1lIE1vcnJpdGEgIDxtb3JyaXRhQGNocm9taXVt Lm9yZz4KKworICAgICAgICBXVEY6OlN0cmluZyBoYXMgZXh0cmEgV1RGX0VYUE9SVF9QUklWQVRF CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03Mjg1OAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogd3RmL3Rl eHQvV1RGU3RyaW5nLmg6CisgICAgICAgIChXVEY6OlN0cmluZzo6U3RyaW5nKToKKwogMjAxMS0x MS0yMCAgRmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3 ZWQgaW50ZXJwcmV0ZXIgYnVpbGQgZml4LgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRD b3JlL3d0Zi90ZXh0L1dURlN0cmluZy5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi90ZXh0 L1dURlN0cmluZy5oCmluZGV4IGNjNDVhYTAzOWRmMzdmZDQ4NjkwMjgzYTVkYTk2NjY3NWRmNGQ4 NTguLmZkMWYwZDI4YWI0ZmM4YThmNTU4MDllNzg3YTRiOWEyMTliYTYxNjEgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvdGV4dC9XVEZTdHJpbmcuaAorKysgYi9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvd3RmL3RleHQvV1RGU3RyaW5nLmgKQEAgLTg3LDcgKzg3LDcgQEAgdGVt cGxhdGU8Ym9vbCBpc1NwZWNpYWxDaGFyYWN0ZXIoVUNoYXIpPiBib29sIGlzQWxsU3BlY2lhbENo YXJhY3RlcnMoY29uc3QgVUNoYXIKIGNsYXNzIFN0cmluZyB7CiBwdWJsaWM6CiAgICAgLy8gQ29u c3RydWN0IGEgbnVsbCBzdHJpbmcsIGRpc3Rpbmd1aXNoYWJsZSBmcm9tIGFuIGVtcHR5IHN0cmlu Zy4KLSAgICBXVEZfRVhQT1JUX1BSSVZBVEUgU3RyaW5nKCkgeyB9CisgICAgU3RyaW5nKCkgeyB9 CiAKICAgICAvLyBDb25zdHJ1Y3QgYSBzdHJpbmcgd2l0aCBVVEYtMTYgZGF0YS4KICAgICBXVEZf RVhQT1JUX1BSSVZBVEUgU3RyaW5nKGNvbnN0IFVDaGFyKiBjaGFyYWN0ZXJzLCB1bnNpZ25lZCBs ZW5ndGgpOwpAQCAtMTA5LDkgKzEwOSw5IEBAIHB1YmxpYzoKICAgICBXVEZfRVhQT1JUX1BSSVZB VEUgU3RyaW5nKGNvbnN0IGNoYXIqIGNoYXJhY3RlcnMpOwogCiAgICAgLy8gQ29uc3RydWN0IGEg c3RyaW5nIHJlZmVyZW5jaW5nIGFuIGV4aXN0aW5nIFN0cmluZ0ltcGwuCi0gICAgV1RGX0VYUE9S VF9QUklWQVRFIFN0cmluZyhTdHJpbmdJbXBsKiBpbXBsKSA6IG1faW1wbChpbXBsKSB7IH0KLSAg ICBXVEZfRVhQT1JUX1BSSVZBVEUgU3RyaW5nKFBhc3NSZWZQdHI8U3RyaW5nSW1wbD4gaW1wbCkg OiBtX2ltcGwoaW1wbCkgeyB9Ci0gICAgV1RGX0VYUE9SVF9QUklWQVRFIFN0cmluZyhSZWZQdHI8 U3RyaW5nSW1wbD4gaW1wbCkgOiBtX2ltcGwoaW1wbCkgeyB9CisgICAgU3RyaW5nKFN0cmluZ0lt cGwqIGltcGwpIDogbV9pbXBsKGltcGwpIHsgfQorICAgIFN0cmluZyhQYXNzUmVmUHRyPFN0cmlu Z0ltcGw+IGltcGwpIDogbV9pbXBsKGltcGwpIHsgfQorICAgIFN0cmluZyhSZWZQdHI8U3RyaW5n SW1wbD4gaW1wbCkgOiBtX2ltcGwoaW1wbCkgeyB9CiAKICAgICAvLyBJbmxpbmUgdGhlIGRlc3Ry dWN0b3IuCiAgICAgQUxXQVlTX0lOTElORSB+U3RyaW5nKCkgeyB9Cg==