72850 2011-11-20 21:41:28 -0800 [WK2] Modify EFL port's WebEventFactory to use EflKeyboardUtilities's keyIdentifierForEvasKeyName() and windowsKeyCodeForEvasKeyName(). 2011-11-22 01:32:27 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 61838 0 enmi.lee webkit-unassigned rakuco webkit.review.bot oldest_to_newest 506692 0 enmi.lee 2011-11-20 21:41:28 -0800 The EflKeyboardUtilities has been added, so we can use keyIdentifierForEvasKeyName() and windowsKeyCodeForEvasKeyName() for EFL port's WebEventFactory. 506695 1 116026 enmi.lee 2011-11-20 21:44:21 -0800 Created attachment 116026 patch for WebEventFactory 506865 2 rakuco 2011-11-21 04:19:12 -0800 LGTM. 507464 3 116026 webkit.review.bot 2011-11-22 01:32:23 -0800 Comment on attachment 116026 patch for WebEventFactory Clearing flags on attachment: 116026 Committed r100983: <http://trac.webkit.org/changeset/100983> 507465 4 webkit.review.bot 2011-11-22 01:32:27 -0800 All reviewed patches have been landed. Closing bug. 116026 2011-11-20 21:44:21 -0800 2011-11-22 01:32:23 -0800 patch for WebEventFactory WebEventFactory.patch text/plain 2896 enmi.lee ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBjNjE1M2M2Li5hZWNjMzhiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTEtMTEtMjAgIEV1bm1pIExlZSAgPGV1bm1pMTUubGVlQHNhbXN1bmcuY29tPgorCisg ICAgICAgIFtXSzJdIE1vZGlmeSBFRkwgcG9ydCdzIFdlYkV2ZW50RmFjdG9yeSB0byB1c2UgRWZs S2V5Ym9hcmRVdGlsaXRpZXMncworICAgICAgICBrZXlJZGVudGlmaWVyRm9yRXZhc0tleU5hbWUo KSBhbmQgd2luZG93c0tleUNvZGVGb3JFdmFzS2V5TmFtZSgpLgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzI4NTAKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgRWZsS2V5Ym9hcmRVdGlsaXRpZXMgaGFz IGJlZW4gYWRkZWQsIHNvIHdlIGNhbiB1c2Uga2V5SWRlbnRpZmllckZvckV2YXNLZXlOYW1lKCkg YW5kCisgICAgICAgIHdpbmRvd3NLZXlDb2RlRm9yRXZhc0tleU5hbWUoKSBmb3IgRUZMIHBvcnQn cyBXZWJFdmVudEZhY3RvcnkuCisKKyAgICAgICAgKiBTaGFyZWQvZWZsL1dlYkV2ZW50RmFjdG9y eS5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYkV2ZW50RmFjdG9yeTo6Y3JlYXRlV2ViS2V5Ym9h cmRFdmVudCk6CisKIDIwMTEtMTAtMTcgIEFudG9uaW8gR29tZXMgIDxhZ29tZXNAcmltLmNvbT4K IAogICAgICAgICBQYXNzIGEgRnJhbWUqIHBhcmFtZXRlciBpbiBFZGl0b3JDbGllbnQ6OnJlc3Bv bmRUb0NoYW5nZWRTZWxlY3Rpb24KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9l ZmwvV2ViRXZlbnRGYWN0b3J5LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9lZmwvV2ViRXZl bnRGYWN0b3J5LmNwcAppbmRleCBlZWNkYTc0Li5mZmUyY2I1IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0Mi9TaGFyZWQvZWZsL1dlYkV2ZW50RmFjdG9yeS5jcHAKKysrIGIvU291cmNlL1dlYktp dDIvU2hhcmVkL2VmbC9XZWJFdmVudEZhY3RvcnkuY3BwCkBAIC0yNiw4ICsyNiw3IEBACiAjaW5j bHVkZSAiY29uZmlnLmgiCiAjaW5jbHVkZSAiV2ViRXZlbnRGYWN0b3J5LmgiCiAKLSNpbmNsdWRl IDxXZWJDb3JlL05vdEltcGxlbWVudGVkLmg+Ci0jaW5jbHVkZSA8V2ViQ29yZS9QbGF0Zm9ybUtl eWJvYXJkRXZlbnQuaD4KKyNpbmNsdWRlICJFZmxLZXlib2FyZFV0aWxpdGllcy5oIgogI2luY2x1 ZGUgPFdlYkNvcmUvU2Nyb2xsYmFyLmg+CiAKIHVzaW5nIG5hbWVzcGFjZSBXZWJDb3JlOwpAQCAt MTYzLDggKzE2Miw4IEBAIFdlYktleWJvYXJkRXZlbnQgV2ViRXZlbnRGYWN0b3J5OjpjcmVhdGVX ZWJLZXlib2FyZEV2ZW50KGNvbnN0IEV2YXNfRXZlbnRfS2V5X0RvCiAgICAgcmV0dXJuIFdlYktl eWJvYXJkRXZlbnQoV2ViRXZlbnQ6OktleURvd24sCiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgU3RyaW5nOjpmcm9tVVRGOChldmVudC0+c3RyaW5nKSwKICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBTdHJpbmc6OmZyb21VVEY4KGV2ZW50LT5zdHJpbmcpLAotICAgICAgICAgICAgICAg ICAgICAgICAgICAgIFBsYXRmb3JtS2V5Ym9hcmRFdmVudDo6a2V5SWRlbnRpZmllckZvckV2YXNL ZXlOYW1lKGtleU5hbWUpLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgIFBsYXRmb3JtS2V5 Ym9hcmRFdmVudDo6d2luZG93c0tleUNvZGVGb3JFdmFzS2V5TmFtZShrZXlOYW1lKSwKKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICBrZXlJZGVudGlmaWVyRm9yRXZhc0tleU5hbWUoa2V5TmFt ZSksCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgd2luZG93c0tleUNvZGVGb3JFdmFzS2V5 TmFtZShrZXlOYW1lKSwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAwIC8qIEZJWE1FOiBu YXRpdmVWaXJ0dWFsS2V5Q29kZSAqLywKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAwIC8q IG1hY0NoYXJDb2RlICovLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgIGZhbHNlIC8qIEZJ WE1FOiBpc0F1dG9SZXBlYXQgKi8sCkBAIC0xODAsOCArMTc5LDggQEAgV2ViS2V5Ym9hcmRFdmVu dCBXZWJFdmVudEZhY3Rvcnk6OmNyZWF0ZVdlYktleWJvYXJkRXZlbnQoY29uc3QgRXZhc19FdmVu dF9LZXlfVXAKICAgICByZXR1cm4gV2ViS2V5Ym9hcmRFdmVudChXZWJFdmVudDo6S2V5VXAsCiAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgU3RyaW5nOjpmcm9tVVRGOChldmVudC0+c3RyaW5n KSwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICBTdHJpbmc6OmZyb21VVEY4KGV2ZW50LT5z dHJpbmcpLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgIFBsYXRmb3JtS2V5Ym9hcmRFdmVu dDo6a2V5SWRlbnRpZmllckZvckV2YXNLZXlOYW1lKGtleU5hbWUpLAotICAgICAgICAgICAgICAg ICAgICAgICAgICAgIFBsYXRmb3JtS2V5Ym9hcmRFdmVudDo6d2luZG93c0tleUNvZGVGb3JFdmFz S2V5TmFtZShrZXlOYW1lKSwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICBrZXlJZGVudGlm aWVyRm9yRXZhc0tleU5hbWUoa2V5TmFtZSksCisgICAgICAgICAgICAgICAgICAgICAgICAgICAg d2luZG93c0tleUNvZGVGb3JFdmFzS2V5TmFtZShrZXlOYW1lKSwKICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAwIC8qIEZJWE1FOiBuYXRpdmVWaXJ0dWFsS2V5Q29kZSAqLywKICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAwIC8qIG1hY0NoYXJDb2RlICovLAogICAgICAgICAgICAgICAg ICAgICAgICAgICAgIGZhbHNlIC8qIEZJWE1FOiBpc0F1dG9SZXBlYXQgKi8sCg==