72827 2011-11-20 11:34:50 -0800 [Qt] [WK2] WebKitTestRunner doesn't build in debug 2011-11-21 08:49:08 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Qt P3 Normal --- 1 ostap73 webkit-unassigned levin+threading ossy webkit.review.bot oldest_to_newest 506555 0 ostap73 2011-11-20 11:34:50 -0800 obj/debug/EventSenderProxyQt.o: In function `WTR::EventSenderProxy::updateTouchPoint(int, int, int)': /home/sl/work/webkit/WebKitBuild/Debug/Tools/WebKitTestRunner/../../../../Tools/WebKitTestRunner/qt/EventSenderProxyQt.cpp:325: undefined reference to `WTFReportAssertionFailure' obj/debug/TestControllerQt.o: In function `WTR::TestControllerRunLoop::start(int)': /home/sl/work/webkit/WebKitBuild/Debug/Tools/WebKitTestRunner/../../../../Tools/WebKitTestRunner/qt/TestControllerQt.cpp:56: undefined reference to `WTFReportAssertionFailure' obj/debug/TestInvocationQt.o: In function `WTR::TestInvocation::dumpPixelsAndCompareWithExpected(OpaqueWKImage const*, OpaqueWKArray const*)': /home/sl/work/webkit/WebKitBuild/Debug/Tools/WebKitTestRunner/../../../../Tools/WebKitTestRunner/qt/TestInvocationQt.cpp:76: undefined reference to `WTFReportAssertionFailure' obj/debug/TestController.o: In function `WTR::TestController::shared()': /home/sl/work/webkit/WebKitBuild/Debug/Tools/WebKitTestRunner/../../../../Tools/WebKitTestRunner/TestController.cpp:60: undefined reference to `WTFReportAssertionFailure' obj/debug/TestController.o: In function `WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle(OpaqueWKString const*, void const*)': /home/sl/work/webkit/WebKitBuild/Debug/Tools/WebKitTestRunner/../../../../Tools/WebKitTestRunner/TestController.cpp:546: undefined reference to `WTFReportAssertionFailure' obj/debug/TestController.o:/home/sl/work/webkit/WebKitBuild/Debug/Tools/WebKitTestRunner/../../../../Tools/WebKitTestRunner/TestController.cpp:694: more undefined references to `WTFReportAssertionFailure' follow collect2: ld returned 1 exit status 506561 1 115990 ostap73 2011-11-20 11:59:08 -0800 Created attachment 115990 Patch 506573 2 115990 kling 2011-11-20 13:15:08 -0800 Comment on attachment 115990 Patch rs=me 506588 3 115990 webkit.review.bot 2011-11-20 14:21:52 -0800 Comment on attachment 115990 Patch Rejecting attachment 115990 from commit-queue. New failing tests: platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html Full output: http://queues.webkit.org/results/10534064 506598 4 ostap73 2011-11-20 15:02:04 -0800 (In reply to comment #3) > (From update of attachment 115990 [details]) > Rejecting attachment 115990 [details] from commit-queue. > > New failing tests: > platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html > Full output: http://queues.webkit.org/results/10534064 Wow! How change in Qt exports could fail chromium layout tests? ;) 506933 5 115990 ostap73 2011-11-21 07:11:12 -0800 Comment on attachment 115990 Patch I'd like to retry commit queue because this change couldn't break chromium layout tests. 507001 6 115990 ossy 2011-11-21 08:49:00 -0800 Comment on attachment 115990 Patch Clearing flags on attachment: 115990 Committed r100920: <http://trac.webkit.org/changeset/100920> 507002 7 ossy 2011-11-21 08:49:08 -0800 All reviewed patches have been landed. Closing bug. 115990 2011-11-20 11:59:08 -0800 2011-11-21 08:49:00 -0800 Patch webkittestrunner_debug_build_fix.diff text/plain 1200 ostap73 ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCAyYjE4NTQwLi42NWU0YjYx IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAK KzIwMTEtMTEtMjAgIFZpYXRjaGVzbGF2IE9zdGFwZW5rbyAgPG9zdGFwZW5rby52aWF0Y2hlc2xh dkBub2tpYS5jb20+CisKKyAgICAgICAgW1F0XSBbV0syXSBXZWJLaXRUZXN0UnVubmVyIGRvZXNu J3QgYnVpbGQgaW4gZGVidWcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTcyODI3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgQWRkIGV4cG9ydHMgdG8gZml4IFdlYktpdFRlc3RSdW5uZXIgZGVidWcgYnVpbGQu CisKKyAgICAgICAgKiBTb3VyY2UvcXR3ZWJraXQtZXhwb3J0Lm1hcDoKKwogMjAxMS0xMS0xOSAg S2V2aW4gT2xsaXZpZXIgIDxrZXZpbm9AdGhlb2xsaXZpZXJzLmNvbT4KIAogICAgICAgICBbd3hd IEJ1aWxkIGZpeCBhZnRlciBHZW5lcmF0ZWRJbWFnZSByZWZhY3RvcmluZy4KZGlmZiAtLWdpdCBh L1NvdXJjZS9xdHdlYmtpdC1leHBvcnQubWFwIGIvU291cmNlL3F0d2Via2l0LWV4cG9ydC5tYXAK aW5kZXggZWNhMzZiYi4uZjc0NTJmNyAxMDA2NDQKLS0tIGEvU291cmNlL3F0d2Via2l0LWV4cG9y dC5tYXAKKysrIGIvU291cmNlL3F0d2Via2l0LWV4cG9ydC5tYXAKQEAgLTM3LDYgKzM3LDggQEAg cXdrXzEuMCB7CiAgICAgSlNWYWx1ZVByb3RlY3Q7CiAgICAgSlNFdmFsdWF0ZVNjcmlwdDsKICAg ICBfV0tDb250ZXh0U2V0QWRkaXRpb25hbFBsdWdpbnNEaXJlY3Rvcnk7CisgICAgV1RGUmVwb3J0 QXJndW1lbnRBc3NlcnRpb25GYWlsdXJlOworICAgIFdURlJlcG9ydEFzc2VydGlvbkZhaWx1cmU7 CiAgICAgV1RGUmVwb3J0QmFja3RyYWNlOwogICAgIGV4dGVybiAiQysrIiB7CiAgICAgICAgICMg V2ViS2l0IDEgQVBJCkBAIC05Nyw2ICs5OSw4IEBAIHF3a18xLjAgewogICAgICAgICBXVEY6OmZh c3RNYWxsb2MqOwogICAgICAgICBXVEY6OmZhc3RGcmVlKjsKICAgICAgICAgV1RGOjpmYXN0WmVy b2VkTWFsbG9jKjsKKyAgICAgICAgV1RGOjpNdXRleDo6KjsKKyAgICAgICAgV1RGOjpjdXJyZW50 VGhyZWFkKjsKIAogICAgICAgICAjIFdlYktpdCAyIEFQSQogICAgICAgICAqUVF1aWNrV2ViVmll dzsK