72804 2011-11-19 11:28:50 -0800 [Gtk] Regression: Push buttons no longer expose their displayed text/name 2011-11-29 03:01:15 -0800 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 25531 0 jdiggs webkit-unassigned mario mrobinson pnormand oldest_to_newest 506424 0 115957 jdiggs 2011-11-19 11:28:50 -0800 Created attachment 115957 test case Step to reproduce: 1. Open the attached test case in Epiphany and examine it with Accerciser Expected result: The text displayed on the button ('Search') would be exposed to ATs. Ideally as the button's name. Actual result: The text displayed on the button is not exposed to ATs. 509212 1 116633 mario 2011-11-25 10:35:12 -0800 Created attachment 116633 Patch proposal + layout test 509213 2 mario 2011-11-25 10:35:30 -0800 Adding reviewers to CC 510031 3 116633 cfleizach 2011-11-28 11:47:51 -0800 Comment on attachment 116633 Patch proposal + layout test r=me 510650 4 mario 2011-11-29 03:01:15 -0800 Committed r101348: <http://trac.webkit.org/changeset/101348> 115957 2011-11-19 11:28:50 -0800 2011-11-19 11:28:50 -0800 test case button.html text/html 208 jdiggs PGh0bWw+CjxoZWFkPjx0aXRsZT5CdXR0b24gVGVzdDwvdGl0bGU+PC9oZWFkPgo8Ym9keT4KPGZv cm0+CjxpbnB1dCBpZD0ic2VhcmNoQm94IiB0eXBlPSJ0ZXh0IiBuYW1lPSJxIiBzaXplPSIyNSIg Lz4KPGlucHV0IGlkPSJzZWFyY2hCdXR0b24iIHR5cGU9InN1Ym1pdCIgbmFtZT0ic2EiIHZhbHVl PSJTZWFyY2giIC8+CjwvZm9ybT4KPC9ib2R5Pgo8L2h0bWw+Cg== 116633 2011-11-25 10:35:12 -0800 2011-11-28 11:47:51 -0800 Patch proposal + layout test 0001-2011-11-25-Mario-Sanchez-Prada-msanchez-igalia.com.patch text/plain 6109 mario RnJvbSBhNzk3OGZhYjdhMGNkNzczODUwMzU0YTRhMTRmMDAxN2Q5MWVjNTliIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJpbyBTYW5jaGV6IFByYWRhIDxtc2FuY2hlekBpZ2FsaWEu Y29tPgpEYXRlOiBUdWUsIDIyIE5vdiAyMDExIDEyOjI0OjExICswMTAwClN1YmplY3Q6IFtQQVRD SF0gMjAxMS0xMS0yNSAgTWFyaW8gU2FuY2hleiBQcmFkYSAgPG1zYW5jaGV6QGlnYWxpYS5jb20+ CgogICAgICAgIFtHdGtdIFJlZ3Jlc3Npb246IFB1c2ggYnV0dG9ucyBubyBsb25nZXIgZXhwb3Nl IHRoZWlyIGRpc3BsYXllZCB0ZXh0L25hbWUKICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NzI4MDQKCiAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCgogICAgICAgIFVzZSBBY2Nlc3NpYmlsaXR5T2JqZWN0Ojp0aXRsZSgpIGFzIHRoZSBsYXN0 IGZhbGxiYWNrIGluCiAgICAgICAgd2Via2l0X2FjY2Vzc2libGVfZ2V0X25hbWUoKSByaWdodCBi ZWZvcmUgcmVseWluZyBvbiB0aGUKICAgICAgICBzdHJpbmdWYWx1ZSgpIG1ldGhvZCwgaWYgbm8g YmV0dGVyIGFsdGVybmF0aXZlIHdhcyBmb3VuZC4KCiAgICAgICAgVGVzdDogcGxhdGZvcm0vZ3Rr L2FjY2Vzc2liaWxpdHkvYnV0dG9uLWFjY2Vzc2libGUtbmFtZS5odG1sCgogICAgICAgICogYWNj ZXNzaWJpbGl0eS9ndGsvQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXJBdGsuY3BwOgogICAgICAg ICh3ZWJraXRfYWNjZXNzaWJsZV9nZXRfbmFtZSk6IFVzZSB0aXRsZSgpIGFzIHRoZSBsYXN0IGZh bGxiYWNrCiAgICAgICAgbWV0aG9kIGJlZm9yZSB1c2luZyBzdHJpbmdWYWx1ZSgpLgoKMjAxMS0x MS0yNSAgTWFyaW8gU2FuY2hleiBQcmFkYSAgPG1zYW5jaGV6QGlnYWxpYS5jb20+CgogICAgICAg IFtHdGtdIFJlZ3Jlc3Npb246IFB1c2ggYnV0dG9ucyBubyBsb25nZXIgZXhwb3NlIHRoZWlyIGRp c3BsYXllZCB0ZXh0L25hbWUKICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NzI4MDQKCiAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgogICAg ICAgIEFkZCBuZXcgR1RLLXNwZWNpZmljIGxheW91dCB0ZXN0IGFuZCBleHBlY3Rpb25zLgoKICAg ICAgICAqIHBsYXRmb3JtL2d0ay9hY2Nlc3NpYmlsaXR5L2J1dHRvbi1hY2Nlc3NpYmxlLW5hbWUt ZXhwZWN0ZWQudHh0OiBBZGRlZC4KICAgICAgICAqIHBsYXRmb3JtL2d0ay9hY2Nlc3NpYmlsaXR5 L2J1dHRvbi1hY2Nlc3NpYmxlLW5hbWUuaHRtbDogQWRkZWQuCi0tLQogTGF5b3V0VGVzdHMvQ2hh bmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgIDEyICsrKysrKysrCiAuLi4v YnV0dG9uLWFjY2Vzc2libGUtbmFtZS1leHBlY3RlZC50eHQgICAgICAgICAgICB8ICAgMTIgKysr KysrKysKIC4uLi9ndGsvYWNjZXNzaWJpbGl0eS9idXR0b24tYWNjZXNzaWJsZS1uYW1lLmh0bWwg IHwgICAyOCArKysrKysrKysrKysrKysrKysrKwogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nICAg ICAgICAgICAgICAgICAgICAgICAgICAgfCAgIDE3ICsrKysrKysrKysrKwogLi4uL2d0ay9BY2Nl c3NpYmlsaXR5T2JqZWN0V3JhcHBlckF0ay5jcHAgICAgICAgICAgfCAgICA2ICsrKysKIDUgZmls ZXMgY2hhbmdlZCwgNzUgaW5zZXJ0aW9ucygrKSwgMCBkZWxldGlvbnMoLSkKIGNyZWF0ZSBtb2Rl IDEwMDY0NCBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvYWNjZXNzaWJpbGl0eS9idXR0b24tYWNj ZXNzaWJsZS1uYW1lLWV4cGVjdGVkLnR4dAogY3JlYXRlIG1vZGUgMTAwNjQ0IExheW91dFRlc3Rz L3BsYXRmb3JtL2d0ay9hY2Nlc3NpYmlsaXR5L2J1dHRvbi1hY2Nlc3NpYmxlLW5hbWUuaHRtbAoK ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBlNTJmYWIwLi41ZDE2M2M4IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMTEt MjUgIE1hcmlvIFNhbmNoZXogUHJhZGEgIDxtc2FuY2hlekBpZ2FsaWEuY29tPgorCisgICAgICAg IFtHdGtdIFJlZ3Jlc3Npb246IFB1c2ggYnV0dG9ucyBubyBsb25nZXIgZXhwb3NlIHRoZWlyIGRp c3BsYXllZCB0ZXh0L25hbWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTcyODA0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgQWRkIG5ldyBHVEstc3BlY2lmaWMgbGF5b3V0IHRlc3QgYW5kIGV4cGVjdGlvbnMu CisKKyAgICAgICAgKiBwbGF0Zm9ybS9ndGsvYWNjZXNzaWJpbGl0eS9idXR0b24tYWNjZXNzaWJs ZS1uYW1lLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogcGxhdGZvcm0vZ3RrL2FjY2Vz c2liaWxpdHkvYnV0dG9uLWFjY2Vzc2libGUtbmFtZS5odG1sOiBBZGRlZC4KKwogMjAxMS0xMS0y MiAgTWFyaW8gU2FuY2hleiBQcmFkYSAgPG1zYW5jaGV6QGlnYWxpYS5jb20+CiAKICAgICAgICAg W0dUS10gcGxhdGZvcm0vZ3RrL2FjY2Vzc2liaWxpdHkvbmFtZS1mcm9tLWxhYmVsLmh0bWwgZmFp bHMKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9hY2Nlc3NpYmlsaXR5L2J1 dHRvbi1hY2Nlc3NpYmxlLW5hbWUtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0v Z3RrL2FjY2Vzc2liaWxpdHkvYnV0dG9uLWFjY2Vzc2libGUtbmFtZS1leHBlY3RlZC50eHQKbmV3 IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uYTFmNzFkOAotLS0gL2Rldi9udWxsCisr KyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9hY2Nlc3NpYmlsaXR5L2J1dHRvbi1hY2Nlc3Np YmxlLW5hbWUtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMTIgQEAKKworVGhpcyB0ZXN0cyB0aGF0 IHRoZSB0ZXh0IG9mIGEgYnV0dG9uIGlzIGV4cG9zZWQgdG8gQXNzaXN0aXZlIFRlY2hub2xvZ2ll cy4KKworT24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdl cywgZm9sbG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgorCisKK1BBU1MgYXhCdXR0b24ucm9sZSBp cyAnQVhSb2xlOiBwdXNoIGJ1dHRvbicKK1BBU1MgYXhCdXR0b24udGl0bGUgaXMgJ0FYVGl0bGU6 IFRoZSBCdXR0b24nCitQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCisKK1RFU1QgQ09N UExFVEUKKwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL2FjY2Vzc2liaWxp dHkvYnV0dG9uLWFjY2Vzc2libGUtbmFtZS5odG1sIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3Rr L2FjY2Vzc2liaWxpdHkvYnV0dG9uLWFjY2Vzc2libGUtbmFtZS5odG1sCm5ldyBmaWxlIG1vZGUg MTAwNjQ0CmluZGV4IDAwMDAwMDAuLmU0YzE2YjIKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRU ZXN0cy9wbGF0Zm9ybS9ndGsvYWNjZXNzaWJpbGl0eS9idXR0b24tYWNjZXNzaWJsZS1uYW1lLmh0 bWwKQEAgLTAsMCArMSwyOCBAQAorPCFET0NUWVBFIEhUTUwgUFVCTElDICItLy9JRVRGLy9EVEQg SFRNTC8vRU4iPgorPGh0bWw+Cis8aGVhZD4KKzxzY3JpcHQgc3JjPSIuLi8uLi8uLi9mYXN0L2pz L3Jlc291cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keT4KKzxm b3JtPgorPGlucHV0IGlkPSJidXR0b24iIHR5cGU9InN1Ym1pdCIgdmFsdWU9IlRoZSBCdXR0b24i Lz4KKzwvZm9ybT4KKzxwIGlkPSJkZXNjcmlwdGlvbiI+PC9wPgorPGRpdiBpZD0iY29uc29sZSI+ PC9kaXY+Cis8c2NyaXB0PgorZGVzY3JpcHRpb24oIlRoaXMgdGVzdHMgdGhhdCB0aGUgdGV4dCBv ZiBhIGJ1dHRvbiBpcyBleHBvc2VkIHRvIEFzc2lzdGl2ZSBUZWNobm9sb2dpZXMuIik7CisKK2lm ICh3aW5kb3cuYWNjZXNzaWJpbGl0eUNvbnRyb2xsZXIpIHsKKyAgICBsYXlvdXRUZXN0Q29udHJv bGxlci5kdW1wQXNUZXh0KCk7CisKKyAgYnV0dG9uID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQo ImJ1dHRvbiIpOworICBidXR0b24uZm9jdXMoKTsKKworICBheEJ1dHRvbiA9IGFjY2Vzc2liaWxp dHlDb250cm9sbGVyLmZvY3VzZWRFbGVtZW50OworICBzaG91bGRCZSgiYXhCdXR0b24ucm9sZSIs ICInQVhSb2xlOiBwdXNoIGJ1dHRvbiciKTsKKyAgc2hvdWxkQmUoImF4QnV0dG9uLnRpdGxlIiwg IidBWFRpdGxlOiBUaGUgQnV0dG9uJyIpOworfQorPC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0iLi4v Li4vLi4vZmFzdC9qcy9yZXNvdXJjZXMvanMtdGVzdC1wb3N0LmpzIj48L3NjcmlwdD4KKzwvYm9k eT4KKzwvaHRtbD4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA5NjI4ZWI2Li5mM2QyZWQ5IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjAgQEAKKzIwMTEtMTEtMjUgIE1hcmlvIFNhbmNoZXogUHJhZGEgIDxtc2FuY2hl ekBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHdGtdIFJlZ3Jlc3Npb246IFB1c2ggYnV0dG9ucyBu byBsb25nZXIgZXhwb3NlIHRoZWlyIGRpc3BsYXllZCB0ZXh0L25hbWUKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcyODA0CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXNlIEFjY2Vzc2liaWxpdHlPYmplY3Q6 OnRpdGxlKCkgYXMgdGhlIGxhc3QgZmFsbGJhY2sgaW4KKyAgICAgICAgd2Via2l0X2FjY2Vzc2li bGVfZ2V0X25hbWUoKSByaWdodCBiZWZvcmUgcmVseWluZyBvbiB0aGUKKyAgICAgICAgc3RyaW5n VmFsdWUoKSBtZXRob2QsIGlmIG5vIGJldHRlciBhbHRlcm5hdGl2ZSB3YXMgZm91bmQuCisKKyAg ICAgICAgVGVzdDogcGxhdGZvcm0vZ3RrL2FjY2Vzc2liaWxpdHkvYnV0dG9uLWFjY2Vzc2libGUt bmFtZS5odG1sCisKKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L2d0ay9BY2Nlc3NpYmlsaXR5T2Jq ZWN0V3JhcHBlckF0ay5jcHA6CisgICAgICAgICh3ZWJraXRfYWNjZXNzaWJsZV9nZXRfbmFtZSk6 IFVzZSB0aXRsZSgpIGFzIHRoZSBsYXN0IGZhbGxiYWNrCisgICAgICAgIG1ldGhvZCBiZWZvcmUg dXNpbmcgc3RyaW5nVmFsdWUoKS4KKwogMjAxMS0xMS0yMSAgRGF2aWQgQmFyciAgPGRhdmlkYmFy ckBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUkVHUkVTU0lPTihyOTg1NDIpOiBDaHJvbWl1bTog Q1NTIHRleHQgaXMgcmVuZGVyZWQgb24gcGFnZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv YWNjZXNzaWJpbGl0eS9ndGsvQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXJBdGsuY3BwIGIvU291 cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9ndGsvQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXJB dGsuY3BwCmluZGV4IGMxZTc1NzEuLmQ2ZTAwODIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L2FjY2Vzc2liaWxpdHkvZ3RrL0FjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVyQXRrLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2d0ay9BY2Nlc3NpYmlsaXR5T2JqZWN0V3Jh cHBlckF0ay5jcHAKQEAgLTIwNiw2ICsyMDYsMTIgQEAgc3RhdGljIGNvbnN0IGdjaGFyKiB3ZWJr aXRfYWNjZXNzaWJsZV9nZXRfbmFtZShBdGtPYmplY3QqIG9iamVjdCkKICAgICAgICAgICAgIHJl dHVybiByZXR1cm5TdHJpbmcoZG9jdW1lbnQtPnRpdGxlKCkpOwogICAgIH0KIAorICAgIC8vIE5v dGhpbmcgd29ya2VkIHNvIGZhciwgdHJ5IHdpdGggdGhlIEFjY2Vzc2liaWxpdHlPYmplY3Qncwor ICAgIC8vIHRpdGxlKCkgYmVmb3JlIGdvaW5nIGFoZWFkIHdpdGggc3RyaW5nVmFsdWUoKS4KKyAg ICBTdHJpbmcgYXhUaXRsZSA9IGNvcmVPYmplY3QtPnRpdGxlKCk7CisgICAgaWYgKCFheFRpdGxl LmlzRW1wdHkoKSkKKyAgICAgICAgcmV0dXJuIHJldHVyblN0cmluZyhheFRpdGxlKTsKKwogICAg IHJldHVybiByZXR1cm5TdHJpbmcoY29yZU9iamVjdC0+c3RyaW5nVmFsdWUoKSk7CiB9CiAKLS0g CjEuNy43LjMKCg==