72803 2011-11-19 10:38:47 -0800 Web Inspector: remove addStyleClass, removeStyleClass and hasStyleClass 2014-12-13 15:55:28 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 timothy webkit-unassigned apavlov burg bweinstein joepeck keishi loislo pfeldman pmuellr rik yurys oldest_to_newest 506422 0 timothy 2011-11-19 10:38:47 -0800 These functions are just thin wrappers around classList now. We should use classList cirectly instead of these functions. 510391 1 timothy 2011-11-28 18:36:09 -0800 I did TreeOutline in r101313 because I had done it internally on a copy we use in Safari and I upstreamed our changes. We should do the rest of the Inspector next! 510400 2 joepeck 2011-11-28 18:59:21 -0800 There was a comment in: <http://webkit.org/b/55758> Web Inspector: Make use of element.classList in utilities.js > Bug 56096 fixes the first item, and we have agreed with pfeldman that the > add/remove/hasStyleClass improve readability, so the classList methods will > not be inlined. We have reached our primary goal of getting rid of regex-based > operations and the className property modification (which is slow). 510401 3 timothy 2011-11-28 19:05:09 -0800 I think reducing out own wrappers is a good idea, especially if they are so thin as these are. We should also remove Function.prototype.bind, which is native in JSC at least not sure about V8. 510402 4 timothy 2011-11-28 19:05:36 -0800 reducing our own*