72802 2011-11-19 10:22:07 -0800 [GTK] Slider thumb is not centered on the track with the unico theme 2012-01-03 10:55:31 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mrobinson mrobinson cgarcia webkit.review.bot xan.lopez oldest_to_newest 506419 0 mrobinson 2011-11-19 10:22:07 -0800 It seems that the slider thumb is resized by the trough border when painting. I don't see this happening in the GTK+ sources and removing this resize re-center the thumb. 506421 1 115956 mrobinson 2011-11-19 10:31:33 -0800 Created attachment 115956 Patch 528817 2 115956 pnormand 2012-01-03 09:26:35 -0800 Comment on attachment 115956 Patch Ok! 528850 3 115956 webkit.review.bot 2012-01-03 10:55:27 -0800 Comment on attachment 115956 Patch Clearing flags on attachment: 115956 Committed r103945: <http://trac.webkit.org/changeset/103945> 528851 4 webkit.review.bot 2012-01-03 10:55:31 -0800 All reviewed patches have been landed. Closing bug. 115956 2011-11-19 10:31:33 -0800 2012-01-03 10:55:27 -0800 Patch bug-72802-20111119103132.patch text/plain 2481 mrobinson U3VidmVyc2lvbiBSZXZpc2lvbjogMTAwODE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjZjZDRiN2E5ZjZmNzNj OWYxOWUxNzdiY2E2NzA1M2EzYzZlZjMzYy4uYWM3ZTgyNWQ1NDU5Njg0N2I5YTQyYTc2ZTIxNmU0 YTlkODkxNjg3MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDExLTExLTE5ICBNYXJ0 aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KIAorICAgICAgICBbR1RLXSBTbGlk ZXIgdGh1bWIgaXMgbm90IGNlbnRlcmVkIG9uIHRoZSB0cmFjayB3aXRoIHRoZSB1bmljbyB0aGVt ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzI4MDIK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcg dGVzdHMuIFRoaXMgb25seSBhcHBsaWVzIHRvIGNlcnRhaW4gR1RLKyB0aGVtZXMuCisgICAgICAg IEV4aXN0aW5nIHRlc3RzIGNvdmVyIHRoZSBkZWZhdWx0IEdUSysgdGhlbWUuCisKKyAgICAgICAg KiBwbGF0Zm9ybS9ndGsvUmVuZGVyVGhlbWVHdGszLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJl bmRlclRoZW1lR3RrOjpwYWludFNsaWRlclRodW1iKTogRG8gbm90IHJlc2l6ZSB0aGUKKyAgICAg ICAgc2xpZGVyIHRodW1iIGJ5IHRoZSB0cm91Z2ggYm9yZGVyLgorCisyMDExLTExLTE5ICBNYXJ0 aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KKwogICAgICAgICBbR1RLXSBHVEsr IDMgdGhlbWluZyBjb2RlIGRvZXMgbm90IHVzZSB0aGUgR3RrT3JpZW50YWJsZSBzdHlsZSBjbGFz cwogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzI3ODkK IApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL1JlbmRlclRoZW1lR3Rr My5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvUmVuZGVyVGhlbWVHdGszLmNwcApp bmRleCBmNTdkMmI5NmFlYTdjY2UxZWM2OTI1YjY3MTlmYjI0YjUxN2NhMTMxLi40OTEwOTk5MDE0 ODY2MWY3OGQwYjFhNTY5MjRhMTI3YWFmOTEwMWQ1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ndGsvUmVuZGVyVGhlbWVHdGszLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ndGsvUmVuZGVyVGhlbWVHdGszLmNwcApAQCAtNjQ5LDEyICs2NDksNiBAQCBib29s IFJlbmRlclRoZW1lR3RrOjpwYWludFNsaWRlclRodW1iKFJlbmRlck9iamVjdCogcmVuZGVyT2Jq ZWN0LCBjb25zdCBQYWludEluZgogICAgIGFwcGx5U2xpZGVyU3R5bGVDb250ZXh0Q2xhc3Nlcyhj b250ZXh0LCBwYXJ0KTsKICAgICBndGtfc3R5bGVfY29udGV4dF9hZGRfY2xhc3MoY29udGV4dCwg R1RLX1NUWUxFX0NMQVNTX1NMSURFUik7CiAKLSAgICBnaW50IHRyb3VnaEJvcmRlcjsKLSAgICBn dGtfc3R5bGVfY29udGV4dF9nZXRfc3R5bGUoY29udGV4dCwgInRyb3VnaC1ib3JkZXIiLCAmdHJv dWdoQm9yZGVyLCBOVUxMKTsKLQotICAgIEludFJlY3Qgc2xpZGVyUmVjdChyZWN0KTsKLSAgICBz bGlkZXJSZWN0LmluZmxhdGUoLXRyb3VnaEJvcmRlcik7Ci0KICAgICBndWludCBmbGFncyA9IDA7 CiAgICAgaWYgKCFpc0VuYWJsZWQocmVuZGVyT2JqZWN0KSB8fCBpc1JlYWRPbmx5Q29udHJvbChy ZW5kZXJPYmplY3QpKQogICAgICAgICBmbGFncyB8PSBHVEtfU1RBVEVfRkxBR19JTlNFTlNJVElW RTsKQEAgLTY2NCw3ICs2NTgsNyBAQCBib29sIFJlbmRlclRoZW1lR3RrOjpwYWludFNsaWRlclRo dW1iKFJlbmRlck9iamVjdCogcmVuZGVyT2JqZWN0LCBjb25zdCBQYWludEluZgogICAgICAgICBm bGFncyB8PSBHVEtfU1RBVEVfRkxBR19BQ1RJVkU7CiAgICAgZ3RrX3N0eWxlX2NvbnRleHRfc2V0 X3N0YXRlKGNvbnRleHQsIHN0YXRpY19jYXN0PEd0a1N0YXRlRmxhZ3M+KGZsYWdzKSk7CiAKLSAg ICBndGtfcmVuZGVyX3NsaWRlcihjb250ZXh0LCBwYWludEluZm8uY29udGV4dC0+cGxhdGZvcm1D b250ZXh0KCktPmNyKCksIHNsaWRlclJlY3QueCgpLCBzbGlkZXJSZWN0LnkoKSwgc2xpZGVyUmVj dC53aWR0aCgpLCBzbGlkZXJSZWN0LmhlaWdodCgpLAorICAgIGd0a19yZW5kZXJfc2xpZGVyKGNv bnRleHQsIHBhaW50SW5mby5jb250ZXh0LT5wbGF0Zm9ybUNvbnRleHQoKS0+Y3IoKSwgcmVjdC54 KCksIHJlY3QueSgpLCByZWN0LndpZHRoKCksIHJlY3QuaGVpZ2h0KCksCiAgICAgICAgICAgICAg ICAgICAgICAgcGFydCA9PSBTbGlkZXJUaHVtYkhvcml6b250YWxQYXJ0ID8gR1RLX09SSUVOVEFU SU9OX0hPUklaT05UQUwgOiBHVEtfT1JJRU5UQVRJT05fVkVSVElDQUwpOwogCiAgICAgZ3RrX3N0 eWxlX2NvbnRleHRfcmVzdG9yZShjb250ZXh0KTsK