<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>72763</bug_id>
          
          <creation_ts>2011-11-18 14:54:22 -0800</creation_ts>
          <short_desc>Forgot to completely de-virtualize isDynamicScope</short_desc>
          <delta_ts>2011-11-18 16:12:35 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Mark Hahnenberg">mhahnenberg</reporter>
          <assigned_to name="Mark Hahnenberg">mhahnenberg</assigned_to>
          <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>506082</commentid>
    <comment_count>0</comment_count>
    <who name="Mark Hahnenberg">mhahnenberg</who>
    <bug_when>2011-11-18 14:54:22 -0800</bug_when>
    <thetext>Missed removing one of the virtual keywords on JSActivation::isDynamicScope.  Not exactly a build fix, so I figured it deserved a bug of its own.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>506086</commentid>
    <comment_count>1</comment_count>
      <attachid>115878</attachid>
    <who name="Mark Hahnenberg">mhahnenberg</who>
    <bug_when>2011-11-18 14:57:39 -0800</bug_when>
    <thetext>Created attachment 115878
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>506167</commentid>
    <comment_count>2</comment_count>
      <attachid>115878</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-11-18 16:12:30 -0800</bug_when>
    <thetext>Comment on attachment 115878
Patch

Clearing flags on attachment: 115878

Committed r100822: &lt;http://trac.webkit.org/changeset/100822&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>506168</commentid>
    <comment_count>3</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-11-18 16:12:35 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>115878</attachid>
            <date>2011-11-18 14:57:39 -0800</date>
            <delta_ts>2011-11-18 16:12:30 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-72763-20111118145737.patch</filename>
            <type>text/plain</type>
            <size>1469</size>
            <attacher name="Mark Hahnenberg">mhahnenberg</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTAwODEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw
dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBh
NTkyNzYyMDZlM2U5ZDRjOGU5ZTE3NzRkNTY4OGE3Y2U5OTk3MTI5Li41ZGExZTNkMDRhOGQ1OTI2
NzA5MTBhZTgyNzJlMDk3OGYwNjhiMTFmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv
cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs
NSArMSwxNCBAQAogMjAxMS0xMS0xOCAgTWFyayBIYWhuZW5iZXJnICA8bWhhaG5lbmJlcmdAYXBw
bGUuY29tPgogCisgICAgICAgIEZvcmdvdCB0byBjb21wbGV0ZWx5IGRlLXZpcnR1YWxpemUgaXNE
eW5hbWljU2NvcGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp
P2lkPTcyNzYzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg
ICAgKiBydW50aW1lL0pTQWN0aXZhdGlvbi5oOiBSZW1vdmVkIHZpcnR1YWwga2V5d29yZC4KKwor
MjAxMS0xMS0xOCAgTWFyayBIYWhuZW5iZXJnICA8bWhhaG5lbmJlcmdAYXBwbGUuY29tPgorCiAg
ICAgICAgIERlLXZpcnR1YWxpemUgRXhlY3V0YWJsZUJhc2U6OmludHJpbnNpYwogICAgICAgICBo
dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzI1NDgKIApkaWZmIC0tZ2l0
IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNBY3RpdmF0aW9uLmggYi9Tb3VyY2Uv
SmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0FjdGl2YXRpb24uaAppbmRleCAxNGNhYmJkMzVjYmQ2
ODdmM2YxNmQ5NDJkMmFhNWU2ZWEwZTcyOWY1Li4xMmRkYjhhOGM3YWQ2YzRhZWI0MzNlNTcwYjVl
M2Y1NDJjMTYwNTNlIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9K
U0FjdGl2YXRpb24uaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0FjdGl2
YXRpb24uaApAQCAtNTcsNyArNTcsNyBAQCBuYW1lc3BhY2UgSlNDIHsKIAogICAgICAgICBzdGF0
aWMgdm9pZCB2aXNpdENoaWxkcmVuKEpTQ2VsbCosIFNsb3RWaXNpdG9yJik7CiAKLSAgICAgICAg
dmlydHVhbCBib29sIGlzRHluYW1pY1Njb3BlKGJvb2wmIHJlcXVpcmVzRHluYW1pY0NoZWNrcykg
Y29uc3Q7CisgICAgICAgIGJvb2wgaXNEeW5hbWljU2NvcGUoYm9vbCYgcmVxdWlyZXNEeW5hbWlj
Q2hlY2tzKSBjb25zdDsKIAogICAgICAgICBzdGF0aWMgYm9vbCBnZXRPd25Qcm9wZXJ0eVNsb3Qo
SlNDZWxsKiwgRXhlY1N0YXRlKiwgY29uc3QgSWRlbnRpZmllciYsIFByb3BlcnR5U2xvdCYpOwog
ICAgICAgICBzdGF0aWMgdm9pZCBnZXRPd25Qcm9wZXJ0eU5hbWVzKEpTT2JqZWN0KiwgRXhlY1N0
YXRlKiwgUHJvcGVydHlOYW1lQXJyYXkmLCBFbnVtZXJhdGlvbk1vZGUpOwo=
</data>

          </attachment>
      

    </bug>

</bugzilla>